feat(config): Restructure .taskmasterconfig and enhance gateway integration
Config Structure Changes and Gateway Integration ## Configuration Structure Changes - Restructured .taskmasterconfig to use 'account' section for user settings - Moved userId, userEmail, mode, telemetryEnabled from global to account section - API keys remain isolated in .env file (not accessible to AI) - Enhanced getUserId() to always return value, never null (sets default '1234567890') ## Gateway Integration Enhancements - Updated registerUserWithGateway() to accept both email and userId parameters - Enhanced /auth/init endpoint integration for existing user validation - API key updates automatically written to .env during registration process - Improved user identification and validation flow ## Code Updates for New Structure - Fixed config-manager.js getter functions for account section access - Updated user-management.js to use config.account.userId/mode - Modified telemetry-submission.js to read from account section - Added getTelemetryEnabled() function with proper account section access - Enhanced telemetry configuration reading with new structure ## Comprehensive Test Updates - Updated integration tests (init-config.test.js) for new config structure - Fixed unit tests (config-manager.test.js) with updated default config - Updated telemetry tests (telemetry-submission.test.js) for account structure - Added missing getTelemetryEnabled mock to ai-services-unified.test.js - Fixed all test expectations to use config.account.* instead of config.global.* - Removed references to deprecated config.subscription object ## Configuration Access Consistency - Standardized configuration access patterns across entire codebase - Clean separation: user settings in account, API keys in .env, models/global in respective sections - All tests passing with new configuration structure - Maintained backward compatibility during transition Changes support enhanced telemetry system with proper user management and gateway integration while maintaining security through API key isolation.
This commit is contained in:
@@ -34,6 +34,7 @@ jest.unstable_mockModule(
|
||||
getProjectName: jest.fn(() => "Test Project"),
|
||||
getDefaultPriority: jest.fn(() => "medium"),
|
||||
getDefaultNumTasks: jest.fn(() => 10),
|
||||
getTelemetryEnabled: jest.fn(() => true),
|
||||
})
|
||||
);
|
||||
|
||||
@@ -48,17 +49,17 @@ const { getConfig } = await import(
|
||||
"../../../../scripts/modules/config-manager.js"
|
||||
);
|
||||
|
||||
describe("Telemetry Submission Service - Task 90.2", () => {
|
||||
describe("Telemetry Submission Service", () => {
|
||||
beforeEach(() => {
|
||||
jest.clearAllMocks();
|
||||
global.fetch.mockClear();
|
||||
});
|
||||
|
||||
describe("Subtask 90.2: Send telemetry data to remote database endpoint", () => {
|
||||
describe("should send telemetry data to remote database endpoint", () => {
|
||||
it("should successfully submit telemetry data to hardcoded gateway endpoint", async () => {
|
||||
// Mock successful config with proper structure
|
||||
getConfig.mockReturnValue({
|
||||
global: {
|
||||
account: {
|
||||
userId: "test-user-id",
|
||||
},
|
||||
});
|
||||
@@ -113,7 +114,7 @@ describe("Telemetry Submission Service - Task 90.2", () => {
|
||||
|
||||
it("should implement retry logic for failed requests", async () => {
|
||||
getConfig.mockReturnValue({
|
||||
global: {
|
||||
account: {
|
||||
userId: "test-user-id",
|
||||
},
|
||||
});
|
||||
@@ -149,7 +150,7 @@ describe("Telemetry Submission Service - Task 90.2", () => {
|
||||
|
||||
it("should handle failures gracefully without blocking execution", async () => {
|
||||
getConfig.mockReturnValue({
|
||||
global: {
|
||||
account: {
|
||||
userId: "test-user-id",
|
||||
},
|
||||
});
|
||||
@@ -180,8 +181,16 @@ describe("Telemetry Submission Service - Task 90.2", () => {
|
||||
}, 10000);
|
||||
|
||||
it("should respect user opt-out preferences", async () => {
|
||||
// Mock getTelemetryEnabled to return false for this test
|
||||
const { getTelemetryEnabled } = await import(
|
||||
"../../../../scripts/modules/config-manager.js"
|
||||
);
|
||||
getTelemetryEnabled.mockReturnValue(false);
|
||||
|
||||
getConfig.mockReturnValue({
|
||||
telemetryEnabled: false,
|
||||
account: {
|
||||
telemetryEnabled: false,
|
||||
},
|
||||
});
|
||||
|
||||
const telemetryData = {
|
||||
@@ -198,11 +207,14 @@ describe("Telemetry Submission Service - Task 90.2", () => {
|
||||
expect(result.skipped).toBe(true);
|
||||
expect(result.reason).toBe("Telemetry disabled by user preference");
|
||||
expect(global.fetch).not.toHaveBeenCalled();
|
||||
|
||||
// Reset the mock for other tests
|
||||
getTelemetryEnabled.mockReturnValue(true);
|
||||
});
|
||||
|
||||
it("should validate telemetry data before submission", async () => {
|
||||
getConfig.mockReturnValue({
|
||||
global: {
|
||||
account: {
|
||||
userId: "test-user-id",
|
||||
},
|
||||
});
|
||||
@@ -229,7 +241,7 @@ describe("Telemetry Submission Service - Task 90.2", () => {
|
||||
|
||||
it("should handle HTTP error responses appropriately", async () => {
|
||||
getConfig.mockReturnValue({
|
||||
global: {
|
||||
account: {
|
||||
userId: "test-user-id",
|
||||
},
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user