fix: normalize task IDs to numbers on load to fix comparison issues (#1063)

* fix: normalize task IDs to numbers on load to fix comparison issues

When tasks.json contains string IDs (e.g., "5" instead of 5), task lookups
fail because the code uses parseInt() and strict equality (===) for comparisons.

This fix normalizes all task and subtask IDs to numbers when loading the JSON,
ensuring consistent comparisons throughout the codebase without requiring
changes to multiple comparison locations.

Fixes task not found errors when using string IDs in tasks.json.

* Added test

* Don't mess up formatting

* Fix formatting once and for all

* Update scripts/modules/utils.js

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* Update scripts/modules/utils.js

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* Update scripts/modules/utils.js

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* fix: normalize task IDs to numbers on load to fix comparison issues

- Added normalizeTaskIds function to convert string IDs to numbers
- Applied normalization in readJSON for all code paths
- Fixed set-task-status, add-task, and move-task to normalize IDs when working with raw data
- Exported normalizeTaskIds function for use in other modules
- Added test case for string ID normalization

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

* Simplified implementation

* refactor: normalize IDs once when loading JSON instead of scattered calls

- Normalize all tags' data when creating _rawTaggedData in readJSON
- Add support for handling malformed dotted subtask IDs (e.g., "5.1" -> 1)
- Remove redundant normalizeTaskIds calls from set-task-status, add-task, and move-task
- Add comprehensive test for mixed ID formats (string IDs and dotted notation)
- Cleaner, more maintainable solution that normalizes IDs at load time

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

* chore: run format to resolve CI issues

---------

Co-authored-by: Carl Mercier <carl@carlmercier.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: Claude <noreply@anthropic.com>

scripts/modules/utils.js

@@ -262,6 +262,43 @@ function hasTaggedStructure(data) {
 	return false;
 }
 
+/**
+ * Normalizes task IDs to ensure they are numbers instead of strings
+ * @param {Array} tasks - Array of tasks to normalize
+ */
+function normalizeTaskIds(tasks) {
+	if (!Array.isArray(tasks)) return;
+
+	tasks.forEach((task) => {
+		// Convert task ID to number with validation
+		if (task.id !== undefined) {
+			const parsedId = parseInt(task.id, 10);
+			if (!isNaN(parsedId) && parsedId > 0) {
+				task.id = parsedId;
+			}
+		}
+
+		// Convert subtask IDs to numbers with validation
+		if (Array.isArray(task.subtasks)) {
+			task.subtasks.forEach((subtask) => {
+				if (subtask.id !== undefined) {
+					// Check for dot notation (which shouldn't exist in storage)
+					if (typeof subtask.id === 'string' && subtask.id.includes('.')) {
+						// Extract the subtask part after the dot
+						const parts = subtask.id.split('.');
+						subtask.id = parseInt(parts[parts.length - 1], 10);
+					} else {
+						const parsedSubtaskId = parseInt(subtask.id, 10);
+						if (!isNaN(parsedSubtaskId) && parsedSubtaskId > 0) {
+							subtask.id = parsedSubtaskId;
+						}
+					}
+				}
+			});
+		}
+	});
+}
+
 /**
  * Reads and parses a JSON file
  * @param {string} filepath - Path to the JSON file
@@ -322,6 +359,8 @@ function readJSON(filepath, projectRoot = null, tag = null) {
 			console.log(`File is in legacy format, performing migration...`);
 		}
 
+		normalizeTaskIds(data.tasks);
+
 		// This is legacy format - migrate it to tagged format
 		const migratedData = {
 			master: {
@@ -401,6 +440,16 @@ function readJSON(filepath, projectRoot = null, tag = null) {
 		// Store reference to the raw tagged data for functions that need it
 		const originalTaggedData = JSON.parse(JSON.stringify(data));
 
+		// Normalize IDs in all tags before storing as originalTaggedData
+		for (const tagName in originalTaggedData) {
+			if (
+				originalTaggedData[tagName] &&
+				Array.isArray(originalTaggedData[tagName].tasks)
+			) {
+				normalizeTaskIds(originalTaggedData[tagName].tasks);
+			}
+		}
+
 		// Check and auto-switch git tags if enabled (for existing tagged format)
 		// This needs to run synchronously BEFORE tag resolution
 		if (projectRoot) {
@@ -448,6 +497,8 @@ function readJSON(filepath, projectRoot = null, tag = null) {
 			// Get the data for the resolved tag
 			const tagData = data[resolvedTag];
 			if (tagData && tagData.tasks) {
+				normalizeTaskIds(tagData.tasks);
+
 				// Add the _rawTaggedData property and the resolved tag to the returned data
 				const result = {
 					...tagData,
@@ -464,6 +515,8 @@ function readJSON(filepath, projectRoot = null, tag = null) {
 				// If the resolved tag doesn't exist, fall back to master
 				const masterData = data.master;
 				if (masterData && masterData.tasks) {
+					normalizeTaskIds(masterData.tasks);
+
 					if (isDebug) {
 						console.log(
 							`Tag '${resolvedTag}' not found, falling back to master with ${masterData.tasks.length} tasks`
@@ -493,6 +546,7 @@ function readJSON(filepath, projectRoot = null, tag = null) {
 			// If anything goes wrong, try to return master or empty
 			const masterData = data.master;
 			if (masterData && masterData.tasks) {
+				normalizeTaskIds(masterData.tasks);
 				return {
 					...masterData,
 					_rawTaggedData: originalTaggedData
@@ -1412,5 +1466,6 @@ export {
 	createStateJson,
 	markMigrationForNotice,
 	flattenTasksWithSubtasks,
-	ensureTagMetadata
+	ensureTagMetadata,
+	normalizeTaskIds
 };