fix(update-task): pass projectRoot and adjust parsing

Modified update-task-by-id core, direct function, and tool to pass projectRoot. Reverted parsing logic in core function to prioritize `{...}` extraction, resolving parsing errors. Fixed ReferenceError by correctly destructuring projectRoot.

mcp-server/src/tools/update-task.js

@@ -4,6 +4,7 @@
  */
 
 import { z } from 'zod';
+import path from 'path'; // Import path
 import {
 	handleApiResult,
 	createErrorResponse,
@@ -23,7 +24,7 @@ export function registerUpdateTaskTool(server) {
 			'Updates a single task by ID with new information or context provided in the prompt.',
 		parameters: z.object({
 			id: z
-				.string()
+				.string() // ID can be number or string like "1.2"
 				.describe(
 					"ID of the task (e.g., '15') to update. Subtasks are supported using the update-subtask tool."
 				),
@@ -40,59 +41,65 @@ export function registerUpdateTaskTool(server) {
 				.describe('The directory of the project. Must be an absolute path.')
 		}),
 		execute: async (args, { log, session }) => {
+			const toolName = 'update_task';
 			try {
-				log.info(`Updating task with args: ${JSON.stringify(args)}`);
+				log.info(
+					`Executing ${toolName} tool with args: ${JSON.stringify(args)}`
+				);
 
-				// Get project root from args or session
-				const rootFolder =
-					args.projectRoot || getProjectRootFromSession(session, log);
-
-				// Ensure project root was determined
-				if (!rootFolder) {
+				// 1. Get Project Root
+				const rootFolder = args.projectRoot;
+				if (!rootFolder || !path.isAbsolute(rootFolder)) {
+					log.error(
+						`${toolName}: projectRoot is required and must be absolute.`
+					);
 					return createErrorResponse(
-						'Could not determine project root. Please provide it explicitly or ensure your session contains valid root information.'
+						'projectRoot is required and must be absolute.'
 					);
 				}
+				log.info(`${toolName}: Project root: ${rootFolder}`);
 
-				// Resolve the path to tasks.json
+				// 2. Resolve Tasks Path
 				let tasksJsonPath;
 				try {
 					tasksJsonPath = findTasksJsonPath(
-						{ projectRoot: rootFolder, file: args.file },
+						{ projectRoot: rootFolder, file: args.file }, // Pass root and optional relative file
 						log
 					);
+					log.info(`${toolName}: Resolved tasks path: ${tasksJsonPath}`);
 				} catch (error) {
-					log.error(`Error finding tasks.json: ${error.message}`);
+					log.error(`${toolName}: Error finding tasks.json: ${error.message}`);
 					return createErrorResponse(
-						`Failed to find tasks.json: ${error.message}`
+						`Failed to find tasks.json within project root '${rootFolder}': ${error.message}`
 					);
 				}
 
+				// 3. Call Direct Function - Include projectRoot
 				const result = await updateTaskByIdDirect(
 					{
-						// Pass the explicitly resolved path
-						tasksJsonPath: tasksJsonPath,
-						// Pass other relevant args
+						tasksJsonPath: tasksJsonPath, // Pass resolved path
 						id: args.id,
 						prompt: args.prompt,
-						research: args.research
+						research: args.research,
+						projectRoot: rootFolder // <<< Pass projectRoot HERE
 					},
 					log,
-					{ session }
+					{ session } // Pass context with session
 				);
 
-				if (result.success) {
-					log.info(`Successfully updated task with ID ${args.id}`);
-				} else {
-					log.error(
-						`Failed to update task: ${result.error?.message || 'Unknown error'}`
-					);
-				}
-
+				// 4. Handle Result
+				log.info(
+					`${toolName}: Direct function result: success=${result.success}`
+				);
+				// Pass the actual data from the result (contains updated task or message)
 				return handleApiResult(result, log, 'Error updating task');
 			} catch (error) {
-				log.error(`Error in update_task tool: ${error.message}`);
-				return createErrorResponse(error.message);
+				log.error(
+					`Critical error in ${toolName} tool execute: ${error.message}`
+				);
+				return createErrorResponse(
+					`Internal tool error (${toolName}): ${error.message}`
+				);
 			}
 		}
 	});