fix(move-task): Fix critical bugs in task move functionality

- Fixed parent-to-parent task moves where original task would remain as duplicate
- Fixed moving tasks to become subtasks of empty parents (validation errors)
- Fixed moving subtasks between different parent tasks
- Improved comma-separated batch moves with proper error handling
- Updated MCP tool to use core logic instead of custom implementation
- Resolves task duplication issues and enables proper task hierarchy reorganization

mcp-server/src/core/direct-functions/move-task.js

@@ -13,10 +13,11 @@ import {
  * Move a task or subtask to a new position
  * @param {Object} args - Function arguments
  * @param {string} args.tasksJsonPath - Explicit path to the tasks.json file
- * @param {string} args.sourceId - ID of the task/subtask to move (e.g., '5' or '5.2')
- * @param {string} args.destinationId - ID of the destination (e.g., '7' or '7.3')
+ * @param {string} args.sourceId - ID of the task/subtask to move (e.g., '5' or '5.2' or '5,6,7')
+ * @param {string} args.destinationId - ID of the destination (e.g., '7' or '7.3' or '7,8,9')
  * @param {string} args.file - Alternative path to the tasks.json file
  * @param {string} args.projectRoot - Project root directory
+ * @param {boolean} args.generateFiles - Whether to regenerate task files after moving (default: true)
  * @param {Object} log - Logger object
  * @returns {Promise<{success: boolean, data?: Object, error?: Object}>}
  */
@@ -64,12 +65,13 @@ export async function moveTaskDirect(args, log, context = {}) {
 		// Enable silent mode to prevent console output during MCP operation
 		enableSilentMode();
 
-		// Call the core moveTask function, always generate files
+		// Call the core moveTask function with file generation control
+		const generateFiles = args.generateFiles !== false; // Default to true
 		const result = await moveTask(
 			tasksPath,
 			args.sourceId,
 			args.destinationId,
-			true
+			generateFiles
 		);
 
 		// Restore console output
@@ -78,7 +80,7 @@ export async function moveTaskDirect(args, log, context = {}) {
 		return {
 			success: true,
 			data: {
-				movedTask: result.movedTask,
+				...result,
 				message: `Successfully moved task/subtask ${args.sourceId} to ${args.destinationId}`
 			}
 		};

mcp-server/src/tools/move-task.js

@@ -41,83 +41,20 @@ export function registerMoveTaskTool(server) {
 		}),
 		execute: withNormalizedProjectRoot(async (args, { log, session }) => {
 			try {
-				// Find tasks.json path if not provided
-				let tasksJsonPath = args.file;
+				// Let the core logic handle comma-separated IDs and validation
+				const result = await moveTaskDirect(
+					{
+						sourceId: args.from,
+						destinationId: args.to,
+						file: args.file,
+						projectRoot: args.projectRoot,
+						generateFiles: true // Always generate files for MCP operations
+					},
+					log,
+					{ session }
+				);
 
-				if (!tasksJsonPath) {
-					tasksJsonPath = findTasksJsonPath(args, log);
-				}
-
-				// Parse comma-separated IDs
-				const fromIds = args.from.split(',').map((id) => id.trim());
-				const toIds = args.to.split(',').map((id) => id.trim());
-
-				// Validate matching IDs count
-				if (fromIds.length !== toIds.length) {
-					return createErrorResponse(
-						'The number of source and destination IDs must match',
-						'MISMATCHED_ID_COUNT'
-					);
-				}
-
-				// If moving multiple tasks
-				if (fromIds.length > 1) {
-					const results = [];
-					// Move tasks one by one, only generate files on the last move
-					for (let i = 0; i < fromIds.length; i++) {
-						const fromId = fromIds[i];
-						const toId = toIds[i];
-
-						// Skip if source and destination are the same
-						if (fromId === toId) {
-							log.info(`Skipping ${fromId} -> ${toId} (same ID)`);
-							continue;
-						}
-
-						const shouldGenerateFiles = i === fromIds.length - 1;
-						const result = await moveTaskDirect(
-							{
-								sourceId: fromId,
-								destinationId: toId,
-								tasksJsonPath,
-								projectRoot: args.projectRoot
-							},
-							log,
-							{ session }
-						);
-
-						if (!result.success) {
-							log.error(
-								`Failed to move ${fromId} to ${toId}: ${result.error.message}`
-							);
-						} else {
-							results.push(result.data);
-						}
-					}
-
-					return {
-						success: true,
-						data: {
-							moves: results,
-							message: `Successfully moved ${results.length} tasks`
-						}
-					};
-				} else {
-					// Moving a single task
-					return handleApiResult(
-						await moveTaskDirect(
-							{
-								sourceId: args.from,
-								destinationId: args.to,
-								tasksJsonPath,
-								projectRoot: args.projectRoot
-							},
-							log,
-							{ session }
-						),
-						log
-					);
-				}
+				return handleApiResult(result, log);
 			} catch (error) {
 				return createErrorResponse(
 					`Failed to move task: ${error.message}`,