feat: implement cross-tag task movement functionality (#1088)
* feat: enhance move command with cross-tag functionality - Updated the `move` command to allow moving tasks between different tags, including options for handling dependencies. - Added new options: `--from-tag`, `--to-tag`, `--with-dependencies`, `--ignore-dependencies`, and `--force`. - Implemented validation for cross-tag moves and dependency checks. - Introduced helper functions in the dependency manager for validating and resolving cross-tag dependencies. - Added integration and unit tests to cover new functionality and edge cases. * fix: refactor cross-tag move logic and enhance validation - Moved the import of `moveTasksBetweenTags` to the correct location in `commands.js` for better clarity. - Added new helper functions in `dependency-manager.js` to improve validation and error handling for cross-tag moves. - Enhanced existing functions to ensure proper handling of task dependencies and conflicts. - Updated tests to cover new validation scenarios and ensure robust error messaging for invalid task IDs and tags. * fix: improve task ID handling and error messaging in cross-tag moves - Refactored `moveTasksBetweenTags` to normalize task IDs for comparison, ensuring consistent handling of string and numeric IDs. - Enhanced error messages for cases where source and target tags are the same but no destination is specified. - Updated tests to validate new behavior, including handling string dependencies correctly during cross-tag moves. - Cleaned up existing code for better readability and maintainability. * test: add comprehensive tests for cross-tag move and dependency validation - Introduced new test files for `move-cross-tag` and `cross-tag-dependencies` to cover various scenarios in cross-tag task movement. - Implemented tests for handling task movement with and without dependencies, including edge cases for error handling. - Enhanced existing tests in `fix-dependencies-command` and `move-task` to ensure robust validation of task IDs and dependencies. - Mocked necessary modules and functions to isolate tests and improve reliability. - Ensured coverage for both successful and failed cross-tag move operations, validating expected outcomes and error messages. * test: refactor cross-tag move tests for better clarity and reusability - Introduced a helper function `simulateCrossTagMove` to streamline cross-tag move test cases, reducing redundancy and improving readability. - Updated existing tests to utilize the new helper function, ensuring consistent handling of expected messages and options. - Enhanced test coverage for various scenarios, including handling of dependencies and flags. * feat: add cross-tag task movement functionality - Introduced new commands for moving tasks between different tags, enhancing project organization capabilities. - Updated README with usage examples for cross-tag movement, including options for handling dependencies. - Created comprehensive documentation for cross-tag task movement, detailing usage, error handling, and best practices. - Implemented core logic for cross-tag moves, including validation for dependencies and error handling. - Added integration and unit tests to ensure robust functionality and coverage for various scenarios, including edge cases. * fix: enhance error handling and logging in cross-tag task movement - Improved logging in `moveTaskCrossTagDirect` to include detailed arguments for better traceability. - Refactored error handling to utilize structured error objects, providing clearer suggestions for resolving cross-tag dependency conflicts and subtask movement restrictions. - Updated documentation to reflect changes in error handling and provide clearer guidance on task movement options. - Added integration tests for cross-tag movement scenarios, ensuring robust validation of error handling and task movement logic. - Cleaned up existing tests for clarity and reusability, enhancing overall test coverage. * feat: enhance dependency resolution and error handling in task movement - Added recursive dependency resolution for tasks in `moveTasksBetweenTags`, improving handling of complex task relationships. - Introduced helper functions to find all dependencies and reverse dependencies, ensuring comprehensive coverage during task moves. - Enhanced error messages in `validateSubtaskMove` and `displaySubtaskMoveError` for better clarity on movement restrictions. - Updated tests to cover new functionality, including integration tests for complex cross-tag movement scenarios and edge cases. - Refactored existing code for improved readability and maintainability, ensuring consistent handling of task IDs and dependencies. * feat: unify dependency traversal and enhance task management utilities - Introduced `traverseDependencies` utility for unified forward and reverse dependency traversal, improving code reusability and clarity. - Refactored `findAllDependenciesRecursively` to leverage the new utility, streamlining dependency resolution in task management. - Added `formatTaskIdForDisplay` helper for better task ID formatting in UI, enhancing user experience during error displays. - Updated tests to cover new utility functions and ensure robust validation of dependency handling across various scenarios. - Improved overall code organization and readability, ensuring consistent handling of task dependencies and IDs. * fix: improve validation for dependency parameters in `findAllDependenciesRecursively` - Added checks to ensure `sourceTasks` and `allTasks` are arrays, throwing errors if not, to prevent runtime issues. - Updated documentation comment for clarity on the function's purpose and parameters. * fix: remove `force` option from task movement parameters - Eliminated the `force` parameter from the `moveTaskCrossTagDirect` function and related tools, simplifying the task movement logic. - Updated documentation and tests to reflect the removal of the `force` option, ensuring clarity and consistency across the codebase. - Adjusted related functions and tests to focus on `ignoreDependencies` as the primary control for handling dependency conflicts during task moves. * Add cross-tag task movement functionality - Introduced functionality for organizing tasks across different contexts by enabling cross-tag movement. - Added `formatTaskIdForDisplay` helper to improve task ID formatting in UI error messages. - Updated relevant tests to incorporate new functionality and ensure accurate error displays during task movements. * Update scripts/modules/dependency-manager.js Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * refactor(dependency-manager): Fix subtask resolution and extract helper functions 1. Fix subtask finding logic (lines 1315-1330): - Correctly locate parent task by numeric ID - Search within parent's subtasks array instead of top-level tasks - Properly handle relative subtask references 2. Extract helper functions from getDependentTaskIds (lines 1440-1636): - Move findTasksThatDependOn as module-level function - Move taskDependsOnSource as module-level function - Move subtasksDependOnSource as module-level function - Improves readability, maintainability, and testability Both fixes address architectural issues and improve code organization. * refactor(dependency-manager): Enhance subtask resolution and dependency validation - Improved subtask resolution logic to correctly find parent tasks and their subtasks, ensuring accurate identification of dependencies. - Filtered out null/undefined dependencies before processing, enhancing robustness in dependency checks. - Updated comments for clarity on the logic flow and purpose of changes, improving code maintainability. * refactor(move-task): clarify destination ID description and improve skipped task handling - Updated the description for the destination ID to clarify its usage in cross-tag moves. - Simplified the handling of skipped tasks during multiple task movements, improving readability and logging. - Enhanced the API result response to include detailed information about moved and skipped tasks, ensuring better feedback for users. * refactor(commands): remove redundant tag validation logic - Eliminated the check for identical source and target tags in the task movement logic, simplifying the code. - This change streamlines the flow for within-tag moves, enhancing readability and maintainability. * refactor(commands): enhance move command logic and error handling - Introduced helper functions for better organization of cross-tag and within-tag move logic, improving code readability and maintainability. - Enhanced error handling with structured error objects, providing clearer feedback for dependency conflicts and invalid tag combinations. - Updated move command help output to include best practices and error resolution tips, ensuring users have comprehensive guidance during task movements. - Streamlined task movement logic to handle multiple tasks more effectively, including detailed logging of successful and failed moves. * test(dependency-manager): add subtasks to task structure and mock dependency traversal - Updated `circular-dependencies.test.js` to include subtasks in task definitions, enhancing test coverage for task structures with nested dependencies. - Mocked `traverseDependencies` in `fix-dependencies-command.test.js` to ensure consistent behavior during tests, improving reliability of dependency-related tests. * refactor(dependency-manager): extract subtask finding logic into helper function - Added `findSubtaskInParent` function to encapsulate subtask resolution within a parent task's subtasks array, improving code organization and readability. - Updated `findDependencyTask` to utilize the new helper function, streamlining the logic for finding subtasks and enhancing maintainability. - Enhanced comments for clarity on the purpose and functionality of the new subtask finding logic. * refactor(ui): enhance subtask ID validation and improve error handling - Added validation for subtask ID format in `formatDependenciesWithStatus` and `taskExists`, ensuring proper handling of invalid formats. - Updated error logging in `displaySubtaskMoveError` to provide warnings for unexpected task ID formats, improving user feedback. - Converted hints to a Set in `displayDependencyValidationHints` to ensure unique hints are displayed, enhancing clarity in the UI. * test(cli): remove redundant timing check in complex cross-tag scenarios - Eliminated the timing check for task completion within 5 seconds in `complex-cross-tag-scenarios.test.js`, streamlining the test logic. - This change focuses on verifying task success without unnecessary timing constraints, enhancing test clarity and maintainability. * test(integration): enhance task movement tests with mock file system - Added integration tests for moving tasks within the same tag and between different tags using the actual `moveTask` and `moveTasksBetweenTags` functions. - Implemented `mock-fs` to simulate file system interactions, improving test isolation and reliability. - Verified task movement success and ensured proper handling of subtasks and dependencies, enhancing overall test coverage for task management functionality. - Included error handling tests for missing tags and task IDs to ensure robustness in task movement operations. * test(unit): add comprehensive tests for moveTaskCrossTagDirect functionality - Introduced new test cases to verify mock functionality, ensuring that mocks for `findTasksPath` and `readJSON` are working as expected. - Added tests for parameter validation, error handling, and function call flow, including scenarios for missing project roots and identical source/target tags. - Enhanced coverage for ID parsing and move options, ensuring robust handling of various input conditions and improving overall test reliability. * test(integration): skip tests for dependency conflict handling and withDependencies option - Marked tests for handling dependency conflicts and the withDependencies option as skipped due to issues with the mock setup. - Added TODOs to address the mock-fs setup for complex dependency scenarios, ensuring future improvements in test reliability. * test(unit): expand cross-tag move command tests with comprehensive mocks - Added extensive mocks for various modules to enhance the testing of the cross-tag move functionality in `move-cross-tag.test.js`. - Implemented detailed test cases for handling cross-tag moves, including validation for missing parameters and identical source/target tags. - Improved error handling tests to ensure robust feedback for invalid operations, enhancing overall test reliability and coverage. * test(integration): add complex dependency scenarios to task movement tests - Introduced new integration tests for handling complex dependency scenarios in task movement, utilizing the actual `moveTasksBetweenTags` function. - Added tests for circular dependencies, nested dependency chains, and cross-tag dependency resolution, enhancing coverage and reliability. - Documented limitations of the mock-fs setup for complex scenarios and provided warnings in the test output to guide future improvements. - Skipped tests for dependency conflicts and the withDependencies option due to mock setup issues, with TODOs for resolution. * test(unit): refactor move-cross-tag tests with focused mock system - Simplified mocking in `move-cross-tag.test.js` by implementing a configuration-driven mock system, reducing the number of mocked modules from 20+ to 5 core functionalities. - Introduced a reusable mock factory to streamline the creation of mocks based on configuration, enhancing maintainability and clarity. - Added documentation for the new mock system, detailing usage examples and benefits, including reduced complexity and improved test focus. - Implemented tests to validate the mock configuration, ensuring flexibility in enabling/disabling specific mocks. * test(unit): clean up mocks and improve isEmpty function in fix-dependencies-command tests - Removed the mock for `traverseDependencies` as it was unnecessary, simplifying the test setup. - Updated the `isEmpty` function to clarify its behavior regarding null and undefined values, enhancing code readability and maintainability. * test(unit): update traverseDependencies mock for consistency across tests - Standardized the mock implementation of `traverseDependencies` in both `fix-dependencies-command.test.js` and `complexity-report-tag-isolation.test.js` to accept `sourceTasks`, `allTasks`, and `options` parameters, ensuring uniformity in test setups. - This change enhances clarity and maintainability of the tests by aligning the mock behavior across different test files. * fix(core): improve task movement error handling and ID normalization - Wrapped task movement logic in a try-finally block to ensure console output is restored even on errors, enhancing reliability. - Normalized source IDs to handle mixed string/number comparisons, preventing potential issues in dependency checks. - Added tests for ID type consistency to verify that the normalization fix works correctly across various scenarios, improving test coverage and robustness. * refactor(task-manager): restructure task movement logic for improved validation and execution - Renamed and refactored `moveTasksBetweenTags` to streamline the task movement process into distinct phases: validation, data preparation, dependency resolution, execution, and finalization. - Introduced `validateMove`, `prepareTaskData`, `resolveDependencies`, `executeMoveOperation`, and `finalizeMove` functions to enhance modularity and clarity. - Updated documentation comments to reflect changes in function responsibilities and parameters. - Added comprehensive unit tests for the new structure, ensuring robust validation and error handling across various scenarios. - Improved handling of dependencies and task existence checks during the move operation, enhancing overall reliability. * fix(move-task): streamline task movement logic and improve error handling - Refactored the task movement process to enhance clarity and maintainability by replacing `forEach` with a `for...of` loop for better async handling. - Consolidated error handling and result logging to ensure consistent feedback during task moves. - Updated the logic for generating files only on the last move, improving performance and reducing unnecessary operations. - Enhanced validation for skipped tasks, ensuring accurate reporting of moved and skipped tasks in the final result. * fix(docs): update error message formatting and enhance clarity in task movement documentation - Changed code block syntax from generic to `text` for better readability in error messages related to task movement and dependency conflicts. - Ensured consistent formatting across all error message examples to improve user understanding of task movement restrictions and resolutions. - Added a newline at the end of the file for proper formatting. * Update .changeset/crazy-meals-hope.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * chore: improve changeset * chore: improve changeset * fix referenced bug in docs and remove docs * chore: fix format --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Ralph Khreish <35776126+Crunchyman-ralph@users.noreply.github.com>
This commit is contained in:
Parthy
498
tests/unit/scripts/modules/ui/cross-tag-error-display.test.js
Normal file
498
tests/unit/scripts/modules/ui/cross-tag-error-display.test.js
Normal file
@@ -0,0 +1,498 @@
|
||||
import { jest } from '@jest/globals';
|
||||
import {
|
||||
displayCrossTagDependencyError,
|
||||
displaySubtaskMoveError,
|
||||
displayInvalidTagCombinationError,
|
||||
displayDependencyValidationHints,
|
||||
formatTaskIdForDisplay
|
||||
} from '../../../../../scripts/modules/ui.js';
|
||||
|
||||
// Mock console.log to capture output
|
||||
const originalConsoleLog = console.log;
|
||||
const mockConsoleLog = jest.fn();
|
||||
global.console.log = mockConsoleLog;
|
||||
|
||||
// Add afterAll hook to restore
|
||||
afterAll(() => {
|
||||
global.console.log = originalConsoleLog;
|
||||
});
|
||||
|
||||
describe('Cross-Tag Error Display Functions', () => {
|
||||
beforeEach(() => {
|
||||
mockConsoleLog.mockClear();
|
||||
});
|
||||
|
||||
describe('displayCrossTagDependencyError', () => {
|
||||
it('should display cross-tag dependency error with conflicts', () => {
|
||||
const conflicts = [
|
||||
{
|
||||
taskId: 1,
|
||||
dependencyId: 2,
|
||||
dependencyTag: 'backlog',
|
||||
message: 'Task 1 depends on 2 (in backlog)'
|
||||
},
|
||||
{
|
||||
taskId: 3,
|
||||
dependencyId: 4,
|
||||
dependencyTag: 'done',
|
||||
message: 'Task 3 depends on 4 (in done)'
|
||||
}
|
||||
];
|
||||
|
||||
displayCrossTagDependencyError(conflicts, 'in-progress', 'done', '1,3');
|
||||
|
||||
expect(mockConsoleLog).toHaveBeenCalledWith(
|
||||
expect.stringContaining(
|
||||
'❌ Cannot move tasks from "in-progress" to "done"'
|
||||
)
|
||||
);
|
||||
expect(mockConsoleLog).toHaveBeenCalledWith(
|
||||
expect.stringContaining('Cross-tag dependency conflicts detected:')
|
||||
);
|
||||
expect(mockConsoleLog).toHaveBeenCalledWith(
|
||||
expect.stringContaining('• Task 1 depends on 2 (in backlog)')
|
||||
);
|
||||
expect(mockConsoleLog).toHaveBeenCalledWith(
|
||||
expect.stringContaining('• Task 3 depends on 4 (in done)')
|
||||
);
|
||||
expect(mockConsoleLog).toHaveBeenCalledWith(
|
||||
expect.stringContaining('Resolution options:')
|
||||
);
|
||||
expect(mockConsoleLog).toHaveBeenCalledWith(
|
||||
expect.stringContaining('--with-dependencies')
|
||||
);
|
||||
expect(mockConsoleLog).toHaveBeenCalledWith(
|
||||
expect.stringContaining('--ignore-dependencies')
|
||||
);
|
||||
});
|
||||
|
||||
it('should handle empty conflicts array', () => {
|
||||
displayCrossTagDependencyError([], 'backlog', 'done', '1');
|
||||
|
||||
expect(mockConsoleLog).toHaveBeenCalledWith(
|
||||
expect.stringContaining('❌ Cannot move tasks from "backlog" to "done"')
|
||||
);
|
||||
expect(mockConsoleLog).toHaveBeenCalledWith(
|
||||
expect.stringContaining('Cross-tag dependency conflicts detected:')
|
||||
);
|
||||
});
|
||||
});
|
||||
|
||||
describe('displaySubtaskMoveError', () => {
|
||||
it('should display subtask movement restriction error', () => {
|
||||
displaySubtaskMoveError('5.2', 'backlog', 'in-progress');
|
||||
|
||||
expect(mockConsoleLog).toHaveBeenCalledWith(
|
||||
expect.stringContaining(
|
||||
'❌ Cannot move subtask 5.2 directly between tags'
|
||||
)
|
||||
);
|
||||
expect(mockConsoleLog).toHaveBeenCalledWith(
|
||||
expect.stringContaining('Subtask movement restriction:')
|
||||
);
|
||||
expect(mockConsoleLog).toHaveBeenCalledWith(
|
||||
expect.stringContaining(
|
||||
'• Subtasks cannot be moved directly between tags'
|
||||
)
|
||||
);
|
||||
expect(mockConsoleLog).toHaveBeenCalledWith(
|
||||
expect.stringContaining('Resolution options:')
|
||||
);
|
||||
expect(mockConsoleLog).toHaveBeenCalledWith(
|
||||
expect.stringContaining('remove-subtask --id=5.2 --convert')
|
||||
);
|
||||
});
|
||||
|
||||
it('should handle nested subtask IDs (three levels)', () => {
|
||||
displaySubtaskMoveError('5.2.1', 'feature-auth', 'production');
|
||||
|
||||
expect(mockConsoleLog).toHaveBeenCalledWith(
|
||||
expect.stringContaining(
|
||||
'❌ Cannot move subtask 5.2.1 directly between tags'
|
||||
)
|
||||
);
|
||||
expect(mockConsoleLog).toHaveBeenCalledWith(
|
||||
expect.stringContaining('remove-subtask --id=5.2.1 --convert')
|
||||
);
|
||||
});
|
||||
|
||||
it('should handle deeply nested subtask IDs (four levels)', () => {
|
||||
displaySubtaskMoveError('10.3.2.1', 'development', 'testing');
|
||||
|
||||
expect(mockConsoleLog).toHaveBeenCalledWith(
|
||||
expect.stringContaining(
|
||||
'❌ Cannot move subtask 10.3.2.1 directly between tags'
|
||||
)
|
||||
);
|
||||
expect(mockConsoleLog).toHaveBeenCalledWith(
|
||||
expect.stringContaining('remove-subtask --id=10.3.2.1 --convert')
|
||||
);
|
||||
});
|
||||
|
||||
it('should handle single-level subtask IDs', () => {
|
||||
displaySubtaskMoveError('15.1', 'master', 'feature-branch');
|
||||
|
||||
expect(mockConsoleLog).toHaveBeenCalledWith(
|
||||
expect.stringContaining(
|
||||
'❌ Cannot move subtask 15.1 directly between tags'
|
||||
)
|
||||
);
|
||||
expect(mockConsoleLog).toHaveBeenCalledWith(
|
||||
expect.stringContaining('remove-subtask --id=15.1 --convert')
|
||||
);
|
||||
});
|
||||
|
||||
it('should handle invalid subtask ID format gracefully', () => {
|
||||
displaySubtaskMoveError('invalid-id', 'tag1', 'tag2');
|
||||
|
||||
expect(mockConsoleLog).toHaveBeenCalledWith(
|
||||
expect.stringContaining(
|
||||
'❌ Cannot move subtask invalid-id directly between tags'
|
||||
)
|
||||
);
|
||||
expect(mockConsoleLog).toHaveBeenCalledWith(
|
||||
expect.stringContaining('remove-subtask --id=invalid-id --convert')
|
||||
);
|
||||
});
|
||||
|
||||
it('should handle empty subtask ID', () => {
|
||||
displaySubtaskMoveError('', 'source', 'target');
|
||||
|
||||
expect(mockConsoleLog).toHaveBeenCalledWith(
|
||||
expect.stringContaining(
|
||||
`❌ Cannot move subtask ${formatTaskIdForDisplay('')} directly between tags`
|
||||
)
|
||||
);
|
||||
expect(mockConsoleLog).toHaveBeenCalledWith(
|
||||
expect.stringContaining(
|
||||
`remove-subtask --id=${formatTaskIdForDisplay('')} --convert`
|
||||
)
|
||||
);
|
||||
});
|
||||
|
||||
it('should handle null subtask ID', () => {
|
||||
displaySubtaskMoveError(null, 'source', 'target');
|
||||
|
||||
expect(mockConsoleLog).toHaveBeenCalledWith(
|
||||
expect.stringContaining(
|
||||
'❌ Cannot move subtask null directly between tags'
|
||||
)
|
||||
);
|
||||
expect(mockConsoleLog).toHaveBeenCalledWith(
|
||||
expect.stringContaining('remove-subtask --id=null --convert')
|
||||
);
|
||||
});
|
||||
|
||||
it('should handle undefined subtask ID', () => {
|
||||
displaySubtaskMoveError(undefined, 'source', 'target');
|
||||
|
||||
expect(mockConsoleLog).toHaveBeenCalledWith(
|
||||
expect.stringContaining(
|
||||
'❌ Cannot move subtask undefined directly between tags'
|
||||
)
|
||||
);
|
||||
expect(mockConsoleLog).toHaveBeenCalledWith(
|
||||
expect.stringContaining('remove-subtask --id=undefined --convert')
|
||||
);
|
||||
});
|
||||
|
||||
it('should handle special characters in subtask ID', () => {
|
||||
displaySubtaskMoveError('5.2@test', 'dev', 'prod');
|
||||
|
||||
expect(mockConsoleLog).toHaveBeenCalledWith(
|
||||
expect.stringContaining(
|
||||
'❌ Cannot move subtask 5.2@test directly between tags'
|
||||
)
|
||||
);
|
||||
expect(mockConsoleLog).toHaveBeenCalledWith(
|
||||
expect.stringContaining('remove-subtask --id=5.2@test --convert')
|
||||
);
|
||||
});
|
||||
|
||||
it('should handle numeric subtask IDs', () => {
|
||||
displaySubtaskMoveError('123.456', 'alpha', 'beta');
|
||||
|
||||
expect(mockConsoleLog).toHaveBeenCalledWith(
|
||||
expect.stringContaining(
|
||||
'❌ Cannot move subtask 123.456 directly between tags'
|
||||
)
|
||||
);
|
||||
expect(mockConsoleLog).toHaveBeenCalledWith(
|
||||
expect.stringContaining('remove-subtask --id=123.456 --convert')
|
||||
);
|
||||
});
|
||||
|
||||
it('should handle identical source and target tags', () => {
|
||||
displaySubtaskMoveError('7.3', 'same-tag', 'same-tag');
|
||||
|
||||
expect(mockConsoleLog).toHaveBeenCalledWith(
|
||||
expect.stringContaining(
|
||||
'❌ Cannot move subtask 7.3 directly between tags'
|
||||
)
|
||||
);
|
||||
expect(mockConsoleLog).toHaveBeenCalledWith(
|
||||
expect.stringContaining('• Source tag: "same-tag"')
|
||||
);
|
||||
expect(mockConsoleLog).toHaveBeenCalledWith(
|
||||
expect.stringContaining('• Target tag: "same-tag"')
|
||||
);
|
||||
});
|
||||
|
||||
it('should handle empty tag names', () => {
|
||||
displaySubtaskMoveError('9.1', '', '');
|
||||
|
||||
expect(mockConsoleLog).toHaveBeenCalledWith(
|
||||
expect.stringContaining(
|
||||
'❌ Cannot move subtask 9.1 directly between tags'
|
||||
)
|
||||
);
|
||||
expect(mockConsoleLog).toHaveBeenCalledWith(
|
||||
expect.stringContaining('• Source tag: ""')
|
||||
);
|
||||
expect(mockConsoleLog).toHaveBeenCalledWith(
|
||||
expect.stringContaining('• Target tag: ""')
|
||||
);
|
||||
});
|
||||
|
||||
it('should handle null tag names', () => {
|
||||
displaySubtaskMoveError('12.4', null, null);
|
||||
|
||||
expect(mockConsoleLog).toHaveBeenCalledWith(
|
||||
expect.stringContaining(
|
||||
'❌ Cannot move subtask 12.4 directly between tags'
|
||||
)
|
||||
);
|
||||
expect(mockConsoleLog).toHaveBeenCalledWith(
|
||||
expect.stringContaining('• Source tag: "null"')
|
||||
);
|
||||
expect(mockConsoleLog).toHaveBeenCalledWith(
|
||||
expect.stringContaining('• Target tag: "null"')
|
||||
);
|
||||
});
|
||||
|
||||
it('should handle complex tag names with special characters', () => {
|
||||
displaySubtaskMoveError(
|
||||
'3.2.1',
|
||||
'feature/user-auth@v2.0',
|
||||
'production@stable'
|
||||
);
|
||||
|
||||
expect(mockConsoleLog).toHaveBeenCalledWith(
|
||||
expect.stringContaining(
|
||||
'❌ Cannot move subtask 3.2.1 directly between tags'
|
||||
)
|
||||
);
|
||||
expect(mockConsoleLog).toHaveBeenCalledWith(
|
||||
expect.stringContaining('• Source tag: "feature/user-auth@v2.0"')
|
||||
);
|
||||
expect(mockConsoleLog).toHaveBeenCalledWith(
|
||||
expect.stringContaining('• Target tag: "production@stable"')
|
||||
);
|
||||
});
|
||||
|
||||
it('should handle very long subtask IDs', () => {
|
||||
const longId = '1.2.3.4.5.6.7.8.9.10.11.12.13.14.15.16.17.18.19.20';
|
||||
displaySubtaskMoveError(longId, 'short', 'long');
|
||||
|
||||
expect(mockConsoleLog).toHaveBeenCalledWith(
|
||||
expect.stringContaining(
|
||||
`❌ Cannot move subtask ${longId} directly between tags`
|
||||
)
|
||||
);
|
||||
expect(mockConsoleLog).toHaveBeenCalledWith(
|
||||
expect.stringContaining(`remove-subtask --id=${longId} --convert`)
|
||||
);
|
||||
});
|
||||
|
||||
it('should handle whitespace in subtask ID', () => {
|
||||
displaySubtaskMoveError(' 5.2 ', 'clean', 'dirty');
|
||||
|
||||
expect(mockConsoleLog).toHaveBeenCalledWith(
|
||||
expect.stringContaining(
|
||||
'❌ Cannot move subtask 5.2 directly between tags'
|
||||
)
|
||||
);
|
||||
expect(mockConsoleLog).toHaveBeenCalledWith(
|
||||
expect.stringContaining('remove-subtask --id= 5.2 --convert')
|
||||
);
|
||||
});
|
||||
});
|
||||
|
||||
describe('displayInvalidTagCombinationError', () => {
|
||||
it('should display invalid tag combination error', () => {
|
||||
displayInvalidTagCombinationError(
|
||||
'backlog',
|
||||
'backlog',
|
||||
'Source and target tags are identical'
|
||||
);
|
||||
|
||||
expect(mockConsoleLog).toHaveBeenCalledWith(
|
||||
expect.stringContaining('❌ Invalid tag combination')
|
||||
);
|
||||
expect(mockConsoleLog).toHaveBeenCalledWith(
|
||||
expect.stringContaining('Error details:')
|
||||
);
|
||||
expect(mockConsoleLog).toHaveBeenCalledWith(
|
||||
expect.stringContaining('• Source tag: "backlog"')
|
||||
);
|
||||
expect(mockConsoleLog).toHaveBeenCalledWith(
|
||||
expect.stringContaining('• Target tag: "backlog"')
|
||||
);
|
||||
expect(mockConsoleLog).toHaveBeenCalledWith(
|
||||
expect.stringContaining(
|
||||
'• Reason: Source and target tags are identical'
|
||||
)
|
||||
);
|
||||
expect(mockConsoleLog).toHaveBeenCalledWith(
|
||||
expect.stringContaining('Resolution options:')
|
||||
);
|
||||
});
|
||||
});
|
||||
|
||||
describe('displayDependencyValidationHints', () => {
|
||||
it('should display general hints by default', () => {
|
||||
displayDependencyValidationHints();
|
||||
|
||||
expect(mockConsoleLog).toHaveBeenCalledWith(
|
||||
expect.stringContaining('Helpful hints:')
|
||||
);
|
||||
expect(mockConsoleLog).toHaveBeenCalledWith(
|
||||
expect.stringContaining('💡 Use "task-master validate-dependencies"')
|
||||
);
|
||||
expect(mockConsoleLog).toHaveBeenCalledWith(
|
||||
expect.stringContaining('💡 Use "task-master fix-dependencies"')
|
||||
);
|
||||
});
|
||||
|
||||
it('should display before-move hints', () => {
|
||||
displayDependencyValidationHints('before-move');
|
||||
|
||||
expect(mockConsoleLog).toHaveBeenCalledWith(
|
||||
expect.stringContaining('Helpful hints:')
|
||||
);
|
||||
expect(mockConsoleLog).toHaveBeenCalledWith(
|
||||
expect.stringContaining(
|
||||
'💡 Tip: Run "task-master validate-dependencies"'
|
||||
)
|
||||
);
|
||||
expect(mockConsoleLog).toHaveBeenCalledWith(
|
||||
expect.stringContaining('💡 Tip: Use "task-master fix-dependencies"')
|
||||
);
|
||||
});
|
||||
|
||||
it('should display after-error hints', () => {
|
||||
displayDependencyValidationHints('after-error');
|
||||
|
||||
expect(mockConsoleLog).toHaveBeenCalledWith(
|
||||
expect.stringContaining('Helpful hints:')
|
||||
);
|
||||
expect(mockConsoleLog).toHaveBeenCalledWith(
|
||||
expect.stringContaining(
|
||||
'🔧 Quick fix: Run "task-master validate-dependencies"'
|
||||
)
|
||||
);
|
||||
expect(mockConsoleLog).toHaveBeenCalledWith(
|
||||
expect.stringContaining(
|
||||
'🔧 Quick fix: Use "task-master fix-dependencies"'
|
||||
)
|
||||
);
|
||||
});
|
||||
|
||||
it('should handle unknown context gracefully', () => {
|
||||
displayDependencyValidationHints('unknown-context');
|
||||
|
||||
expect(mockConsoleLog).toHaveBeenCalledWith(
|
||||
expect.stringContaining('Helpful hints:')
|
||||
);
|
||||
// Should fall back to general hints
|
||||
expect(mockConsoleLog).toHaveBeenCalledWith(
|
||||
expect.stringContaining('💡 Use "task-master validate-dependencies"')
|
||||
);
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
/**
|
||||
* Test for ID type consistency in dependency comparisons
|
||||
* This test verifies that the fix for mixed string/number ID comparison issues works correctly
|
||||
*/
|
||||
|
||||
describe('ID Type Consistency in Dependency Comparisons', () => {
|
||||
test('should handle mixed string/number ID comparisons correctly', () => {
|
||||
// Test the pattern that was fixed in the move-task tests
|
||||
const sourceTasks = [
|
||||
{ id: 1, title: 'Task 1' },
|
||||
{ id: 2, title: 'Task 2' },
|
||||
{ id: '3.1', title: 'Subtask 3.1' }
|
||||
];
|
||||
|
||||
const allTasks = [
|
||||
{ id: 1, title: 'Task 1', dependencies: [2, '3.1'] },
|
||||
{ id: 2, title: 'Task 2', dependencies: ['1'] },
|
||||
{
|
||||
id: 3,
|
||||
title: 'Task 3',
|
||||
subtasks: [{ id: 1, title: 'Subtask 3.1', dependencies: [1] }]
|
||||
}
|
||||
];
|
||||
|
||||
// Test the fixed pattern: normalize source IDs and compare with string conversion
|
||||
const sourceIds = sourceTasks.map((t) => t.id);
|
||||
const normalizedSourceIds = sourceIds.map((id) => String(id));
|
||||
|
||||
// Test that dependencies are correctly identified regardless of type
|
||||
const result = [];
|
||||
allTasks.forEach((task) => {
|
||||
if (task.dependencies && Array.isArray(task.dependencies)) {
|
||||
const hasDependency = task.dependencies.some((depId) =>
|
||||
normalizedSourceIds.includes(String(depId))
|
||||
);
|
||||
if (hasDependency) {
|
||||
result.push(task.id);
|
||||
}
|
||||
}
|
||||
});
|
||||
|
||||
// Verify that the comparison works correctly
|
||||
expect(result).toContain(1); // Task 1 has dependency on 2 and '3.1'
|
||||
expect(result).toContain(2); // Task 2 has dependency on '1'
|
||||
|
||||
// Test edge cases
|
||||
const mixedDependencies = [
|
||||
{ id: 1, dependencies: [1, 2, '3.1', '4.2'] },
|
||||
{ id: 2, dependencies: ['1', 3, '5.1'] }
|
||||
];
|
||||
|
||||
const testSourceIds = [1, '3.1', 4];
|
||||
const normalizedTestSourceIds = testSourceIds.map((id) => String(id));
|
||||
|
||||
mixedDependencies.forEach((task) => {
|
||||
const hasMatch = task.dependencies.some((depId) =>
|
||||
normalizedTestSourceIds.includes(String(depId))
|
||||
);
|
||||
expect(typeof hasMatch).toBe('boolean');
|
||||
expect(hasMatch).toBe(true); // Should find matches in both tasks
|
||||
});
|
||||
});
|
||||
|
||||
test('should handle edge cases in ID normalization', () => {
|
||||
// Test various ID formats
|
||||
const testCases = [
|
||||
{ source: 1, dependency: '1', expected: true },
|
||||
{ source: '1', dependency: 1, expected: true },
|
||||
{ source: '3.1', dependency: '3.1', expected: true },
|
||||
{ source: 3, dependency: '3.1', expected: false }, // Different formats
|
||||
{ source: '3.1', dependency: 3, expected: false }, // Different formats
|
||||
{ source: 1, dependency: 2, expected: false }, // No match
|
||||
{ source: '1.2', dependency: '1.2', expected: true },
|
||||
{ source: 1, dependency: null, expected: false }, // Handle null
|
||||
{ source: 1, dependency: undefined, expected: false } // Handle undefined
|
||||
];
|
||||
|
||||
testCases.forEach(({ source, dependency, expected }) => {
|
||||
const normalizedSourceIds = [String(source)];
|
||||
const hasMatch = normalizedSourceIds.includes(String(dependency));
|
||||
expect(hasMatch).toBe(expected);
|
||||
});
|
||||
});
|
||||
});
|
||||
Reference in New Issue
Block a user