ros/claude-code
1
0
Fork 0
mirror of https://github.com/anthropics/claude-code.git synced 2026-01-30 04:02:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #14527 from anthropics/fvolcic/code-review-updates

Browse Source 
Improve code review inline comments
This commit is contained in:
Franklin Volcic
2025-12-18 13:52:59 -08:00
committed by GitHub
parent b31e2fd182 b8a2ffb38f
commit 5d2df70860
1 changed files with 11 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

47
plugins/code-review/commands/code-review.md
View File

@@ -52,25 +52,22 @@ Note: Still review Claude generated PR's.
6. Filter out any issues that were not validated in step 5. This step will give us our list of high signal issues for our review. 6. Filter out any issues that were not validated in step 5. This step will give us our list of high signal issues for our review.
7. Post summary comment FIRST using `gh pr comment` (if `--comment` argument is provided): 7. If issues were found, skip to step 8 to post inline comments directly.
- Total number of issues found
- Brief one-line summary of each issue (no "Bug:" prefix)
- Or if no issues: "No issues found. Checked for bugs and CLAUDE.md compliance."
When writing your comment, follow these guidelines: If NO issues were found, post a summary comment using `gh pr comment` (if `--comment` argument is provided):
a. Keep your output brief "No issues found. Checked for bugs and CLAUDE.md compliance."
b. Avoid emojis
c. Link and cite relevant code, files, and URLs for each issue
d. When citing CLAUDE.md violations, you MUST quote the exact text from CLAUDE.md that is being violated (e.g., CLAUDE.md says: "Use snake_case for variable names")
8. THEN post inline comments for each issue using `mcp__github_inline_comment__create_inline_comment`: 8. Post inline comments for each issue using `mcp__github_inline_comment__create_inline_comment`:
- `path`: the file path - `path`: the file path
- `line` (and `startLine` for ranges): select the buggy lines so the user sees them - `line` (and `startLine` for ranges): select the buggy lines so the user sees them
- `body`: Brief description of the issue (no "Bug:" prefix). For small fixes (up to 5 lines changed), include a committable suggestion: - `body`: Brief description of the issue (no "Bug:" prefix). For small fixes (up to 5 lines changed), include a committable suggestion:
```suggestion ```suggestion
corrected code here corrected code here
``` ```
For larger fixes (6+ lines or structural changes), do NOT use suggestion blocks. Instead:
**Suggestions must be COMPLETE.** If a fix requires additional changes elsewhere (e.g., renaming a variable requires updating all usages), do NOT use a suggestion block. The author should be able to click "Commit suggestion" and have a working fix - no followup work required.
For larger fixes (6+ lines, structural changes, or changes spanning multiple locations), do NOT use suggestion blocks. Instead:
1. Describe what the issue is 1. Describe what the issue is
2. Explain the suggested fix at a high level 2. Explain the suggested fix at a high level
3. Include a copyable prompt for Claude Code that the user can use to fix the issue, formatted as: 3. Include a copyable prompt for Claude Code that the user can use to fix the issue, formatted as:
@@ -93,40 +90,18 @@ Notes:
- Use gh CLI to interact with GitHub (e.g., fetch pull requests, create comments). Do not use web fetch. - Use gh CLI to interact with GitHub (e.g., fetch pull requests, create comments). Do not use web fetch.
- Create a todo list before starting. - Create a todo list before starting.
- You must cite and link each issue (e.g., if referring to a CLAUDE.md, include a link to it). - You must cite and link each issue in inline comments (e.g., if referring to a CLAUDE.md, include a link to it).
- For your final comment, follow the following format precisely (assuming for this example that you found 3 issues): - If no issues are found, post a comment with the following format:
--- ---
## Code review ## Code review
Found 3 issues:
1. <brief description of bug> (CLAUDE.md says: "<exact quote from CLAUDE.md>")
<link to file and line with full sha1 + line range for context, eg. https://github.com/anthropics/claude-code/blob/1d54823877c4de72b2316a64032a54afc404e619/README.md#L13-L17>
2. <brief description of bug> (some/other/CLAUDE.md says: "<exact quote from CLAUDE.md>")
<link to file and line with full sha1 + line range for context>
3. <brief description of bug> (bug due to <file and code snippet>)
<link to file and line with full sha1 + line range for context>
---
- Or, if you found no issues:
---
## Auto code review
No issues found. Checked for bugs and CLAUDE.md compliance. No issues found. Checked for bugs and CLAUDE.md compliance.
--- ---
- When linking to code, follow the following format precisely, otherwise the Markdown preview won't render correctly: https://github.com/anthropics/claude-code/blob/c21d3c10bc8e898b7ac1a2d745bdc9bc4e423afe/package.json#L10-L15 - When linking to code in inline comments, follow the following format precisely, otherwise the Markdown preview won't render correctly: https://github.com/anthropics/claude-code/blob/c21d3c10bc8e898b7ac1a2d745bdc9bc4e423afe/package.json#L10-L15
- Requires full git sha - Requires full git sha
- You must provide the full sha. Commands like `https://github.com/owner/repo/blob/$(git rev-parse HEAD)/foo/bar` will not work, since your comment will be directly rendered in Markdown. - You must provide the full sha. Commands like `https://github.com/owner/repo/blob/$(git rev-parse HEAD)/foo/bar` will not work, since your comment will be directly rendered in Markdown.
- Repo name must match the repo you're code reviewing - Repo name must match the repo you're code reviewing