mirror of
https://github.com/AutoMaker-Org/automaker.git
synced 2026-03-20 23:13:07 +00:00
* feat: refactor Claude API Profiles to Claude Compatible Providers
- Rename ClaudeApiProfile to ClaudeCompatibleProvider with models[] array
- Each ProviderModel has mapsToClaudeModel field for Claude tier mapping
- Add providerType field for provider-specific icons (glm, minimax, openrouter)
- Add thinking level support for provider models in phase selectors
- Show all mapped Claude models per provider model (e.g., "Maps to Haiku, Sonnet, Opus")
- Add Bulk Replace feature to switch all phases to a provider at once
- Hide Bulk Replace button when no providers are enabled
- Fix project-level phaseModelOverrides not persisting after refresh
- Fix deleting last provider not persisting (remove empty array guard)
- Add getProviderByModelId() helper for all SDK routes
- Update all routes to pass provider config for provider models
- Update terminology from "profiles" to "providers" throughout UI
- Update documentation to reflect new provider system
* fix: atomic writer race condition and bulk replace reset to defaults
1. AtomicWriter Race Condition Fix (libs/utils/src/atomic-writer.ts):
- Changed temp file naming from Date.now() to Date.now() + random hex
- Uses crypto.randomBytes(4).toString('hex') for uniqueness
- Prevents ENOENT errors when multiple concurrent writes happen
within the same millisecond
2. Bulk Replace "Anthropic Direct" Reset (both dialogs):
- When selecting "Anthropic Direct", now uses DEFAULT_PHASE_MODELS
- Properly resets thinking levels and other settings to defaults
- Added thinkingLevel to the change detection comparison
- Affects both global and project-level bulk replace dialogs
* fix: update tests for new model resolver passthrough behavior
1. model-resolver tests:
- Unknown models now pass through unchanged (provider model support)
- Removed expectations for warnings on unknown models
- Updated case sensitivity and edge case tests accordingly
- Added tests for provider-like model names (GLM-4.7, MiniMax-M2.1)
2. atomic-writer tests:
- Updated regex to match new temp file format with random suffix
- Format changed from .tmp.{timestamp} to .tmp.{timestamp}.{hex}
* refactor: simplify getPhaseModelWithOverrides calls per code review
Address code review feedback on PR #629:
- Make settingsService parameter optional in getPhaseModelWithOverrides
- Function now handles undefined settingsService gracefully by returning defaults
- Remove redundant ternary checks in 4 call sites:
- apps/server/src/routes/context/routes/describe-file.ts
- apps/server/src/routes/context/routes/describe-image.ts
- apps/server/src/routes/worktree/routes/generate-commit-message.ts
- apps/server/src/services/auto-mode-service.ts
- Remove unused DEFAULT_PHASE_MODELS imports where applicable
* test: fix server tests for provider model passthrough behavior
- Update model-resolver.test.ts to expect unknown models to pass through
unchanged (supports ClaudeCompatibleProvider models like GLM-4.7)
- Remove warning expectations for unknown models (valid for providers)
- Add missing getCredentials and getGlobalSettings mocks to
ideation-service.test.ts for settingsService
* fix: address code review feedback for model providers
- Honor thinkingLevel in generate-commit-message.ts
- Pass claudeCompatibleProvider in ideation-service.ts for provider models
- Resolve provider configuration for model overrides in generate-suggestions.ts
- Update "Active Profile" to "Active Provider" label in project-claude-section
- Use substring instead of deprecated substr in api-profiles-section
- Preserve provider enabled state when editing in api-profiles-section
* fix: address CodeRabbit review issues for Claude Compatible Providers
- Fix TypeScript TS2339 error in generate-suggestions.ts where
settingsService was narrowed to 'never' type in else branch
- Use DEFAULT_PHASE_MODELS per-phase defaults instead of hardcoded
'sonnet' in settings-helpers.ts
- Remove duplicate eventHooks key in use-settings-migration.ts
- Add claudeCompatibleProviders to localStorage migration parsing
and merging functions
- Handle canonical claude-* model IDs (claude-haiku, claude-sonnet,
claude-opus) in project-models-section display names
This resolves the CI build failures and addresses code review feedback.
* fix: skip broken list-view-priority E2E test and add Priority column label
- Skip list-view-priority.spec.ts with TODO explaining the infrastructure
issue: setupRealProject only sets localStorage but server settings
take precedence with localStorageMigrated: true
- Add 'Priority' label to list-header.tsx for the priority column
(was empty string, now shows proper header text)
- Increase column width to accommodate the label
The E2E test issue is that tests create features in a temp directory,
but the server loads from the E2E Test Project fixture path set in
setup-e2e-fixtures.mjs. Needs infrastructure fix to properly switch
projects or create features through UI instead of on disk.
221 lines
7.3 KiB
TypeScript
221 lines
7.3 KiB
TypeScript
/**
|
|
* POST /context/describe-file endpoint - Generate description for a text file
|
|
*
|
|
* Uses AI to analyze a text file and generate a concise description
|
|
* suitable for context file metadata. Model is configurable via
|
|
* phaseModels.fileDescriptionModel in settings (defaults to Haiku).
|
|
*
|
|
* SECURITY: This endpoint validates file paths against ALLOWED_ROOT_DIRECTORY
|
|
* and reads file content directly (not via Claude's Read tool) to prevent
|
|
* arbitrary file reads and prompt injection attacks.
|
|
*/
|
|
|
|
import type { Request, Response } from 'express';
|
|
import { createLogger } from '@automaker/utils';
|
|
import { PathNotAllowedError } from '@automaker/platform';
|
|
import { resolvePhaseModel } from '@automaker/model-resolver';
|
|
import { simpleQuery } from '../../../providers/simple-query-service.js';
|
|
import * as secureFs from '../../../lib/secure-fs.js';
|
|
import * as path from 'path';
|
|
import type { SettingsService } from '../../../services/settings-service.js';
|
|
import {
|
|
getAutoLoadClaudeMdSetting,
|
|
getPromptCustomization,
|
|
getPhaseModelWithOverrides,
|
|
} from '../../../lib/settings-helpers.js';
|
|
|
|
const logger = createLogger('DescribeFile');
|
|
|
|
/**
|
|
* Request body for the describe-file endpoint
|
|
*/
|
|
interface DescribeFileRequestBody {
|
|
/** Path to the file */
|
|
filePath: string;
|
|
}
|
|
|
|
/**
|
|
* Success response from the describe-file endpoint
|
|
*/
|
|
interface DescribeFileSuccessResponse {
|
|
success: true;
|
|
description: string;
|
|
}
|
|
|
|
/**
|
|
* Error response from the describe-file endpoint
|
|
*/
|
|
interface DescribeFileErrorResponse {
|
|
success: false;
|
|
error: string;
|
|
}
|
|
|
|
/**
|
|
* Create the describe-file request handler
|
|
*
|
|
* @param settingsService - Optional settings service for loading autoLoadClaudeMd setting
|
|
* @returns Express request handler for file description
|
|
*/
|
|
export function createDescribeFileHandler(
|
|
settingsService?: SettingsService
|
|
): (req: Request, res: Response) => Promise<void> {
|
|
return async (req: Request, res: Response): Promise<void> => {
|
|
try {
|
|
const { filePath } = req.body as DescribeFileRequestBody;
|
|
|
|
// Validate required fields
|
|
if (!filePath || typeof filePath !== 'string') {
|
|
const response: DescribeFileErrorResponse = {
|
|
success: false,
|
|
error: 'filePath is required and must be a string',
|
|
};
|
|
res.status(400).json(response);
|
|
return;
|
|
}
|
|
|
|
logger.info(`Starting description generation for: ${filePath}`);
|
|
|
|
// Resolve the path for logging and cwd derivation
|
|
const resolvedPath = secureFs.resolvePath(filePath);
|
|
|
|
// Read file content using secureFs (validates path against ALLOWED_ROOT_DIRECTORY)
|
|
// This prevents arbitrary file reads (e.g., /etc/passwd, ~/.ssh/id_rsa)
|
|
// and prompt injection attacks where malicious filePath values could inject instructions
|
|
let fileContent: string;
|
|
try {
|
|
const content = await secureFs.readFile(resolvedPath, 'utf-8');
|
|
fileContent = typeof content === 'string' ? content : content.toString('utf-8');
|
|
} catch (readError) {
|
|
// Path not allowed - return 403 Forbidden
|
|
if (readError instanceof PathNotAllowedError) {
|
|
logger.warn(`Path not allowed: ${filePath}`);
|
|
const response: DescribeFileErrorResponse = {
|
|
success: false,
|
|
error: 'File path is not within the allowed directory',
|
|
};
|
|
res.status(403).json(response);
|
|
return;
|
|
}
|
|
|
|
// File not found
|
|
if (
|
|
readError !== null &&
|
|
typeof readError === 'object' &&
|
|
'code' in readError &&
|
|
readError.code === 'ENOENT'
|
|
) {
|
|
logger.warn(`File not found: ${resolvedPath}`);
|
|
const response: DescribeFileErrorResponse = {
|
|
success: false,
|
|
error: `File not found: ${filePath}`,
|
|
};
|
|
res.status(404).json(response);
|
|
return;
|
|
}
|
|
|
|
const errorMessage = readError instanceof Error ? readError.message : 'Unknown error';
|
|
logger.error(`Failed to read file: ${errorMessage}`);
|
|
const response: DescribeFileErrorResponse = {
|
|
success: false,
|
|
error: `Failed to read file: ${errorMessage}`,
|
|
};
|
|
res.status(500).json(response);
|
|
return;
|
|
}
|
|
|
|
// Truncate very large files to avoid token limits
|
|
const MAX_CONTENT_LENGTH = 50000;
|
|
const truncated = fileContent.length > MAX_CONTENT_LENGTH;
|
|
const contentToAnalyze = truncated
|
|
? fileContent.substring(0, MAX_CONTENT_LENGTH)
|
|
: fileContent;
|
|
|
|
// Get the filename for context
|
|
const fileName = path.basename(resolvedPath);
|
|
|
|
// Get customized prompts from settings
|
|
const prompts = await getPromptCustomization(settingsService, '[DescribeFile]');
|
|
|
|
// Build prompt with file content passed as structured data
|
|
// The file content is included directly, not via tool invocation
|
|
const prompt = `${prompts.contextDescription.describeFilePrompt}
|
|
|
|
File: ${fileName}${truncated ? ' (truncated)' : ''}
|
|
|
|
--- FILE CONTENT ---
|
|
${contentToAnalyze}`;
|
|
|
|
// Use the file's directory as the working directory
|
|
const cwd = path.dirname(resolvedPath);
|
|
|
|
// Load autoLoadClaudeMd setting
|
|
const autoLoadClaudeMd = await getAutoLoadClaudeMdSetting(
|
|
cwd,
|
|
settingsService,
|
|
'[DescribeFile]'
|
|
);
|
|
|
|
// Get model from phase settings with provider info
|
|
const {
|
|
phaseModel: phaseModelEntry,
|
|
provider,
|
|
credentials,
|
|
} = await getPhaseModelWithOverrides(
|
|
'fileDescriptionModel',
|
|
settingsService,
|
|
cwd,
|
|
'[DescribeFile]'
|
|
);
|
|
const { model, thinkingLevel } = resolvePhaseModel(phaseModelEntry);
|
|
|
|
logger.info(
|
|
`Resolved model: ${model}, thinkingLevel: ${thinkingLevel}`,
|
|
provider ? `via provider: ${provider.name}` : 'direct API'
|
|
);
|
|
|
|
// Use simpleQuery - provider abstraction handles routing to correct provider
|
|
const result = await simpleQuery({
|
|
prompt,
|
|
model,
|
|
cwd,
|
|
maxTurns: 1,
|
|
allowedTools: [],
|
|
thinkingLevel,
|
|
readOnly: true, // File description only reads, doesn't write
|
|
settingSources: autoLoadClaudeMd ? ['user', 'project', 'local'] : undefined,
|
|
claudeCompatibleProvider: provider, // Pass provider for alternative endpoint configuration
|
|
credentials, // Pass credentials for resolving 'credentials' apiKeySource
|
|
});
|
|
|
|
const description = result.text;
|
|
|
|
if (!description || description.trim().length === 0) {
|
|
logger.warn('Received empty response from Claude');
|
|
const response: DescribeFileErrorResponse = {
|
|
success: false,
|
|
error: 'Failed to generate description - empty response',
|
|
};
|
|
res.status(500).json(response);
|
|
return;
|
|
}
|
|
|
|
logger.info(`Description generated, length: ${description.length} chars`);
|
|
|
|
const response: DescribeFileSuccessResponse = {
|
|
success: true,
|
|
description: description.trim(),
|
|
};
|
|
res.json(response);
|
|
} catch (error) {
|
|
const errorMessage = error instanceof Error ? error.message : 'Unknown error occurred';
|
|
logger.error('File description failed:', errorMessage);
|
|
|
|
const response: DescribeFileErrorResponse = {
|
|
success: false,
|
|
error: errorMessage,
|
|
};
|
|
res.status(500).json(response);
|
|
}
|
|
};
|
|
}
|