mirror of
https://github.com/AutoMaker-Org/automaker.git
synced 2026-01-30 06:12:03 +00:00
- Add isExecutable() helper to verify files have execute permission - On Unix: uses fs.constants.X_OK to check execute permission - On Windows: only checks file existence (X_OK not meaningful) - Replace fs.existsSync with isExecutable for all node path checks - Add JSDoc comment documenting version sorting limitations - Add test to verify found node binary is executable 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
145 lines
4.7 KiB
TypeScript
145 lines
4.7 KiB
TypeScript
import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest';
|
|
import { findNodeExecutable, buildEnhancedPath } from '../src/node-finder.js';
|
|
import path from 'path';
|
|
import fs from 'fs';
|
|
|
|
describe('node-finder', () => {
|
|
describe('findNodeExecutable', () => {
|
|
it("should return 'node' with fallback source when skipSearch is true", () => {
|
|
const result = findNodeExecutable({ skipSearch: true });
|
|
|
|
expect(result.nodePath).toBe('node');
|
|
expect(result.source).toBe('fallback');
|
|
});
|
|
|
|
it('should call logger when node is found', () => {
|
|
const logger = vi.fn();
|
|
findNodeExecutable({ logger });
|
|
|
|
// Logger should be called at least once (either found or fallback message)
|
|
expect(logger).toHaveBeenCalled();
|
|
});
|
|
|
|
it('should return a valid NodeFinderResult structure', () => {
|
|
const result = findNodeExecutable();
|
|
|
|
expect(result).toHaveProperty('nodePath');
|
|
expect(result).toHaveProperty('source');
|
|
expect(typeof result.nodePath).toBe('string');
|
|
expect(result.nodePath.length).toBeGreaterThan(0);
|
|
});
|
|
|
|
it('should find node on the current system', () => {
|
|
// This test verifies that node can be found on the test machine
|
|
const result = findNodeExecutable();
|
|
|
|
// Should find node since we're running in Node.js
|
|
expect(result.nodePath).toBeDefined();
|
|
|
|
// Source should be one of the valid sources
|
|
const validSources = [
|
|
'homebrew',
|
|
'system',
|
|
'nvm',
|
|
'fnm',
|
|
'nvm-windows',
|
|
'program-files',
|
|
'scoop',
|
|
'chocolatey',
|
|
'which',
|
|
'where',
|
|
'fallback',
|
|
];
|
|
expect(validSources).toContain(result.source);
|
|
});
|
|
|
|
it('should find an executable node binary', () => {
|
|
const result = findNodeExecutable();
|
|
|
|
// Skip this test if fallback is used (node not found via path search)
|
|
if (result.source === 'fallback') {
|
|
expect(result.nodePath).toBe('node');
|
|
return;
|
|
}
|
|
|
|
// Verify the found path is actually executable
|
|
if (process.platform === 'win32') {
|
|
// On Windows, just check file exists (X_OK is not meaningful)
|
|
expect(() => fs.accessSync(result.nodePath, fs.constants.F_OK)).not.toThrow();
|
|
} else {
|
|
// On Unix-like systems, verify execute permission
|
|
expect(() => fs.accessSync(result.nodePath, fs.constants.X_OK)).not.toThrow();
|
|
}
|
|
});
|
|
});
|
|
|
|
describe('buildEnhancedPath', () => {
|
|
const delimiter = path.delimiter;
|
|
|
|
it("should return current path unchanged when nodePath is 'node'", () => {
|
|
const currentPath = '/usr/bin:/usr/local/bin';
|
|
const result = buildEnhancedPath('node', currentPath);
|
|
|
|
expect(result).toBe(currentPath);
|
|
});
|
|
|
|
it("should return empty string when nodePath is 'node' and currentPath is empty", () => {
|
|
const result = buildEnhancedPath('node', '');
|
|
|
|
expect(result).toBe('');
|
|
});
|
|
|
|
it('should prepend node directory to path', () => {
|
|
const nodePath = '/opt/homebrew/bin/node';
|
|
const currentPath = '/usr/bin:/usr/local/bin';
|
|
|
|
const result = buildEnhancedPath(nodePath, currentPath);
|
|
|
|
expect(result).toBe(`/opt/homebrew/bin${delimiter}${currentPath}`);
|
|
});
|
|
|
|
it('should not duplicate node directory if already in path', () => {
|
|
const nodePath = '/usr/local/bin/node';
|
|
const currentPath = '/usr/local/bin:/usr/bin';
|
|
|
|
const result = buildEnhancedPath(nodePath, currentPath);
|
|
|
|
expect(result).toBe(currentPath);
|
|
});
|
|
|
|
it('should handle empty currentPath without trailing delimiter', () => {
|
|
const nodePath = '/opt/homebrew/bin/node';
|
|
|
|
const result = buildEnhancedPath(nodePath, '');
|
|
|
|
expect(result).toBe('/opt/homebrew/bin');
|
|
});
|
|
|
|
it('should handle Windows-style paths', () => {
|
|
// On Windows, path.dirname recognizes backslash paths
|
|
// On other platforms, backslash is not a path separator
|
|
const nodePath = 'C:\\Program Files\\nodejs\\node.exe';
|
|
const currentPath = 'C:\\Windows\\System32';
|
|
|
|
const result = buildEnhancedPath(nodePath, currentPath);
|
|
|
|
if (process.platform === 'win32') {
|
|
// On Windows, should prepend the node directory
|
|
expect(result).toBe(`C:\\Program Files\\nodejs${delimiter}${currentPath}`);
|
|
} else {
|
|
// On non-Windows, backslash paths are treated as relative paths
|
|
// path.dirname returns '.' so the function returns currentPath unchanged
|
|
expect(result).toBe(currentPath);
|
|
}
|
|
});
|
|
|
|
it('should use default empty string for currentPath', () => {
|
|
const nodePath = '/usr/local/bin/node';
|
|
|
|
const result = buildEnhancedPath(nodePath);
|
|
|
|
expect(result).toBe('/usr/local/bin');
|
|
});
|
|
});
|
|
});
|