Files
automaker/apps/ui/tests/memory/mobile-memory-view.spec.ts
gsxdsm 583c3eb4a6 Make memory and context views mobile-friendly (#813)
* Changes from fix/memory-and-context-mobile-friendly

* fix: Improve file extension detection and add path traversal protection

* refactor: Extract file extension utilities and add path traversal guards

Code review improvements:
- Extract isMarkdownFilename and isImageFilename to shared image-utils.ts
- Remove duplicated code from context-view.tsx and memory-view.tsx
- Add path traversal guard for context fixture utilities (matching memory)
- Add 7 new tests for context fixture path traversal protection
- Total 61 tests pass

Addresses code review feedback from PR #813

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* test: Add e2e tests for profiles crud and board background persistence

* Update apps/ui/playwright.config.ts

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* fix: Add robust test navigation handling and file filtering

* fix: Format NODE_OPTIONS configuration on single line

* test: Update profiles and board background persistence tests

* test: Replace iPhone 13 Pro with Pixel 5 for mobile test consistency

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
2026-02-26 03:31:40 -08:00

274 lines
9.5 KiB
TypeScript

/**
* Mobile Memory View E2E Tests
*
* Tests for mobile-friendly behavior in the memory view:
* - File list hides when file is selected on mobile
* - Back button appears on mobile to return to file list
* - Toolbar buttons are icon-only on mobile
* - Delete button is hidden on mobile (use dropdown menu instead)
*/
import { test, expect, devices } from '@playwright/test';
import {
resetMemoryDirectory,
setupProjectWithFixture,
getFixturePath,
navigateToMemory,
waitForMemoryFile,
selectMemoryFile,
waitForMemoryContentToLoad,
clickElement,
fillInput,
waitForNetworkIdle,
authenticateForTests,
waitForElementHidden,
} from '../utils';
// Use mobile viewport for mobile tests in Chromium CI
test.use({ ...devices['Pixel 5'] });
test.describe('Mobile Memory View', () => {
test.beforeEach(async () => {
resetMemoryDirectory();
});
test.afterEach(async () => {
resetMemoryDirectory();
});
test('should hide file list when a file is selected on mobile', async ({ page }) => {
const fileName = 'mobile-test.md';
await setupProjectWithFixture(page, getFixturePath());
await authenticateForTests(page);
await navigateToMemory(page);
// Create a test file - on mobile, open the actions panel first
await clickElement(page, 'header-actions-panel-trigger');
await clickElement(page, 'create-memory-button-mobile');
await page.waitForSelector('[data-testid="create-memory-dialog"]', { timeout: 5000 });
await fillInput(page, 'new-memory-name', fileName);
await fillInput(page, 'new-memory-content', '# Mobile Test\n\nThis tests mobile view behavior');
await clickElement(page, 'confirm-create-memory');
await waitForElementHidden(page, 'create-memory-dialog', { timeout: 5000 });
await waitForNetworkIdle(page);
await waitForMemoryFile(page, fileName);
// File list should be visible before selection
const fileListBefore = page.locator('[data-testid="memory-file-list"]');
await expect(fileListBefore).toBeVisible();
// Select the file
await selectMemoryFile(page, fileName);
await waitForMemoryContentToLoad(page);
// On mobile, file list should be hidden after selection (full-screen editor)
const fileListAfter = page.locator('[data-testid="memory-file-list"]');
await expect(fileListAfter).toBeHidden();
});
test('should show back button in editor toolbar on mobile', async ({ page }) => {
const fileName = 'back-button-test.md';
await setupProjectWithFixture(page, getFixturePath());
await authenticateForTests(page);
await navigateToMemory(page);
// Create a test file - on mobile, open the actions panel first
await clickElement(page, 'header-actions-panel-trigger');
await clickElement(page, 'create-memory-button-mobile');
await page.waitForSelector('[data-testid="create-memory-dialog"]', { timeout: 5000 });
await fillInput(page, 'new-memory-name', fileName);
await fillInput(
page,
'new-memory-content',
'# Back Button Test\n\nTesting back button on mobile'
);
await clickElement(page, 'confirm-create-memory');
await waitForElementHidden(page, 'create-memory-dialog', { timeout: 5000 });
await waitForNetworkIdle(page);
await waitForMemoryFile(page, fileName);
// Select the file
await selectMemoryFile(page, fileName);
await waitForMemoryContentToLoad(page);
// Back button should be visible on mobile
const backButton = page.locator('button[aria-label="Back"]');
await expect(backButton).toBeVisible();
// Back button should have ArrowLeft icon
const arrowIcon = backButton.locator('svg.lucide-arrow-left');
await expect(arrowIcon).toBeVisible();
});
test('should return to file list when back button is clicked on mobile', async ({ page }) => {
const fileName = 'back-navigation-test.md';
await setupProjectWithFixture(page, getFixturePath());
await authenticateForTests(page);
await navigateToMemory(page);
// Create a test file - on mobile, open the actions panel first
await clickElement(page, 'header-actions-panel-trigger');
await clickElement(page, 'create-memory-button-mobile');
await page.waitForSelector('[data-testid="create-memory-dialog"]', { timeout: 5000 });
await fillInput(page, 'new-memory-name', fileName);
await fillInput(page, 'new-memory-content', '# Back Navigation Test');
await clickElement(page, 'confirm-create-memory');
await waitForElementHidden(page, 'create-memory-dialog', { timeout: 5000 });
await waitForNetworkIdle(page);
await waitForMemoryFile(page, fileName);
// Select the file
await selectMemoryFile(page, fileName);
await waitForMemoryContentToLoad(page);
// File list should be hidden after selection
const fileListHidden = page.locator('[data-testid="memory-file-list"]');
await expect(fileListHidden).toBeHidden();
// Click back button
const backButton = page.locator('button[aria-label="Back"]');
await backButton.click();
// File list should be visible again
const fileListVisible = page.locator('[data-testid="memory-file-list"]');
await expect(fileListVisible).toBeVisible();
// Editor should no longer be visible
const editor = page.locator('[data-testid="memory-editor"]');
await expect(editor).not.toBeVisible();
});
test('should show icon-only buttons in toolbar on mobile', async ({ page }) => {
const fileName = 'icon-buttons-test.md';
await setupProjectWithFixture(page, getFixturePath());
await authenticateForTests(page);
await navigateToMemory(page);
// Create a test file - on mobile, open the actions panel first
await clickElement(page, 'header-actions-panel-trigger');
await clickElement(page, 'create-memory-button-mobile');
await page.waitForSelector('[data-testid="create-memory-dialog"]', { timeout: 5000 });
await fillInput(page, 'new-memory-name', fileName);
await fillInput(
page,
'new-memory-content',
'# Icon Buttons Test\n\nTesting icon-only buttons on mobile'
);
await clickElement(page, 'confirm-create-memory');
await waitForElementHidden(page, 'create-memory-dialog', { timeout: 5000 });
await waitForNetworkIdle(page);
await waitForMemoryFile(page, fileName);
// Select the file
await selectMemoryFile(page, fileName);
await waitForMemoryContentToLoad(page);
// Get the toggle preview mode button
const toggleButton = page.locator('[data-testid="toggle-preview-mode"]');
await expect(toggleButton).toBeVisible();
// Button should have icon (Eye or Pencil)
const eyeIcon = toggleButton.locator('svg.lucide-eye');
const pencilIcon = toggleButton.locator('svg.lucide-pencil');
// One of the icons should be present
const hasIcon = await (async () => {
const eyeVisible = await eyeIcon.isVisible().catch(() => false);
const pencilVisible = await pencilIcon.isVisible().catch(() => false);
return eyeVisible || pencilVisible;
})();
expect(hasIcon).toBe(true);
// Text label should not be present (or minimal space on mobile)
const buttonText = await toggleButton.textContent();
// On mobile, button should have icon only (no "Edit" or "Preview" text visible)
// The text is wrapped in {!isMobile && <span>}, so it shouldn't render
expect(buttonText?.trim()).toBe('');
});
test('should hide delete button in toolbar on mobile', async ({ page }) => {
const fileName = 'delete-button-test.md';
await setupProjectWithFixture(page, getFixturePath());
await authenticateForTests(page);
await navigateToMemory(page);
// Create a test file - on mobile, open the actions panel first
await clickElement(page, 'header-actions-panel-trigger');
await clickElement(page, 'create-memory-button-mobile');
await page.waitForSelector('[data-testid="create-memory-dialog"]', { timeout: 5000 });
await fillInput(page, 'new-memory-name', fileName);
await fillInput(page, 'new-memory-content', '# Delete Button Test');
await clickElement(page, 'confirm-create-memory');
await waitForElementHidden(page, 'create-memory-dialog', { timeout: 5000 });
await waitForNetworkIdle(page);
await waitForMemoryFile(page, fileName);
// Select the file
await selectMemoryFile(page, fileName);
await waitForMemoryContentToLoad(page);
// Delete button in toolbar should be hidden on mobile
const deleteButton = page.locator('[data-testid="delete-memory-file"]');
await expect(deleteButton).not.toBeVisible();
});
test('should show file list at full width on mobile when no file is selected', async ({
page,
}) => {
await setupProjectWithFixture(page, getFixturePath());
await authenticateForTests(page);
await navigateToMemory(page);
// File list should be visible
const fileList = page.locator('[data-testid="memory-file-list"]');
await expect(fileList).toBeVisible();
// On mobile with no file selected, the file list should take full width
// Check that the file list container has the w-full class (mobile behavior)
const fileListBox = await fileList.boundingBox();
expect(fileListBox).not.toBeNull();
if (fileListBox) {
// On mobile (Pixel 5 has width 393), the file list should take most of the width
// We check that it's significantly wider than the desktop w-64 (256px)
expect(fileListBox.width).toBeGreaterThan(300);
}
// Editor panel should be hidden on mobile when no file is selected
const editor = page.locator('[data-testid="memory-editor"]');
await expect(editor).not.toBeVisible();
});
});