mirror of
https://github.com/AutoMaker-Org/automaker.git
synced 2026-03-17 22:13:08 +00:00
* fix(copilot): correct tool.execution_complete event handling The CopilotProvider was using incorrect event type and data structure for tool execution completion events from the @github/copilot-sdk, causing tool call outputs to be empty. Changes: - Update event type from 'tool.execution_end' to 'tool.execution_complete' - Fix data structure to use nested result.content instead of flat result - Fix error structure to use error.message instead of flat error - Add success field to match SDK event structure - Add tests for empty and missing result handling This aligns with the official @github/copilot-sdk v0.1.16 types defined in session-events.d.ts. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * test(copilot): add edge case test for error with code field Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * refactor(copilot): improve error handling and code quality Code review improvements: - Extract magic string '[ERROR]' to TOOL_ERROR_PREFIX constant - Add null-safe error handling with direct error variable assignment - Include error codes in error messages for better debugging - Add JSDoc documentation for tool.execution_complete handler - Update tests to verify error codes are displayed - Add missing tool_use_id assertion in error test These changes improve: - Code maintainability (no magic strings) - Debugging experience (error codes now visible) - Type safety (explicit null checks) - Test coverage (verify error code formatting) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Changes from fix/bug-fixes-1-0 * test(copilot): add edge case test for error with code field Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Changes from fix/bug-fixes-1-0 * fix: Handle detached HEAD state in worktree discovery and recovery * fix: Remove unused isDevServerStarting prop and md: breakpoint classes * fix: Add missing dependency and sanitize persisted cache data * feat: Ensure NODE_ENV is set to test in vitest configs * feat: Configure Playwright to run only E2E tests * fix: Improve PR tracking and dev server lifecycle management * feat: Add settings-based defaults for planning mode, model config, and custom providers. Fixes #816 * feat: Add worktree and branch selector to graph view * fix: Add timeout and error handling for worktree HEAD ref resolution * fix: use absolute icon path and place icon outside asar on Linux The hicolor icon theme index only lists sizes up to 512x512, so an icon installed only at 1024x1024 is invisible to GNOME/KDE's theme resolver, causing both the app launcher and taskbar to show a generic icon. Additionally, BrowserWindow.icon cannot be read by the window manager when the file is inside app.asar. - extraResources: copy logo_larger.png to resources/ (outside asar) so it lands at /opt/Automaker/resources/logo_larger.png on install - linux.desktop.Icon: set to the absolute resources path, bypassing the hicolor theme lookup and its size constraints entirely - icon-manager.ts: on Linux production use process.resourcesPath so BrowserWindow receives a real filesystem path the WM can read directly Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: use linux.desktop.entry for custom desktop Icon field electron-builder v26 rejects arbitrary keys in linux.desktop — the correct schema wraps custom .desktop overrides inside desktop.entry. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: set desktop name on Linux so taskbar uses the correct app icon Without app.setDesktopName(), the window manager cannot associate the running Electron process with automaker.desktop. GNOME/KDE fall back to _NET_WM_ICON which defaults to Electron's own bundled icon. Calling app.setDesktopName('automaker.desktop') before any window is created sets the _GTK_APPLICATION_ID hint and XDG app_id so the WM picks up the desktop entry's Icon for the taskbar. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Fix: memory and context views mobile friendly (#818) * Changes from fix/memory-and-context-mobile-friendly * fix: Improve file extension detection and add path traversal protection * refactor: Extract file extension utilities and add path traversal guards Code review improvements: - Extract isMarkdownFilename and isImageFilename to shared image-utils.ts - Remove duplicated code from context-view.tsx and memory-view.tsx - Add path traversal guard for context fixture utilities (matching memory) - Add 7 new tests for context fixture path traversal protection - Total 61 tests pass Addresses code review feedback from PR #813 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * test: Add e2e tests for profiles crud and board background persistence * Update apps/ui/playwright.config.ts Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * fix: Add robust test navigation handling and file filtering * fix: Format NODE_OPTIONS configuration on single line * test: Update profiles and board background persistence tests * test: Replace iPhone 13 Pro with Pixel 5 for mobile test consistency * Update apps/ui/src/components/views/context-view.tsx Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * chore: Remove test project directory * feat: Filter context files by type and improve mobile menu visibility --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * fix: Improve test reliability and localhost handling * chore: Use explicit TEST_USE_EXTERNAL_BACKEND env var for server cleanup * feat: Add E2E/CI mock mode for provider factory and auth verification * feat: Add remoteBranch parameter to pull and rebase operations * chore: Enhance E2E testing setup with worker isolation and auth state management - Updated .gitignore to include worker-specific test fixtures. - Modified e2e-tests.yml to implement test sharding for improved CI performance. - Refactored global setup to authenticate once and save session state for reuse across tests. - Introduced worker-isolated fixture paths to prevent conflicts during parallel test execution. - Improved test navigation and loading handling for better reliability. - Updated various test files to utilize new auth state management and fixture paths. * fix: Update Playwright configuration and improve test reliability - Increased the number of workers in Playwright configuration for better parallelism in CI environments. - Enhanced the board background persistence test to ensure dropdown stability by waiting for the list to populate before interaction, improving test reliability. * chore: Simplify E2E test configuration and enhance mock implementations - Updated e2e-tests.yml to run tests in a single shard for streamlined CI execution. - Enhanced unit tests for worktree list handling by introducing a mock for execGitCommand, improving test reliability and coverage. - Refactored setup functions to better manage command mocks for git operations in tests. - Improved error handling in mkdirSafe function to account for undefined stats in certain environments. * refactor: Improve test configurations and enhance error handling - Updated Playwright configuration to clear VITE_SERVER_URL, ensuring the frontend uses the Vite proxy and preventing cookie domain mismatches. - Enhanced MergeRebaseDialog logic to normalize selectedBranch for better handling of various ref formats. - Improved global setup with a more robust backend health check, throwing an error if the backend is not healthy after retries. - Refactored project creation tests to handle file existence checks more reliably. - Added error handling for missing E2E source fixtures to guide setup process. - Enhanced memory navigation to handle sandbox dialog visibility more effectively. * refactor: Enhance Git command execution and improve test configurations - Updated Git command execution to merge environment paths correctly, ensuring proper command execution context. - Refactored the Git initialization process to handle errors more gracefully and ensure user configuration is set before creating the initial commit. - Improved test configurations by updating Playwright test identifiers for better clarity and consistency across different project states. - Enhanced cleanup functions in tests to handle directory removal more robustly, preventing errors during test execution. * fix: Resolve React hooks errors from duplicate instances in dependency tree * style: Format alias configuration for improved readability --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: DhanushSantosh <dhanushsantoshs05@gmail.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
281 lines
8.6 KiB
TypeScript
281 lines
8.6 KiB
TypeScript
import { Page } from '@playwright/test';
|
|
import * as fs from 'fs';
|
|
import * as path from 'path';
|
|
import { getWorkspaceRoot, assertSafeProjectPath } from '../core/safe-paths';
|
|
|
|
export { getWorkspaceRoot };
|
|
|
|
const WORKSPACE_ROOT = getWorkspaceRoot();
|
|
const FIXTURE_PATH = path.join(WORKSPACE_ROOT, 'test/fixtures/projectA');
|
|
|
|
// Original spec content for resetting between tests
|
|
const ORIGINAL_SPEC_CONTENT = `<app_spec>
|
|
<name>Test Project A</name>
|
|
<description>A test fixture project for Playwright testing</description>
|
|
<tech_stack>
|
|
<item>TypeScript</item>
|
|
<item>React</item>
|
|
</tech_stack>
|
|
</app_spec>
|
|
`;
|
|
|
|
// Worker-isolated fixture path to avoid conflicts when running tests in parallel.
|
|
// Each Playwright worker gets its own copy of the fixture directory.
|
|
let _workerFixturePath: string | null = null;
|
|
|
|
/**
|
|
* Bootstrap the shared fixture directory if it doesn't exist.
|
|
* The fixture contains a nested .git/ dir so it can't be tracked by the
|
|
* parent repo — in CI this directory won't exist after checkout.
|
|
*/
|
|
function ensureFixtureExists(): void {
|
|
if (fs.existsSync(FIXTURE_PATH)) return;
|
|
|
|
fs.mkdirSync(path.join(FIXTURE_PATH, '.automaker/context'), { recursive: true });
|
|
|
|
fs.writeFileSync(path.join(FIXTURE_PATH, '.automaker/app_spec.txt'), ORIGINAL_SPEC_CONTENT);
|
|
fs.writeFileSync(path.join(FIXTURE_PATH, '.automaker/categories.json'), '[]');
|
|
fs.writeFileSync(
|
|
path.join(FIXTURE_PATH, '.automaker/context/context-metadata.json'),
|
|
'{"files": {}}'
|
|
);
|
|
}
|
|
|
|
/**
|
|
* Get a worker-isolated fixture path. Creates a copy of the fixture directory
|
|
* for this worker process so parallel tests don't conflict.
|
|
* Falls back to the shared fixture path for backwards compatibility.
|
|
*/
|
|
function getWorkerFixturePath(): string {
|
|
if (_workerFixturePath) return _workerFixturePath;
|
|
|
|
// Ensure the source fixture exists (may not in CI)
|
|
ensureFixtureExists();
|
|
|
|
if (!fs.existsSync(FIXTURE_PATH)) {
|
|
throw new Error(
|
|
`E2E source fixture is missing at ${FIXTURE_PATH}. ` +
|
|
'Run the setup script to create it: from apps/ui, run `node scripts/setup-e2e-fixtures.mjs` (or use `pnpm test`, which runs it via pretest).'
|
|
);
|
|
}
|
|
|
|
// Use process.pid + a unique suffix to isolate per-worker
|
|
const workerId = process.env.TEST_WORKER_INDEX || process.pid.toString();
|
|
const workerDir = path.join(WORKSPACE_ROOT, `test/fixtures/.worker-${workerId}`);
|
|
|
|
// Copy projectA fixture to worker directory if it doesn't exist
|
|
if (!fs.existsSync(workerDir)) {
|
|
fs.cpSync(FIXTURE_PATH, workerDir, { recursive: true });
|
|
}
|
|
|
|
_workerFixturePath = workerDir;
|
|
return workerDir;
|
|
}
|
|
|
|
/**
|
|
* Get the worker-isolated context path
|
|
*/
|
|
function getWorkerContextPath(): string {
|
|
return path.join(getWorkerFixturePath(), '.automaker/context');
|
|
}
|
|
|
|
/**
|
|
* Get the worker-isolated memory path
|
|
*/
|
|
function getWorkerMemoryPath(): string {
|
|
return path.join(getWorkerFixturePath(), '.automaker/memory');
|
|
}
|
|
|
|
/**
|
|
* Get the worker-isolated spec file path
|
|
*/
|
|
function getWorkerSpecPath(): string {
|
|
return path.join(getWorkerFixturePath(), '.automaker/app_spec.txt');
|
|
}
|
|
|
|
/**
|
|
* Reset the fixture's app_spec.txt to original content
|
|
*/
|
|
export function resetFixtureSpec(): void {
|
|
const specPath = getWorkerSpecPath();
|
|
const dir = path.dirname(specPath);
|
|
if (!fs.existsSync(dir)) {
|
|
fs.mkdirSync(dir, { recursive: true });
|
|
}
|
|
fs.writeFileSync(specPath, ORIGINAL_SPEC_CONTENT);
|
|
}
|
|
|
|
/**
|
|
* Reset the context directory to empty state
|
|
*/
|
|
export function resetContextDirectory(): void {
|
|
const contextPath = getWorkerContextPath();
|
|
if (fs.existsSync(contextPath)) {
|
|
fs.rmSync(contextPath, { recursive: true });
|
|
}
|
|
fs.mkdirSync(contextPath, { recursive: true });
|
|
}
|
|
|
|
/**
|
|
* Reset the memory directory to empty state
|
|
*/
|
|
export function resetMemoryDirectory(): void {
|
|
const memoryPath = getWorkerMemoryPath();
|
|
if (fs.existsSync(memoryPath)) {
|
|
fs.rmSync(memoryPath, { recursive: true });
|
|
}
|
|
fs.mkdirSync(memoryPath, { recursive: true });
|
|
}
|
|
|
|
/**
|
|
* Resolve and validate a context fixture path to prevent path traversal
|
|
*/
|
|
function resolveContextFixturePath(filename: string): string {
|
|
const contextPath = getWorkerContextPath();
|
|
const resolved = path.resolve(contextPath, filename);
|
|
const base = path.resolve(contextPath) + path.sep;
|
|
if (!resolved.startsWith(base)) {
|
|
throw new Error(`Invalid context filename: ${filename}`);
|
|
}
|
|
return resolved;
|
|
}
|
|
|
|
/**
|
|
* Create a context file directly on disk (for test setup)
|
|
*/
|
|
export function createContextFileOnDisk(filename: string, content: string): void {
|
|
const filePath = resolveContextFixturePath(filename);
|
|
fs.writeFileSync(filePath, content);
|
|
}
|
|
|
|
/**
|
|
* Resolve and validate a memory fixture path to prevent path traversal
|
|
*/
|
|
function resolveMemoryFixturePath(filename: string): string {
|
|
const memoryPath = getWorkerMemoryPath();
|
|
const resolved = path.resolve(memoryPath, filename);
|
|
const base = path.resolve(memoryPath) + path.sep;
|
|
if (!resolved.startsWith(base)) {
|
|
throw new Error(`Invalid memory filename: ${filename}`);
|
|
}
|
|
return resolved;
|
|
}
|
|
|
|
/**
|
|
* Create a memory file directly on disk (for test setup)
|
|
*/
|
|
export function createMemoryFileOnDisk(filename: string, content: string): void {
|
|
const filePath = resolveMemoryFixturePath(filename);
|
|
fs.writeFileSync(filePath, content);
|
|
}
|
|
|
|
/**
|
|
* Check if a context file exists on disk
|
|
*/
|
|
export function contextFileExistsOnDisk(filename: string): boolean {
|
|
const filePath = resolveContextFixturePath(filename);
|
|
return fs.existsSync(filePath);
|
|
}
|
|
|
|
/**
|
|
* Check if a memory file exists on disk
|
|
*/
|
|
export function memoryFileExistsOnDisk(filename: string): boolean {
|
|
const filePath = resolveMemoryFixturePath(filename);
|
|
return fs.existsSync(filePath);
|
|
}
|
|
|
|
/**
|
|
* Set up localStorage with a project pointing to our test fixture
|
|
* Note: In CI, setup wizard is also skipped via NEXT_PUBLIC_SKIP_SETUP env var
|
|
* Project path must be under test/ or temp to avoid affecting the main project's git.
|
|
* Defaults to a worker-isolated copy of the fixture to support parallel test execution.
|
|
*/
|
|
export async function setupProjectWithFixture(
|
|
page: Page,
|
|
projectPath: string = getWorkerFixturePath()
|
|
): Promise<void> {
|
|
assertSafeProjectPath(projectPath);
|
|
await page.addInitScript((pathArg: string) => {
|
|
const mockProject = {
|
|
id: 'test-project-fixture',
|
|
name: 'projectA',
|
|
path: pathArg,
|
|
lastOpened: new Date().toISOString(),
|
|
};
|
|
|
|
const mockState = {
|
|
state: {
|
|
projects: [mockProject],
|
|
currentProject: mockProject,
|
|
currentView: 'board',
|
|
theme: 'dark',
|
|
sidebarOpen: true,
|
|
skipSandboxWarning: true,
|
|
apiKeys: { anthropic: '', google: '' },
|
|
chatSessions: [],
|
|
chatHistoryOpen: false,
|
|
maxConcurrency: 3,
|
|
},
|
|
version: 2, // Must match app-store.ts persist version
|
|
};
|
|
|
|
localStorage.setItem('automaker-storage', JSON.stringify(mockState));
|
|
|
|
// Also mark setup as complete (fallback for when NEXT_PUBLIC_SKIP_SETUP isn't set)
|
|
const setupState = {
|
|
state: {
|
|
isFirstRun: false,
|
|
setupComplete: true,
|
|
currentStep: 'complete',
|
|
skipClaudeSetup: false,
|
|
},
|
|
version: 0, // setup-store.ts doesn't specify a version, so zustand defaults to 0
|
|
};
|
|
localStorage.setItem('automaker-setup', JSON.stringify(setupState));
|
|
|
|
// Set settings cache so the fast-hydrate path uses our fixture project.
|
|
// Without this, a stale settings cache from a previous test can override
|
|
// the project we just set in automaker-storage.
|
|
const settingsCache = {
|
|
setupComplete: true,
|
|
isFirstRun: false,
|
|
projects: [
|
|
{
|
|
id: mockProject.id,
|
|
name: mockProject.name,
|
|
path: mockProject.path,
|
|
lastOpened: mockProject.lastOpened,
|
|
},
|
|
],
|
|
currentProjectId: mockProject.id,
|
|
theme: 'dark',
|
|
sidebarOpen: true,
|
|
maxConcurrency: 3,
|
|
skipSandboxWarning: true,
|
|
};
|
|
localStorage.setItem('automaker-settings-cache', JSON.stringify(settingsCache));
|
|
|
|
// Disable splash screen in tests
|
|
localStorage.setItem('automaker-disable-splash', 'true');
|
|
}, projectPath);
|
|
}
|
|
|
|
/**
|
|
* Get the fixture path (worker-isolated for parallel test execution)
|
|
*/
|
|
export function getFixturePath(): string {
|
|
return getWorkerFixturePath();
|
|
}
|
|
|
|
/**
|
|
* Set up a mock project with the fixture path (for profile/settings tests that need a project).
|
|
* Options such as customProfilesCount are reserved for future use (e.g. mocking server profile state).
|
|
*/
|
|
export async function setupMockProjectWithProfiles(
|
|
page: Page,
|
|
_options?: { customProfilesCount?: number }
|
|
): Promise<void> {
|
|
await setupProjectWithFixture(page);
|
|
}
|