Files
automaker/apps/ui/tests/features/running-task-card-display.spec.ts
gsxdsm 0a5540c9a2 Fix concurrency limits and remote branch fetching issues (#788)
* Changes from fix/bug-fixes

* feat: Refactor worktree iteration and improve error logging across services

* feat: Extract URL/port patterns to module level and fix abort condition

* fix: Improve IPv6 loopback handling, select component layout, and terminal UI

* feat: Add thinking level defaults and adjust list row padding

* Update apps/ui/src/store/app-store.ts

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* feat: Add worktree-aware terminal creation and split options, fix npm security issues from audit

* feat: Add tracked remote detection to pull dialog flow

* feat: Add merge state tracking to git operations

* feat: Improve merge detection and add post-merge action preferences

* Update apps/ui/src/components/views/board-view/dialogs/git-pull-dialog.tsx

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* Update apps/ui/src/components/views/board-view/dialogs/git-pull-dialog.tsx

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* fix: Pass merge detection info to stash reapplication and handle merge state consistently

* fix: Call onPulled callback in merge handlers and add validation checks

---------

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
2026-02-20 13:48:22 -08:00

212 lines
8.2 KiB
TypeScript

/**
* Running Task Card Display E2E Test
*
* Tests that task cards with a running state display the correct UI controls.
*
* This test verifies that:
* 1. A feature in the in_progress column with status 'in_progress' shows Logs/Stop controls (not Make)
* 2. A feature with status 'backlog' that is tracked as running (stale status race condition)
* shows Logs/Stop controls instead of the Make button when placed in in_progress column
* 3. The Make button only appears for genuinely idle backlog/interrupted/ready features
* 4. Features in backlog that are NOT running show the correct Edit/Make buttons
*/
import { test, expect } from '@playwright/test';
import * as fs from 'fs';
import * as path from 'path';
import {
createTempDirPath,
cleanupTempDir,
setupRealProject,
waitForNetworkIdle,
getKanbanColumn,
authenticateForTests,
handleLoginScreenIfPresent,
} from '../utils';
const TEST_TEMP_DIR = createTempDirPath('running-task-display-test');
// Generate deterministic projectId once at test module load
const TEST_PROJECT_ID = `project-running-task-${Date.now()}`;
test.describe('Running Task Card Display', () => {
let projectPath: string;
const projectName = `test-project-${Date.now()}`;
const backlogFeatureId = 'test-feature-backlog';
const inProgressFeatureId = 'test-feature-in-progress';
test.beforeAll(async () => {
if (!fs.existsSync(TEST_TEMP_DIR)) {
fs.mkdirSync(TEST_TEMP_DIR, { recursive: true });
}
projectPath = path.join(TEST_TEMP_DIR, projectName);
fs.mkdirSync(projectPath, { recursive: true });
fs.writeFileSync(
path.join(projectPath, 'package.json'),
JSON.stringify({ name: projectName, version: '1.0.0' }, null, 2)
);
const automakerDir = path.join(projectPath, '.automaker');
fs.mkdirSync(automakerDir, { recursive: true });
fs.mkdirSync(path.join(automakerDir, 'features'), { recursive: true });
fs.mkdirSync(path.join(automakerDir, 'context'), { recursive: true });
fs.writeFileSync(
path.join(automakerDir, 'categories.json'),
JSON.stringify({ categories: [] }, null, 2)
);
fs.writeFileSync(
path.join(automakerDir, 'app_spec.txt'),
`# ${projectName}\n\nA test project for e2e testing.`
);
});
test.afterAll(async () => {
cleanupTempDir(TEST_TEMP_DIR);
});
test('should show Logs/Stop buttons for in_progress features, not Make button', async ({
page,
}) => {
// Set up the project in localStorage with a deterministic projectId
await setupRealProject(page, projectPath, projectName, {
setAsCurrent: true,
projectId: TEST_PROJECT_ID,
});
// Intercept settings API to ensure our test project remains current
await page.route('**/api/settings/global', async (route) => {
const method = route.request().method();
if (method === 'PUT') {
return route.continue();
}
const response = await route.fetch();
const json = await response.json();
if (json.settings) {
const existingProjects = json.settings.projects || [];
let testProject = existingProjects.find((p: { path: string }) => p.path === projectPath);
if (!testProject) {
testProject = {
id: TEST_PROJECT_ID,
name: projectName,
path: projectPath,
lastOpened: new Date().toISOString(),
};
json.settings.projects = [testProject, ...existingProjects];
}
json.settings.currentProjectId = testProject.id;
json.settings.setupComplete = true;
json.settings.isFirstRun = false;
}
await route.fulfill({ response, json });
});
await authenticateForTests(page);
// Navigate to board
await page.goto('/board');
await page.waitForLoadState('load');
await handleLoginScreenIfPresent(page);
await waitForNetworkIdle(page);
await expect(page.locator('[data-testid="board-view"]')).toBeVisible({ timeout: 10000 });
// Create a feature that is already in_progress status (simulates a running task)
const inProgressFeature = {
id: inProgressFeatureId,
description: 'Test feature that is currently running',
category: 'test',
status: 'in_progress',
skipTests: false,
model: 'sonnet',
thinkingLevel: 'none',
createdAt: new Date().toISOString(),
startedAt: new Date().toISOString(),
branchName: '',
priority: 2,
};
// Create a feature in backlog status (idle, should show Make button)
const backlogFeature = {
id: backlogFeatureId,
description: 'Test feature in backlog waiting to start',
category: 'test',
status: 'backlog',
skipTests: false,
model: 'sonnet',
thinkingLevel: 'none',
createdAt: new Date().toISOString(),
branchName: '',
priority: 2,
};
const API_BASE_URL = process.env.SERVER_URL || 'http://localhost:3008';
// Create both features via HTTP API
const createInProgress = await page.request.post(`${API_BASE_URL}/api/features/create`, {
data: { projectPath, feature: inProgressFeature },
headers: { 'Content-Type': 'application/json' },
});
if (!createInProgress.ok()) {
throw new Error(`Failed to create in_progress feature: ${await createInProgress.text()}`);
}
const createBacklog = await page.request.post(`${API_BASE_URL}/api/features/create`, {
data: { projectPath, feature: backlogFeature },
headers: { 'Content-Type': 'application/json' },
});
if (!createBacklog.ok()) {
throw new Error(`Failed to create backlog feature: ${await createBacklog.text()}`);
}
// Reload to pick up the new features
await page.reload();
await page.waitForLoadState('load');
await handleLoginScreenIfPresent(page);
await waitForNetworkIdle(page);
await expect(page.locator('[data-testid="board-view"]')).toBeVisible({ timeout: 10000 });
// Wait for both feature cards to appear
const inProgressCard = page.locator(`[data-testid="kanban-card-${inProgressFeatureId}"]`);
const backlogCard = page.locator(`[data-testid="kanban-card-${backlogFeatureId}"]`);
await expect(inProgressCard).toBeVisible({ timeout: 20000 });
await expect(backlogCard).toBeVisible({ timeout: 20000 });
// Verify the in_progress feature is in the in_progress column
const inProgressColumn = await getKanbanColumn(page, 'in_progress');
await expect(inProgressColumn).toBeVisible({ timeout: 5000 });
const cardInInProgress = inProgressColumn.locator(
`[data-testid="kanban-card-${inProgressFeatureId}"]`
);
await expect(cardInInProgress).toBeVisible({ timeout: 5000 });
// Verify the backlog feature is in the backlog column
const backlogColumn = await getKanbanColumn(page, 'backlog');
await expect(backlogColumn).toBeVisible({ timeout: 5000 });
const cardInBacklog = backlogColumn.locator(`[data-testid="kanban-card-${backlogFeatureId}"]`);
await expect(cardInBacklog).toBeVisible({ timeout: 5000 });
// CRITICAL: Verify the in_progress feature does NOT show a Make button
// The Make button should only appear on backlog/interrupted/ready features that are NOT running
const makeButtonOnInProgress = page.locator(`[data-testid="make-${inProgressFeatureId}"]`);
await expect(makeButtonOnInProgress).not.toBeVisible({ timeout: 3000 });
// Verify the in_progress feature shows appropriate controls
// (view-output/force-stop buttons should be present for in_progress without error)
const viewOutputButton = page.locator(`[data-testid="view-output-${inProgressFeatureId}"]`);
await expect(viewOutputButton).toBeVisible({ timeout: 5000 });
const forceStopButton = page.locator(`[data-testid="force-stop-${inProgressFeatureId}"]`);
await expect(forceStopButton).toBeVisible({ timeout: 5000 });
// Verify the backlog feature DOES show a Make button
const makeButtonOnBacklog = page.locator(`[data-testid="make-${backlogFeatureId}"]`);
await expect(makeButtonOnBacklog).toBeVisible({ timeout: 5000 });
// Verify the backlog feature also shows an Edit button
const editButton = page.locator(`[data-testid="edit-backlog-${backlogFeatureId}"]`);
await expect(editButton).toBeVisible({ timeout: 5000 });
});
});