Compare commits

..

1 Commits

Author SHA1 Message Date
Shirone
c7d2033277 fix: update structured output logic to support Claude and Codex models
- Modify the condition for using structured output to include both Claude and Codex models, ensuring compatibility with the latest model capabilities.
2026-01-23 15:55:36 +01:00
286 changed files with 9878 additions and 18021 deletions

View File

@@ -25,7 +25,6 @@ COPY libs/types/package*.json ./libs/types/
COPY libs/utils/package*.json ./libs/utils/ COPY libs/utils/package*.json ./libs/utils/
COPY libs/prompts/package*.json ./libs/prompts/ COPY libs/prompts/package*.json ./libs/prompts/
COPY libs/platform/package*.json ./libs/platform/ COPY libs/platform/package*.json ./libs/platform/
COPY libs/spec-parser/package*.json ./libs/spec-parser/
COPY libs/model-resolver/package*.json ./libs/model-resolver/ COPY libs/model-resolver/package*.json ./libs/model-resolver/
COPY libs/dependency-resolver/package*.json ./libs/dependency-resolver/ COPY libs/dependency-resolver/package*.json ./libs/dependency-resolver/
COPY libs/git-utils/package*.json ./libs/git-utils/ COPY libs/git-utils/package*.json ./libs/git-utils/

View File

@@ -288,31 +288,6 @@ services:
**Note:** The Claude CLI config must be writable (do not use `:ro` flag) as the CLI writes debug files. **Note:** The Claude CLI config must be writable (do not use `:ro` flag) as the CLI writes debug files.
> **⚠️ Important: Linux/WSL Users**
>
> The container runs as UID 1001 by default. If your host user has a different UID (common on Linux/WSL where the first user is UID 1000), you must create a `.env` file to match your host user:
>
> ```bash
> # Check your UID/GID
> id -u # outputs your UID (e.g., 1000)
> id -g # outputs your GID (e.g., 1000)
> ```
>
> Create a `.env` file in the automaker directory:
>
> ```
> UID=1000
> GID=1000
> ```
>
> Then rebuild the images:
>
> ```bash
> docker compose build
> ```
>
> Without this, files written by the container will be inaccessible to your host user.
##### GitHub CLI Authentication (For Git Push/PR Operations) ##### GitHub CLI Authentication (For Git Push/PR Operations)
To enable git push and GitHub CLI operations inside the container: To enable git push and GitHub CLI operations inside the container:

300
SECURITY_TODO.md Normal file
View File

@@ -0,0 +1,300 @@
# Security Audit Findings - v0.13.0rc Branch
**Date:** $(date)
**Audit Type:** Git diff security review against v0.13.0rc branch
**Status:** ⚠️ Security vulnerabilities found - requires fixes before release
## Executive Summary
No intentionally malicious code was detected in the changes. However, several **critical security vulnerabilities** were identified that could allow command injection attacks. These must be fixed before release.
---
## 🔴 Critical Security Issues
### 1. Command Injection in Merge Handler
**File:** `apps/server/src/routes/worktree/routes/merge.ts`
**Lines:** 43, 54, 65-66, 93
**Severity:** CRITICAL
**Issue:**
User-controlled inputs (`branchName`, `mergeTo`, `options?.message`) are directly interpolated into shell commands without validation, allowing command injection attacks.
**Vulnerable Code:**
```typescript
// Line 43 - branchName not validated
await execAsync(`git rev-parse --verify ${branchName}`, { cwd: projectPath });
// Line 54 - mergeTo not validated
await execAsync(`git rev-parse --verify ${mergeTo}`, { cwd: projectPath });
// Lines 65-66 - branchName and message not validated
const mergeCmd = options?.squash
? `git merge --squash ${branchName}`
: `git merge ${branchName} -m "${options?.message || `Merge ${branchName} into ${mergeTo}`}"`;
// Line 93 - message not sanitized
await execAsync(`git commit -m "${options?.message || `Merge ${branchName} (squash)`}"`, {
cwd: projectPath,
});
```
**Attack Vector:**
An attacker could inject shell commands via branch names or commit messages:
- Branch name: `main; rm -rf /`
- Commit message: `"; malicious_command; "`
**Fix Required:**
1. Validate `branchName` and `mergeTo` using `isValidBranchName()` before use
2. Sanitize commit messages or use `execGitCommand` with proper escaping
3. Replace `execAsync` template literals with `execGitCommand` array-based calls
**Note:** `isValidBranchName` is imported but only used AFTER deletion (line 119), not before execAsync calls.
---
### 2. Command Injection in Push Handler
**File:** `apps/server/src/routes/worktree/routes/push.ts`
**Lines:** 44, 49
**Severity:** CRITICAL
**Issue:**
User-controlled `remote` parameter and `branchName` are directly interpolated into shell commands without validation.
**Vulnerable Code:**
```typescript
// Line 38 - remote defaults to 'origin' but not validated
const targetRemote = remote || 'origin';
// Lines 44, 49 - targetRemote and branchName not validated
await execAsync(`git push -u ${targetRemote} ${branchName} ${forceFlag}`, {
cwd: worktreePath,
});
await execAsync(`git push --set-upstream ${targetRemote} ${branchName} ${forceFlag}`, {
cwd: worktreePath,
});
```
**Attack Vector:**
An attacker could inject commands via the remote name:
- Remote: `origin; malicious_command; #`
**Fix Required:**
1. Validate `targetRemote` parameter (alphanumeric + `-`, `_` only)
2. Validate `branchName` before use (even though it comes from git output)
3. Use `execGitCommand` with array arguments instead of template literals
---
### 3. Unsafe Environment Variable Export in Shell Script
**File:** `start-automaker.sh`
**Lines:** 5068, 5085
**Severity:** CRITICAL
**Issue:**
Unsafe parsing and export of `.env` file contents using `xargs` without proper handling of special characters.
**Vulnerable Code:**
```bash
export $(grep -v '^#' .env | xargs)
```
**Attack Vector:**
If `.env` file contains malicious content with spaces, special characters, or code, it could be executed:
- `.env` entry: `VAR="value; malicious_command"`
- Could lead to code execution during startup
**Fix Required:**
Replace with safer parsing method:
```bash
# Safer approach
set -a
source <(grep -v '^#' .env | sed 's/^/export /')
set +a
# Or even safer - validate each line
while IFS= read -r line; do
[[ "$line" =~ ^[[:space:]]*# ]] && continue
[[ -z "$line" ]] && continue
if [[ "$line" =~ ^([A-Za-z_][A-Za-z0-9_]*)=(.*)$ ]]; then
export "${BASH_REMATCH[1]}"="${BASH_REMATCH[2]}"
fi
done < .env
```
---
## 🟡 Moderate Security Concerns
### 4. Inconsistent Use of Secure Command Execution
**Issue:**
The codebase has `execGitCommand()` function available (which uses array arguments and is safer), but it's not consistently used. Some places still use `execAsync` with template literals.
**Files Affected:**
- `apps/server/src/routes/worktree/routes/merge.ts`
- `apps/server/src/routes/worktree/routes/push.ts`
**Recommendation:**
- Audit all `execAsync` calls with template literals
- Replace with `execGitCommand` where possible
- Document when `execAsync` is acceptable (only with fully validated inputs)
---
### 5. Missing Input Validation
**Issues:**
1. `targetRemote` in `push.ts` defaults to 'origin' but isn't validated
2. Commit messages in `merge.ts` aren't sanitized before use in shell commands
3. `worktreePath` validation relies on middleware but should be double-checked
**Recommendation:**
- Add validation functions for remote names
- Sanitize commit messages (remove shell metacharacters)
- Add defensive validation even when middleware exists
---
## ✅ Positive Security Findings
1. **No Hardcoded Credentials:** No API keys, passwords, or tokens found in the diff
2. **No Data Exfiltration:** No suspicious network requests or data transmission patterns
3. **No Backdoors:** No hidden functionality or unauthorized access patterns detected
4. **Safe Command Execution:** `execGitCommand` function properly uses array arguments in some places
5. **Environment Variable Handling:** `init-script-service.ts` properly sanitizes environment variables (lines 194-220)
---
## 📋 Action Items
### Immediate (Before Release)
- [ ] **Fix command injection in `merge.ts`**
- [ ] Validate `branchName` with `isValidBranchName()` before line 43
- [ ] Validate `mergeTo` with `isValidBranchName()` before line 54
- [ ] Sanitize commit messages or use `execGitCommand` for merge commands
- [ ] Replace `execAsync` template literals with `execGitCommand` array calls
- [ ] **Fix command injection in `push.ts`**
- [ ] Add validation function for remote names
- [ ] Validate `targetRemote` before use
- [ ] Validate `branchName` before use (defensive programming)
- [ ] Replace `execAsync` template literals with `execGitCommand`
- [ ] **Fix shell script security issue**
- [ ] Replace unsafe `export $(grep ... | xargs)` with safer parsing
- [ ] Add validation for `.env` file contents
- [ ] Test with edge cases (spaces, special chars, quotes)
### Short-term (Next Sprint)
- [ ] **Audit all `execAsync` calls**
- [ ] Create inventory of all `execAsync` calls with template literals
- [ ] Replace with `execGitCommand` where possible
- [ ] Document exceptions and why they're safe
- [ ] **Add input validation utilities**
- [ ] Create `isValidRemoteName()` function
- [ ] Create `sanitizeCommitMessage()` function
- [ ] Add validation for all user-controlled inputs
- [ ] **Security testing**
- [ ] Add unit tests for command injection prevention
- [ ] Add integration tests with malicious inputs
- [ ] Test shell script with malicious `.env` files
### Long-term (Security Hardening)
- [ ] **Code review process**
- [ ] Add security checklist for PR reviews
- [ ] Require security review for shell command execution changes
- [ ] Add automated security scanning
- [ ] **Documentation**
- [ ] Document secure coding practices for shell commands
- [ ] Create security guidelines for contributors
- [ ] Add security section to CONTRIBUTING.md
---
## 🔍 Testing Recommendations
### Command Injection Tests
```typescript
// Test cases for merge.ts
describe('merge handler security', () => {
it('should reject branch names with shell metacharacters', () => {
// Test: branchName = "main; rm -rf /"
// Expected: Validation error, command not executed
});
it('should sanitize commit messages', () => {
// Test: message = '"; malicious_command; "'
// Expected: Sanitized or rejected
});
});
// Test cases for push.ts
describe('push handler security', () => {
it('should reject remote names with shell metacharacters', () => {
// Test: remote = "origin; malicious_command; #"
// Expected: Validation error, command not executed
});
});
```
### Shell Script Tests
```bash
# Test with malicious .env content
echo 'VAR="value; echo PWNED"' > test.env
# Expected: Should not execute the command
# Test with spaces in values
echo 'VAR="value with spaces"' > test.env
# Expected: Should handle correctly
# Test with special characters
echo 'VAR="value\$with\$dollars"' > test.env
# Expected: Should handle correctly
```
---
## 📚 References
- [OWASP Command Injection](https://owasp.org/www-community/attacks/Command_Injection)
- [Node.js Child Process Security](https://nodejs.org/api/child_process.html#child_process_security_concerns)
- [Shell Script Security Best Practices](https://mywiki.wooledge.org/BashGuide/Practices)
---
## Notes
- All findings are based on code diff analysis
- No runtime testing was performed
- Assumes attacker has access to API endpoints (authenticated or unauthenticated)
- Fixes should be tested thoroughly before deployment
---
**Last Updated:** $(date)
**Next Review:** After fixes are implemented

25
TODO.md Normal file
View File

@@ -0,0 +1,25 @@
# Bugs
- Setting the default model does not seem like it works.
# Performance (completed)
- [x] Graph performance mode for large graphs (compact nodes/edges + visible-only rendering)
- [x] Render containment on heavy scroll regions (kanban columns, chat history)
- [x] Reduce blur/shadow effects when lists get large
- [x] React Query tuning for heavy datasets (less refetch on focus/reconnect)
- [x] DnD/list rendering optimizations (virtualized kanban + memoized card sections)
# UX
- Consolidate all models to a single place in the settings instead of having AI profiles and all this other stuff
- Simplify the create feature modal. It should just be one page. I don't need nessa tabs and all these nested buttons. It's too complex.
- added to do's list checkbox directly into the card so as it's going through if there's any to do items we can see those update live
- When the feature is done, I want to see a summary of the LLM. That's the first thing I should see when I double click the card.
- I went away to mass edit all my features. For example, when I created a new project, it added auto testing on every single feature card. Now I have to manually go through one by one and change those. Have a way to mass edit those, the configuration of all them.
- Double check and debug if there's memory leaks. It seems like the memory of automaker grows like 3 gigabytes. It's 5gb right now and I'm running three different cursor cli features implementing at the same time.
- Typing in the text area of the plan mode was super laggy.
- When I have a bunch of features running at the same time, it seems like I cannot edit the features in the backlog. Like they don't persist their file changes and I think this is because of the secure FS file has an internal queue to prevent hitting that file open write limit. We may have to reconsider refactoring away from file system and do Postgres or SQLite or something.
- modals are not scrollable if height of the screen is small enough
- and the Agent Runner add an archival button for the new sessions.
- investigate a potential issue with the feature cards not refreshing. I see a lock icon on the feature card But it doesn't go away until I open the card and edit it and I turn the testing mode off. I think there's like a refresh sync issue.

View File

@@ -16,7 +16,7 @@ import { createServer } from 'http';
import dotenv from 'dotenv'; import dotenv from 'dotenv';
import { createEventEmitter, type EventEmitter } from './lib/events.js'; import { createEventEmitter, type EventEmitter } from './lib/events.js';
import { initAllowedPaths, getClaudeAuthIndicators } from '@automaker/platform'; import { initAllowedPaths } from '@automaker/platform';
import { createLogger, setLogLevel, LogLevel } from '@automaker/utils'; import { createLogger, setLogLevel, LogLevel } from '@automaker/utils';
const logger = createLogger('Server'); const logger = createLogger('Server');
@@ -117,44 +117,15 @@ export function isRequestLoggingEnabled(): boolean {
// Width for log box content (excluding borders) // Width for log box content (excluding borders)
const BOX_CONTENT_WIDTH = 67; const BOX_CONTENT_WIDTH = 67;
// Check for Claude authentication (async - runs in background) // Check for required environment variables
// The Claude Agent SDK can use either ANTHROPIC_API_KEY or Claude Code CLI authentication const hasAnthropicKey = !!process.env.ANTHROPIC_API_KEY;
(async () => {
const hasAnthropicKey = !!process.env.ANTHROPIC_API_KEY;
if (hasAnthropicKey) { if (!hasAnthropicKey) {
logger.info('✓ ANTHROPIC_API_KEY detected');
return;
}
// Check for Claude Code CLI authentication
try {
const indicators = await getClaudeAuthIndicators();
const hasCliAuth =
indicators.hasStatsCacheWithActivity ||
(indicators.hasSettingsFile && indicators.hasProjectsSessions) ||
(indicators.hasCredentialsFile &&
(indicators.credentials?.hasOAuthToken || indicators.credentials?.hasApiKey));
if (hasCliAuth) {
logger.info('✓ Claude Code CLI authentication detected');
return;
}
} catch (error) {
// Ignore errors checking CLI auth - will fall through to warning
logger.warn('Error checking for Claude Code CLI authentication:', error);
}
// No authentication found - show warning
const wHeader = '⚠️ WARNING: No Claude authentication configured'.padEnd(BOX_CONTENT_WIDTH); const wHeader = '⚠️ WARNING: No Claude authentication configured'.padEnd(BOX_CONTENT_WIDTH);
const w1 = 'The Claude Agent SDK requires authentication to function.'.padEnd(BOX_CONTENT_WIDTH); const w1 = 'The Claude Agent SDK requires authentication to function.'.padEnd(BOX_CONTENT_WIDTH);
const w2 = 'Options:'.padEnd(BOX_CONTENT_WIDTH); const w2 = 'Set your Anthropic API key:'.padEnd(BOX_CONTENT_WIDTH);
const w3 = '1. Install Claude Code CLI and authenticate with subscription'.padEnd( const w3 = ' export ANTHROPIC_API_KEY="sk-ant-..."'.padEnd(BOX_CONTENT_WIDTH);
BOX_CONTENT_WIDTH const w4 = 'Or use the setup wizard in Settings to configure authentication.'.padEnd(
);
const w4 = '2. Set your Anthropic API key:'.padEnd(BOX_CONTENT_WIDTH);
const w5 = ' export ANTHROPIC_API_KEY="sk-ant-..."'.padEnd(BOX_CONTENT_WIDTH);
const w6 = '3. Use the setup wizard in Settings to configure authentication.'.padEnd(
BOX_CONTENT_WIDTH BOX_CONTENT_WIDTH
); );
@@ -167,13 +138,14 @@ const BOX_CONTENT_WIDTH = 67;
║ ║ ║ ║
${w2} ${w2}
${w3} ${w3}
║ ║
${w4} ${w4}
${w5}
${w6}
║ ║ ║ ║
╚═════════════════════════════════════════════════════════════════════╝ ╚═════════════════════════════════════════════════════════════════════╝
`); `);
})(); } else {
logger.info('✓ ANTHROPIC_API_KEY detected');
}
// Initialize security // Initialize security
initAllowedPaths(); initAllowedPaths();
@@ -354,10 +326,7 @@ app.get('/api/health/detailed', createDetailedHandler());
app.use('/api/fs', createFsRoutes(events)); app.use('/api/fs', createFsRoutes(events));
app.use('/api/agent', createAgentRoutes(agentService, events)); app.use('/api/agent', createAgentRoutes(agentService, events));
app.use('/api/sessions', createSessionsRoutes(agentService)); app.use('/api/sessions', createSessionsRoutes(agentService));
app.use( app.use('/api/features', createFeaturesRoutes(featureLoader, settingsService, events));
'/api/features',
createFeaturesRoutes(featureLoader, settingsService, events, autoModeService)
);
app.use('/api/auto-mode', createAutoModeRoutes(autoModeService)); app.use('/api/auto-mode', createAutoModeRoutes(autoModeService));
app.use('/api/enhance-prompt', createEnhancePromptRoutes(settingsService)); app.use('/api/enhance-prompt', createEnhancePromptRoutes(settingsService));
app.use('/api/worktree', createWorktreeRoutes(events, settingsService)); app.use('/api/worktree', createWorktreeRoutes(events, settingsService));
@@ -390,7 +359,7 @@ const server = createServer(app);
// WebSocket servers using noServer mode for proper multi-path support // WebSocket servers using noServer mode for proper multi-path support
const wss = new WebSocketServer({ noServer: true }); const wss = new WebSocketServer({ noServer: true });
const terminalWss = new WebSocketServer({ noServer: true }); const terminalWss = new WebSocketServer({ noServer: true });
const terminalService = getTerminalService(settingsService); const terminalService = getTerminalService();
/** /**
* Authenticate WebSocket upgrade requests * Authenticate WebSocket upgrade requests
@@ -800,36 +769,21 @@ process.on('uncaughtException', (error: Error) => {
process.exit(1); process.exit(1);
}); });
// Graceful shutdown timeout (30 seconds) // Graceful shutdown
const SHUTDOWN_TIMEOUT_MS = 30000; process.on('SIGTERM', () => {
logger.info('SIGTERM received, shutting down...');
// Graceful shutdown helper
const gracefulShutdown = async (signal: string) => {
logger.info(`${signal} received, shutting down...`);
// Set up a force-exit timeout to prevent hanging
const forceExitTimeout = setTimeout(() => {
logger.error(`Shutdown timed out after ${SHUTDOWN_TIMEOUT_MS}ms, forcing exit`);
process.exit(1);
}, SHUTDOWN_TIMEOUT_MS);
// Mark all running features as interrupted before shutdown
// This ensures they can be resumed when the server restarts
// Note: markAllRunningFeaturesInterrupted handles errors internally and never rejects
await autoModeService.markAllRunningFeaturesInterrupted(`${signal} signal received`);
terminalService.cleanup(); terminalService.cleanup();
server.close(() => { server.close(() => {
clearTimeout(forceExitTimeout);
logger.info('Server closed'); logger.info('Server closed');
process.exit(0); process.exit(0);
}); });
};
process.on('SIGTERM', () => {
gracefulShutdown('SIGTERM');
}); });
process.on('SIGINT', () => { process.on('SIGINT', () => {
gracefulShutdown('SIGINT'); logger.info('SIGINT received, shutting down...');
terminalService.cleanup();
server.close(() => {
logger.info('Server closed');
process.exit(0);
});
}); });

View File

@@ -1,25 +0,0 @@
/**
* Terminal Theme Data - Re-export terminal themes from platform package
*
* This module re-exports terminal theme data for use in the server.
*/
import { terminalThemeColors, getTerminalThemeColors as getThemeColors } from '@automaker/platform';
import type { ThemeMode } from '@automaker/types';
import type { TerminalTheme } from '@automaker/platform';
/**
* Get terminal theme colors for a given theme mode
*/
export function getTerminalThemeColors(theme: ThemeMode): TerminalTheme {
return getThemeColors(theme);
}
/**
* Get all terminal themes
*/
export function getAllTerminalThemes(): Record<ThemeMode, TerminalTheme> {
return terminalThemeColors;
}
export default terminalThemeColors;

View File

@@ -98,14 +98,9 @@ const TEXT_ENCODING = 'utf-8';
* This is the "no output" timeout - if the CLI doesn't produce any JSONL output * This is the "no output" timeout - if the CLI doesn't produce any JSONL output
* for this duration, the process is killed. For reasoning models with high * for this duration, the process is killed. For reasoning models with high
* reasoning effort, this timeout is dynamically extended via calculateReasoningTimeout(). * reasoning effort, this timeout is dynamically extended via calculateReasoningTimeout().
*
* For feature generation (which can generate 50+ features), we use a much longer
* base timeout (5 minutes) since Codex models are slower at generating large JSON responses.
*
* @see calculateReasoningTimeout from @automaker/types * @see calculateReasoningTimeout from @automaker/types
*/ */
const CODEX_CLI_TIMEOUT_MS = DEFAULT_TIMEOUT_MS; const CODEX_CLI_TIMEOUT_MS = DEFAULT_TIMEOUT_MS;
const CODEX_FEATURE_GENERATION_BASE_TIMEOUT_MS = 300000; // 5 minutes for feature generation
const CONTEXT_WINDOW_256K = 256000; const CONTEXT_WINDOW_256K = 256000;
const MAX_OUTPUT_32K = 32000; const MAX_OUTPUT_32K = 32000;
const MAX_OUTPUT_16K = 16000; const MAX_OUTPUT_16K = 16000;
@@ -832,14 +827,7 @@ export class CodexProvider extends BaseProvider {
// Higher reasoning effort (e.g., 'xhigh' for "xtra thinking" mode) requires more time // Higher reasoning effort (e.g., 'xhigh' for "xtra thinking" mode) requires more time
// for the model to generate reasoning tokens before producing output. // for the model to generate reasoning tokens before producing output.
// This fixes GitHub issue #530 where features would get stuck with reasoning models. // This fixes GitHub issue #530 where features would get stuck with reasoning models.
// const timeout = calculateReasoningTimeout(options.reasoningEffort, CODEX_CLI_TIMEOUT_MS);
// For feature generation with 'xhigh', use the extended 5-minute base timeout
// since generating 50+ features takes significantly longer than normal operations.
const baseTimeout =
options.reasoningEffort === 'xhigh'
? CODEX_FEATURE_GENERATION_BASE_TIMEOUT_MS
: CODEX_CLI_TIMEOUT_MS;
const timeout = calculateReasoningTimeout(options.reasoningEffort, baseTimeout);
const stream = spawnJSONLProcess({ const stream = spawnJSONLProcess({
command: commandPath, command: commandPath,

View File

@@ -14,7 +14,6 @@ import { execSync } from 'child_process';
import * as fs from 'fs'; import * as fs from 'fs';
import * as path from 'path'; import * as path from 'path';
import * as os from 'os'; import * as os from 'os';
import { findCliInWsl, isWslAvailable } from '@automaker/platform';
import { import {
CliProvider, CliProvider,
type CliSpawnConfig, type CliSpawnConfig,
@@ -287,113 +286,15 @@ export class CursorProvider extends CliProvider {
getSpawnConfig(): CliSpawnConfig { getSpawnConfig(): CliSpawnConfig {
return { return {
windowsStrategy: 'direct', windowsStrategy: 'wsl', // cursor-agent requires WSL on Windows
commonPaths: { commonPaths: {
linux: [ linux: [
path.join(os.homedir(), '.local/bin/cursor-agent'), // Primary symlink location path.join(os.homedir(), '.local/bin/cursor-agent'), // Primary symlink location
'/usr/local/bin/cursor-agent', '/usr/local/bin/cursor-agent',
], ],
darwin: [path.join(os.homedir(), '.local/bin/cursor-agent'), '/usr/local/bin/cursor-agent'], darwin: [path.join(os.homedir(), '.local/bin/cursor-agent'), '/usr/local/bin/cursor-agent'],
win32: [ // Windows paths are not used - we check for WSL installation instead
path.join( win32: [],
process.env.LOCALAPPDATA || path.join(os.homedir(), 'AppData', 'Local'),
'Programs',
'Cursor',
'resources',
'app',
'bin',
'cursor-agent.exe'
),
path.join(
process.env.LOCALAPPDATA || path.join(os.homedir(), 'AppData', 'Local'),
'Programs',
'Cursor',
'resources',
'app',
'bin',
'cursor-agent.cmd'
),
path.join(
process.env.LOCALAPPDATA || path.join(os.homedir(), 'AppData', 'Local'),
'Programs',
'Cursor',
'resources',
'app',
'bin',
'cursor.exe'
),
path.join(
process.env.LOCALAPPDATA || path.join(os.homedir(), 'AppData', 'Local'),
'Programs',
'Cursor',
'cursor.exe'
),
path.join(
process.env.LOCALAPPDATA || path.join(os.homedir(), 'AppData', 'Local'),
'Programs',
'cursor',
'resources',
'app',
'bin',
'cursor-agent.exe'
),
path.join(
process.env.LOCALAPPDATA || path.join(os.homedir(), 'AppData', 'Local'),
'Programs',
'cursor',
'resources',
'app',
'bin',
'cursor-agent.cmd'
),
path.join(
process.env.LOCALAPPDATA || path.join(os.homedir(), 'AppData', 'Local'),
'Programs',
'cursor',
'resources',
'app',
'bin',
'cursor.exe'
),
path.join(
process.env.LOCALAPPDATA || path.join(os.homedir(), 'AppData', 'Local'),
'Programs',
'cursor',
'cursor.exe'
),
path.join(
process.env.APPDATA || path.join(os.homedir(), 'AppData', 'Roaming'),
'npm',
'cursor-agent.cmd'
),
path.join(
process.env.APPDATA || path.join(os.homedir(), 'AppData', 'Roaming'),
'npm',
'cursor.cmd'
),
path.join(
process.env.APPDATA || path.join(os.homedir(), 'AppData', 'Roaming'),
'.npm-global',
'bin',
'cursor-agent.cmd'
),
path.join(
process.env.APPDATA || path.join(os.homedir(), 'AppData', 'Roaming'),
'.npm-global',
'bin',
'cursor.cmd'
),
path.join(
process.env.LOCALAPPDATA || path.join(os.homedir(), 'AppData', 'Local'),
'pnpm',
'cursor-agent.cmd'
),
path.join(
process.env.LOCALAPPDATA || path.join(os.homedir(), 'AppData', 'Local'),
'pnpm',
'cursor.cmd'
),
],
}, },
}; };
} }
@@ -586,92 +487,6 @@ export class CursorProvider extends CliProvider {
* 2. Cursor IDE with 'cursor agent' subcommand support * 2. Cursor IDE with 'cursor agent' subcommand support
*/ */
protected detectCli(): CliDetectionResult { protected detectCli(): CliDetectionResult {
if (process.platform === 'win32') {
const findInPath = (command: string): string | null => {
try {
const result = execSync(`where ${command}`, {
encoding: 'utf8',
timeout: 5000,
stdio: ['pipe', 'pipe', 'pipe'],
windowsHide: true,
})
.trim()
.split(/\r?\n/)[0];
if (result && fs.existsSync(result)) {
return result;
}
} catch {
// Not in PATH
}
return null;
};
const isCursorAgentBinary = (cliPath: string) =>
cliPath.toLowerCase().includes('cursor-agent');
const supportsCursorAgentSubcommand = (cliPath: string) => {
try {
execSync(`"${cliPath}" agent --version`, {
encoding: 'utf8',
timeout: 5000,
stdio: 'pipe',
windowsHide: true,
});
return true;
} catch {
return false;
}
};
const pathResult = findInPath('cursor-agent') || findInPath('cursor');
if (pathResult) {
if (isCursorAgentBinary(pathResult) || supportsCursorAgentSubcommand(pathResult)) {
return {
cliPath: pathResult,
useWsl: false,
strategy: pathResult.toLowerCase().endsWith('.cmd') ? 'cmd' : 'direct',
};
}
}
const config = this.getSpawnConfig();
for (const candidate of config.commonPaths.win32 || []) {
const resolved = candidate;
if (!fs.existsSync(resolved)) {
continue;
}
if (isCursorAgentBinary(resolved) || supportsCursorAgentSubcommand(resolved)) {
return {
cliPath: resolved,
useWsl: false,
strategy: resolved.toLowerCase().endsWith('.cmd') ? 'cmd' : 'direct',
};
}
}
const wslLogger = (msg: string) => logger.debug(msg);
if (isWslAvailable({ logger: wslLogger })) {
const wslResult = findCliInWsl('cursor-agent', { logger: wslLogger });
if (wslResult) {
logger.debug(
`Using cursor-agent via WSL (${wslResult.distribution || 'default'}): ${wslResult.wslPath}`
);
return {
cliPath: 'wsl.exe',
useWsl: true,
wslCliPath: wslResult.wslPath,
wslDistribution: wslResult.distribution,
strategy: 'wsl',
};
}
}
logger.debug('cursor-agent not found on Windows');
return { cliPath: null, useWsl: false, strategy: 'direct' };
}
// First try standard detection (PATH, common paths, WSL) // First try standard detection (PATH, common paths, WSL)
const result = super.detectCli(); const result = super.detectCli();
if (result.cliPath) { if (result.cliPath) {
@@ -680,7 +495,7 @@ export class CursorProvider extends CliProvider {
// Cursor-specific: Check versions directory for any installed version // Cursor-specific: Check versions directory for any installed version
// This handles cases where cursor-agent is installed but not in PATH // This handles cases where cursor-agent is installed but not in PATH
if (fs.existsSync(CursorProvider.VERSIONS_DIR)) { if (process.platform !== 'win32' && fs.existsSync(CursorProvider.VERSIONS_DIR)) {
try { try {
const versions = fs const versions = fs
.readdirSync(CursorProvider.VERSIONS_DIR) .readdirSync(CursorProvider.VERSIONS_DIR)
@@ -706,6 +521,7 @@ export class CursorProvider extends CliProvider {
// If cursor-agent not found, try to find 'cursor' IDE and use 'cursor agent' subcommand // If cursor-agent not found, try to find 'cursor' IDE and use 'cursor agent' subcommand
// The Cursor IDE includes the agent as a subcommand: cursor agent // The Cursor IDE includes the agent as a subcommand: cursor agent
if (process.platform !== 'win32') {
const cursorPaths = [ const cursorPaths = [
'/usr/bin/cursor', '/usr/bin/cursor',
'/usr/local/bin/cursor', '/usr/local/bin/cursor',
@@ -734,6 +550,7 @@ export class CursorProvider extends CliProvider {
} }
} }
} }
}
return result; return result;
} }

View File

@@ -8,11 +8,10 @@
import * as secureFs from '../../lib/secure-fs.js'; import * as secureFs from '../../lib/secure-fs.js';
import type { EventEmitter } from '../../lib/events.js'; import type { EventEmitter } from '../../lib/events.js';
import { createLogger } from '@automaker/utils'; import { createLogger } from '@automaker/utils';
import { DEFAULT_PHASE_MODELS, supportsStructuredOutput, isCodexModel } from '@automaker/types'; import { DEFAULT_PHASE_MODELS } from '@automaker/types';
import { resolvePhaseModel } from '@automaker/model-resolver'; import { resolvePhaseModel } from '@automaker/model-resolver';
import { streamingQuery } from '../../providers/simple-query-service.js'; import { streamingQuery } from '../../providers/simple-query-service.js';
import { parseAndCreateFeatures } from './parse-and-create-features.js'; import { parseAndCreateFeatures } from './parse-and-create-features.js';
import { extractJsonWithArray } from '../../lib/json-extractor.js';
import { getAppSpecPath } from '@automaker/platform'; import { getAppSpecPath } from '@automaker/platform';
import type { SettingsService } from '../../services/settings-service.js'; import type { SettingsService } from '../../services/settings-service.js';
import { import {
@@ -26,64 +25,6 @@ const logger = createLogger('SpecRegeneration');
const DEFAULT_MAX_FEATURES = 50; const DEFAULT_MAX_FEATURES = 50;
/**
* Timeout for Codex models when generating features (5 minutes).
* Codex models are slower and need more time to generate 50+ features.
*/
const CODEX_FEATURE_GENERATION_TIMEOUT_MS = 300000; // 5 minutes
/**
* Type for extracted features JSON response
*/
interface FeaturesExtractionResult {
features: Array<{
id: string;
category?: string;
title: string;
description: string;
priority?: number;
complexity?: 'simple' | 'moderate' | 'complex';
dependencies?: string[];
}>;
}
/**
* JSON schema for features output format (Claude/Codex structured output)
*/
const featuresOutputSchema = {
type: 'object',
properties: {
features: {
type: 'array',
items: {
type: 'object',
properties: {
id: { type: 'string', description: 'Unique feature identifier (kebab-case)' },
category: { type: 'string', description: 'Feature category' },
title: { type: 'string', description: 'Short, descriptive title' },
description: { type: 'string', description: 'Detailed feature description' },
priority: {
type: 'number',
description: 'Priority level: 1 (highest) to 5 (lowest)',
},
complexity: {
type: 'string',
enum: ['simple', 'moderate', 'complex'],
description: 'Implementation complexity',
},
dependencies: {
type: 'array',
items: { type: 'string' },
description: 'IDs of features this depends on',
},
},
required: ['id', 'title', 'description'],
},
},
},
required: ['features'],
} as const;
export async function generateFeaturesFromSpec( export async function generateFeaturesFromSpec(
projectPath: string, projectPath: string,
events: EventEmitter, events: EventEmitter,
@@ -195,80 +136,23 @@ Generate ${featureCount} NEW features that build on each other logically. Rememb
provider: undefined, provider: undefined,
credentials: undefined, credentials: undefined,
}; };
const { model, thinkingLevel, reasoningEffort } = resolvePhaseModel(phaseModelEntry); const { model, thinkingLevel } = resolvePhaseModel(phaseModelEntry);
logger.info('Using model:', model, provider ? `via provider: ${provider.name}` : 'direct API'); logger.info('Using model:', model, provider ? `via provider: ${provider.name}` : 'direct API');
// Codex models need extended timeout for generating many features.
// Use 'xhigh' reasoning effort to get 5-minute timeout (300s base * 1.0x = 300s).
// The Codex provider has a special 5-minute base timeout for feature generation.
const isCodex = isCodexModel(model);
const effectiveReasoningEffort = isCodex ? 'xhigh' : reasoningEffort;
if (isCodex) {
logger.info('Codex model detected - using extended timeout (5 minutes for feature generation)');
}
if (effectiveReasoningEffort) {
logger.info('Reasoning effort:', effectiveReasoningEffort);
}
// Determine if we should use structured output based on model type
const useStructuredOutput = supportsStructuredOutput(model);
logger.info(
`Structured output mode: ${useStructuredOutput ? 'enabled (Claude/Codex)' : 'disabled (using JSON instructions)'}`
);
// Build the final prompt - for non-Claude/Codex models, include explicit JSON instructions
let finalPrompt = prompt;
if (!useStructuredOutput) {
finalPrompt = `${prompt}
CRITICAL INSTRUCTIONS:
1. DO NOT write any files. Return the JSON in your response only.
2. After analyzing the spec, respond with ONLY a JSON object - no explanations, no markdown, just raw JSON.
3. The JSON must have this exact structure:
{
"features": [
{
"id": "unique-feature-id",
"category": "Category Name",
"title": "Short Feature Title",
"description": "Detailed description of the feature",
"priority": 1,
"complexity": "simple|moderate|complex",
"dependencies": ["other-feature-id"]
}
]
}
4. Feature IDs must be unique, lowercase, kebab-case (e.g., "user-authentication", "data-export")
5. Priority ranges from 1 (highest) to 5 (lowest)
6. Complexity must be one of: "simple", "moderate", "complex"
7. Dependencies is an array of feature IDs that must be completed first (can be empty)
Your entire response should be valid JSON starting with { and ending with }. No text before or after.`;
}
// Use streamingQuery with event callbacks // Use streamingQuery with event callbacks
const result = await streamingQuery({ const result = await streamingQuery({
prompt: finalPrompt, prompt,
model, model,
cwd: projectPath, cwd: projectPath,
maxTurns: 250, maxTurns: 250,
allowedTools: ['Read', 'Glob', 'Grep'], allowedTools: ['Read', 'Glob', 'Grep'],
abortController, abortController,
thinkingLevel, thinkingLevel,
reasoningEffort: effectiveReasoningEffort, // Extended timeout for Codex models
readOnly: true, // Feature generation only reads code, doesn't write readOnly: true, // Feature generation only reads code, doesn't write
settingSources: autoLoadClaudeMd ? ['user', 'project', 'local'] : undefined, settingSources: autoLoadClaudeMd ? ['user', 'project', 'local'] : undefined,
claudeCompatibleProvider: provider, // Pass provider for alternative endpoint configuration claudeCompatibleProvider: provider, // Pass provider for alternative endpoint configuration
credentials, // Pass credentials for resolving 'credentials' apiKeySource credentials, // Pass credentials for resolving 'credentials' apiKeySource
outputFormat: useStructuredOutput
? {
type: 'json_schema',
schema: featuresOutputSchema,
}
: undefined,
onText: (text) => { onText: (text) => {
logger.debug(`Feature text block received (${text.length} chars)`); logger.debug(`Feature text block received (${text.length} chars)`);
events.emit('spec-regeneration:event', { events.emit('spec-regeneration:event', {
@@ -279,51 +163,15 @@ Your entire response should be valid JSON starting with { and ending with }. No
}, },
}); });
// Get response content - prefer structured output if available const responseText = result.text;
let contentForParsing: string;
if (result.structured_output) {
// Use structured output from Claude/Codex models
logger.info('✅ Received structured output from model');
contentForParsing = JSON.stringify(result.structured_output);
logger.debug('Structured output:', contentForParsing);
} else {
// Use text response (for non-Claude/Codex models or fallback)
// Pre-extract JSON to handle conversational text that may surround the JSON response
// This follows the same pattern used in generate-spec.ts and validate-issue.ts
const rawText = result.text;
logger.info(`Feature stream complete.`); logger.info(`Feature stream complete.`);
logger.info(`Feature response length: ${rawText.length} chars`); logger.info(`Feature response length: ${responseText.length} chars`);
logger.info('========== FULL RESPONSE TEXT =========='); logger.info('========== FULL RESPONSE TEXT ==========');
logger.info(rawText); logger.info(responseText);
logger.info('========== END RESPONSE TEXT =========='); logger.info('========== END RESPONSE TEXT ==========');
// Pre-extract JSON from response - handles conversational text around the JSON await parseAndCreateFeatures(projectPath, responseText, events);
const extracted = extractJsonWithArray<FeaturesExtractionResult>(rawText, 'features', {
logger,
});
if (extracted) {
contentForParsing = JSON.stringify(extracted);
logger.info('✅ Pre-extracted JSON from text response');
} else {
// If pre-extraction fails, we know the next step will also fail.
// Throw an error here to avoid redundant parsing and make the failure point clearer.
logger.error(
'❌ Could not extract features JSON from model response. Full response text was:\n' +
rawText
);
const errorMessage =
'Failed to parse features from model response: No valid JSON with a "features" array found.';
events.emit('spec-regeneration:event', {
type: 'spec_regeneration_error',
error: errorMessage,
projectPath: projectPath,
});
throw new Error(errorMessage);
}
}
await parseAndCreateFeatures(projectPath, contentForParsing, events);
logger.debug('========== generateFeaturesFromSpec() completed =========='); logger.debug('========== generateFeaturesFromSpec() completed ==========');
} }

View File

@@ -9,7 +9,7 @@ import * as secureFs from '../../lib/secure-fs.js';
import type { EventEmitter } from '../../lib/events.js'; import type { EventEmitter } from '../../lib/events.js';
import { specOutputSchema, specToXml, type SpecOutput } from '../../lib/app-spec-format.js'; import { specOutputSchema, specToXml, type SpecOutput } from '../../lib/app-spec-format.js';
import { createLogger } from '@automaker/utils'; import { createLogger } from '@automaker/utils';
import { DEFAULT_PHASE_MODELS, supportsStructuredOutput } from '@automaker/types'; import { DEFAULT_PHASE_MODELS, isClaudeModel, isCodexModel } from '@automaker/types';
import { resolvePhaseModel } from '@automaker/model-resolver'; import { resolvePhaseModel } from '@automaker/model-resolver';
import { extractJson } from '../../lib/json-extractor.js'; import { extractJson } from '../../lib/json-extractor.js';
import { streamingQuery } from '../../providers/simple-query-service.js'; import { streamingQuery } from '../../providers/simple-query-service.js';
@@ -120,13 +120,10 @@ ${prompts.appSpec.structuredSpecInstructions}`;
let responseText = ''; let responseText = '';
let structuredOutput: SpecOutput | null = null; let structuredOutput: SpecOutput | null = null;
// Determine if we should use structured output based on model type // Determine if we should use structured output (only Claude and Codex support it)
const useStructuredOutput = supportsStructuredOutput(model); const useStructuredOutput = isClaudeModel(model) || isCodexModel(model);
logger.info(
`Structured output mode: ${useStructuredOutput ? 'enabled (Claude/Codex)' : 'disabled (using JSON instructions)'}`
);
// Build the final prompt - for non-Claude/Codex models, include JSON schema instructions // Build the final prompt - for Cursor, include JSON schema instructions
let finalPrompt = prompt; let finalPrompt = prompt;
if (!useStructuredOutput) { if (!useStructuredOutput) {
finalPrompt = `${prompt} finalPrompt = `${prompt}

View File

@@ -10,10 +10,9 @@
import * as secureFs from '../../lib/secure-fs.js'; import * as secureFs from '../../lib/secure-fs.js';
import type { EventEmitter } from '../../lib/events.js'; import type { EventEmitter } from '../../lib/events.js';
import { createLogger } from '@automaker/utils'; import { createLogger } from '@automaker/utils';
import { DEFAULT_PHASE_MODELS, supportsStructuredOutput } from '@automaker/types'; import { DEFAULT_PHASE_MODELS } from '@automaker/types';
import { resolvePhaseModel } from '@automaker/model-resolver'; import { resolvePhaseModel } from '@automaker/model-resolver';
import { streamingQuery } from '../../providers/simple-query-service.js'; import { streamingQuery } from '../../providers/simple-query-service.js';
import { extractJson } from '../../lib/json-extractor.js';
import { getAppSpecPath } from '@automaker/platform'; import { getAppSpecPath } from '@automaker/platform';
import type { SettingsService } from '../../services/settings-service.js'; import type { SettingsService } from '../../services/settings-service.js';
import { import {
@@ -35,28 +34,6 @@ import { getNotificationService } from '../../services/notification-service.js';
const logger = createLogger('SpecSync'); const logger = createLogger('SpecSync');
/**
* Type for extracted tech stack JSON response
*/
interface TechStackExtractionResult {
technologies: string[];
}
/**
* JSON schema for tech stack analysis output (Claude/Codex structured output)
*/
const techStackOutputSchema = {
type: 'object',
properties: {
technologies: {
type: 'array',
items: { type: 'string' },
description: 'List of technologies detected in the project',
},
},
required: ['technologies'],
} as const;
/** /**
* Result of a sync operation * Result of a sync operation
*/ */
@@ -199,14 +176,8 @@ export async function syncSpec(
logger.info('Using model:', model, provider ? `via provider: ${provider.name}` : 'direct API'); logger.info('Using model:', model, provider ? `via provider: ${provider.name}` : 'direct API');
// Determine if we should use structured output based on model type
const useStructuredOutput = supportsStructuredOutput(model);
logger.info(
`Structured output mode: ${useStructuredOutput ? 'enabled (Claude/Codex)' : 'disabled (using JSON instructions)'}`
);
// Use AI to analyze tech stack // Use AI to analyze tech stack
let techAnalysisPrompt = `Analyze this project and return ONLY a JSON object with the current technology stack. const techAnalysisPrompt = `Analyze this project and return ONLY a JSON object with the current technology stack.
Current known technologies: ${currentTechStack.join(', ')} Current known technologies: ${currentTechStack.join(', ')}
@@ -222,16 +193,6 @@ Return ONLY this JSON format, no other text:
"technologies": ["Technology 1", "Technology 2", ...] "technologies": ["Technology 1", "Technology 2", ...]
}`; }`;
// Add explicit JSON instructions for non-Claude/Codex models
if (!useStructuredOutput) {
techAnalysisPrompt = `${techAnalysisPrompt}
CRITICAL INSTRUCTIONS:
1. DO NOT write any files. Return the JSON in your response only.
2. Your entire response should be valid JSON starting with { and ending with }.
3. No explanations, no markdown, no text before or after the JSON.`;
}
try { try {
const techResult = await streamingQuery({ const techResult = await streamingQuery({
prompt: techAnalysisPrompt, prompt: techAnalysisPrompt,
@@ -245,44 +206,17 @@ CRITICAL INSTRUCTIONS:
settingSources: autoLoadClaudeMd ? ['user', 'project', 'local'] : undefined, settingSources: autoLoadClaudeMd ? ['user', 'project', 'local'] : undefined,
claudeCompatibleProvider: provider, // Pass provider for alternative endpoint configuration claudeCompatibleProvider: provider, // Pass provider for alternative endpoint configuration
credentials, // Pass credentials for resolving 'credentials' apiKeySource credentials, // Pass credentials for resolving 'credentials' apiKeySource
outputFormat: useStructuredOutput
? {
type: 'json_schema',
schema: techStackOutputSchema,
}
: undefined,
onText: (text) => { onText: (text) => {
logger.debug(`Tech analysis text: ${text.substring(0, 100)}`); logger.debug(`Tech analysis text: ${text.substring(0, 100)}`);
}, },
}); });
// Parse tech stack from response - prefer structured output if available // Parse tech stack from response
let parsedTechnologies: string[] | null = null; const jsonMatch = techResult.text.match(/\{[\s\S]*"technologies"[\s\S]*\}/);
if (jsonMatch) {
if (techResult.structured_output) { const parsed = JSON.parse(jsonMatch[0]);
// Use structured output from Claude/Codex models if (Array.isArray(parsed.technologies)) {
const structured = techResult.structured_output as unknown as TechStackExtractionResult; const newTechStack = parsed.technologies as string[];
if (Array.isArray(structured.technologies)) {
parsedTechnologies = structured.technologies;
logger.info('✅ Received structured output for tech analysis');
}
} else {
// Fall back to text parsing for non-Claude/Codex models
const extracted = extractJson<TechStackExtractionResult>(techResult.text, {
logger,
requiredKey: 'technologies',
requireArray: true,
});
if (extracted && Array.isArray(extracted.technologies)) {
parsedTechnologies = extracted.technologies;
logger.info('✅ Extracted tech stack from text response');
} else {
logger.warn('⚠️ Failed to extract tech stack JSON from response');
}
}
if (parsedTechnologies) {
const newTechStack = parsedTechnologies;
// Calculate differences // Calculate differences
const currentSet = new Set(currentTechStack.map((t) => t.toLowerCase())); const currentSet = new Set(currentTechStack.map((t) => t.toLowerCase()));
@@ -301,13 +235,17 @@ CRITICAL INSTRUCTIONS:
} }
// Update spec with new tech stack if there are changes // Update spec with new tech stack if there are changes
if (result.techStackUpdates.added.length > 0 || result.techStackUpdates.removed.length > 0) { if (
result.techStackUpdates.added.length > 0 ||
result.techStackUpdates.removed.length > 0
) {
specContent = updateTechnologyStack(specContent, newTechStack); specContent = updateTechnologyStack(specContent, newTechStack);
logger.info( logger.info(
`Updated tech stack: +${result.techStackUpdates.added.length}, -${result.techStackUpdates.removed.length}` `Updated tech stack: +${result.techStackUpdates.added.length}, -${result.techStackUpdates.removed.length}`
); );
} }
} }
}
} catch (error) { } catch (error) {
logger.warn('Failed to analyze tech stack:', error); logger.warn('Failed to analyze tech stack:', error);
// Continue with other sync operations // Continue with other sync operations

View File

@@ -10,23 +10,14 @@ import type { Request, Response } from 'express';
import { createLogger } from '@automaker/utils'; import { createLogger } from '@automaker/utils';
import { resolveModelString } from '@automaker/model-resolver'; import { resolveModelString } from '@automaker/model-resolver';
import { CLAUDE_MODEL_MAP, type ThinkingLevel } from '@automaker/types'; import { CLAUDE_MODEL_MAP, type ThinkingLevel } from '@automaker/types';
import { getAppSpecPath } from '@automaker/platform';
import { simpleQuery } from '../../../providers/simple-query-service.js'; import { simpleQuery } from '../../../providers/simple-query-service.js';
import type { SettingsService } from '../../../services/settings-service.js'; import type { SettingsService } from '../../../services/settings-service.js';
import { getPromptCustomization, getProviderByModelId } from '../../../lib/settings-helpers.js'; import { getPromptCustomization, getProviderByModelId } from '../../../lib/settings-helpers.js';
import { FeatureLoader } from '../../../services/feature-loader.js';
import * as secureFs from '../../../lib/secure-fs.js';
import { import {
buildUserPrompt, buildUserPrompt,
isValidEnhancementMode, isValidEnhancementMode,
type EnhancementMode, type EnhancementMode,
} from '../../../lib/enhancement-prompts.js'; } from '../../../lib/enhancement-prompts.js';
import {
extractTechnologyStack,
extractXmlElements,
extractXmlSection,
unescapeXml,
} from '../../../lib/xml-extractor.js';
const logger = createLogger('EnhancePrompt'); const logger = createLogger('EnhancePrompt');
@@ -62,66 +53,6 @@ interface EnhanceErrorResponse {
error: string; error: string;
} }
async function buildProjectContext(projectPath: string): Promise<string | null> {
const contextBlocks: string[] = [];
try {
const appSpecPath = getAppSpecPath(projectPath);
const specContent = (await secureFs.readFile(appSpecPath, 'utf-8')) as string;
const projectName = extractXmlSection(specContent, 'project_name');
const overview = extractXmlSection(specContent, 'overview');
const techStack = extractTechnologyStack(specContent);
const coreSection = extractXmlSection(specContent, 'core_capabilities');
const coreCapabilities = coreSection ? extractXmlElements(coreSection, 'capability') : [];
const summaryLines: string[] = [];
if (projectName) {
summaryLines.push(`Name: ${unescapeXml(projectName.trim())}`);
}
if (overview) {
summaryLines.push(`Overview: ${unescapeXml(overview.trim())}`);
}
if (techStack.length > 0) {
summaryLines.push(`Tech Stack: ${techStack.join(', ')}`);
}
if (coreCapabilities.length > 0) {
summaryLines.push(`Core Capabilities: ${coreCapabilities.slice(0, 10).join(', ')}`);
}
if (summaryLines.length > 0) {
contextBlocks.push(`PROJECT CONTEXT:\n${summaryLines.map((line) => `- ${line}`).join('\n')}`);
}
} catch (error) {
logger.debug('No app_spec.txt context available for enhancement', error);
}
try {
const featureLoader = new FeatureLoader();
const features = await featureLoader.getAll(projectPath);
const featureTitles = features
.map((feature) => feature.title || feature.name || feature.id)
.filter((title) => Boolean(title));
if (featureTitles.length > 0) {
const listed = featureTitles.slice(0, 30).map((title) => `- ${title}`);
contextBlocks.push(
`EXISTING FEATURES (avoid duplicates):\n${listed.join('\n')}${
featureTitles.length > 30 ? '\n- ...' : ''
}`
);
}
} catch (error) {
logger.debug('Failed to load existing features for enhancement context', error);
}
if (contextBlocks.length === 0) {
return null;
}
return contextBlocks.join('\n\n');
}
/** /**
* Create the enhance request handler * Create the enhance request handler
* *
@@ -191,10 +122,6 @@ export function createEnhanceHandler(
// Build the user prompt with few-shot examples // Build the user prompt with few-shot examples
const userPrompt = buildUserPrompt(validMode, trimmedText, true); const userPrompt = buildUserPrompt(validMode, trimmedText, true);
const projectContext = projectPath ? await buildProjectContext(projectPath) : null;
if (projectContext) {
logger.debug('Including project context in enhancement prompt');
}
// Check if the model is a provider model (like "GLM-4.5-Air") // Check if the model is a provider model (like "GLM-4.5-Air")
// If so, get the provider config and resolved Claude model // If so, get the provider config and resolved Claude model
@@ -229,7 +156,7 @@ export function createEnhanceHandler(
// The system prompt is combined with user prompt since some providers // The system prompt is combined with user prompt since some providers
// don't have a separate system prompt concept // don't have a separate system prompt concept
const result = await simpleQuery({ const result = await simpleQuery({
prompt: [systemPrompt, projectContext, userPrompt].filter(Boolean).join('\n\n'), prompt: `${systemPrompt}\n\n${userPrompt}`,
model: resolvedModel, model: resolvedModel,
cwd: process.cwd(), // Enhancement doesn't need a specific working directory cwd: process.cwd(), // Enhancement doesn't need a specific working directory
maxTurns: 1, maxTurns: 1,

View File

@@ -5,7 +5,6 @@
import { Router } from 'express'; import { Router } from 'express';
import { FeatureLoader } from '../../services/feature-loader.js'; import { FeatureLoader } from '../../services/feature-loader.js';
import type { SettingsService } from '../../services/settings-service.js'; import type { SettingsService } from '../../services/settings-service.js';
import type { AutoModeService } from '../../services/auto-mode-service.js';
import type { EventEmitter } from '../../lib/events.js'; import type { EventEmitter } from '../../lib/events.js';
import { validatePathParams } from '../../middleware/validate-paths.js'; import { validatePathParams } from '../../middleware/validate-paths.js';
import { createListHandler } from './routes/list.js'; import { createListHandler } from './routes/list.js';
@@ -23,16 +22,11 @@ import { createImportHandler, createConflictCheckHandler } from './routes/import
export function createFeaturesRoutes( export function createFeaturesRoutes(
featureLoader: FeatureLoader, featureLoader: FeatureLoader,
settingsService?: SettingsService, settingsService?: SettingsService,
events?: EventEmitter, events?: EventEmitter
autoModeService?: AutoModeService
): Router { ): Router {
const router = Router(); const router = Router();
router.post( router.post('/list', validatePathParams('projectPath'), createListHandler(featureLoader));
'/list',
validatePathParams('projectPath'),
createListHandler(featureLoader, autoModeService)
);
router.post('/get', validatePathParams('projectPath'), createGetHandler(featureLoader)); router.post('/get', validatePathParams('projectPath'), createGetHandler(featureLoader));
router.post( router.post(
'/create', '/create',

View File

@@ -43,7 +43,7 @@ export function createCreateHandler(featureLoader: FeatureLoader, events?: Event
if (events) { if (events) {
events.emit('feature:created', { events.emit('feature:created', {
featureId: created.id, featureId: created.id,
featureName: created.title || 'Untitled Feature', featureName: created.name,
projectPath, projectPath,
}); });
} }

View File

@@ -1,19 +1,12 @@
/** /**
* POST /list endpoint - List all features for a project * POST /list endpoint - List all features for a project
*
* Also performs orphan detection when a project is loaded to identify
* features whose branches no longer exist. This runs on every project load/switch.
*/ */
import type { Request, Response } from 'express'; import type { Request, Response } from 'express';
import { FeatureLoader } from '../../../services/feature-loader.js'; import { FeatureLoader } from '../../../services/feature-loader.js';
import type { AutoModeService } from '../../../services/auto-mode-service.js';
import { getErrorMessage, logError } from '../common.js'; import { getErrorMessage, logError } from '../common.js';
import { createLogger } from '@automaker/utils';
const logger = createLogger('FeaturesListRoute'); export function createListHandler(featureLoader: FeatureLoader) {
export function createListHandler(featureLoader: FeatureLoader, autoModeService?: AutoModeService) {
return async (req: Request, res: Response): Promise<void> => { return async (req: Request, res: Response): Promise<void> => {
try { try {
const { projectPath } = req.body as { projectPath: string }; const { projectPath } = req.body as { projectPath: string };
@@ -24,26 +17,6 @@ export function createListHandler(featureLoader: FeatureLoader, autoModeService?
} }
const features = await featureLoader.getAll(projectPath); const features = await featureLoader.getAll(projectPath);
// Run orphan detection in background when project is loaded
// This detects features whose branches no longer exist (e.g., after merge/delete)
// We don't await this to keep the list response fast
// Note: detectOrphanedFeatures handles errors internally and always resolves
if (autoModeService) {
autoModeService.detectOrphanedFeatures(projectPath).then((orphanedFeatures) => {
if (orphanedFeatures.length > 0) {
logger.info(
`[ProjectLoad] Detected ${orphanedFeatures.length} orphaned feature(s) in ${projectPath}`
);
for (const { feature, missingBranch } of orphanedFeatures) {
logger.info(
`[ProjectLoad] Orphaned: ${feature.title || feature.id} - branch "${missingBranch}" no longer exists`
);
}
}
});
}
res.json({ success: true, features }); res.json({ success: true, features });
} catch (error) { } catch (error) {
logError(error, 'List features failed'); logError(error, 'List features failed');

View File

@@ -31,9 +31,7 @@ export function createSaveBoardBackgroundHandler() {
await secureFs.mkdir(boardDir, { recursive: true }); await secureFs.mkdir(boardDir, { recursive: true });
// Decode base64 data (remove data URL prefix if present) // Decode base64 data (remove data URL prefix if present)
// Use a regex that handles all data URL formats including those with extra params const base64Data = data.replace(/^data:image\/\w+;base64,/, '');
// e.g., data:image/gif;charset=utf-8;base64,R0lGOD...
const base64Data = data.replace(/^data:[^,]+,/, '');
const buffer = Buffer.from(base64Data, 'base64'); const buffer = Buffer.from(base64Data, 'base64');
// Use a fixed filename for the board background (overwrite previous) // Use a fixed filename for the board background (overwrite previous)

View File

@@ -31,9 +31,7 @@ export function createSaveImageHandler() {
await secureFs.mkdir(imagesDir, { recursive: true }); await secureFs.mkdir(imagesDir, { recursive: true });
// Decode base64 data (remove data URL prefix if present) // Decode base64 data (remove data URL prefix if present)
// Use a regex that handles all data URL formats including those with extra params const base64Data = data.replace(/^data:image\/\w+;base64,/, '');
// e.g., data:image/gif;charset=utf-8;base64,R0lGOD...
const base64Data = data.replace(/^data:[^,]+,/, '');
const buffer = Buffer.from(base64Data, 'base64'); const buffer = Buffer.from(base64Data, 'base64');
// Generate unique filename with timestamp // Generate unique filename with timestamp

View File

@@ -23,7 +23,6 @@ import {
isCodexModel, isCodexModel,
isCursorModel, isCursorModel,
isOpencodeModel, isOpencodeModel,
supportsStructuredOutput,
} from '@automaker/types'; } from '@automaker/types';
import { resolvePhaseModel } from '@automaker/model-resolver'; import { resolvePhaseModel } from '@automaker/model-resolver';
import { extractJson } from '../../../lib/json-extractor.js'; import { extractJson } from '../../../lib/json-extractor.js';
@@ -125,9 +124,8 @@ async function runValidation(
const prompts = await getPromptCustomization(settingsService, '[ValidateIssue]'); const prompts = await getPromptCustomization(settingsService, '[ValidateIssue]');
const issueValidationSystemPrompt = prompts.issueValidation.systemPrompt; const issueValidationSystemPrompt = prompts.issueValidation.systemPrompt;
// Determine if we should use structured output based on model type // Determine if we should use structured output (Claude/Codex support it, Cursor/OpenCode don't)
// Claude and Codex support it; Cursor, Gemini, OpenCode, Copilot don't const useStructuredOutput = isClaudeModel(model) || isCodexModel(model);
const useStructuredOutput = supportsStructuredOutput(model);
// Build the final prompt - for Cursor, include system prompt and JSON schema instructions // Build the final prompt - for Cursor, include system prompt and JSON schema instructions
let finalPrompt = basePrompt; let finalPrompt = basePrompt;

View File

@@ -4,21 +4,15 @@
import type { Request, Response } from 'express'; import type { Request, Response } from 'express';
import type { IdeationService } from '../../../services/ideation-service.js'; import type { IdeationService } from '../../../services/ideation-service.js';
import type { IdeationContextSources } from '@automaker/types';
import { createLogger } from '@automaker/utils'; import { createLogger } from '@automaker/utils';
import { getErrorMessage, logError } from '../common.js'; import { getErrorMessage, logError } from '../common.js';
const logger = createLogger('ideation:suggestions-generate'); const logger = createLogger('ideation:suggestions-generate');
/**
* Creates an Express route handler for generating AI-powered ideation suggestions.
* Accepts a prompt, category, and optional context sources configuration,
* then returns structured suggestions that can be added to the board.
*/
export function createSuggestionsGenerateHandler(ideationService: IdeationService) { export function createSuggestionsGenerateHandler(ideationService: IdeationService) {
return async (req: Request, res: Response): Promise<void> => { return async (req: Request, res: Response): Promise<void> => {
try { try {
const { projectPath, promptId, category, count, contextSources } = req.body; const { projectPath, promptId, category, count } = req.body;
if (!projectPath) { if (!projectPath) {
res.status(400).json({ success: false, error: 'projectPath is required' }); res.status(400).json({ success: false, error: 'projectPath is required' });
@@ -44,8 +38,7 @@ export function createSuggestionsGenerateHandler(ideationService: IdeationServic
projectPath, projectPath,
promptId, promptId,
category, category,
suggestionCount, suggestionCount
contextSources as IdeationContextSources | undefined
); );
res.json({ res.json({

View File

@@ -14,7 +14,6 @@ import type { GlobalSettings } from '../../../types/settings.js';
import { getErrorMessage, logError, logger } from '../common.js'; import { getErrorMessage, logError, logger } from '../common.js';
import { setLogLevel, LogLevel } from '@automaker/utils'; import { setLogLevel, LogLevel } from '@automaker/utils';
import { setRequestLoggingEnabled } from '../../../index.js'; import { setRequestLoggingEnabled } from '../../../index.js';
import { getTerminalService } from '../../../services/terminal-service.js';
/** /**
* Map server log level string to LogLevel enum * Map server log level string to LogLevel enum
@@ -58,10 +57,6 @@ export function createUpdateGlobalHandler(settingsService: SettingsService) {
}, localStorageMigrated=${(updates as any).localStorageMigrated ?? 'n/a'}` }, localStorageMigrated=${(updates as any).localStorageMigrated ?? 'n/a'}`
); );
// Get old settings to detect theme changes
const oldSettings = await settingsService.getGlobalSettings();
const oldTheme = oldSettings?.theme;
logger.info('[SERVER_SETTINGS_UPDATE] Calling updateGlobalSettings...'); logger.info('[SERVER_SETTINGS_UPDATE] Calling updateGlobalSettings...');
const settings = await settingsService.updateGlobalSettings(updates); const settings = await settingsService.updateGlobalSettings(updates);
logger.info( logger.info(
@@ -69,37 +64,6 @@ export function createUpdateGlobalHandler(settingsService: SettingsService) {
settings.projects?.length ?? 0 settings.projects?.length ?? 0
); );
// Handle theme change - regenerate terminal RC files for all projects
if ('theme' in updates && updates.theme && updates.theme !== oldTheme) {
const terminalService = getTerminalService(settingsService);
const newTheme = updates.theme;
logger.info(
`[TERMINAL_CONFIG] Theme changed from ${oldTheme} to ${newTheme}, regenerating RC files`
);
// Regenerate RC files for all projects with terminal config enabled
const projects = settings.projects || [];
for (const project of projects) {
try {
const projectSettings = await settingsService.getProjectSettings(project.path);
// Check if terminal config is enabled (global or project-specific)
const terminalConfigEnabled =
projectSettings.terminalConfig?.enabled !== false &&
settings.terminalConfig?.enabled === true;
if (terminalConfigEnabled) {
await terminalService.onThemeChange(project.path, newTheme);
logger.info(`[TERMINAL_CONFIG] Regenerated RC files for project: ${project.name}`);
}
} catch (error) {
logger.warn(
`[TERMINAL_CONFIG] Failed to regenerate RC files for project ${project.name}: ${error}`
);
}
}
}
// Apply server log level if it was updated // Apply server log level if it was updated
if ('serverLogLevel' in updates && updates.serverLogLevel) { if ('serverLogLevel' in updates && updates.serverLogLevel) {
const level = LOG_LEVEL_MAP[updates.serverLogLevel]; const level = LOG_LEVEL_MAP[updates.serverLogLevel];

View File

@@ -43,14 +43,10 @@ export function createInitGitHandler() {
// .git doesn't exist, continue with initialization // .git doesn't exist, continue with initialization
} }
// Initialize git with 'main' as the default branch (matching GitHub's standard since 2020) // Initialize git and create an initial empty commit
// and create an initial empty commit await execAsync(`git init && git commit --allow-empty -m "Initial commit"`, {
await execAsync(
`git init --initial-branch=main && git commit --allow-empty -m "Initial commit"`,
{
cwd: projectPath, cwd: projectPath,
} });
);
res.json({ res.json({
success: true, success: true,

View File

@@ -39,15 +39,8 @@ interface GitHubRemoteCacheEntry {
checkedAt: number; checkedAt: number;
} }
interface GitHubPRCacheEntry {
prs: Map<string, WorktreePRInfo>;
fetchedAt: number;
}
const githubRemoteCache = new Map<string, GitHubRemoteCacheEntry>(); const githubRemoteCache = new Map<string, GitHubRemoteCacheEntry>();
const githubPRCache = new Map<string, GitHubPRCacheEntry>();
const GITHUB_REMOTE_CACHE_TTL_MS = 5 * 60 * 1000; // 5 minutes const GITHUB_REMOTE_CACHE_TTL_MS = 5 * 60 * 1000; // 5 minutes
const GITHUB_PR_CACHE_TTL_MS = 2 * 60 * 1000; // 2 minutes - avoid hitting GitHub on every poll
interface WorktreeInfo { interface WorktreeInfo {
path: string; path: string;
@@ -187,21 +180,9 @@ async function getGitHubRemoteStatus(projectPath: string): Promise<GitHubRemoteS
* This also allows detecting PRs that were created outside the app. * This also allows detecting PRs that were created outside the app.
* *
* Uses cached GitHub remote status to avoid repeated warnings when the * Uses cached GitHub remote status to avoid repeated warnings when the
* project doesn't have a GitHub remote configured. Results are cached * project doesn't have a GitHub remote configured.
* briefly to avoid hammering GitHub on frequent worktree polls.
*/ */
async function fetchGitHubPRs( async function fetchGitHubPRs(projectPath: string): Promise<Map<string, WorktreePRInfo>> {
projectPath: string,
forceRefresh = false
): Promise<Map<string, WorktreePRInfo>> {
const now = Date.now();
const cached = githubPRCache.get(projectPath);
// Return cached result if valid and not forcing refresh
if (!forceRefresh && cached && now - cached.fetchedAt < GITHUB_PR_CACHE_TTL_MS) {
return cached.prs;
}
const prMap = new Map<string, WorktreePRInfo>(); const prMap = new Map<string, WorktreePRInfo>();
try { try {
@@ -244,22 +225,8 @@ async function fetchGitHubPRs(
createdAt: pr.createdAt, createdAt: pr.createdAt,
}); });
} }
// Only update cache on successful fetch
githubPRCache.set(projectPath, {
prs: prMap,
fetchedAt: Date.now(),
});
} catch (error) { } catch (error) {
// On fetch failure, return stale cached data if available to avoid // Silently fail - PR detection is optional
// repeated API calls during GitHub API flakiness or temporary outages
if (cached) {
logger.warn(`Failed to fetch GitHub PRs, returning stale cache: ${getErrorMessage(error)}`);
// Extend cache TTL to avoid repeated retries during outages
githubPRCache.set(projectPath, { prs: cached.prs, fetchedAt: Date.now() });
return cached.prs;
}
// No cache available, log warning and return empty map
logger.warn(`Failed to fetch GitHub PRs: ${getErrorMessage(error)}`); logger.warn(`Failed to fetch GitHub PRs: ${getErrorMessage(error)}`);
} }
@@ -397,7 +364,7 @@ export function createListHandler() {
// Only fetch GitHub PRs if includeDetails is requested (performance optimization). // Only fetch GitHub PRs if includeDetails is requested (performance optimization).
// Uses --state all to detect merged/closed PRs, limited to 1000 recent PRs. // Uses --state all to detect merged/closed PRs, limited to 1000 recent PRs.
const githubPRs = includeDetails const githubPRs = includeDetails
? await fetchGitHubPRs(projectPath, forceRefreshGitHub) ? await fetchGitHubPRs(projectPath)
: new Map<string, WorktreePRInfo>(); : new Map<string, WorktreePRInfo>();
for (const worktree of worktrees) { for (const worktree of worktrees) {

File diff suppressed because it is too large Load Diff

View File

@@ -169,10 +169,9 @@ export class EventHookService {
} }
// Build context for variable substitution // Build context for variable substitution
// Use loaded featureName (from feature.title) or fall back to payload.featureName
const context: HookContext = { const context: HookContext = {
featureId: payload.featureId, featureId: payload.featureId,
featureName: featureName || payload.featureName, featureName: payload.featureName,
projectPath: payload.projectPath, projectPath: payload.projectPath,
projectName: payload.projectPath ? this.extractProjectName(payload.projectPath) : undefined, projectName: payload.projectPath ? this.extractProjectName(payload.projectPath) : undefined,
error: payload.error || payload.message, error: payload.error || payload.message,

View File

@@ -23,9 +23,7 @@ import type {
SendMessageOptions, SendMessageOptions,
PromptCategory, PromptCategory,
IdeationPrompt, IdeationPrompt,
IdeationContextSources,
} from '@automaker/types'; } from '@automaker/types';
import { DEFAULT_IDEATION_CONTEXT_SOURCES } from '@automaker/types';
import { import {
getIdeationDir, getIdeationDir,
getIdeasDir, getIdeasDir,
@@ -34,10 +32,8 @@ import {
getIdeationSessionsDir, getIdeationSessionsDir,
getIdeationSessionPath, getIdeationSessionPath,
getIdeationAnalysisPath, getIdeationAnalysisPath,
getAppSpecPath,
ensureIdeationDir, ensureIdeationDir,
} from '@automaker/platform'; } from '@automaker/platform';
import { extractXmlElements, extractImplementedFeatures } from '../lib/xml-extractor.js';
import { createLogger, loadContextFiles, isAbortError } from '@automaker/utils'; import { createLogger, loadContextFiles, isAbortError } from '@automaker/utils';
import { ProviderFactory } from '../providers/provider-factory.js'; import { ProviderFactory } from '../providers/provider-factory.js';
import type { SettingsService } from './settings-service.js'; import type { SettingsService } from './settings-service.js';
@@ -642,12 +638,8 @@ export class IdeationService {
projectPath: string, projectPath: string,
promptId: string, promptId: string,
category: IdeaCategory, category: IdeaCategory,
count: number = 10, count: number = 10
contextSources?: IdeationContextSources
): Promise<AnalysisSuggestion[]> { ): Promise<AnalysisSuggestion[]> {
const suggestionCount = Math.min(Math.max(Math.floor(count ?? 10), 1), 20);
// Merge with defaults for backward compatibility
const sources = { ...DEFAULT_IDEATION_CONTEXT_SOURCES, ...contextSources };
validateWorkingDirectory(projectPath); validateWorkingDirectory(projectPath);
// Get the prompt // Get the prompt
@@ -664,26 +656,16 @@ export class IdeationService {
}); });
try { try {
// Load context files (respecting toggle settings) // Load context files
const contextResult = await loadContextFiles({ const contextResult = await loadContextFiles({
projectPath, projectPath,
fsModule: secureFs as Parameters<typeof loadContextFiles>[0]['fsModule'], fsModule: secureFs as Parameters<typeof loadContextFiles>[0]['fsModule'],
includeContextFiles: sources.useContextFiles,
includeMemory: sources.useMemoryFiles,
}); });
// Build context from multiple sources // Build context from multiple sources
let contextPrompt = contextResult.formattedPrompt; let contextPrompt = contextResult.formattedPrompt;
// Add app spec context if enabled // If no context files, try to gather basic project info
if (sources.useAppSpec) {
const appSpecContext = await this.buildAppSpecContext(projectPath);
if (appSpecContext) {
contextPrompt = contextPrompt ? `${contextPrompt}\n\n${appSpecContext}` : appSpecContext;
}
}
// If no context was found, try to gather basic project info
if (!contextPrompt) { if (!contextPrompt) {
const projectInfo = await this.gatherBasicProjectInfo(projectPath); const projectInfo = await this.gatherBasicProjectInfo(projectPath);
if (projectInfo) { if (projectInfo) {
@@ -691,11 +673,8 @@ export class IdeationService {
} }
} }
// Gather existing features and ideas to prevent duplicates (respecting toggle settings) // Gather existing features and ideas to prevent duplicates
const existingWorkContext = await this.gatherExistingWorkContext(projectPath, { const existingWorkContext = await this.gatherExistingWorkContext(projectPath);
includeFeatures: sources.useExistingFeatures,
includeIdeas: sources.useExistingIdeas,
});
// Get customized prompts from settings // Get customized prompts from settings
const prompts = await getPromptCustomization(this.settingsService, '[IdeationService]'); const prompts = await getPromptCustomization(this.settingsService, '[IdeationService]');
@@ -705,7 +684,7 @@ export class IdeationService {
prompts.ideation.suggestionsSystemPrompt, prompts.ideation.suggestionsSystemPrompt,
contextPrompt, contextPrompt,
category, category,
suggestionCount, count,
existingWorkContext existingWorkContext
); );
@@ -772,11 +751,7 @@ export class IdeationService {
} }
// Parse the response into structured suggestions // Parse the response into structured suggestions
const suggestions = this.parseSuggestionsFromResponse( const suggestions = this.parseSuggestionsFromResponse(responseText, category);
responseText,
category,
suggestionCount
);
// Emit complete event // Emit complete event
this.events.emit('ideation:suggestions', { this.events.emit('ideation:suggestions', {
@@ -839,24 +814,22 @@ ${contextSection}${existingWorkSection}`;
*/ */
private parseSuggestionsFromResponse( private parseSuggestionsFromResponse(
response: string, response: string,
category: IdeaCategory, category: IdeaCategory
count: number
): AnalysisSuggestion[] { ): AnalysisSuggestion[] {
try { try {
// Try to extract JSON from the response // Try to extract JSON from the response
const jsonMatch = response.match(/\[[\s\S]*\]/); const jsonMatch = response.match(/\[[\s\S]*\]/);
if (!jsonMatch) { if (!jsonMatch) {
logger.warn('No JSON array found in response, falling back to text parsing'); logger.warn('No JSON array found in response, falling back to text parsing');
return this.parseTextResponse(response, category, count); return this.parseTextResponse(response, category);
} }
const parsed = JSON.parse(jsonMatch[0]); const parsed = JSON.parse(jsonMatch[0]);
if (!Array.isArray(parsed)) { if (!Array.isArray(parsed)) {
return this.parseTextResponse(response, category, count); return this.parseTextResponse(response, category);
} }
return parsed return parsed.map((item: any, index: number) => ({
.map((item: any, index: number) => ({
id: this.generateId('sug'), id: this.generateId('sug'),
category, category,
title: item.title || `Suggestion ${index + 1}`, title: item.title || `Suggestion ${index + 1}`,
@@ -864,22 +837,17 @@ ${contextSection}${existingWorkSection}`;
rationale: item.rationale || '', rationale: item.rationale || '',
priority: item.priority || 'medium', priority: item.priority || 'medium',
relatedFiles: item.relatedFiles || [], relatedFiles: item.relatedFiles || [],
})) }));
.slice(0, count);
} catch (error) { } catch (error) {
logger.warn('Failed to parse JSON response:', error); logger.warn('Failed to parse JSON response:', error);
return this.parseTextResponse(response, category, count); return this.parseTextResponse(response, category);
} }
} }
/** /**
* Fallback: parse text response into suggestions * Fallback: parse text response into suggestions
*/ */
private parseTextResponse( private parseTextResponse(response: string, category: IdeaCategory): AnalysisSuggestion[] {
response: string,
category: IdeaCategory,
count: number
): AnalysisSuggestion[] {
const suggestions: AnalysisSuggestion[] = []; const suggestions: AnalysisSuggestion[] = [];
// Try to find numbered items or headers // Try to find numbered items or headers
@@ -939,7 +907,7 @@ ${contextSection}${existingWorkSection}`;
}); });
} }
return suggestions.slice(0, count); return suggestions.slice(0, 5); // Max 5 suggestions
} }
// ============================================================================ // ============================================================================
@@ -1377,68 +1345,6 @@ ${contextSection}${existingWorkSection}`;
return descriptions[category] || ''; return descriptions[category] || '';
} }
/**
* Build context from app_spec.txt for suggestion generation
* Extracts project name, overview, capabilities, and implemented features
*/
private async buildAppSpecContext(projectPath: string): Promise<string> {
try {
const specPath = getAppSpecPath(projectPath);
const specContent = (await secureFs.readFile(specPath, 'utf-8')) as string;
const parts: string[] = [];
parts.push('## App Specification');
// Extract project name
const projectNames = extractXmlElements(specContent, 'project_name');
if (projectNames.length > 0 && projectNames[0]) {
parts.push(`**Project:** ${projectNames[0]}`);
}
// Extract overview
const overviews = extractXmlElements(specContent, 'overview');
if (overviews.length > 0 && overviews[0]) {
parts.push(`**Overview:** ${overviews[0]}`);
}
// Extract core capabilities
const capabilities = extractXmlElements(specContent, 'capability');
if (capabilities.length > 0) {
parts.push('**Core Capabilities:**');
for (const cap of capabilities) {
parts.push(`- ${cap}`);
}
}
// Extract implemented features
const implementedFeatures = extractImplementedFeatures(specContent);
if (implementedFeatures.length > 0) {
parts.push('**Implemented Features:**');
for (const feature of implementedFeatures) {
if (feature.description) {
parts.push(`- ${feature.name}: ${feature.description}`);
} else {
parts.push(`- ${feature.name}`);
}
}
}
// Only return content if we extracted something meaningful
if (parts.length > 1) {
return parts.join('\n');
}
return '';
} catch (error) {
// If file doesn't exist, return empty string silently
if ((error as NodeJS.ErrnoException).code === 'ENOENT') {
return '';
}
// For other errors, log and return empty string
logger.warn('Failed to build app spec context:', error);
return '';
}
}
/** /**
* Gather basic project information for context when no context files exist * Gather basic project information for context when no context files exist
*/ */
@@ -1534,15 +1440,11 @@ ${contextSection}${existingWorkSection}`;
* Gather existing features and ideas to prevent duplicate suggestions * Gather existing features and ideas to prevent duplicate suggestions
* Returns a concise list of titles grouped by status to avoid polluting context * Returns a concise list of titles grouped by status to avoid polluting context
*/ */
private async gatherExistingWorkContext( private async gatherExistingWorkContext(projectPath: string): Promise<string> {
projectPath: string,
options?: { includeFeatures?: boolean; includeIdeas?: boolean }
): Promise<string> {
const { includeFeatures = true, includeIdeas = true } = options ?? {};
const parts: string[] = []; const parts: string[] = [];
// Load existing features from the board // Load existing features from the board
if (includeFeatures && this.featureLoader) { if (this.featureLoader) {
try { try {
const features = await this.featureLoader.getAll(projectPath); const features = await this.featureLoader.getAll(projectPath);
if (features.length > 0) { if (features.length > 0) {
@@ -1590,7 +1492,6 @@ ${contextSection}${existingWorkSection}`;
} }
// Load existing ideas // Load existing ideas
if (includeIdeas) {
try { try {
const ideas = await this.getIdeas(projectPath); const ideas = await this.getIdeas(projectPath);
// Filter out archived ideas // Filter out archived ideas
@@ -1620,7 +1521,6 @@ ${contextSection}${existingWorkSection}`;
} catch (error) { } catch (error) {
logger.warn('Failed to load existing ideas:', error); logger.warn('Failed to load existing ideas:', error);
} }
}
return parts.join('\n'); return parts.join('\n');
} }

View File

@@ -13,14 +13,6 @@ import * as path from 'path';
// to enforce ALLOWED_ROOT_DIRECTORY security boundary // to enforce ALLOWED_ROOT_DIRECTORY security boundary
import * as secureFs from '../lib/secure-fs.js'; import * as secureFs from '../lib/secure-fs.js';
import { createLogger } from '@automaker/utils'; import { createLogger } from '@automaker/utils';
import type { SettingsService } from './settings-service.js';
import { getTerminalThemeColors, getAllTerminalThemes } from '../lib/terminal-themes-data.js';
import {
getRcFilePath,
getTerminalDir,
ensureRcFilesUpToDate,
type TerminalConfig,
} from '@automaker/platform';
const logger = createLogger('Terminal'); const logger = createLogger('Terminal');
// System paths module handles shell binary checks and WSL detection // System paths module handles shell binary checks and WSL detection
@@ -32,27 +24,6 @@ import {
getShellPaths, getShellPaths,
} from '@automaker/platform'; } from '@automaker/platform';
const BASH_LOGIN_ARG = '--login';
const BASH_RCFILE_ARG = '--rcfile';
const SHELL_NAME_BASH = 'bash';
const SHELL_NAME_ZSH = 'zsh';
const SHELL_NAME_SH = 'sh';
const DEFAULT_SHOW_USER_HOST = true;
const DEFAULT_SHOW_PATH = true;
const DEFAULT_SHOW_TIME = false;
const DEFAULT_SHOW_EXIT_STATUS = false;
const DEFAULT_PATH_DEPTH = 0;
const DEFAULT_PATH_STYLE: TerminalConfig['pathStyle'] = 'full';
const DEFAULT_CUSTOM_PROMPT = true;
const DEFAULT_PROMPT_FORMAT: TerminalConfig['promptFormat'] = 'standard';
const DEFAULT_SHOW_GIT_BRANCH = true;
const DEFAULT_SHOW_GIT_STATUS = true;
const DEFAULT_CUSTOM_ALIASES = '';
const DEFAULT_CUSTOM_ENV_VARS: Record<string, string> = {};
const PROMPT_THEME_CUSTOM = 'custom';
const PROMPT_THEME_PREFIX = 'omp-';
const OMP_THEME_ENV_VAR = 'AUTOMAKER_OMP_THEME';
// Maximum scrollback buffer size (characters) // Maximum scrollback buffer size (characters)
const MAX_SCROLLBACK_SIZE = 50000; // ~50KB per terminal const MAX_SCROLLBACK_SIZE = 50000; // ~50KB per terminal
@@ -71,114 +42,6 @@ let maxSessions = parseInt(process.env.TERMINAL_MAX_SESSIONS || '1000', 10);
const OUTPUT_THROTTLE_MS = 4; // ~250fps max update rate for responsive input const OUTPUT_THROTTLE_MS = 4; // ~250fps max update rate for responsive input
const OUTPUT_BATCH_SIZE = 4096; // Smaller batches for lower latency const OUTPUT_BATCH_SIZE = 4096; // Smaller batches for lower latency
function applyBashRcFileArgs(args: string[], rcFilePath: string): string[] {
const sanitizedArgs: string[] = [];
for (let index = 0; index < args.length; index += 1) {
const arg = args[index];
if (arg === BASH_LOGIN_ARG) {
continue;
}
if (arg === BASH_RCFILE_ARG) {
index += 1;
continue;
}
sanitizedArgs.push(arg);
}
sanitizedArgs.push(BASH_RCFILE_ARG, rcFilePath);
return sanitizedArgs;
}
function normalizePathStyle(
pathStyle: TerminalConfig['pathStyle'] | undefined
): TerminalConfig['pathStyle'] {
if (pathStyle === 'short' || pathStyle === 'basename') {
return pathStyle;
}
return DEFAULT_PATH_STYLE;
}
function normalizePathDepth(pathDepth: number | undefined): number {
const depth =
typeof pathDepth === 'number' && Number.isFinite(pathDepth) ? pathDepth : DEFAULT_PATH_DEPTH;
return Math.max(DEFAULT_PATH_DEPTH, Math.floor(depth));
}
function getShellBasename(shellPath: string): string {
const lastSep = Math.max(shellPath.lastIndexOf('/'), shellPath.lastIndexOf('\\'));
return lastSep >= 0 ? shellPath.slice(lastSep + 1) : shellPath;
}
function getShellArgsForPath(shellPath: string): string[] {
const shellName = getShellBasename(shellPath).toLowerCase().replace('.exe', '');
if (shellName === 'powershell' || shellName === 'pwsh' || shellName === 'cmd') {
return [];
}
if (shellName === SHELL_NAME_SH) {
return [];
}
return [BASH_LOGIN_ARG];
}
function resolveOmpThemeName(promptTheme: string | undefined): string | null {
if (!promptTheme || promptTheme === PROMPT_THEME_CUSTOM) {
return null;
}
if (promptTheme.startsWith(PROMPT_THEME_PREFIX)) {
return promptTheme.slice(PROMPT_THEME_PREFIX.length);
}
return null;
}
function buildEffectiveTerminalConfig(
globalTerminalConfig: TerminalConfig | undefined,
projectTerminalConfig: Partial<TerminalConfig> | undefined
): TerminalConfig {
const mergedEnvVars = {
...(globalTerminalConfig?.customEnvVars ?? DEFAULT_CUSTOM_ENV_VARS),
...(projectTerminalConfig?.customEnvVars ?? DEFAULT_CUSTOM_ENV_VARS),
};
return {
enabled: projectTerminalConfig?.enabled ?? globalTerminalConfig?.enabled ?? false,
customPrompt: globalTerminalConfig?.customPrompt ?? DEFAULT_CUSTOM_PROMPT,
promptFormat: globalTerminalConfig?.promptFormat ?? DEFAULT_PROMPT_FORMAT,
showGitBranch:
projectTerminalConfig?.showGitBranch ??
globalTerminalConfig?.showGitBranch ??
DEFAULT_SHOW_GIT_BRANCH,
showGitStatus:
projectTerminalConfig?.showGitStatus ??
globalTerminalConfig?.showGitStatus ??
DEFAULT_SHOW_GIT_STATUS,
showUserHost:
projectTerminalConfig?.showUserHost ??
globalTerminalConfig?.showUserHost ??
DEFAULT_SHOW_USER_HOST,
showPath:
projectTerminalConfig?.showPath ?? globalTerminalConfig?.showPath ?? DEFAULT_SHOW_PATH,
pathStyle: normalizePathStyle(
projectTerminalConfig?.pathStyle ?? globalTerminalConfig?.pathStyle
),
pathDepth: normalizePathDepth(
projectTerminalConfig?.pathDepth ?? globalTerminalConfig?.pathDepth
),
showTime:
projectTerminalConfig?.showTime ?? globalTerminalConfig?.showTime ?? DEFAULT_SHOW_TIME,
showExitStatus:
projectTerminalConfig?.showExitStatus ??
globalTerminalConfig?.showExitStatus ??
DEFAULT_SHOW_EXIT_STATUS,
customAliases:
projectTerminalConfig?.customAliases ??
globalTerminalConfig?.customAliases ??
DEFAULT_CUSTOM_ALIASES,
customEnvVars: mergedEnvVars,
rcFileVersion: globalTerminalConfig?.rcFileVersion,
};
}
export interface TerminalSession { export interface TerminalSession {
id: string; id: string;
pty: pty.IPty; pty: pty.IPty;
@@ -214,12 +77,6 @@ export class TerminalService extends EventEmitter {
!!(process.versions && (process.versions as Record<string, string>).electron) || !!(process.versions && (process.versions as Record<string, string>).electron) ||
!!process.env.ELECTRON_RUN_AS_NODE; !!process.env.ELECTRON_RUN_AS_NODE;
private useConptyFallback = false; // Track if we need to use winpty fallback on Windows private useConptyFallback = false; // Track if we need to use winpty fallback on Windows
private settingsService: SettingsService | null = null;
constructor(settingsService?: SettingsService) {
super();
this.settingsService = settingsService || null;
}
/** /**
* Kill a PTY process with platform-specific handling. * Kill a PTY process with platform-specific handling.
@@ -245,19 +102,37 @@ export class TerminalService extends EventEmitter {
const platform = os.platform(); const platform = os.platform();
const shellPaths = getShellPaths(); const shellPaths = getShellPaths();
// Helper to get basename handling both path separators
const getBasename = (shellPath: string): string => {
const lastSep = Math.max(shellPath.lastIndexOf('/'), shellPath.lastIndexOf('\\'));
return lastSep >= 0 ? shellPath.slice(lastSep + 1) : shellPath;
};
// Helper to get shell args based on shell name
const getShellArgs = (shell: string): string[] => {
const shellName = getBasename(shell).toLowerCase().replace('.exe', '');
// PowerShell and cmd don't need --login
if (shellName === 'powershell' || shellName === 'pwsh' || shellName === 'cmd') {
return [];
}
// sh doesn't support --login in all implementations
if (shellName === 'sh') {
return [];
}
// bash, zsh, and other POSIX shells support --login
return ['--login'];
};
// Check if running in WSL - prefer user's shell or bash with --login // Check if running in WSL - prefer user's shell or bash with --login
if (platform === 'linux' && this.isWSL()) { if (platform === 'linux' && this.isWSL()) {
const userShell = process.env.SHELL; const userShell = process.env.SHELL;
if (userShell) { if (userShell) {
// Try to find userShell in allowed paths // Try to find userShell in allowed paths
for (const allowedShell of shellPaths) { for (const allowedShell of shellPaths) {
if ( if (allowedShell === userShell || getBasename(allowedShell) === getBasename(userShell)) {
allowedShell === userShell ||
getShellBasename(allowedShell) === getShellBasename(userShell)
) {
try { try {
if (systemPathExists(allowedShell)) { if (systemPathExists(allowedShell)) {
return { shell: allowedShell, args: getShellArgsForPath(allowedShell) }; return { shell: allowedShell, args: getShellArgs(allowedShell) };
} }
} catch { } catch {
// Path not allowed, continue searching // Path not allowed, continue searching
@@ -269,7 +144,7 @@ export class TerminalService extends EventEmitter {
for (const shell of shellPaths) { for (const shell of shellPaths) {
try { try {
if (systemPathExists(shell)) { if (systemPathExists(shell)) {
return { shell, args: getShellArgsForPath(shell) }; return { shell, args: getShellArgs(shell) };
} }
} catch { } catch {
// Path not allowed, continue // Path not allowed, continue
@@ -283,13 +158,10 @@ export class TerminalService extends EventEmitter {
if (userShell && platform !== 'win32') { if (userShell && platform !== 'win32') {
// Try to find userShell in allowed paths // Try to find userShell in allowed paths
for (const allowedShell of shellPaths) { for (const allowedShell of shellPaths) {
if ( if (allowedShell === userShell || getBasename(allowedShell) === getBasename(userShell)) {
allowedShell === userShell ||
getShellBasename(allowedShell) === getShellBasename(userShell)
) {
try { try {
if (systemPathExists(allowedShell)) { if (systemPathExists(allowedShell)) {
return { shell: allowedShell, args: getShellArgsForPath(allowedShell) }; return { shell: allowedShell, args: getShellArgs(allowedShell) };
} }
} catch { } catch {
// Path not allowed, continue searching // Path not allowed, continue searching
@@ -302,7 +174,7 @@ export class TerminalService extends EventEmitter {
for (const shell of shellPaths) { for (const shell of shellPaths) {
try { try {
if (systemPathExists(shell)) { if (systemPathExists(shell)) {
return { shell, args: getShellArgsForPath(shell) }; return { shell, args: getShellArgs(shell) };
} }
} catch { } catch {
// Path not allowed or doesn't exist, continue to next // Path not allowed or doesn't exist, continue to next
@@ -441,9 +313,8 @@ export class TerminalService extends EventEmitter {
const id = `term-${Date.now()}-${Math.random().toString(36).slice(2, 11)}`; const id = `term-${Date.now()}-${Math.random().toString(36).slice(2, 11)}`;
const { shell: detectedShell, args: detectedShellArgs } = this.detectShell(); const { shell: detectedShell, args: shellArgs } = this.detectShell();
const shell = options.shell || detectedShell; const shell = options.shell || detectedShell;
let shellArgs = options.shell ? getShellArgsForPath(shell) : [...detectedShellArgs];
// Validate and resolve working directory // Validate and resolve working directory
// Uses secureFs internally to enforce ALLOWED_ROOT_DIRECTORY // Uses secureFs internally to enforce ALLOWED_ROOT_DIRECTORY
@@ -461,89 +332,6 @@ export class TerminalService extends EventEmitter {
} }
} }
// Terminal config injection (custom prompts, themes)
const terminalConfigEnv: Record<string, string> = {};
if (this.settingsService) {
try {
logger.info(
`[createSession] Checking terminal config for session ${id}, cwd: ${options.cwd || cwd}`
);
const globalSettings = await this.settingsService.getGlobalSettings();
const projectSettings = options.cwd
? await this.settingsService.getProjectSettings(options.cwd)
: null;
const globalTerminalConfig = globalSettings?.terminalConfig;
const projectTerminalConfig = projectSettings?.terminalConfig;
const effectiveConfig = buildEffectiveTerminalConfig(
globalTerminalConfig,
projectTerminalConfig
);
logger.info(
`[createSession] Terminal config: global.enabled=${globalTerminalConfig?.enabled}, project.enabled=${projectTerminalConfig?.enabled}`
);
logger.info(
`[createSession] Terminal config effective enabled: ${effectiveConfig.enabled}`
);
if (effectiveConfig.enabled && globalTerminalConfig) {
const currentTheme = globalSettings?.theme || 'dark';
const themeColors = getTerminalThemeColors(currentTheme);
const allThemes = getAllTerminalThemes();
const promptTheme =
projectTerminalConfig?.promptTheme ?? globalTerminalConfig.promptTheme;
const ompThemeName = resolveOmpThemeName(promptTheme);
// Ensure RC files are up to date
await ensureRcFilesUpToDate(
options.cwd || cwd,
currentTheme,
effectiveConfig,
themeColors,
allThemes
);
// Set shell-specific env vars
const shellName = getShellBasename(shell).toLowerCase();
if (ompThemeName && effectiveConfig.customPrompt) {
terminalConfigEnv[OMP_THEME_ENV_VAR] = ompThemeName;
}
if (shellName.includes(SHELL_NAME_BASH)) {
const bashRcFilePath = getRcFilePath(options.cwd || cwd, SHELL_NAME_BASH);
terminalConfigEnv.BASH_ENV = bashRcFilePath;
terminalConfigEnv.AUTOMAKER_CUSTOM_PROMPT = effectiveConfig.customPrompt
? 'true'
: 'false';
terminalConfigEnv.AUTOMAKER_THEME = currentTheme;
shellArgs = applyBashRcFileArgs(shellArgs, bashRcFilePath);
} else if (shellName.includes(SHELL_NAME_ZSH)) {
terminalConfigEnv.ZDOTDIR = getTerminalDir(options.cwd || cwd);
terminalConfigEnv.AUTOMAKER_CUSTOM_PROMPT = effectiveConfig.customPrompt
? 'true'
: 'false';
terminalConfigEnv.AUTOMAKER_THEME = currentTheme;
} else if (shellName === SHELL_NAME_SH) {
terminalConfigEnv.ENV = getRcFilePath(options.cwd || cwd, SHELL_NAME_SH);
terminalConfigEnv.AUTOMAKER_CUSTOM_PROMPT = effectiveConfig.customPrompt
? 'true'
: 'false';
terminalConfigEnv.AUTOMAKER_THEME = currentTheme;
}
// Add custom env vars from config
Object.assign(terminalConfigEnv, effectiveConfig.customEnvVars);
logger.info(
`[createSession] Terminal config enabled for session ${id}, shell: ${shellName}`
);
}
} catch (error) {
logger.warn(`[createSession] Failed to apply terminal config: ${error}`);
}
}
const env: Record<string, string> = { const env: Record<string, string> = {
...cleanEnv, ...cleanEnv,
TERM: 'xterm-256color', TERM: 'xterm-256color',
@@ -553,7 +341,6 @@ export class TerminalService extends EventEmitter {
LANG: process.env.LANG || 'en_US.UTF-8', LANG: process.env.LANG || 'en_US.UTF-8',
LC_ALL: process.env.LC_ALL || process.env.LANG || 'en_US.UTF-8', LC_ALL: process.env.LC_ALL || process.env.LANG || 'en_US.UTF-8',
...options.env, ...options.env,
...terminalConfigEnv, // Apply terminal config env vars last (highest priority)
}; };
logger.info(`Creating session ${id} with shell: ${shell} in ${cwd}`); logger.info(`Creating session ${id} with shell: ${shell} in ${cwd}`);
@@ -865,44 +652,6 @@ export class TerminalService extends EventEmitter {
return () => this.exitCallbacks.delete(callback); return () => this.exitCallbacks.delete(callback);
} }
/**
* Handle theme change - regenerate RC files with new theme colors
*/
async onThemeChange(projectPath: string, newTheme: string): Promise<void> {
if (!this.settingsService) {
logger.warn('[onThemeChange] SettingsService not available');
return;
}
try {
const globalSettings = await this.settingsService.getGlobalSettings();
const terminalConfig = globalSettings?.terminalConfig;
const projectSettings = await this.settingsService.getProjectSettings(projectPath);
const projectTerminalConfig = projectSettings?.terminalConfig;
const effectiveConfig = buildEffectiveTerminalConfig(terminalConfig, projectTerminalConfig);
if (effectiveConfig.enabled && terminalConfig) {
const themeColors = getTerminalThemeColors(
newTheme as import('@automaker/types').ThemeMode
);
const allThemes = getAllTerminalThemes();
// Regenerate RC files with new theme
await ensureRcFilesUpToDate(
projectPath,
newTheme as import('@automaker/types').ThemeMode,
effectiveConfig,
themeColors,
allThemes
);
logger.info(`[onThemeChange] Regenerated RC files for theme: ${newTheme}`);
}
} catch (error) {
logger.error(`[onThemeChange] Failed to regenerate RC files: ${error}`);
}
}
/** /**
* Clean up all sessions * Clean up all sessions
*/ */
@@ -927,9 +676,9 @@ export class TerminalService extends EventEmitter {
// Singleton instance // Singleton instance
let terminalService: TerminalService | null = null; let terminalService: TerminalService | null = null;
export function getTerminalService(settingsService?: SettingsService): TerminalService { export function getTerminalService(): TerminalService {
if (!terminalService) { if (!terminalService) {
terminalService = new TerminalService(settingsService); terminalService = new TerminalService();
} }
return terminalService; return terminalService;
} }

View File

@@ -20,8 +20,8 @@ export interface TestRepo {
export async function createTestGitRepo(): Promise<TestRepo> { export async function createTestGitRepo(): Promise<TestRepo> {
const tmpDir = await fs.mkdtemp(path.join(os.tmpdir(), 'automaker-test-')); const tmpDir = await fs.mkdtemp(path.join(os.tmpdir(), 'automaker-test-'));
// Initialize git repo with 'main' as the default branch (matching GitHub's standard) // Initialize git repo
await execAsync('git init --initial-branch=main', { cwd: tmpDir }); await execAsync('git init', { cwd: tmpDir });
// Use environment variables instead of git config to avoid affecting user's git config // Use environment variables instead of git config to avoid affecting user's git config
// These env vars override git config without modifying it // These env vars override git config without modifying it
@@ -38,6 +38,9 @@ export async function createTestGitRepo(): Promise<TestRepo> {
await execAsync('git add .', { cwd: tmpDir, env: gitEnv }); await execAsync('git add .', { cwd: tmpDir, env: gitEnv });
await execAsync('git commit -m "Initial commit"', { cwd: tmpDir, env: gitEnv }); await execAsync('git commit -m "Initial commit"', { cwd: tmpDir, env: gitEnv });
// Create main branch explicitly
await execAsync('git branch -M main', { cwd: tmpDir });
return { return {
path: tmpDir, path: tmpDir,
cleanup: async () => { cleanup: async () => {

View File

@@ -14,8 +14,7 @@ describe('worktree create route - repositories without commits', () => {
async function initRepoWithoutCommit() { async function initRepoWithoutCommit() {
repoPath = await fs.mkdtemp(path.join(os.tmpdir(), 'automaker-no-commit-')); repoPath = await fs.mkdtemp(path.join(os.tmpdir(), 'automaker-no-commit-'));
// Initialize with 'main' as the default branch (matching GitHub's standard) await execAsync('git init', { cwd: repoPath });
await execAsync('git init --initial-branch=main', { cwd: repoPath });
// Don't set git config - use environment variables in commit operations instead // Don't set git config - use environment variables in commit operations instead
// to avoid affecting user's git config // to avoid affecting user's git config
// Intentionally skip creating an initial commit // Intentionally skip creating an initial commit

View File

@@ -325,12 +325,8 @@ describe('codex-provider.ts', () => {
); );
const call = vi.mocked(spawnJSONLProcess).mock.calls[0][0]; const call = vi.mocked(spawnJSONLProcess).mock.calls[0][0];
// xhigh reasoning effort uses 5-minute base timeout (300000ms) for feature generation // xhigh reasoning effort should have 4x the default timeout (120000ms)
// then applies 4x multiplier: 300000 * 4.0 = 1200000ms (20 minutes) expect(call.timeout).toBe(DEFAULT_TIMEOUT_MS * REASONING_TIMEOUT_MULTIPLIERS.xhigh);
const CODEX_FEATURE_GENERATION_BASE_TIMEOUT_MS = 300000;
expect(call.timeout).toBe(
CODEX_FEATURE_GENERATION_BASE_TIMEOUT_MS * REASONING_TIMEOUT_MULTIPLIERS.xhigh
);
}); });
it('uses default timeout when no reasoning effort is specified', async () => { it('uses default timeout when no reasoning effort is specified', async () => {

View File

@@ -315,531 +315,4 @@ describe('auto-mode-service.ts', () => {
expect(duration).toBeLessThan(40); expect(duration).toBeLessThan(40);
}); });
}); });
describe('detectOrphanedFeatures', () => {
// Helper to mock featureLoader.getAll
const mockFeatureLoaderGetAll = (svc: AutoModeService, mockFn: ReturnType<typeof vi.fn>) => {
(svc as any).featureLoader = { getAll: mockFn };
};
// Helper to mock getExistingBranches
const mockGetExistingBranches = (svc: AutoModeService, branches: string[]) => {
(svc as any).getExistingBranches = vi.fn().mockResolvedValue(new Set(branches));
};
it('should return empty array when no features have branch names', async () => {
const getAllMock = vi.fn().mockResolvedValue([
{ id: 'f1', title: 'Feature 1', description: 'desc', category: 'test' },
{ id: 'f2', title: 'Feature 2', description: 'desc', category: 'test' },
] satisfies Feature[]);
mockFeatureLoaderGetAll(service, getAllMock);
mockGetExistingBranches(service, ['main', 'develop']);
const result = await service.detectOrphanedFeatures('/test/project');
expect(result).toEqual([]);
});
it('should return empty array when all feature branches exist', async () => {
const getAllMock = vi.fn().mockResolvedValue([
{
id: 'f1',
title: 'Feature 1',
description: 'desc',
category: 'test',
branchName: 'feature-1',
},
{
id: 'f2',
title: 'Feature 2',
description: 'desc',
category: 'test',
branchName: 'feature-2',
},
] satisfies Feature[]);
mockFeatureLoaderGetAll(service, getAllMock);
mockGetExistingBranches(service, ['main', 'feature-1', 'feature-2']);
const result = await service.detectOrphanedFeatures('/test/project');
expect(result).toEqual([]);
});
it('should detect orphaned features with missing branches', async () => {
const features: Feature[] = [
{
id: 'f1',
title: 'Feature 1',
description: 'desc',
category: 'test',
branchName: 'feature-1',
},
{
id: 'f2',
title: 'Feature 2',
description: 'desc',
category: 'test',
branchName: 'deleted-branch',
},
{ id: 'f3', title: 'Feature 3', description: 'desc', category: 'test' }, // No branch
];
const getAllMock = vi.fn().mockResolvedValue(features);
mockFeatureLoaderGetAll(service, getAllMock);
mockGetExistingBranches(service, ['main', 'feature-1']); // deleted-branch not in list
const result = await service.detectOrphanedFeatures('/test/project');
expect(result).toHaveLength(1);
expect(result[0].feature.id).toBe('f2');
expect(result[0].missingBranch).toBe('deleted-branch');
});
it('should detect multiple orphaned features', async () => {
const features: Feature[] = [
{
id: 'f1',
title: 'Feature 1',
description: 'desc',
category: 'test',
branchName: 'orphan-1',
},
{
id: 'f2',
title: 'Feature 2',
description: 'desc',
category: 'test',
branchName: 'orphan-2',
},
{
id: 'f3',
title: 'Feature 3',
description: 'desc',
category: 'test',
branchName: 'valid-branch',
},
];
const getAllMock = vi.fn().mockResolvedValue(features);
mockFeatureLoaderGetAll(service, getAllMock);
mockGetExistingBranches(service, ['main', 'valid-branch']);
const result = await service.detectOrphanedFeatures('/test/project');
expect(result).toHaveLength(2);
expect(result.map((r) => r.feature.id)).toContain('f1');
expect(result.map((r) => r.feature.id)).toContain('f2');
});
it('should return empty array when getAll throws error', async () => {
const getAllMock = vi.fn().mockRejectedValue(new Error('Failed to load features'));
mockFeatureLoaderGetAll(service, getAllMock);
const result = await service.detectOrphanedFeatures('/test/project');
expect(result).toEqual([]);
});
it('should ignore empty branchName strings', async () => {
const features: Feature[] = [
{ id: 'f1', title: 'Feature 1', description: 'desc', category: 'test', branchName: '' },
{ id: 'f2', title: 'Feature 2', description: 'desc', category: 'test', branchName: ' ' },
];
const getAllMock = vi.fn().mockResolvedValue(features);
mockFeatureLoaderGetAll(service, getAllMock);
mockGetExistingBranches(service, ['main']);
const result = await service.detectOrphanedFeatures('/test/project');
expect(result).toEqual([]);
});
it('should skip features whose branchName matches the primary branch', async () => {
const features: Feature[] = [
{ id: 'f1', title: 'Feature 1', description: 'desc', category: 'test', branchName: 'main' },
{
id: 'f2',
title: 'Feature 2',
description: 'desc',
category: 'test',
branchName: 'orphaned',
},
];
const getAllMock = vi.fn().mockResolvedValue(features);
mockFeatureLoaderGetAll(service, getAllMock);
mockGetExistingBranches(service, ['main', 'develop']);
// Mock getCurrentBranch to return 'main'
(service as any).getCurrentBranch = vi.fn().mockResolvedValue('main');
const result = await service.detectOrphanedFeatures('/test/project');
// Only f2 should be orphaned (orphaned branch doesn't exist)
expect(result).toHaveLength(1);
expect(result[0].feature.id).toBe('f2');
});
});
describe('markFeatureInterrupted', () => {
// Helper to mock updateFeatureStatus
const mockUpdateFeatureStatus = (svc: AutoModeService, mockFn: ReturnType<typeof vi.fn>) => {
(svc as any).updateFeatureStatus = mockFn;
};
// Helper to mock loadFeature
const mockLoadFeature = (svc: AutoModeService, mockFn: ReturnType<typeof vi.fn>) => {
(svc as any).loadFeature = mockFn;
};
it('should call updateFeatureStatus with interrupted status for non-pipeline features', async () => {
const loadMock = vi.fn().mockResolvedValue({ id: 'feature-123', status: 'in_progress' });
const updateMock = vi.fn().mockResolvedValue(undefined);
mockLoadFeature(service, loadMock);
mockUpdateFeatureStatus(service, updateMock);
await service.markFeatureInterrupted('/test/project', 'feature-123');
expect(updateMock).toHaveBeenCalledWith('/test/project', 'feature-123', 'interrupted');
});
it('should call updateFeatureStatus with reason when provided', async () => {
const loadMock = vi.fn().mockResolvedValue({ id: 'feature-123', status: 'in_progress' });
const updateMock = vi.fn().mockResolvedValue(undefined);
mockLoadFeature(service, loadMock);
mockUpdateFeatureStatus(service, updateMock);
await service.markFeatureInterrupted('/test/project', 'feature-123', 'server shutdown');
expect(updateMock).toHaveBeenCalledWith('/test/project', 'feature-123', 'interrupted');
});
it('should propagate errors from updateFeatureStatus', async () => {
const loadMock = vi.fn().mockResolvedValue({ id: 'feature-123', status: 'in_progress' });
const updateMock = vi.fn().mockRejectedValue(new Error('Update failed'));
mockLoadFeature(service, loadMock);
mockUpdateFeatureStatus(service, updateMock);
await expect(service.markFeatureInterrupted('/test/project', 'feature-123')).rejects.toThrow(
'Update failed'
);
});
it('should preserve pipeline_implementation status instead of marking as interrupted', async () => {
const loadMock = vi
.fn()
.mockResolvedValue({ id: 'feature-123', status: 'pipeline_implementation' });
const updateMock = vi.fn().mockResolvedValue(undefined);
mockLoadFeature(service, loadMock);
mockUpdateFeatureStatus(service, updateMock);
await service.markFeatureInterrupted('/test/project', 'feature-123', 'server shutdown');
// updateFeatureStatus should NOT be called for pipeline statuses
expect(updateMock).not.toHaveBeenCalled();
});
it('should preserve pipeline_testing status instead of marking as interrupted', async () => {
const loadMock = vi.fn().mockResolvedValue({ id: 'feature-123', status: 'pipeline_testing' });
const updateMock = vi.fn().mockResolvedValue(undefined);
mockLoadFeature(service, loadMock);
mockUpdateFeatureStatus(service, updateMock);
await service.markFeatureInterrupted('/test/project', 'feature-123');
expect(updateMock).not.toHaveBeenCalled();
});
it('should preserve pipeline_review status instead of marking as interrupted', async () => {
const loadMock = vi.fn().mockResolvedValue({ id: 'feature-123', status: 'pipeline_review' });
const updateMock = vi.fn().mockResolvedValue(undefined);
mockLoadFeature(service, loadMock);
mockUpdateFeatureStatus(service, updateMock);
await service.markFeatureInterrupted('/test/project', 'feature-123');
expect(updateMock).not.toHaveBeenCalled();
});
it('should mark feature as interrupted when loadFeature returns null', async () => {
const loadMock = vi.fn().mockResolvedValue(null);
const updateMock = vi.fn().mockResolvedValue(undefined);
mockLoadFeature(service, loadMock);
mockUpdateFeatureStatus(service, updateMock);
await service.markFeatureInterrupted('/test/project', 'feature-123');
expect(updateMock).toHaveBeenCalledWith('/test/project', 'feature-123', 'interrupted');
});
it('should mark feature as interrupted for pending status', async () => {
const loadMock = vi.fn().mockResolvedValue({ id: 'feature-123', status: 'pending' });
const updateMock = vi.fn().mockResolvedValue(undefined);
mockLoadFeature(service, loadMock);
mockUpdateFeatureStatus(service, updateMock);
await service.markFeatureInterrupted('/test/project', 'feature-123');
expect(updateMock).toHaveBeenCalledWith('/test/project', 'feature-123', 'interrupted');
});
});
describe('markAllRunningFeaturesInterrupted', () => {
// Helper to access private runningFeatures Map
const getRunningFeaturesMap = (svc: AutoModeService) =>
(svc as any).runningFeatures as Map<
string,
{ featureId: string; projectPath: string; isAutoMode: boolean }
>;
// Helper to mock updateFeatureStatus
const mockUpdateFeatureStatus = (svc: AutoModeService, mockFn: ReturnType<typeof vi.fn>) => {
(svc as any).updateFeatureStatus = mockFn;
};
// Helper to mock loadFeature
const mockLoadFeature = (svc: AutoModeService, mockFn: ReturnType<typeof vi.fn>) => {
(svc as any).loadFeature = mockFn;
};
it('should do nothing when no features are running', async () => {
const updateMock = vi.fn().mockResolvedValue(undefined);
mockUpdateFeatureStatus(service, updateMock);
await service.markAllRunningFeaturesInterrupted();
expect(updateMock).not.toHaveBeenCalled();
});
it('should mark a single running feature as interrupted', async () => {
const runningFeaturesMap = getRunningFeaturesMap(service);
runningFeaturesMap.set('feature-1', {
featureId: 'feature-1',
projectPath: '/project/path',
isAutoMode: true,
});
const loadMock = vi.fn().mockResolvedValue({ id: 'feature-1', status: 'in_progress' });
const updateMock = vi.fn().mockResolvedValue(undefined);
mockLoadFeature(service, loadMock);
mockUpdateFeatureStatus(service, updateMock);
await service.markAllRunningFeaturesInterrupted();
expect(updateMock).toHaveBeenCalledWith('/project/path', 'feature-1', 'interrupted');
});
it('should mark multiple running features as interrupted', async () => {
const runningFeaturesMap = getRunningFeaturesMap(service);
runningFeaturesMap.set('feature-1', {
featureId: 'feature-1',
projectPath: '/project-a',
isAutoMode: true,
});
runningFeaturesMap.set('feature-2', {
featureId: 'feature-2',
projectPath: '/project-b',
isAutoMode: false,
});
runningFeaturesMap.set('feature-3', {
featureId: 'feature-3',
projectPath: '/project-a',
isAutoMode: true,
});
const loadMock = vi.fn().mockResolvedValue({ status: 'in_progress' });
const updateMock = vi.fn().mockResolvedValue(undefined);
mockLoadFeature(service, loadMock);
mockUpdateFeatureStatus(service, updateMock);
await service.markAllRunningFeaturesInterrupted();
expect(updateMock).toHaveBeenCalledTimes(3);
expect(updateMock).toHaveBeenCalledWith('/project-a', 'feature-1', 'interrupted');
expect(updateMock).toHaveBeenCalledWith('/project-b', 'feature-2', 'interrupted');
expect(updateMock).toHaveBeenCalledWith('/project-a', 'feature-3', 'interrupted');
});
it('should mark features in parallel', async () => {
const runningFeaturesMap = getRunningFeaturesMap(service);
for (let i = 1; i <= 5; i++) {
runningFeaturesMap.set(`feature-${i}`, {
featureId: `feature-${i}`,
projectPath: `/project-${i}`,
isAutoMode: true,
});
}
const loadMock = vi.fn().mockResolvedValue({ status: 'in_progress' });
const callOrder: string[] = [];
const updateMock = vi.fn().mockImplementation(async (_path: string, featureId: string) => {
callOrder.push(featureId);
await new Promise((resolve) => setTimeout(resolve, 10));
});
mockLoadFeature(service, loadMock);
mockUpdateFeatureStatus(service, updateMock);
const startTime = Date.now();
await service.markAllRunningFeaturesInterrupted();
const duration = Date.now() - startTime;
expect(updateMock).toHaveBeenCalledTimes(5);
// If executed in parallel, total time should be ~10ms
// If sequential, it would be ~50ms (5 * 10ms)
expect(duration).toBeLessThan(40);
});
it('should continue marking other features when one fails', async () => {
const runningFeaturesMap = getRunningFeaturesMap(service);
runningFeaturesMap.set('feature-1', {
featureId: 'feature-1',
projectPath: '/project-a',
isAutoMode: true,
});
runningFeaturesMap.set('feature-2', {
featureId: 'feature-2',
projectPath: '/project-b',
isAutoMode: false,
});
const loadMock = vi.fn().mockResolvedValue({ status: 'in_progress' });
const updateMock = vi
.fn()
.mockResolvedValueOnce(undefined)
.mockRejectedValueOnce(new Error('Failed to update'));
mockLoadFeature(service, loadMock);
mockUpdateFeatureStatus(service, updateMock);
// Should not throw even though one feature failed
await expect(service.markAllRunningFeaturesInterrupted()).resolves.not.toThrow();
expect(updateMock).toHaveBeenCalledTimes(2);
});
it('should use provided reason in logging', async () => {
const runningFeaturesMap = getRunningFeaturesMap(service);
runningFeaturesMap.set('feature-1', {
featureId: 'feature-1',
projectPath: '/project/path',
isAutoMode: true,
});
const loadMock = vi.fn().mockResolvedValue({ id: 'feature-1', status: 'in_progress' });
const updateMock = vi.fn().mockResolvedValue(undefined);
mockLoadFeature(service, loadMock);
mockUpdateFeatureStatus(service, updateMock);
await service.markAllRunningFeaturesInterrupted('manual stop');
expect(updateMock).toHaveBeenCalledWith('/project/path', 'feature-1', 'interrupted');
});
it('should use default reason when none provided', async () => {
const runningFeaturesMap = getRunningFeaturesMap(service);
runningFeaturesMap.set('feature-1', {
featureId: 'feature-1',
projectPath: '/project/path',
isAutoMode: true,
});
const loadMock = vi.fn().mockResolvedValue({ id: 'feature-1', status: 'in_progress' });
const updateMock = vi.fn().mockResolvedValue(undefined);
mockLoadFeature(service, loadMock);
mockUpdateFeatureStatus(service, updateMock);
await service.markAllRunningFeaturesInterrupted();
expect(updateMock).toHaveBeenCalledWith('/project/path', 'feature-1', 'interrupted');
});
it('should preserve pipeline statuses for running features', async () => {
const runningFeaturesMap = getRunningFeaturesMap(service);
runningFeaturesMap.set('feature-1', {
featureId: 'feature-1',
projectPath: '/project-a',
isAutoMode: true,
});
runningFeaturesMap.set('feature-2', {
featureId: 'feature-2',
projectPath: '/project-b',
isAutoMode: false,
});
runningFeaturesMap.set('feature-3', {
featureId: 'feature-3',
projectPath: '/project-c',
isAutoMode: true,
});
// feature-1 has in_progress (should be interrupted)
// feature-2 has pipeline_testing (should be preserved)
// feature-3 has pipeline_implementation (should be preserved)
const loadMock = vi
.fn()
.mockImplementation(async (_projectPath: string, featureId: string) => {
if (featureId === 'feature-1') return { id: 'feature-1', status: 'in_progress' };
if (featureId === 'feature-2') return { id: 'feature-2', status: 'pipeline_testing' };
if (featureId === 'feature-3')
return { id: 'feature-3', status: 'pipeline_implementation' };
return null;
});
const updateMock = vi.fn().mockResolvedValue(undefined);
mockLoadFeature(service, loadMock);
mockUpdateFeatureStatus(service, updateMock);
await service.markAllRunningFeaturesInterrupted();
// Only feature-1 should be marked as interrupted
expect(updateMock).toHaveBeenCalledTimes(1);
expect(updateMock).toHaveBeenCalledWith('/project-a', 'feature-1', 'interrupted');
});
});
describe('isFeatureRunning', () => {
// Helper to access private runningFeatures Map
const getRunningFeaturesMap = (svc: AutoModeService) =>
(svc as any).runningFeatures as Map<
string,
{ featureId: string; projectPath: string; isAutoMode: boolean }
>;
it('should return false when no features are running', () => {
expect(service.isFeatureRunning('feature-123')).toBe(false);
});
it('should return true when the feature is running', () => {
const runningFeaturesMap = getRunningFeaturesMap(service);
runningFeaturesMap.set('feature-123', {
featureId: 'feature-123',
projectPath: '/project/path',
isAutoMode: true,
});
expect(service.isFeatureRunning('feature-123')).toBe(true);
});
it('should return false for non-running feature when others are running', () => {
const runningFeaturesMap = getRunningFeaturesMap(service);
runningFeaturesMap.set('feature-other', {
featureId: 'feature-other',
projectPath: '/project/path',
isAutoMode: true,
});
expect(service.isFeatureRunning('feature-123')).toBe(false);
});
it('should correctly track multiple running features', () => {
const runningFeaturesMap = getRunningFeaturesMap(service);
runningFeaturesMap.set('feature-1', {
featureId: 'feature-1',
projectPath: '/project-a',
isAutoMode: true,
});
runningFeaturesMap.set('feature-2', {
featureId: 'feature-2',
projectPath: '/project-b',
isAutoMode: false,
});
expect(service.isFeatureRunning('feature-1')).toBe(true);
expect(service.isFeatureRunning('feature-2')).toBe(true);
expect(service.isFeatureRunning('feature-3')).toBe(false);
});
});
}); });

View File

@@ -1,11 +1,18 @@
import { describe, it, expect } from 'vitest'; import { describe, it, expect } from 'vitest';
import type { ParsedTask } from '@automaker/types';
/** /**
* Test the task parsing logic by reimplementing the parsing functions * Test the task parsing logic by reimplementing the parsing functions
* These mirror the logic in auto-mode-service.ts parseTasksFromSpec and parseTaskLine * These mirror the logic in auto-mode-service.ts parseTasksFromSpec and parseTaskLine
*/ */
interface ParsedTask {
id: string;
description: string;
filePath?: string;
phase?: string;
status: 'pending' | 'in_progress' | 'completed';
}
function parseTaskLine(line: string, currentPhase?: string): ParsedTask | null { function parseTaskLine(line: string, currentPhase?: string): ParsedTask | null {
// Match pattern: - [ ] T###: Description | File: path // Match pattern: - [ ] T###: Description | File: path
const taskMatch = line.match(/- \[ \] (T\d{3}):\s*([^|]+)(?:\|\s*File:\s*(.+))?$/); const taskMatch = line.match(/- \[ \] (T\d{3}):\s*([^|]+)(?:\|\s*File:\s*(.+))?$/);
@@ -335,236 +342,4 @@ Some other text
expect(fullModeOutput).toContain('[SPEC_GENERATED]'); expect(fullModeOutput).toContain('[SPEC_GENERATED]');
}); });
}); });
describe('detectSpecFallback - non-Claude model support', () => {
/**
* Reimplementation of detectSpecFallback for testing
* This mirrors the logic in auto-mode-service.ts for detecting specs
* when the [SPEC_GENERATED] marker is missing (common with non-Claude models)
*/
function detectSpecFallback(text: string): boolean {
// Check for key structural elements of a spec
const hasTasksBlock = /```tasks[\s\S]*```/.test(text);
const hasTaskLines = /- \[ \] T\d{3}:/.test(text);
// Check for common spec sections (case-insensitive)
const hasAcceptanceCriteria = /acceptance criteria/i.test(text);
const hasTechnicalContext = /technical context/i.test(text);
const hasProblemStatement = /problem statement/i.test(text);
const hasUserStory = /user story/i.test(text);
// Additional patterns for different model outputs
const hasGoal = /\*\*Goal\*\*:/i.test(text);
const hasSolution = /\*\*Solution\*\*:/i.test(text);
const hasImplementation = /implementation\s*(plan|steps|approach)/i.test(text);
const hasOverview = /##\s*(overview|summary)/i.test(text);
// Spec is detected if we have task structure AND at least some spec content
const hasTaskStructure = hasTasksBlock || hasTaskLines;
const hasSpecContent =
hasAcceptanceCriteria ||
hasTechnicalContext ||
hasProblemStatement ||
hasUserStory ||
hasGoal ||
hasSolution ||
hasImplementation ||
hasOverview;
return hasTaskStructure && hasSpecContent;
}
it('should detect spec with tasks block and acceptance criteria', () => {
const content = `
## Acceptance Criteria
- GIVEN a user, WHEN they login, THEN they see the dashboard
\`\`\`tasks
- [ ] T001: Create login form | File: src/Login.tsx
\`\`\`
`;
expect(detectSpecFallback(content)).toBe(true);
});
it('should detect spec with task lines and problem statement', () => {
const content = `
## Problem Statement
Users cannot currently log in to the application.
## Implementation Plan
- [ ] T001: Add authentication endpoint
- [ ] T002: Create login UI
`;
expect(detectSpecFallback(content)).toBe(true);
});
it('should detect spec with Goal section (lite planning mode style)', () => {
const content = `
**Goal**: Implement user authentication
**Solution**: Use JWT tokens for session management
- [ ] T001: Setup auth middleware
- [ ] T002: Create token service
`;
expect(detectSpecFallback(content)).toBe(true);
});
it('should detect spec with User Story format', () => {
const content = `
## User Story
As a user, I want to reset my password, so that I can regain access.
## Technical Context
This will modify the auth module.
\`\`\`tasks
- [ ] T001: Add reset endpoint
\`\`\`
`;
expect(detectSpecFallback(content)).toBe(true);
});
it('should detect spec with Overview section', () => {
const content = `
## Overview
This feature adds dark mode support.
\`\`\`tasks
- [ ] T001: Add theme toggle
- [ ] T002: Update CSS variables
\`\`\`
`;
expect(detectSpecFallback(content)).toBe(true);
});
it('should detect spec with Summary section', () => {
const content = `
## Summary
Adding a new dashboard component.
- [ ] T001: Create dashboard layout
- [ ] T002: Add widgets
`;
expect(detectSpecFallback(content)).toBe(true);
});
it('should detect spec with implementation plan', () => {
const content = `
## Implementation Plan
We will add the feature in two phases.
- [ ] T001: Phase 1 setup
- [ ] T002: Phase 2 implementation
`;
expect(detectSpecFallback(content)).toBe(true);
});
it('should detect spec with implementation steps', () => {
const content = `
## Implementation Steps
Follow these steps:
- [ ] T001: Step one
- [ ] T002: Step two
`;
expect(detectSpecFallback(content)).toBe(true);
});
it('should detect spec with implementation approach', () => {
const content = `
## Implementation Approach
We will use a modular approach.
- [ ] T001: Create modules
`;
expect(detectSpecFallback(content)).toBe(true);
});
it('should NOT detect spec without task structure', () => {
const content = `
## Problem Statement
Users cannot log in.
## Acceptance Criteria
- GIVEN a user, WHEN they try to login, THEN it works
`;
expect(detectSpecFallback(content)).toBe(false);
});
it('should NOT detect spec without spec content sections', () => {
const content = `
Here are some tasks:
- [ ] T001: Do something
- [ ] T002: Do another thing
`;
expect(detectSpecFallback(content)).toBe(false);
});
it('should NOT detect random text as spec', () => {
const content = 'Just some random text without any structure';
expect(detectSpecFallback(content)).toBe(false);
});
it('should handle case-insensitive matching for spec sections', () => {
const content = `
## ACCEPTANCE CRITERIA
All caps section header
- [ ] T001: Task
`;
expect(detectSpecFallback(content)).toBe(true);
const content2 = `
## acceptance criteria
Lower case section header
- [ ] T001: Task
`;
expect(detectSpecFallback(content2)).toBe(true);
});
it('should detect OpenAI-style output without explicit marker', () => {
// Non-Claude models may format specs differently but still have the key elements
const openAIStyleOutput = `
# Feature Specification: User Authentication
**Goal**: Allow users to securely log into the application
**Solution**: Implement JWT-based authentication with refresh tokens
## Acceptance Criteria
1. Users can log in with email and password
2. Invalid credentials show error message
3. Sessions persist across page refreshes
## Implementation Tasks
\`\`\`tasks
- [ ] T001: Create auth service | File: src/services/auth.ts
- [ ] T002: Build login component | File: src/components/Login.tsx
- [ ] T003: Add protected routes | File: src/App.tsx
\`\`\`
`;
expect(detectSpecFallback(openAIStyleOutput)).toBe(true);
});
it('should detect Gemini-style output without explicit marker', () => {
const geminiStyleOutput = `
## Overview
This specification describes the implementation of a user profile page.
## Technical Context
- Framework: React
- State: Redux
## Tasks
- [ ] T001: Create ProfilePage component
- [ ] T002: Add profile API endpoint
- [ ] T003: Style the profile page
`;
expect(detectSpecFallback(geminiStyleOutput)).toBe(true);
});
});
}); });

View File

@@ -30,16 +30,11 @@ import net from 'net';
describe('dev-server-service.ts', () => { describe('dev-server-service.ts', () => {
let testDir: string; let testDir: string;
let originalHostname: string | undefined;
beforeEach(async () => { beforeEach(async () => {
vi.clearAllMocks(); vi.clearAllMocks();
vi.resetModules(); vi.resetModules();
// Store and set HOSTNAME for consistent test behavior
originalHostname = process.env.HOSTNAME;
process.env.HOSTNAME = 'localhost';
testDir = path.join(os.tmpdir(), `dev-server-test-${Date.now()}`); testDir = path.join(os.tmpdir(), `dev-server-test-${Date.now()}`);
await fs.mkdir(testDir, { recursive: true }); await fs.mkdir(testDir, { recursive: true });
@@ -61,13 +56,6 @@ describe('dev-server-service.ts', () => {
}); });
afterEach(async () => { afterEach(async () => {
// Restore original HOSTNAME
if (originalHostname === undefined) {
delete process.env.HOSTNAME;
} else {
process.env.HOSTNAME = originalHostname;
}
try { try {
await fs.rm(testDir, { recursive: true, force: true }); await fs.rm(testDir, { recursive: true, force: true });
} catch { } catch {

View File

@@ -15,7 +15,7 @@ import type {
} from '@automaker/types'; } from '@automaker/types';
import { ProviderFactory } from '@/providers/provider-factory.js'; import { ProviderFactory } from '@/providers/provider-factory.js';
// Create shared mock instances for assertions using vi.hoisted // Create a shared mock logger instance for assertions using vi.hoisted
const mockLogger = vi.hoisted(() => ({ const mockLogger = vi.hoisted(() => ({
info: vi.fn(), info: vi.fn(),
error: vi.fn(), error: vi.fn(),
@@ -23,13 +23,6 @@ const mockLogger = vi.hoisted(() => ({
debug: vi.fn(), debug: vi.fn(),
})); }));
const mockCreateChatOptions = vi.hoisted(() =>
vi.fn(() => ({
model: 'claude-sonnet-4-20250514',
systemPrompt: 'test prompt',
}))
);
// Mock dependencies // Mock dependencies
vi.mock('@/lib/secure-fs.js'); vi.mock('@/lib/secure-fs.js');
vi.mock('@automaker/platform'); vi.mock('@automaker/platform');
@@ -44,7 +37,10 @@ vi.mock('@automaker/utils', async () => {
}); });
vi.mock('@/providers/provider-factory.js'); vi.mock('@/providers/provider-factory.js');
vi.mock('@/lib/sdk-options.js', () => ({ vi.mock('@/lib/sdk-options.js', () => ({
createChatOptions: mockCreateChatOptions, createChatOptions: vi.fn(() => ({
model: 'claude-sonnet-4-20250514',
systemPrompt: 'test prompt',
})),
validateWorkingDirectory: vi.fn(), validateWorkingDirectory: vi.fn(),
})); }));
@@ -790,143 +786,6 @@ describe('IdeationService', () => {
service.generateSuggestions(testProjectPath, 'non-existent', 'features', 5) service.generateSuggestions(testProjectPath, 'non-existent', 'features', 5)
).rejects.toThrow('Prompt non-existent not found'); ).rejects.toThrow('Prompt non-existent not found');
}); });
it('should include app spec context when useAppSpec is enabled', async () => {
const mockAppSpec = `
<project_specification>
<project_name>Test Project</project_name>
<overview>A test application for unit testing</overview>
<core_capabilities>
<capability>User authentication</capability>
<capability>Data visualization</capability>
</core_capabilities>
<implemented_features>
<feature>
<name>Login System</name>
<description>Basic auth with email/password</description>
</feature>
</implemented_features>
</project_specification>
`;
vi.mocked(platform.getAppSpecPath).mockReturnValue('/test/project/.automaker/app_spec.txt');
// First call returns app spec, subsequent calls return empty JSON
vi.mocked(secureFs.readFile)
.mockResolvedValueOnce(mockAppSpec)
.mockResolvedValue(JSON.stringify({}));
const mockProvider = {
executeQuery: vi.fn().mockReturnValue({
async *[Symbol.asyncIterator]() {
yield {
type: 'result',
subtype: 'success',
result: JSON.stringify([{ title: 'Test', description: 'Test' }]),
};
},
}),
};
vi.mocked(ProviderFactory.getProviderForModel).mockReturnValue(mockProvider as any);
const prompts = service.getAllPrompts();
await service.generateSuggestions(testProjectPath, prompts[0].id, 'feature', 5, {
useAppSpec: true,
useContextFiles: false,
useMemoryFiles: false,
useExistingFeatures: false,
useExistingIdeas: false,
});
// Verify createChatOptions was called with systemPrompt containing app spec info
expect(mockCreateChatOptions).toHaveBeenCalled();
const chatOptionsCall = mockCreateChatOptions.mock.calls[0][0];
expect(chatOptionsCall.systemPrompt).toContain('Test Project');
expect(chatOptionsCall.systemPrompt).toContain('A test application for unit testing');
expect(chatOptionsCall.systemPrompt).toContain('User authentication');
expect(chatOptionsCall.systemPrompt).toContain('Login System');
});
it('should exclude app spec context when useAppSpec is disabled', async () => {
const mockAppSpec = `
<project_specification>
<project_name>Hidden Project</project_name>
<overview>This should not appear</overview>
</project_specification>
`;
vi.mocked(platform.getAppSpecPath).mockReturnValue('/test/project/.automaker/app_spec.txt');
vi.mocked(secureFs.readFile).mockResolvedValue(mockAppSpec);
const mockProvider = {
executeQuery: vi.fn().mockReturnValue({
async *[Symbol.asyncIterator]() {
yield {
type: 'result',
subtype: 'success',
result: JSON.stringify([{ title: 'Test', description: 'Test' }]),
};
},
}),
};
vi.mocked(ProviderFactory.getProviderForModel).mockReturnValue(mockProvider as any);
const prompts = service.getAllPrompts();
await service.generateSuggestions(testProjectPath, prompts[0].id, 'feature', 5, {
useAppSpec: false,
useContextFiles: false,
useMemoryFiles: false,
useExistingFeatures: false,
useExistingIdeas: false,
});
// Verify createChatOptions was called with systemPrompt NOT containing app spec info
expect(mockCreateChatOptions).toHaveBeenCalled();
const chatOptionsCall = mockCreateChatOptions.mock.calls[0][0];
expect(chatOptionsCall.systemPrompt).not.toContain('Hidden Project');
expect(chatOptionsCall.systemPrompt).not.toContain('This should not appear');
});
it('should handle missing app spec file gracefully', async () => {
vi.mocked(platform.getAppSpecPath).mockReturnValue('/test/project/.automaker/app_spec.txt');
const enoentError = new Error('ENOENT: no such file or directory') as NodeJS.ErrnoException;
enoentError.code = 'ENOENT';
// First call fails with ENOENT for app spec, subsequent calls return empty JSON
vi.mocked(secureFs.readFile)
.mockRejectedValueOnce(enoentError)
.mockResolvedValue(JSON.stringify({}));
const mockProvider = {
executeQuery: vi.fn().mockReturnValue({
async *[Symbol.asyncIterator]() {
yield {
type: 'result',
subtype: 'success',
result: JSON.stringify([{ title: 'Test', description: 'Test' }]),
};
},
}),
};
vi.mocked(ProviderFactory.getProviderForModel).mockReturnValue(mockProvider as any);
const prompts = service.getAllPrompts();
// Should not throw
await expect(
service.generateSuggestions(testProjectPath, prompts[0].id, 'feature', 5, {
useAppSpec: true,
useContextFiles: false,
useMemoryFiles: false,
useExistingFeatures: false,
useExistingIdeas: false,
})
).resolves.toBeDefined();
// Should not log warning for ENOENT
expect(mockLogger.warn).not.toHaveBeenCalled();
});
}); });
}); });
}); });

View File

@@ -14,13 +14,8 @@ const eslintConfig = defineConfig([
require: 'readonly', require: 'readonly',
__dirname: 'readonly', __dirname: 'readonly',
__filename: 'readonly', __filename: 'readonly',
setTimeout: 'readonly',
clearTimeout: 'readonly',
}, },
}, },
rules: {
'no-unused-vars': ['warn', { argsIgnorePattern: '^_', caughtErrorsIgnorePattern: '^_' }],
},
}, },
{ {
files: ['**/*.ts', '**/*.tsx'], files: ['**/*.ts', '**/*.tsx'],
@@ -50,8 +45,6 @@ const eslintConfig = defineConfig([
confirm: 'readonly', confirm: 'readonly',
getComputedStyle: 'readonly', getComputedStyle: 'readonly',
requestAnimationFrame: 'readonly', requestAnimationFrame: 'readonly',
cancelAnimationFrame: 'readonly',
alert: 'readonly',
// DOM Element Types // DOM Element Types
HTMLElement: 'readonly', HTMLElement: 'readonly',
HTMLInputElement: 'readonly', HTMLInputElement: 'readonly',
@@ -63,8 +56,6 @@ const eslintConfig = defineConfig([
HTMLParagraphElement: 'readonly', HTMLParagraphElement: 'readonly',
HTMLImageElement: 'readonly', HTMLImageElement: 'readonly',
Element: 'readonly', Element: 'readonly',
SVGElement: 'readonly',
SVGSVGElement: 'readonly',
// Event Types // Event Types
Event: 'readonly', Event: 'readonly',
KeyboardEvent: 'readonly', KeyboardEvent: 'readonly',
@@ -73,24 +64,14 @@ const eslintConfig = defineConfig([
CustomEvent: 'readonly', CustomEvent: 'readonly',
ClipboardEvent: 'readonly', ClipboardEvent: 'readonly',
WheelEvent: 'readonly', WheelEvent: 'readonly',
MouseEvent: 'readonly',
UIEvent: 'readonly',
MediaQueryListEvent: 'readonly',
DataTransfer: 'readonly', DataTransfer: 'readonly',
// Web APIs // Web APIs
ResizeObserver: 'readonly', ResizeObserver: 'readonly',
AbortSignal: 'readonly', AbortSignal: 'readonly',
AbortController: 'readonly',
IntersectionObserver: 'readonly',
Audio: 'readonly', Audio: 'readonly',
HTMLAudioElement: 'readonly',
ScrollBehavior: 'readonly', ScrollBehavior: 'readonly',
URL: 'readonly', URL: 'readonly',
URLSearchParams: 'readonly', URLSearchParams: 'readonly',
XMLHttpRequest: 'readonly',
Response: 'readonly',
RequestInit: 'readonly',
RequestCache: 'readonly',
// Timers // Timers
setTimeout: 'readonly', setTimeout: 'readonly',
setInterval: 'readonly', setInterval: 'readonly',
@@ -109,8 +90,6 @@ const eslintConfig = defineConfig([
Electron: 'readonly', Electron: 'readonly',
// Console // Console
console: 'readonly', console: 'readonly',
// Vite defines
__APP_VERSION__: 'readonly',
}, },
}, },
plugins: { plugins: {
@@ -120,13 +99,6 @@ const eslintConfig = defineConfig([
...ts.configs.recommended.rules, ...ts.configs.recommended.rules,
'@typescript-eslint/no-unused-vars': ['warn', { argsIgnorePattern: '^_' }], '@typescript-eslint/no-unused-vars': ['warn', { argsIgnorePattern: '^_' }],
'@typescript-eslint/no-explicit-any': 'warn', '@typescript-eslint/no-explicit-any': 'warn',
'@typescript-eslint/ban-ts-comment': [
'error',
{
'ts-nocheck': 'allow-with-description',
minimumDescriptionLength: 10,
},
],
}, },
}, },
globalIgnores([ globalIgnores([

View File

@@ -107,7 +107,6 @@
"sonner": "2.0.7", "sonner": "2.0.7",
"tailwind-merge": "3.4.0", "tailwind-merge": "3.4.0",
"usehooks-ts": "3.1.1", "usehooks-ts": "3.1.1",
"zod": "^3.24.1 || ^4.0.0",
"zustand": "5.0.9" "zustand": "5.0.9"
}, },
"optionalDependencies": { "optionalDependencies": {
@@ -170,10 +169,6 @@
"from": "server-bundle/node_modules", "from": "server-bundle/node_modules",
"to": "server/node_modules" "to": "server/node_modules"
}, },
{
"from": "server-bundle/libs",
"to": "server/libs"
},
{ {
"from": "server-bundle/package.json", "from": "server-bundle/package.json",
"to": "server/package.json" "to": "server/package.json"

View File

@@ -29,7 +29,7 @@ async function killProcessOnPort(port) {
try { try {
await execAsync(`kill -9 ${pid}`); await execAsync(`kill -9 ${pid}`);
console.log(`[KillTestServers] Killed process ${pid}`); console.log(`[KillTestServers] Killed process ${pid}`);
} catch (_error) { } catch (error) {
// Process might have already exited // Process might have already exited
} }
} }
@@ -47,7 +47,7 @@ async function killProcessOnPort(port) {
await new Promise((resolve) => setTimeout(resolve, 500)); await new Promise((resolve) => setTimeout(resolve, 500));
return; return;
} }
} catch (_error) { } catch (error) {
// No process on port, which is fine // No process on port, which is fine
} }
} }

View File

@@ -7,8 +7,8 @@
*/ */
import { execSync } from 'child_process'; import { execSync } from 'child_process';
import { cpSync, existsSync, mkdirSync, rmSync, writeFileSync, readFileSync, lstatSync } from 'fs'; import { cpSync, existsSync, mkdirSync, rmSync, writeFileSync, readFileSync } from 'fs';
import { join, dirname, resolve } from 'path'; import { join, dirname } from 'path';
import { fileURLToPath } from 'url'; import { fileURLToPath } from 'url';
const __filename = fileURLToPath(import.meta.url); const __filename = fileURLToPath(import.meta.url);
@@ -112,29 +112,6 @@ execSync('npm install --omit=dev', {
}, },
}); });
// Step 6b: Replace symlinks for local packages with real copies
// npm install creates symlinks for file: references, but these break when packaged by electron-builder
console.log('🔗 Replacing symlinks with real directory copies...');
const nodeModulesAutomaker = join(BUNDLE_DIR, 'node_modules', '@automaker');
for (const pkgName of LOCAL_PACKAGES) {
const pkgDir = pkgName.replace('@automaker/', '');
const nmPkgPath = join(nodeModulesAutomaker, pkgDir);
try {
// lstatSync does not follow symlinks, allowing us to check for broken ones
if (lstatSync(nmPkgPath).isSymbolicLink()) {
const realPath = resolve(BUNDLE_DIR, 'libs', pkgDir);
rmSync(nmPkgPath);
cpSync(realPath, nmPkgPath, { recursive: true });
console.log(` ✓ Replaced symlink: ${pkgName}`);
}
} catch (error) {
// If the path doesn't exist, lstatSync throws ENOENT. We can safely ignore this.
if (error.code !== 'ENOENT') {
throw error;
}
}
}
// Step 7: Rebuild native modules for current architecture // Step 7: Rebuild native modules for current architecture
// This is critical for modules like node-pty that have native bindings // This is critical for modules like node-pty that have native bindings
console.log('🔨 Rebuilding native modules for current architecture...'); console.log('🔨 Rebuilding native modules for current architecture...');

View File

@@ -6,26 +6,14 @@ import { SplashScreen } from './components/splash-screen';
import { useSettingsSync } from './hooks/use-settings-sync'; import { useSettingsSync } from './hooks/use-settings-sync';
import { useCursorStatusInit } from './hooks/use-cursor-status-init'; import { useCursorStatusInit } from './hooks/use-cursor-status-init';
import { useProviderAuthInit } from './hooks/use-provider-auth-init'; import { useProviderAuthInit } from './hooks/use-provider-auth-init';
import { useAppStore } from './store/app-store';
import { TooltipProvider } from '@/components/ui/tooltip';
import './styles/global.css'; import './styles/global.css';
import './styles/theme-imports'; import './styles/theme-imports';
import './styles/font-imports'; import './styles/font-imports';
const logger = createLogger('App'); const logger = createLogger('App');
// Key for localStorage to persist splash screen preference
const DISABLE_SPLASH_KEY = 'automaker-disable-splash';
export default function App() { export default function App() {
const disableSplashScreen = useAppStore((state) => state.disableSplashScreen);
const [showSplash, setShowSplash] = useState(() => { const [showSplash, setShowSplash] = useState(() => {
// Check localStorage for user preference (available synchronously)
const savedPreference = localStorage.getItem(DISABLE_SPLASH_KEY);
if (savedPreference === 'true') {
return false;
}
// Only show splash once per session // Only show splash once per session
if (sessionStorage.getItem('automaker-splash-shown')) { if (sessionStorage.getItem('automaker-splash-shown')) {
return false; return false;
@@ -33,11 +21,6 @@ export default function App() {
return true; return true;
}); });
// Sync the disableSplashScreen setting to localStorage for fast access on next startup
useEffect(() => {
localStorage.setItem(DISABLE_SPLASH_KEY, String(disableSplashScreen));
}, [disableSplashScreen]);
// Clear accumulated PerformanceMeasure entries to prevent memory leak in dev mode // Clear accumulated PerformanceMeasure entries to prevent memory leak in dev mode
// React's internal scheduler creates performance marks/measures that accumulate without cleanup // React's internal scheduler creates performance marks/measures that accumulate without cleanup
useEffect(() => { useEffect(() => {
@@ -76,9 +59,9 @@ export default function App() {
}, []); }, []);
return ( return (
<TooltipProvider delayDuration={300}> <>
<RouterProvider router={router} /> <RouterProvider router={router} />
{showSplash && !disableSplashScreen && <SplashScreen onComplete={handleSplashComplete} />} {showSplash && <SplashScreen onComplete={handleSplashComplete} />}
</TooltipProvider> </>
); );
} }

View File

@@ -68,6 +68,7 @@ export function CodexUsagePopover() {
// Use React Query for data fetching with automatic polling // Use React Query for data fetching with automatic polling
const { const {
data: codexUsage, data: codexUsage,
isLoading,
isFetching, isFetching,
error: queryError, error: queryError,
dataUpdatedAt, dataUpdatedAt,

View File

@@ -40,6 +40,8 @@ interface FileBrowserDialogProps {
initialPath?: string; initialPath?: string;
} }
const MAX_RECENT_FOLDERS = 5;
export function FileBrowserDialog({ export function FileBrowserDialog({
open, open,
onOpenChange, onOpenChange,

View File

@@ -191,7 +191,7 @@ export function NewProjectModal({
// Use platform-specific path separator // Use platform-specific path separator
const pathSep = const pathSep =
typeof window !== 'undefined' && window.electronAPI typeof window !== 'undefined' && (window as any).electronAPI
? navigator.platform.indexOf('Win') !== -1 ? navigator.platform.indexOf('Win') !== -1
? '\\' ? '\\'
: '/' : '/'

View File

@@ -15,7 +15,6 @@ import { getAuthenticatedImageUrl } from '@/lib/api-fetch';
import { getHttpApiClient } from '@/lib/http-api-client'; import { getHttpApiClient } from '@/lib/http-api-client';
import type { Project } from '@/lib/electron'; import type { Project } from '@/lib/electron';
import { IconPicker } from './icon-picker'; import { IconPicker } from './icon-picker';
import { toast } from 'sonner';
interface EditProjectDialogProps { interface EditProjectDialogProps {
project: Project; project: Project;
@@ -26,9 +25,9 @@ interface EditProjectDialogProps {
export function EditProjectDialog({ project, open, onOpenChange }: EditProjectDialogProps) { export function EditProjectDialog({ project, open, onOpenChange }: EditProjectDialogProps) {
const { setProjectName, setProjectIcon, setProjectCustomIcon } = useAppStore(); const { setProjectName, setProjectIcon, setProjectCustomIcon } = useAppStore();
const [name, setName] = useState(project.name); const [name, setName] = useState(project.name);
const [icon, setIcon] = useState<string | null>(project.icon || null); const [icon, setIcon] = useState<string | null>((project as any).icon || null);
const [customIconPath, setCustomIconPath] = useState<string | null>( const [customIconPath, setCustomIconPath] = useState<string | null>(
project.customIconPath || null (project as any).customIconPath || null
); );
const [isUploadingIcon, setIsUploadingIcon] = useState(false); const [isUploadingIcon, setIsUploadingIcon] = useState(false);
const fileInputRef = useRef<HTMLInputElement>(null); const fileInputRef = useRef<HTMLInputElement>(null);
@@ -37,10 +36,10 @@ export function EditProjectDialog({ project, open, onOpenChange }: EditProjectDi
if (name.trim() !== project.name) { if (name.trim() !== project.name) {
setProjectName(project.id, name.trim()); setProjectName(project.id, name.trim());
} }
if (icon !== project.icon) { if (icon !== (project as any).icon) {
setProjectIcon(project.id, icon); setProjectIcon(project.id, icon);
} }
if (customIconPath !== project.customIconPath) { if (customIconPath !== (project as any).customIconPath) {
setProjectCustomIcon(project.id, customIconPath); setProjectCustomIcon(project.id, customIconPath);
} }
onOpenChange(false); onOpenChange(false);
@@ -53,18 +52,11 @@ export function EditProjectDialog({ project, open, onOpenChange }: EditProjectDi
// Validate file type // Validate file type
const validTypes = ['image/jpeg', 'image/png', 'image/gif', 'image/webp']; const validTypes = ['image/jpeg', 'image/png', 'image/gif', 'image/webp'];
if (!validTypes.includes(file.type)) { if (!validTypes.includes(file.type)) {
toast.error(
`Invalid file type: ${file.type || 'unknown'}. Please use JPG, PNG, GIF or WebP.`
);
return; return;
} }
// Validate file size (max 5MB for icons - allows animated GIFs) // Validate file size (max 2MB for icons)
const maxSize = 5 * 1024 * 1024; if (file.size > 2 * 1024 * 1024) {
if (file.size > maxSize) {
toast.error(
`File too large (${(file.size / 1024 / 1024).toFixed(2)} MB). Maximum size is 5 MB.`
);
return; return;
} }
@@ -80,24 +72,15 @@ export function EditProjectDialog({ project, open, onOpenChange }: EditProjectDi
file.type, file.type,
project.path project.path
); );
if (result.success && result.path) { if (result.success && result.path) {
setCustomIconPath(result.path); setCustomIconPath(result.path);
// Clear the Lucide icon when custom icon is set // Clear the Lucide icon when custom icon is set
setIcon(null); setIcon(null);
toast.success('Icon uploaded successfully');
} else {
toast.error('Failed to upload icon');
} }
setIsUploadingIcon(false); setIsUploadingIcon(false);
}; };
reader.onerror = () => {
toast.error('Failed to read file');
setIsUploadingIcon(false);
};
reader.readAsDataURL(file); reader.readAsDataURL(file);
} catch { } catch {
toast.error('Failed to upload icon');
setIsUploadingIcon(false); setIsUploadingIcon(false);
} }
}; };
@@ -179,7 +162,7 @@ export function EditProjectDialog({ project, open, onOpenChange }: EditProjectDi
{isUploadingIcon ? 'Uploading...' : 'Upload Custom Icon'} {isUploadingIcon ? 'Uploading...' : 'Upload Custom Icon'}
</Button> </Button>
<p className="text-xs text-muted-foreground mt-1"> <p className="text-xs text-muted-foreground mt-1">
PNG, JPG, GIF or WebP. Max 5MB. PNG, JPG, GIF or WebP. Max 2MB.
</p> </p>
</div> </div>
</div> </div>

View File

@@ -3,7 +3,7 @@
*/ */
import { useCallback } from 'react'; import { useCallback } from 'react';
import { Bell, Check, Trash2 } from 'lucide-react'; import { Bell, Check, Trash2, ExternalLink } from 'lucide-react';
import { useNavigate } from '@tanstack/react-router'; import { useNavigate } from '@tanstack/react-router';
import { useNotificationsStore } from '@/store/notifications-store'; import { useNotificationsStore } from '@/store/notifications-store';
import { useLoadNotifications, useNotificationEvents } from '@/hooks/use-notification-events'; import { useLoadNotifications, useNotificationEvents } from '@/hooks/use-notification-events';

View File

@@ -59,7 +59,7 @@ interface ThemeButtonProps {
/** Handler for pointer leave events (used to clear preview) */ /** Handler for pointer leave events (used to clear preview) */
onPointerLeave: (e: React.PointerEvent) => void; onPointerLeave: (e: React.PointerEvent) => void;
/** Handler for click events (used to select theme) */ /** Handler for click events (used to select theme) */
onClick: (e: React.MouseEvent) => void; onClick: () => void;
} }
/** /**
@@ -77,7 +77,6 @@ const ThemeButton = memo(function ThemeButton({
const Icon = option.icon; const Icon = option.icon;
return ( return (
<button <button
type="button"
onPointerEnter={onPointerEnter} onPointerEnter={onPointerEnter}
onPointerLeave={onPointerLeave} onPointerLeave={onPointerLeave}
onClick={onClick} onClick={onClick}
@@ -146,10 +145,7 @@ const ThemeColumn = memo(function ThemeColumn({
isSelected={selectedTheme === option.value} isSelected={selectedTheme === option.value}
onPointerEnter={() => onPreviewEnter(option.value)} onPointerEnter={() => onPreviewEnter(option.value)}
onPointerLeave={onPreviewLeave} onPointerLeave={onPreviewLeave}
onClick={(e) => { onClick={() => onSelect(option.value)}
e.stopPropagation();
onSelect(option.value);
}}
/> />
))} ))}
</div> </div>
@@ -197,11 +193,13 @@ export function ProjectContextMenu({
const { const {
moveProjectToTrash, moveProjectToTrash,
theme: globalTheme, theme: globalTheme,
setTheme,
setProjectTheme, setProjectTheme,
setPreviewTheme, setPreviewTheme,
} = useAppStore(); } = useAppStore();
const [showRemoveDialog, setShowRemoveDialog] = useState(false); const [showRemoveDialog, setShowRemoveDialog] = useState(false);
const [showThemeSubmenu, setShowThemeSubmenu] = useState(false); const [showThemeSubmenu, setShowThemeSubmenu] = useState(false);
const [removeConfirmed, setRemoveConfirmed] = useState(false);
const themeSubmenuRef = useRef<HTMLDivElement>(null); const themeSubmenuRef = useRef<HTMLDivElement>(null);
const closeTimeoutRef = useRef<ReturnType<typeof setTimeout> | null>(null); const closeTimeoutRef = useRef<ReturnType<typeof setTimeout> | null>(null);
@@ -319,24 +317,13 @@ export function ProjectContextMenu({
const handleThemeSelect = useCallback( const handleThemeSelect = useCallback(
(value: ThemeMode | typeof USE_GLOBAL_THEME) => { (value: ThemeMode | typeof USE_GLOBAL_THEME) => {
// Clear any pending close timeout to prevent race conditions
if (closeTimeoutRef.current) {
clearTimeout(closeTimeoutRef.current);
closeTimeoutRef.current = null;
}
// Close menu first
setShowThemeSubmenu(false);
onClose();
// Then apply theme changes
setPreviewTheme(null); setPreviewTheme(null);
const isUsingGlobal = value === USE_GLOBAL_THEME; const isUsingGlobal = value === USE_GLOBAL_THEME;
// Only set project theme - don't change global theme setTheme(isUsingGlobal ? globalTheme : value);
// The UI uses getEffectiveTheme() which handles: previewTheme ?? projectTheme ?? globalTheme
setProjectTheme(project.id, isUsingGlobal ? null : value); setProjectTheme(project.id, isUsingGlobal ? null : value);
setShowThemeSubmenu(false);
}, },
[onClose, project.id, setPreviewTheme, setProjectTheme] [globalTheme, project.id, setPreviewTheme, setProjectTheme, setTheme]
); );
const handleConfirmRemove = useCallback(() => { const handleConfirmRemove = useCallback(() => {
@@ -344,6 +331,7 @@ export function ProjectContextMenu({
toast.success('Project removed', { toast.success('Project removed', {
description: `${project.name} has been removed from your projects list`, description: `${project.name} has been removed from your projects list`,
}); });
setRemoveConfirmed(true);
}, [moveProjectToTrash, project.id, project.name]); }, [moveProjectToTrash, project.id, project.name]);
const handleDialogClose = useCallback( const handleDialogClose = useCallback(
@@ -352,6 +340,8 @@ export function ProjectContextMenu({
// Close the context menu when dialog closes (whether confirmed or cancelled) // Close the context menu when dialog closes (whether confirmed or cancelled)
// This prevents the context menu from reappearing after dialog interaction // This prevents the context menu from reappearing after dialog interaction
if (!isOpen) { if (!isOpen) {
// Reset confirmation state
setRemoveConfirmed(false);
// Always close the context menu when dialog closes // Always close the context menu when dialog closes
onClose(); onClose();
} }
@@ -440,13 +430,9 @@ export function ProjectContextMenu({
<div className="p-2"> <div className="p-2">
{/* Use Global Option */} {/* Use Global Option */}
<button <button
type="button"
onPointerEnter={() => handlePreviewEnter(globalTheme)} onPointerEnter={() => handlePreviewEnter(globalTheme)}
onPointerLeave={handlePreviewLeave} onPointerLeave={handlePreviewLeave}
onClick={(e) => { onClick={() => handleThemeSelect(USE_GLOBAL_THEME)}
e.stopPropagation();
handleThemeSelect(USE_GLOBAL_THEME);
}}
className={cn( className={cn(
'w-full flex items-center gap-2 px-3 py-2 rounded-md', 'w-full flex items-center gap-2 px-3 py-2 rounded-md',
'text-sm font-medium text-left', 'text-sm font-medium text-left',

View File

@@ -1,4 +1,3 @@
import { useState } from 'react';
import { Folder, LucideIcon } from 'lucide-react'; import { Folder, LucideIcon } from 'lucide-react';
import * as LucideIcons from 'lucide-react'; import * as LucideIcons from 'lucide-react';
import { cn, sanitizeForTestId } from '@/lib/utils'; import { cn, sanitizeForTestId } from '@/lib/utils';
@@ -20,8 +19,6 @@ export function ProjectSwitcherItem({
onClick, onClick,
onContextMenu, onContextMenu,
}: ProjectSwitcherItemProps) { }: ProjectSwitcherItemProps) {
const [imageError, setImageError] = useState(false);
// Convert index to hotkey label: 0 -> "1", 1 -> "2", ..., 8 -> "9", 9 -> "0" // Convert index to hotkey label: 0 -> "1", 1 -> "2", ..., 8 -> "9", 9 -> "0"
const hotkeyLabel = const hotkeyLabel =
hotkeyIndex !== undefined && hotkeyIndex >= 0 && hotkeyIndex <= 9 hotkeyIndex !== undefined && hotkeyIndex >= 0 && hotkeyIndex <= 9
@@ -38,7 +35,7 @@ export function ProjectSwitcherItem({
}; };
const IconComponent = getIconComponent(); const IconComponent = getIconComponent();
const hasCustomIcon = !!project.customIconPath && !imageError; const hasCustomIcon = !!project.customIconPath;
// Combine project.id with sanitized name for uniqueness and readability // Combine project.id with sanitized name for uniqueness and readability
// Format: project-switcher-{id}-{sanitizedName} // Format: project-switcher-{id}-{sanitizedName}
@@ -77,7 +74,6 @@ export function ProjectSwitcherItem({
'w-8 h-8 rounded-lg object-cover transition-all duration-200', 'w-8 h-8 rounded-lg object-cover transition-all duration-200',
isActive ? 'ring-1 ring-brand-500/50' : 'group-hover:scale-110' isActive ? 'ring-1 ring-brand-500/50' : 'group-hover:scale-110'
)} )}
onError={() => setImageError(true)}
/> />
) : ( ) : (
<IconComponent <IconComponent

View File

@@ -1,7 +1,7 @@
import { useState, useCallback, useEffect } from 'react'; import { useState, useCallback, useEffect } from 'react';
import { Plus, Bug, FolderOpen, BookOpen } from 'lucide-react'; import { Plus, Bug, FolderOpen, BookOpen } from 'lucide-react';
import { useNavigate, useLocation } from '@tanstack/react-router'; import { useNavigate, useLocation } from '@tanstack/react-router';
import { cn, isMac } from '@/lib/utils'; import { cn } from '@/lib/utils';
import { useAppStore } from '@/store/app-store'; import { useAppStore } from '@/store/app-store';
import { useOSDetection } from '@/hooks/use-os-detection'; import { useOSDetection } from '@/hooks/use-os-detection';
import { ProjectSwitcherItem } from './components/project-switcher-item'; import { ProjectSwitcherItem } from './components/project-switcher-item';
@@ -11,12 +11,9 @@ import { NotificationBell } from './components/notification-bell';
import { NewProjectModal } from '@/components/dialogs/new-project-modal'; import { NewProjectModal } from '@/components/dialogs/new-project-modal';
import { OnboardingDialog } from '@/components/layout/sidebar/dialogs'; import { OnboardingDialog } from '@/components/layout/sidebar/dialogs';
import { useProjectCreation } from '@/components/layout/sidebar/hooks'; import { useProjectCreation } from '@/components/layout/sidebar/hooks';
import { import { SIDEBAR_FEATURE_FLAGS } from '@/components/layout/sidebar/constants';
MACOS_ELECTRON_TOP_PADDING_CLASS,
SIDEBAR_FEATURE_FLAGS,
} from '@/components/layout/sidebar/constants';
import type { Project } from '@/lib/electron'; import type { Project } from '@/lib/electron';
import { getElectronAPI, isElectron } from '@/lib/electron'; import { getElectronAPI } from '@/lib/electron';
import { initializeProject, hasAppSpec, hasAutomakerDir } from '@/lib/project-init'; import { initializeProject, hasAppSpec, hasAutomakerDir } from '@/lib/project-init';
import { toast } from 'sonner'; import { toast } from 'sonner';
import { CreateSpecDialog } from '@/components/views/spec-view/dialogs'; import { CreateSpecDialog } from '@/components/views/spec-view/dialogs';
@@ -282,12 +279,7 @@ export function ProjectSwitcher() {
data-testid="project-switcher" data-testid="project-switcher"
> >
{/* Automaker Logo and Version */} {/* Automaker Logo and Version */}
<div <div className="flex flex-col items-center pt-3 pb-2 px-2">
className={cn(
'flex flex-col items-center pb-2 px-2',
isMac && isElectron() ? MACOS_ELECTRON_TOP_PADDING_CLASS : 'pt-3'
)}
>
<button <button
onClick={() => navigate({ to: '/dashboard' })} onClick={() => navigate({ to: '/dashboard' })}
className="group flex flex-col items-center gap-0.5" className="group flex flex-col items-center gap-0.5"

View File

@@ -100,8 +100,14 @@ export function ProjectSelectorWithOptions({
const { sensors, handleDragEnd } = useDragAndDrop({ projects, reorderProjects }); const { sensors, handleDragEnd } = useDragAndDrop({ projects, reorderProjects });
const { globalTheme, setProjectTheme, setPreviewTheme, handlePreviewEnter, handlePreviewLeave } = const {
useProjectTheme(); globalTheme,
setTheme,
setProjectTheme,
setPreviewTheme,
handlePreviewEnter,
handlePreviewLeave,
} = useProjectTheme();
if (!sidebarOpen || projects.length === 0) { if (!sidebarOpen || projects.length === 0) {
return null; return null;
@@ -275,8 +281,11 @@ export function ProjectSelectorWithOptions({
onValueChange={(value) => { onValueChange={(value) => {
if (currentProject) { if (currentProject) {
setPreviewTheme(null); setPreviewTheme(null);
// Only set project theme - don't change global theme if (value !== '') {
// The UI uses getEffectiveTheme() which handles: previewTheme ?? projectTheme ?? globalTheme setTheme(value as ThemeMode);
} else {
setTheme(globalTheme);
}
setProjectTheme( setProjectTheme(
currentProject.id, currentProject.id,
value === '' ? null : (value as ThemeMode) value === '' ? null : (value as ThemeMode)

View File

@@ -5,7 +5,7 @@ import { formatShortcut } from '@/store/app-store';
import { Activity, Settings, BookOpen, MessageSquare, ExternalLink } from 'lucide-react'; import { Activity, Settings, BookOpen, MessageSquare, ExternalLink } from 'lucide-react';
import { useOSDetection } from '@/hooks/use-os-detection'; import { useOSDetection } from '@/hooks/use-os-detection';
import { getElectronAPI } from '@/lib/electron'; import { getElectronAPI } from '@/lib/electron';
import { Tooltip, TooltipContent, TooltipTrigger } from '@/components/ui/tooltip'; import { Tooltip, TooltipContent, TooltipProvider, TooltipTrigger } from '@/components/ui/tooltip';
function getOSAbbreviation(os: string): string { function getOSAbbreviation(os: string): string {
switch (os) { switch (os) {
@@ -72,6 +72,7 @@ export function SidebarFooter({
<div className="flex flex-col items-center py-2 px-2 gap-1"> <div className="flex flex-col items-center py-2 px-2 gap-1">
{/* Running Agents */} {/* Running Agents */}
{!hideRunningAgents && ( {!hideRunningAgents && (
<TooltipProvider delayDuration={0}>
<Tooltip> <Tooltip>
<TooltipTrigger asChild> <TooltipTrigger asChild>
<button <button
@@ -120,9 +121,11 @@ export function SidebarFooter({
)} )}
</TooltipContent> </TooltipContent>
</Tooltip> </Tooltip>
</TooltipProvider>
)} )}
{/* Settings */} {/* Settings */}
<TooltipProvider delayDuration={0}>
<Tooltip> <Tooltip>
<TooltipTrigger asChild> <TooltipTrigger asChild>
<button <button
@@ -144,7 +147,10 @@ export function SidebarFooter({
data-testid="settings-button" data-testid="settings-button"
> >
<Settings <Settings
className={cn('w-[18px] h-[18px]', isActiveRoute('settings') && 'text-brand-500')} className={cn(
'w-[18px] h-[18px]',
isActiveRoute('settings') && 'text-brand-500'
)}
/> />
</button> </button>
</TooltipTrigger> </TooltipTrigger>
@@ -155,9 +161,11 @@ export function SidebarFooter({
</span> </span>
</TooltipContent> </TooltipContent>
</Tooltip> </Tooltip>
</TooltipProvider>
{/* Documentation */} {/* Documentation */}
{!hideWiki && ( {!hideWiki && (
<TooltipProvider delayDuration={0}>
<Tooltip> <Tooltip>
<TooltipTrigger asChild> <TooltipTrigger asChild>
<button <button
@@ -177,9 +185,11 @@ export function SidebarFooter({
Documentation Documentation
</TooltipContent> </TooltipContent>
</Tooltip> </Tooltip>
</TooltipProvider>
)} )}
{/* Feedback */} {/* Feedback */}
<TooltipProvider delayDuration={0}>
<Tooltip> <Tooltip>
<TooltipTrigger asChild> <TooltipTrigger asChild>
<button <button
@@ -199,6 +209,7 @@ export function SidebarFooter({
Feedback Feedback
</TooltipContent> </TooltipContent>
</Tooltip> </Tooltip>
</TooltipProvider>
</div> </div>
</div> </div>
); );

View File

@@ -6,7 +6,6 @@ import type { LucideIcon } from 'lucide-react';
import { cn, isMac } from '@/lib/utils'; import { cn, isMac } from '@/lib/utils';
import { formatShortcut } from '@/store/app-store'; import { formatShortcut } from '@/store/app-store';
import { isElectron, type Project } from '@/lib/electron'; import { isElectron, type Project } from '@/lib/electron';
import { MACOS_ELECTRON_TOP_PADDING_CLASS } from '../constants';
import { getAuthenticatedImageUrl } from '@/lib/api-fetch'; import { getAuthenticatedImageUrl } from '@/lib/api-fetch';
import { useAppStore } from '@/store/app-store'; import { useAppStore } from '@/store/app-store';
import { import {
@@ -16,7 +15,7 @@ import {
DropdownMenuSeparator, DropdownMenuSeparator,
DropdownMenuTrigger, DropdownMenuTrigger,
} from '@/components/ui/dropdown-menu'; } from '@/components/ui/dropdown-menu';
import { Tooltip, TooltipContent, TooltipTrigger } from '@/components/ui/tooltip'; import { Tooltip, TooltipContent, TooltipProvider, TooltipTrigger } from '@/components/ui/tooltip';
interface SidebarHeaderProps { interface SidebarHeaderProps {
sidebarOpen: boolean; sidebarOpen: boolean;
@@ -90,9 +89,10 @@ export function SidebarHeader({
<div <div
className={cn( className={cn(
'shrink-0 flex flex-col items-center relative px-2 pt-3 pb-2', 'shrink-0 flex flex-col items-center relative px-2 pt-3 pb-2',
isMac && isElectron() && MACOS_ELECTRON_TOP_PADDING_CLASS isMac && isElectron() && 'pt-[10px]'
)} )}
> >
<TooltipProvider delayDuration={0}>
<Tooltip> <Tooltip>
<TooltipTrigger asChild> <TooltipTrigger asChild>
<button <button
@@ -139,12 +139,14 @@ export function SidebarHeader({
Go to Dashboard Go to Dashboard
</TooltipContent> </TooltipContent>
</Tooltip> </Tooltip>
</TooltipProvider>
{/* Collapsed project icon with dropdown */} {/* Collapsed project icon with dropdown */}
{currentProject && ( {currentProject && (
<> <>
<div className="w-full h-px bg-border/40 my-2" /> <div className="w-full h-px bg-border/40 my-2" />
<DropdownMenu open={dropdownOpen} onOpenChange={setDropdownOpen}> <DropdownMenu open={dropdownOpen} onOpenChange={setDropdownOpen}>
<TooltipProvider delayDuration={0}>
<Tooltip> <Tooltip>
<TooltipTrigger asChild> <TooltipTrigger asChild>
<DropdownMenuTrigger asChild> <DropdownMenuTrigger asChild>
@@ -161,6 +163,7 @@ export function SidebarHeader({
{currentProject.name} {currentProject.name}
</TooltipContent> </TooltipContent>
</Tooltip> </Tooltip>
</TooltipProvider>
<DropdownMenuContent <DropdownMenuContent
align="start" align="start"
side="right" side="right"
@@ -241,7 +244,7 @@ export function SidebarHeader({
<div <div
className={cn( className={cn(
'shrink-0 flex flex-col relative px-3 pt-3 pb-2', 'shrink-0 flex flex-col relative px-3 pt-3 pb-2',
isMac && isElectron() && MACOS_ELECTRON_TOP_PADDING_CLASS isMac && isElectron() && 'pt-[10px]'
)} )}
> >
{/* Header with logo and project dropdown */} {/* Header with logo and project dropdown */}

View File

@@ -1,16 +1,10 @@
import { useCallback, useEffect, useRef } from 'react'; import { useState, useCallback, useEffect, useRef } from 'react';
import type { NavigateOptions } from '@tanstack/react-router'; import type { NavigateOptions } from '@tanstack/react-router';
import { ChevronDown, Wrench, Github, Folder } from 'lucide-react'; import { ChevronDown, Wrench, Github } from 'lucide-react';
import * as LucideIcons from 'lucide-react'; import { cn } from '@/lib/utils';
import type { LucideIcon } from 'lucide-react'; import { formatShortcut } from '@/store/app-store';
import { cn, isMac } from '@/lib/utils';
import { isElectron } from '@/lib/electron';
import { MACOS_ELECTRON_TOP_PADDING_CLASS } from '../constants';
import { formatShortcut, useAppStore } from '@/store/app-store';
import { getAuthenticatedImageUrl } from '@/lib/api-fetch';
import type { NavSection } from '../types'; import type { NavSection } from '../types';
import type { Project } from '@/lib/electron'; import type { Project } from '@/lib/electron';
import type { SidebarStyle } from '@automaker/types';
import { Spinner } from '@/components/ui/spinner'; import { Spinner } from '@/components/ui/spinner';
import { import {
DropdownMenu, DropdownMenu,
@@ -18,7 +12,7 @@ import {
DropdownMenuItem, DropdownMenuItem,
DropdownMenuTrigger, DropdownMenuTrigger,
} from '@/components/ui/dropdown-menu'; } from '@/components/ui/dropdown-menu';
import { Tooltip, TooltipContent, TooltipTrigger } from '@/components/ui/tooltip'; import { Tooltip, TooltipContent, TooltipProvider, TooltipTrigger } from '@/components/ui/tooltip';
// Map section labels to icons // Map section labels to icons
const sectionIcons: Record<string, React.ComponentType<{ className?: string }>> = { const sectionIcons: Record<string, React.ComponentType<{ className?: string }>> = {
@@ -29,7 +23,6 @@ const sectionIcons: Record<string, React.ComponentType<{ className?: string }>>
interface SidebarNavigationProps { interface SidebarNavigationProps {
currentProject: Project | null; currentProject: Project | null;
sidebarOpen: boolean; sidebarOpen: boolean;
sidebarStyle: SidebarStyle;
navSections: NavSection[]; navSections: NavSection[];
isActiveRoute: (id: string) => boolean; isActiveRoute: (id: string) => boolean;
navigate: (opts: NavigateOptions) => void; navigate: (opts: NavigateOptions) => void;
@@ -39,7 +32,6 @@ interface SidebarNavigationProps {
export function SidebarNavigation({ export function SidebarNavigation({
currentProject, currentProject,
sidebarOpen, sidebarOpen,
sidebarStyle,
navSections, navSections,
isActiveRoute, isActiveRoute,
navigate, navigate,
@@ -47,26 +39,21 @@ export function SidebarNavigation({
}: SidebarNavigationProps) { }: SidebarNavigationProps) {
const navRef = useRef<HTMLElement>(null); const navRef = useRef<HTMLElement>(null);
// Get collapsed state from store (persisted across restarts) // Track collapsed state for each collapsible section
const { collapsedNavSections, setCollapsedNavSections, toggleNavSection } = useAppStore(); const [collapsedSections, setCollapsedSections] = useState<Record<string, boolean>>({});
// Initialize collapsed state when sections change (e.g., GitHub section appears) // Initialize collapsed state when sections change (e.g., GitHub section appears)
// Only set defaults for sections that don't have a persisted state
useEffect(() => { useEffect(() => {
let hasNewSections = false; setCollapsedSections((prev) => {
const updated = { ...collapsedNavSections }; const updated = { ...prev };
navSections.forEach((section) => { navSections.forEach((section) => {
if (section.collapsible && section.label && !(section.label in updated)) { if (section.collapsible && section.label && !(section.label in updated)) {
updated[section.label] = section.defaultCollapsed ?? false; updated[section.label] = section.defaultCollapsed ?? false;
hasNewSections = true;
} }
}); });
return updated;
if (hasNewSections) { });
setCollapsedNavSections(updated); }, [navSections]);
}
}, [navSections, collapsedNavSections, setCollapsedNavSections]);
// Check scroll state // Check scroll state
const checkScrollState = useCallback(() => { const checkScrollState = useCallback(() => {
@@ -90,7 +77,14 @@ export function SidebarNavigation({
nav.removeEventListener('scroll', checkScrollState); nav.removeEventListener('scroll', checkScrollState);
resizeObserver.disconnect(); resizeObserver.disconnect();
}; };
}, [checkScrollState, collapsedNavSections]); }, [checkScrollState, collapsedSections]);
const toggleSection = useCallback((label: string) => {
setCollapsedSections((prev) => ({
...prev,
[label]: !prev[label],
}));
}, []);
// Filter sections: always show non-project sections, only show project sections when project exists // Filter sections: always show non-project sections, only show project sections when project exists
const visibleSections = navSections.filter((section) => { const visibleSections = navSections.filter((section) => {
@@ -102,55 +96,11 @@ export function SidebarNavigation({
return !!currentProject; return !!currentProject;
}); });
// Get the icon component for the current project
const getProjectIcon = (): LucideIcon => {
if (currentProject?.icon && currentProject.icon in LucideIcons) {
return (LucideIcons as unknown as Record<string, LucideIcon>)[currentProject.icon];
}
return Folder;
};
const ProjectIcon = getProjectIcon();
const hasCustomIcon = !!currentProject?.customIconPath;
return ( return (
<nav <nav ref={navRef} className={cn('flex-1 overflow-y-auto scrollbar-hide px-3 pb-2 mt-1')}>
ref={navRef}
className={cn(
'flex-1 overflow-y-auto scrollbar-hide px-3 pb-2',
// Add top padding in discord mode since there's no header
// Extra padding for macOS Electron to avoid traffic light overlap
sidebarStyle === 'discord'
? isMac && isElectron()
? MACOS_ELECTRON_TOP_PADDING_CLASS
: 'pt-3'
: 'mt-1'
)}
>
{/* Project name display for classic/discord mode */}
{sidebarStyle === 'discord' && currentProject && sidebarOpen && (
<div className="mb-3">
<div className="flex items-center gap-2.5 px-3 py-2">
{hasCustomIcon ? (
<img
src={getAuthenticatedImageUrl(currentProject.customIconPath!, currentProject.path)}
alt={currentProject.name}
className="w-5 h-5 rounded object-cover"
/>
) : (
<ProjectIcon className="w-5 h-5 text-brand-500 shrink-0" />
)}
<span className="text-sm font-medium text-foreground truncate">
{currentProject.name}
</span>
</div>
<div className="h-px bg-border/40 mx-1 mt-1" />
</div>
)}
{/* Navigation sections */} {/* Navigation sections */}
{visibleSections.map((section, sectionIdx) => { {visibleSections.map((section, sectionIdx) => {
const isCollapsed = section.label ? collapsedNavSections[section.label] : false; const isCollapsed = section.label ? collapsedSections[section.label] : false;
const isCollapsible = section.collapsible && section.label && sidebarOpen; const isCollapsible = section.collapsible && section.label && sidebarOpen;
const SectionIcon = section.label ? sectionIcons[section.label] : null; const SectionIcon = section.label ? sectionIcons[section.label] : null;
@@ -160,37 +110,21 @@ export function SidebarNavigation({
{/* Section Label - clickable if collapsible (expanded sidebar) */} {/* Section Label - clickable if collapsible (expanded sidebar) */}
{section.label && sidebarOpen && ( {section.label && sidebarOpen && (
<button <button
onClick={() => isCollapsible && toggleNavSection(section.label!)} onClick={() => isCollapsible && toggleSection(section.label!)}
className={cn( className={cn(
'group flex items-center w-full px-3 py-1.5 mb-1 rounded-md', 'flex items-center w-full px-3 mb-1.5',
'transition-all duration-200 ease-out', isCollapsible && 'cursor-pointer hover:text-foreground'
isCollapsible
? [
'cursor-pointer',
'hover:bg-accent/50 hover:text-foreground',
'border border-transparent hover:border-border/40',
]
: 'cursor-default'
)} )}
disabled={!isCollapsible} disabled={!isCollapsible}
> >
<span <span className="text-[10px] font-semibold text-muted-foreground/70 uppercase tracking-widest">
className={cn(
'text-[10px] font-semibold uppercase tracking-widest transition-colors duration-200',
isCollapsible
? 'text-muted-foreground/70 group-hover:text-foreground'
: 'text-muted-foreground/70'
)}
>
{section.label} {section.label}
</span> </span>
{isCollapsible && ( {isCollapsible && (
<ChevronDown <ChevronDown
className={cn( className={cn(
'w-3 h-3 ml-auto transition-all duration-200', 'w-3 h-3 ml-auto text-muted-foreground/50 transition-transform duration-200',
isCollapsed isCollapsed && '-rotate-90'
? '-rotate-90 text-muted-foreground/50 group-hover:text-muted-foreground'
: 'text-muted-foreground/50 group-hover:text-muted-foreground'
)} )}
/> />
)} )}
@@ -200,6 +134,7 @@ export function SidebarNavigation({
{/* Section icon with dropdown (collapsed sidebar) */} {/* Section icon with dropdown (collapsed sidebar) */}
{section.label && !sidebarOpen && SectionIcon && section.collapsible && isCollapsed && ( {section.label && !sidebarOpen && SectionIcon && section.collapsible && isCollapsed && (
<DropdownMenu> <DropdownMenu>
<TooltipProvider delayDuration={0}>
<Tooltip> <Tooltip>
<TooltipTrigger asChild> <TooltipTrigger asChild>
<DropdownMenuTrigger asChild> <DropdownMenuTrigger asChild>
@@ -219,6 +154,7 @@ export function SidebarNavigation({
{section.label} {section.label}
</TooltipContent> </TooltipContent>
</Tooltip> </Tooltip>
</TooltipProvider>
<DropdownMenuContent side="right" align="start" sideOffset={8} className="w-48"> <DropdownMenuContent side="right" align="start" sideOffset={8} className="w-48">
{section.items.map((item) => { {section.items.map((item) => {
const ItemIcon = item.icon; const ItemIcon = item.icon;

View File

@@ -9,15 +9,19 @@ export const ThemeMenuItem = memo(function ThemeMenuItem({
}: ThemeMenuItemProps) { }: ThemeMenuItemProps) {
const Icon = option.icon; const Icon = option.icon;
return ( return (
<div
key={option.value}
onPointerEnter={() => onPreviewEnter(option.value)}
onPointerLeave={onPreviewLeave}
>
<DropdownMenuRadioItem <DropdownMenuRadioItem
value={option.value} value={option.value}
data-testid={`project-theme-${option.value}`} data-testid={`project-theme-${option.value}`}
className="text-xs py-1.5" className="text-xs py-1.5"
onPointerEnter={() => onPreviewEnter(option.value)}
onPointerLeave={onPreviewLeave}
> >
<Icon className="w-3.5 h-3.5 mr-1.5" style={{ color: option.color }} /> <Icon className="w-3.5 h-3.5 mr-1.5" style={{ color: option.color }} />
<span>{option.label}</span> <span>{option.label}</span>
</DropdownMenuRadioItem> </DropdownMenuRadioItem>
</div>
); );
}); });

View File

@@ -1,11 +1,5 @@
import { darkThemes, lightThemes } from '@/config/theme-options'; import { darkThemes, lightThemes } from '@/config/theme-options';
/**
* Tailwind class for top padding on macOS Electron to avoid overlapping with traffic light window controls.
* This padding is applied conditionally when running on macOS in Electron.
*/
export const MACOS_ELECTRON_TOP_PADDING_CLASS = 'pt-[38px]';
/** /**
* Shared constants for theme submenu positioning and layout. * Shared constants for theme submenu positioning and layout.
* Used across project-context-menu and project-selector-with-options components * Used across project-context-menu and project-selector-with-options components

View File

@@ -53,7 +53,6 @@ export function Sidebar() {
trashedProjects, trashedProjects,
currentProject, currentProject,
sidebarOpen, sidebarOpen,
sidebarStyle,
mobileSidebarHidden, mobileSidebarHidden,
projectHistory, projectHistory,
upsertAndSetCurrentProject, upsertAndSetCurrentProject,
@@ -382,8 +381,6 @@ export function Sidebar() {
)} )}
<div className="flex-1 flex flex-col overflow-hidden"> <div className="flex-1 flex flex-col overflow-hidden">
{/* Only show header in unified mode - in discord mode, ProjectSwitcher has the logo */}
{sidebarStyle === 'unified' && (
<SidebarHeader <SidebarHeader
sidebarOpen={sidebarOpen} sidebarOpen={sidebarOpen}
currentProject={currentProject} currentProject={currentProject}
@@ -391,12 +388,10 @@ export function Sidebar() {
onOpenFolder={handleOpenFolder} onOpenFolder={handleOpenFolder}
onProjectContextMenu={handleContextMenu} onProjectContextMenu={handleContextMenu}
/> />
)}
<SidebarNavigation <SidebarNavigation
currentProject={currentProject} currentProject={currentProject}
sidebarOpen={sidebarOpen} sidebarOpen={sidebarOpen}
sidebarStyle={sidebarStyle}
navSections={navSections} navSections={navSections}
isActiveRoute={isActiveRoute} isActiveRoute={isActiveRoute}
navigate={navigate} navigate={navigate}

View File

@@ -1,4 +1,8 @@
import * as React from 'react';
import { Settings2 } from 'lucide-react';
import { cn } from '@/lib/utils'; import { cn } from '@/lib/utils';
import { Button } from '@/components/ui/button';
import { Popover, PopoverContent, PopoverTrigger } from '@/components/ui/popover';
import { useAppStore } from '@/store/app-store'; import { useAppStore } from '@/store/app-store';
import type { ModelAlias, CursorModelId, PhaseModelKey, PhaseModelEntry } from '@automaker/types'; import type { ModelAlias, CursorModelId, PhaseModelKey, PhaseModelEntry } from '@automaker/types';
import { PhaseModelSelector } from '@/components/views/settings-view/model-defaults/phase-model-selector'; import { PhaseModelSelector } from '@/components/views/settings-view/model-defaults/phase-model-selector';
@@ -70,6 +74,12 @@ export function ModelOverrideTrigger({
lg: 'h-10 w-10', lg: 'h-10 w-10',
}; };
const iconSizes = {
sm: 'w-3.5 h-3.5',
md: 'w-4 h-4',
lg: 'w-5 h-5',
};
// For icon variant, wrap PhaseModelSelector and hide text/chevron with CSS // For icon variant, wrap PhaseModelSelector and hide text/chevron with CSS
if (variant === 'icon') { if (variant === 'icon') {
return ( return (

View File

@@ -37,6 +37,16 @@ function normalizeEntry(entry: PhaseModelEntry | string): PhaseModelEntry {
return entry; return entry;
} }
/**
* Extract model string from PhaseModelEntry or string
*/
function extractModel(entry: PhaseModelEntry | string): ModelId {
if (typeof entry === 'string') {
return entry as ModelId;
}
return entry.model;
}
/** /**
* Hook for managing model overrides per phase * Hook for managing model overrides per phase
* *

View File

@@ -3,7 +3,7 @@ import { Slot } from '@radix-ui/react-slot';
import { cva, type VariantProps } from 'class-variance-authority'; import { cva, type VariantProps } from 'class-variance-authority';
import { cn } from '@/lib/utils'; import { cn } from '@/lib/utils';
import { Spinner, type SpinnerVariant } from '@/components/ui/spinner'; import { Spinner } from '@/components/ui/spinner';
const buttonVariants = cva( const buttonVariants = cva(
"inline-flex items-center justify-center gap-2 whitespace-nowrap rounded-md text-sm font-medium transition-all duration-200 cursor-pointer disabled:pointer-events-none disabled:opacity-50 disabled:cursor-not-allowed [&_svg]:pointer-events-none [&_svg:not([class*='size-'])]:size-4 shrink-0 [&_svg]:shrink-0 outline-none focus-visible:border-ring focus-visible:ring-ring/50 focus-visible:ring-[3px] aria-invalid:ring-destructive/20 dark:aria-invalid:ring-destructive/40 aria-invalid:border-destructive active:scale-[0.98]", "inline-flex items-center justify-center gap-2 whitespace-nowrap rounded-md text-sm font-medium transition-all duration-200 cursor-pointer disabled:pointer-events-none disabled:opacity-50 disabled:cursor-not-allowed [&_svg]:pointer-events-none [&_svg:not([class*='size-'])]:size-4 shrink-0 [&_svg]:shrink-0 outline-none focus-visible:border-ring focus-visible:ring-ring/50 focus-visible:ring-[3px] aria-invalid:ring-destructive/20 dark:aria-invalid:ring-destructive/40 aria-invalid:border-destructive active:scale-[0.98]",
@@ -37,19 +37,9 @@ const buttonVariants = cva(
} }
); );
/** Button variants that have colored backgrounds requiring foreground spinner color */ // Loading spinner component
const COLORED_BACKGROUND_VARIANTS = new Set<string>(['default', 'destructive']); function ButtonSpinner({ className }: { className?: string }) {
return <Spinner size="sm" className={className} />;
/** Get spinner variant based on button variant - use foreground for colored backgrounds */
function getSpinnerVariant(
buttonVariant: VariantProps<typeof buttonVariants>['variant']
): SpinnerVariant {
const variant = buttonVariant ?? 'default';
if (COLORED_BACKGROUND_VARIANTS.has(variant)) {
return 'foreground';
}
// outline, secondary, ghost, link, animated-outline use standard backgrounds
return 'primary';
} }
function Button({ function Button({
@@ -67,7 +57,6 @@ function Button({
loading?: boolean; loading?: boolean;
}) { }) {
const isDisabled = disabled || loading; const isDisabled = disabled || loading;
const spinnerVariant = getSpinnerVariant(variant);
// Special handling for animated-outline variant // Special handling for animated-outline variant
if (variant === 'animated-outline' && !asChild) { if (variant === 'animated-outline' && !asChild) {
@@ -94,7 +83,7 @@ function Button({
size === 'icon' && 'p-0 gap-0' size === 'icon' && 'p-0 gap-0'
)} )}
> >
{loading && <Spinner size="sm" variant={spinnerVariant} />} {loading && <ButtonSpinner />}
{children} {children}
</span> </span>
</button> </button>
@@ -110,7 +99,7 @@ function Button({
disabled={isDisabled} disabled={isDisabled}
{...props} {...props}
> >
{loading && <Spinner size="sm" variant={spinnerVariant} />} {loading && <ButtonSpinner />}
{children} {children}
</Comp> </Comp>
); );

View File

@@ -1,3 +1,4 @@
import * as React from 'react';
import * as CollapsiblePrimitive from '@radix-ui/react-collapsible'; import * as CollapsiblePrimitive from '@radix-ui/react-collapsible';
const Collapsible = CollapsiblePrimitive.Root; const Collapsible = CollapsiblePrimitive.Root;

View File

@@ -479,7 +479,7 @@ export function GitDiffPanel({
<div className="flex flex-col items-center justify-center gap-2 py-8 text-muted-foreground"> <div className="flex flex-col items-center justify-center gap-2 py-8 text-muted-foreground">
<AlertCircle className="w-5 h-5 text-amber-500" /> <AlertCircle className="w-5 h-5 text-amber-500" />
<span className="text-sm">{error}</span> <span className="text-sm">{error}</span>
<Button variant="ghost" size="sm" onClick={() => void loadDiffs()} className="mt-2"> <Button variant="ghost" size="sm" onClick={loadDiffs} className="mt-2">
<RefreshCw className="w-4 h-4 mr-2" /> <RefreshCw className="w-4 h-4 mr-2" />
Retry Retry
</Button> </Button>
@@ -550,12 +550,7 @@ export function GitDiffPanel({
> >
Collapse All Collapse All
</Button> </Button>
<Button <Button variant="ghost" size="sm" onClick={loadDiffs} className="text-xs h-7">
variant="ghost"
size="sm"
onClick={() => void loadDiffs()}
className="text-xs h-7"
>
<RefreshCw className="w-3 h-3 mr-1" /> <RefreshCw className="w-3 h-3 mr-1" />
Refresh Refresh
</Button> </Button>

View File

@@ -7,7 +7,7 @@ import {
} from '@/store/app-store'; } from '@/store/app-store';
import type { KeyboardShortcuts } from '@/store/app-store'; import type { KeyboardShortcuts } from '@/store/app-store';
import { cn } from '@/lib/utils'; import { cn } from '@/lib/utils';
import { Tooltip, TooltipContent, TooltipTrigger } from '@/components/ui/tooltip'; import { Tooltip, TooltipContent, TooltipProvider, TooltipTrigger } from '@/components/ui/tooltip';
import { Input } from '@/components/ui/input'; import { Input } from '@/components/ui/input';
import { Button } from '@/components/ui/button'; import { Button } from '@/components/ui/button';
import { CheckCircle2, X, RotateCcw, Edit2 } from 'lucide-react'; import { CheckCircle2, X, RotateCcw, Edit2 } from 'lucide-react';
@@ -305,6 +305,7 @@ export function KeyboardMap({ onKeySelect, selectedKey, className }: KeyboardMap
}; };
return ( return (
<TooltipProvider>
<div className={cn('space-y-4', className)} data-testid="keyboard-map"> <div className={cn('space-y-4', className)} data-testid="keyboard-map">
{/* Legend */} {/* Legend */}
<div className="flex flex-wrap gap-4 justify-center text-xs"> <div className="flex flex-wrap gap-4 justify-center text-xs">
@@ -340,8 +341,8 @@ export function KeyboardMap({ onKeySelect, selectedKey, className }: KeyboardMap
shortcuts configured shortcuts configured
</span> </span>
<span> <span>
<strong className="text-foreground">{Object.keys(keyToShortcuts).length}</strong> keys in <strong className="text-foreground">{Object.keys(keyToShortcuts).length}</strong> keys
use in use
</span> </span>
<span> <span>
<strong className="text-foreground"> <strong className="text-foreground">
@@ -351,6 +352,7 @@ export function KeyboardMap({ onKeySelect, selectedKey, className }: KeyboardMap
</span> </span>
</div> </div>
</div> </div>
</TooltipProvider>
); );
} }
@@ -506,6 +508,7 @@ export function ShortcutReferencePanel({ editable = false }: ShortcutReferencePa
}; };
return ( return (
<TooltipProvider>
<div className="space-y-4" data-testid="shortcut-reference-panel"> <div className="space-y-4" data-testid="shortcut-reference-panel">
{editable && ( {editable && (
<div className="flex justify-end"> <div className="flex justify-end">
@@ -695,5 +698,6 @@ export function ShortcutReferencePanel({ editable = false }: ShortcutReferencePa
); );
})} })}
</div> </div>
</TooltipProvider>
); );
} }

View File

@@ -1,4 +1,4 @@
import { useState, useMemo, useRef } from 'react'; import { useState, useMemo, useEffect, useRef } from 'react';
import { import {
ChevronDown, ChevronDown,
ChevronRight, ChevronRight,
@@ -21,6 +21,7 @@ import {
X, X,
Filter, Filter,
Circle, Circle,
Play,
} from 'lucide-react'; } from 'lucide-react';
import { Spinner } from '@/components/ui/spinner'; import { Spinner } from '@/components/ui/spinner';
import { cn } from '@/lib/utils'; import { cn } from '@/lib/utils';

View File

@@ -116,8 +116,9 @@ const PROVIDER_ICON_DEFINITIONS: Record<ProviderIconKey, ProviderIconDefinition>
}, },
copilot: { copilot: {
viewBox: '0 0 98 96', viewBox: '0 0 98 96',
// Official GitHub Octocat logo mark (theme-aware via currentColor) // Official GitHub Octocat logo mark
path: 'M48.854 0C21.839 0 0 22 0 49.217c0 21.756 13.993 40.172 33.405 46.69 2.427.49 3.316-1.059 3.316-2.362 0-1.141-.08-5.052-.08-9.127-13.59 2.934-16.42-5.867-16.42-5.867-2.184-5.704-5.42-7.17-5.42-7.17-4.448-3.015.324-3.015.324-3.015 4.934.326 7.523 5.052 7.523 5.052 4.367 7.496 11.404 5.378 14.235 4.074.404-3.178 1.699-5.378 3.074-6.6-10.839-1.141-22.243-5.378-22.243-24.283 0-5.378 1.94-9.778 5.014-13.2-.485-1.222-2.184-6.275.486-13.038 0 0 4.125-1.304 13.426 5.052a46.97 46.97 0 0 1 12.214-1.63c4.125 0 8.33.571 12.213 1.63 9.302-6.356 13.427-5.052 13.427-5.052 2.67 6.763.97 11.816.485 13.038 3.155 3.422 5.015 7.822 5.015 13.2 0 18.905-11.404 23.06-22.324 24.283 1.78 1.548 3.316 4.481 3.316 9.126 0 6.6-.08 11.897-.08 13.526 0 1.304.89 2.853 3.316 2.364 19.412-6.52 33.405-24.935 33.405-46.691C97.707 22 75.788 0 48.854 0z', path: 'M48.854 0C21.839 0 0 22 0 49.217c0 21.756 13.993 40.172 33.405 46.69 2.427.49 3.316-1.059 3.316-2.362 0-1.141-.08-5.052-.08-9.127-13.59 2.934-16.42-5.867-16.42-5.867-2.184-5.704-5.42-7.17-5.42-7.17-4.448-3.015.324-3.015.324-3.015 4.934.326 7.523 5.052 7.523 5.052 4.367 7.496 11.404 5.378 14.235 4.074.404-3.178 1.699-5.378 3.074-6.6-10.839-1.141-22.243-5.378-22.243-24.283 0-5.378 1.94-9.778 5.014-13.2-.485-1.222-2.184-6.275.486-13.038 0 0 4.125-1.304 13.426 5.052a46.97 46.97 0 0 1 12.214-1.63c4.125 0 8.33.571 12.213 1.63 9.302-6.356 13.427-5.052 13.427-5.052 2.67 6.763.97 11.816.485 13.038 3.155 3.422 5.015 7.822 5.015 13.2 0 18.905-11.404 23.06-22.324 24.283 1.78 1.548 3.316 4.481 3.316 9.126 0 6.6-.08 11.897-.08 13.526 0 1.304.89 2.853 3.316 2.364 19.412-6.52 33.405-24.935 33.405-46.691C97.707 22 75.788 0 48.854 0z',
fill: '#ffffff',
}, },
}; };

View File

@@ -1,8 +1,7 @@
import { Loader2 } from 'lucide-react'; import { Loader2 } from 'lucide-react';
import { cn } from '@/lib/utils'; import { cn } from '@/lib/utils';
export type SpinnerSize = 'xs' | 'sm' | 'md' | 'lg' | 'xl'; type SpinnerSize = 'xs' | 'sm' | 'md' | 'lg' | 'xl';
export type SpinnerVariant = 'primary' | 'foreground' | 'muted';
const sizeClasses: Record<SpinnerSize, string> = { const sizeClasses: Record<SpinnerSize, string> = {
xs: 'h-3 w-3', xs: 'h-3 w-3',
@@ -12,17 +11,9 @@ const sizeClasses: Record<SpinnerSize, string> = {
xl: 'h-8 w-8', xl: 'h-8 w-8',
}; };
const variantClasses: Record<SpinnerVariant, string> = {
primary: 'text-primary',
foreground: 'text-primary-foreground',
muted: 'text-muted-foreground',
};
interface SpinnerProps { interface SpinnerProps {
/** Size of the spinner */ /** Size of the spinner */
size?: SpinnerSize; size?: SpinnerSize;
/** Color variant - use 'foreground' when on primary backgrounds */
variant?: SpinnerVariant;
/** Additional class names */ /** Additional class names */
className?: string; className?: string;
} }
@@ -30,12 +21,11 @@ interface SpinnerProps {
/** /**
* Themed spinner component using the primary brand color. * Themed spinner component using the primary brand color.
* Use this for all loading indicators throughout the app for consistency. * Use this for all loading indicators throughout the app for consistency.
* Use variant='foreground' when placing on primary-colored backgrounds.
*/ */
export function Spinner({ size = 'md', variant = 'primary', className }: SpinnerProps) { export function Spinner({ size = 'md', className }: SpinnerProps) {
return ( return (
<Loader2 <Loader2
className={cn(sizeClasses[size], 'animate-spin', variantClasses[variant], className)} className={cn(sizeClasses[size], 'animate-spin text-primary', className)}
aria-hidden="true" aria-hidden="true"
/> />
); );

View File

@@ -9,7 +9,6 @@ import { Check, Circle, ChevronDown, ChevronRight, FileCode } from 'lucide-react
import { Spinner } from '@/components/ui/spinner'; import { Spinner } from '@/components/ui/spinner';
import { getElectronAPI } from '@/lib/electron'; import { getElectronAPI } from '@/lib/electron';
import type { AutoModeEvent } from '@/types/electron'; import type { AutoModeEvent } from '@/types/electron';
import type { Feature, ParsedTask } from '@automaker/types';
import { Badge } from '@/components/ui/badge'; import { Badge } from '@/components/ui/badge';
interface TaskInfo { interface TaskInfo {
@@ -37,7 +36,7 @@ export function TaskProgressPanel({
const [tasks, setTasks] = useState<TaskInfo[]>([]); const [tasks, setTasks] = useState<TaskInfo[]>([]);
const [isExpanded, setIsExpanded] = useState(defaultExpanded); const [isExpanded, setIsExpanded] = useState(defaultExpanded);
const [isLoading, setIsLoading] = useState(true); const [isLoading, setIsLoading] = useState(true);
const [, setCurrentTaskId] = useState<string | null>(null); const [currentTaskId, setCurrentTaskId] = useState<string | null>(null);
// Load initial tasks from feature's planSpec // Load initial tasks from feature's planSpec
const loadInitialTasks = useCallback(async () => { const loadInitialTasks = useCallback(async () => {
@@ -54,17 +53,15 @@ export function TaskProgressPanel({
} }
const result = await api.features.get(projectPath, featureId); const result = await api.features.get(projectPath, featureId);
const feature = (result as { success: boolean; feature?: Feature }).feature; const feature: any = (result as any).feature;
if (result.success && feature?.planSpec?.tasks) { if (result.success && feature?.planSpec?.tasks) {
const planSpec = feature.planSpec; const planSpec = feature.planSpec as any;
const planTasks = planSpec.tasks; // Already guarded by the if condition above const planTasks = planSpec.tasks;
const currentId = planSpec.currentTaskId; const currentId = planSpec.currentTaskId;
const completedCount = planSpec.tasksCompleted || 0; const completedCount = planSpec.tasksCompleted || 0;
// Convert planSpec tasks to TaskInfo with proper status // Convert planSpec tasks to TaskInfo with proper status
// planTasks is guaranteed to be defined due to the if condition check const initialTasks: TaskInfo[] = planTasks.map((t: any, index: number) => ({
const initialTasks: TaskInfo[] = (planTasks as ParsedTask[]).map(
(t: ParsedTask, index: number) => ({
id: t.id, id: t.id,
description: t.description, description: t.description,
filePath: t.filePath, filePath: t.filePath,
@@ -75,8 +72,7 @@ export function TaskProgressPanel({
: t.id === currentId : t.id === currentId
? ('in_progress' as const) ? ('in_progress' as const)
: ('pending' as const), : ('pending' as const),
}) }));
);
setTasks(initialTasks); setTasks(initialTasks);
setCurrentTaskId(currentId || null); setCurrentTaskId(currentId || null);
@@ -240,7 +236,7 @@ export function TaskProgressPanel({
<div className="absolute left-[2.35rem] top-4 bottom-8 w-px bg-linear-to-b from-border/80 via-border/40 to-transparent" /> <div className="absolute left-[2.35rem] top-4 bottom-8 w-px bg-linear-to-b from-border/80 via-border/40 to-transparent" />
<div className="space-y-5"> <div className="space-y-5">
{tasks.map((task, _index) => { {tasks.map((task, index) => {
const isActive = task.status === 'in_progress'; const isActive = task.status === 'in_progress';
const isCompleted = task.status === 'completed'; const isCompleted = task.status === 'completed';
const isPending = task.status === 'pending'; const isPending = task.status === 'pending';
@@ -265,7 +261,7 @@ export function TaskProgressPanel({
)} )}
> >
{isCompleted && <Check className="h-3.5 w-3.5" />} {isCompleted && <Check className="h-3.5 w-3.5" />}
{isActive && <Spinner size="xs" variant="foreground" />} {isActive && <Spinner size="xs" />}
{isPending && <Circle className="h-2 w-2 fill-current opacity-50" />} {isPending && <Circle className="h-2 w-2 fill-current opacity-50" />}
</div> </div>

View File

@@ -25,6 +25,8 @@ type UsageError = {
message: string; message: string;
}; };
// Fixed refresh interval (45 seconds)
const REFRESH_INTERVAL_SECONDS = 45;
const CLAUDE_SESSION_WINDOW_HOURS = 5; const CLAUDE_SESSION_WINDOW_HOURS = 5;
// Helper to format reset time for Codex // Helper to format reset time for Codex
@@ -227,6 +229,15 @@ export function UsagePopover() {
// Calculate max percentage for header button // Calculate max percentage for header button
const claudeSessionPercentage = claudeUsage?.sessionPercentage || 0; const claudeSessionPercentage = claudeUsage?.sessionPercentage || 0;
const codexMaxPercentage = codexUsage?.rateLimits
? Math.max(
codexUsage.rateLimits.primary?.usedPercent || 0,
codexUsage.rateLimits.secondary?.usedPercent || 0
)
: 0;
const isStale = activeTab === 'claude' ? isClaudeStale : isCodexStale;
const getProgressBarColor = (percentage: number) => { const getProgressBarColor = (percentage: number) => {
if (percentage >= 80) return 'bg-red-500'; if (percentage >= 80) return 'bg-red-500';
if (percentage >= 50) return 'bg-yellow-500'; if (percentage >= 50) return 'bg-yellow-500';

View File

@@ -5,7 +5,17 @@ import { Card, CardContent, CardHeader, CardTitle, CardDescription } from '@/com
import { Button } from '@/components/ui/button'; import { Button } from '@/components/ui/button';
import { Input } from '@/components/ui/input'; import { Input } from '@/components/ui/input';
import { Label } from '@/components/ui/label'; import { Label } from '@/components/ui/label';
import { Terminal, CheckCircle, XCircle, Play, File, Pencil, Wrench } from 'lucide-react'; import {
FileText,
FolderOpen,
Terminal,
CheckCircle,
XCircle,
Play,
File,
Pencil,
Wrench,
} from 'lucide-react';
import { Spinner } from '@/components/ui/spinner'; import { Spinner } from '@/components/ui/spinner';
import { cn } from '@/lib/utils'; import { cn } from '@/lib/utils';
import { getElectronAPI } from '@/lib/electron'; import { getElectronAPI } from '@/lib/electron';
@@ -19,6 +29,13 @@ interface ToolResult {
timestamp: Date; timestamp: Date;
} }
interface ToolExecution {
tool: string;
input: string;
result: ToolResult | null;
isRunning: boolean;
}
export function AgentToolsView() { export function AgentToolsView() {
const { currentProject } = useAppStore(); const { currentProject } = useAppStore();
const api = getElectronAPI(); const api = getElectronAPI();

View File

@@ -63,6 +63,7 @@ export function AgentView() {
sendMessage, sendMessage,
clearHistory, clearHistory,
stopExecution, stopExecution,
error: agentError,
serverQueue, serverQueue,
addToServerQueue, addToServerQueue,
removeFromServerQueue, removeFromServerQueue,

View File

@@ -1,7 +1,7 @@
import { useCallback, useState } from 'react'; import { useCallback, useState } from 'react';
import { createLogger } from '@automaker/utils/logger'; import { createLogger } from '@automaker/utils/logger';
import { useQueryClient } from '@tanstack/react-query'; import { useQueryClient } from '@tanstack/react-query';
import { useAppStore, FileTreeNode, ProjectAnalysis, Feature } from '@/store/app-store'; import { useAppStore, FileTreeNode, ProjectAnalysis } from '@/store/app-store';
import { getElectronAPI } from '@/lib/electron'; import { getElectronAPI } from '@/lib/electron';
import { queryKeys } from '@/lib/query-keys'; import { queryKeys } from '@/lib/query-keys';
import { Card, CardContent, CardDescription, CardHeader, CardTitle } from '@/components/ui/card'; import { Card, CardContent, CardDescription, CardHeader, CardTitle } from '@/components/ui/card';
@@ -640,14 +640,14 @@ ${Object.entries(projectAnalysis.filesByExtension)
} }
for (const detectedFeature of detectedFeatures) { for (const detectedFeature of detectedFeatures) {
const newFeature: Feature = { await api.features.create(currentProject.path, {
id: generateUUID(), id: generateUUID(),
category: detectedFeature.category, category: detectedFeature.category,
description: detectedFeature.description, description: detectedFeature.description,
status: 'backlog', status: 'backlog',
// Initialize with empty steps so the object satisfies the Feature type
steps: [], steps: [],
}; } as any);
await api.features.create(currentProject.path, newFeature);
} }
// Invalidate React Query cache to sync UI // Invalidate React Query cache to sync UI

View File

@@ -1,6 +1,6 @@
import { useEffect, useState, useCallback, useMemo } from 'react'; // @ts-nocheck
import { useEffect, useState, useCallback, useMemo, useRef } from 'react';
import { createLogger } from '@automaker/utils/logger'; import { createLogger } from '@automaker/utils/logger';
import type { PointerEvent as ReactPointerEvent } from 'react';
import { import {
DndContext, DndContext,
PointerSensor, PointerSensor,
@@ -8,8 +8,7 @@ import {
useSensors, useSensors,
rectIntersection, rectIntersection,
pointerWithin, pointerWithin,
type CollisionDetection, type PointerEvent as DndPointerEvent,
type Collision,
} from '@dnd-kit/core'; } from '@dnd-kit/core';
// Custom pointer sensor that ignores drag events from within dialogs // Custom pointer sensor that ignores drag events from within dialogs
@@ -17,7 +16,7 @@ class DialogAwarePointerSensor extends PointerSensor {
static activators = [ static activators = [
{ {
eventName: 'onPointerDown' as const, eventName: 'onPointerDown' as const,
handler: ({ nativeEvent: event }: ReactPointerEvent) => { handler: ({ nativeEvent: event }: { nativeEvent: DndPointerEvent }) => {
// Don't start drag if the event originated from inside a dialog // Don't start drag if the event originated from inside a dialog
if ((event.target as Element)?.closest?.('[role="dialog"]')) { if ((event.target as Element)?.closest?.('[role="dialog"]')) {
return false; return false;
@@ -30,13 +29,16 @@ class DialogAwarePointerSensor extends PointerSensor {
import { useAppStore, Feature } from '@/store/app-store'; import { useAppStore, Feature } from '@/store/app-store';
import { getElectronAPI } from '@/lib/electron'; import { getElectronAPI } from '@/lib/electron';
import { getHttpApiClient } from '@/lib/http-api-client'; import { getHttpApiClient } from '@/lib/http-api-client';
import type { BacklogPlanResult, FeatureStatusWithPipeline } from '@automaker/types'; import type { AutoModeEvent } from '@/types/electron';
import type { ModelAlias, CursorModelId, BacklogPlanResult } from '@automaker/types';
import { pathsEqual } from '@/lib/utils'; import { pathsEqual } from '@/lib/utils';
import { toast } from 'sonner'; import { toast } from 'sonner';
import { getBlockingDependencies } from '@automaker/dependency-resolver';
import { BoardBackgroundModal } from '@/components/dialogs/board-background-modal'; import { BoardBackgroundModal } from '@/components/dialogs/board-background-modal';
import { Spinner } from '@/components/ui/spinner'; import { Spinner } from '@/components/ui/spinner';
import { useShallow } from 'zustand/react/shallow'; import { useShallow } from 'zustand/react/shallow';
import { useAutoMode } from '@/hooks/use-auto-mode'; import { useAutoMode } from '@/hooks/use-auto-mode';
import { useKeyboardShortcutsConfig } from '@/hooks/use-keyboard-shortcuts';
import { useWindowState } from '@/hooks/use-window-state'; import { useWindowState } from '@/hooks/use-window-state';
// Board-view specific imports // Board-view specific imports
import { BoardHeader } from './board-view/board-header'; import { BoardHeader } from './board-view/board-header';
@@ -95,6 +97,8 @@ const logger = createLogger('Board');
export function BoardView() { export function BoardView() {
const { const {
currentProject, currentProject,
maxConcurrency: legacyMaxConcurrency,
setMaxConcurrency: legacySetMaxConcurrency,
defaultSkipTests, defaultSkipTests,
specCreatingForProject, specCreatingForProject,
setSpecCreatingForProject, setSpecCreatingForProject,
@@ -105,6 +109,9 @@ export function BoardView() {
setCurrentWorktree, setCurrentWorktree,
getWorktrees, getWorktrees,
setWorktrees, setWorktrees,
useWorktrees,
enableDependencyBlocking,
skipVerificationInAutoMode,
planUseSelectedWorktreeBranch, planUseSelectedWorktreeBranch,
addFeatureUseSelectedWorktreeBranch, addFeatureUseSelectedWorktreeBranch,
isPrimaryWorktreeBranch, isPrimaryWorktreeBranch,
@@ -113,6 +120,8 @@ export function BoardView() {
} = useAppStore( } = useAppStore(
useShallow((state) => ({ useShallow((state) => ({
currentProject: state.currentProject, currentProject: state.currentProject,
maxConcurrency: state.maxConcurrency,
setMaxConcurrency: state.setMaxConcurrency,
defaultSkipTests: state.defaultSkipTests, defaultSkipTests: state.defaultSkipTests,
specCreatingForProject: state.specCreatingForProject, specCreatingForProject: state.specCreatingForProject,
setSpecCreatingForProject: state.setSpecCreatingForProject, setSpecCreatingForProject: state.setSpecCreatingForProject,
@@ -123,6 +132,9 @@ export function BoardView() {
setCurrentWorktree: state.setCurrentWorktree, setCurrentWorktree: state.setCurrentWorktree,
getWorktrees: state.getWorktrees, getWorktrees: state.getWorktrees,
setWorktrees: state.setWorktrees, setWorktrees: state.setWorktrees,
useWorktrees: state.useWorktrees,
enableDependencyBlocking: state.enableDependencyBlocking,
skipVerificationInAutoMode: state.skipVerificationInAutoMode,
planUseSelectedWorktreeBranch: state.planUseSelectedWorktreeBranch, planUseSelectedWorktreeBranch: state.planUseSelectedWorktreeBranch,
addFeatureUseSelectedWorktreeBranch: state.addFeatureUseSelectedWorktreeBranch, addFeatureUseSelectedWorktreeBranch: state.addFeatureUseSelectedWorktreeBranch,
isPrimaryWorktreeBranch: state.isPrimaryWorktreeBranch, isPrimaryWorktreeBranch: state.isPrimaryWorktreeBranch,
@@ -139,9 +151,12 @@ export function BoardView() {
// Subscribe to worktreePanelVisibleByProject to trigger re-renders when it changes // Subscribe to worktreePanelVisibleByProject to trigger re-renders when it changes
const worktreePanelVisibleByProject = useAppStore((state) => state.worktreePanelVisibleByProject); const worktreePanelVisibleByProject = useAppStore((state) => state.worktreePanelVisibleByProject);
// Subscribe to showInitScriptIndicatorByProject to trigger re-renders when it changes // Subscribe to showInitScriptIndicatorByProject to trigger re-renders when it changes
useAppStore((state) => state.showInitScriptIndicatorByProject); const showInitScriptIndicatorByProject = useAppStore(
(state) => state.showInitScriptIndicatorByProject
);
const getShowInitScriptIndicator = useAppStore((state) => state.getShowInitScriptIndicator); const getShowInitScriptIndicator = useAppStore((state) => state.getShowInitScriptIndicator);
const getDefaultDeleteBranch = useAppStore((state) => state.getDefaultDeleteBranch); const getDefaultDeleteBranch = useAppStore((state) => state.getDefaultDeleteBranch);
const shortcuts = useKeyboardShortcutsConfig();
const { const {
features: hookFeatures, features: hookFeatures,
isLoading, isLoading,
@@ -172,9 +187,13 @@ export function BoardView() {
const [showCreatePRDialog, setShowCreatePRDialog] = useState(false); const [showCreatePRDialog, setShowCreatePRDialog] = useState(false);
const [showCreateBranchDialog, setShowCreateBranchDialog] = useState(false); const [showCreateBranchDialog, setShowCreateBranchDialog] = useState(false);
const [showPullResolveConflictsDialog, setShowPullResolveConflictsDialog] = useState(false); const [showPullResolveConflictsDialog, setShowPullResolveConflictsDialog] = useState(false);
const [selectedWorktreeForAction, setSelectedWorktreeForAction] = useState<WorktreeInfo | null>( const [selectedWorktreeForAction, setSelectedWorktreeForAction] = useState<{
null path: string;
); branch: string;
isMain: boolean;
hasChanges?: boolean;
changedFilesCount?: number;
} | null>(null);
const [worktreeRefreshKey, setWorktreeRefreshKey] = useState(0); const [worktreeRefreshKey, setWorktreeRefreshKey] = useState(0);
// Backlog plan dialog state // Backlog plan dialog state
@@ -345,12 +364,12 @@ export function BoardView() {
}, [currentProject, worktreeRefreshKey]); }, [currentProject, worktreeRefreshKey]);
// Custom collision detection that prioritizes specific drop targets (cards, worktrees) over columns // Custom collision detection that prioritizes specific drop targets (cards, worktrees) over columns
const collisionDetectionStrategy = useCallback((args: Parameters<CollisionDetection>[0]) => { const collisionDetectionStrategy = useCallback((args: any) => {
const pointerCollisions = pointerWithin(args); const pointerCollisions = pointerWithin(args);
// Priority 1: Specific drop targets (cards for dependency links, worktrees) // Priority 1: Specific drop targets (cards for dependency links, worktrees)
// These need to be detected even if they are inside a column // These need to be detected even if they are inside a column
const specificTargetCollisions = pointerCollisions.filter((collision: Collision) => { const specificTargetCollisions = pointerCollisions.filter((collision: any) => {
const id = String(collision.id); const id = String(collision.id);
return id.startsWith('card-drop-') || id.startsWith('worktree-drop-'); return id.startsWith('card-drop-') || id.startsWith('worktree-drop-');
}); });
@@ -360,7 +379,7 @@ export function BoardView() {
} }
// Priority 2: Columns // Priority 2: Columns
const columnCollisions = pointerCollisions.filter((collision: Collision) => const columnCollisions = pointerCollisions.filter((collision: any) =>
COLUMNS.some((col) => col.id === collision.id) COLUMNS.some((col) => col.id === collision.id)
); );
@@ -414,86 +433,19 @@ export function BoardView() {
// Get the branch for the currently selected worktree // Get the branch for the currently selected worktree
// Find the worktree that matches the current selection, or use main worktree // Find the worktree that matches the current selection, or use main worktree
const selectedWorktree = useMemo((): WorktreeInfo | undefined => { const selectedWorktree = useMemo(() => {
let found;
if (currentWorktreePath === null) { if (currentWorktreePath === null) {
// Primary worktree selected - find the main worktree // Primary worktree selected - find the main worktree
found = worktrees.find((w) => w.isMain); return worktrees.find((w) => w.isMain);
} else { } else {
// Specific worktree selected - find it by path // Specific worktree selected - find it by path
found = worktrees.find((w) => !w.isMain && pathsEqual(w.path, currentWorktreePath)); return worktrees.find((w) => !w.isMain && pathsEqual(w.path, currentWorktreePath));
} }
if (!found) return undefined;
// Ensure all required WorktreeInfo fields are present
return {
...found,
isCurrent:
found.isCurrent ??
(currentWorktreePath !== null ? pathsEqual(found.path, currentWorktreePath) : found.isMain),
hasWorktree: found.hasWorktree ?? true,
};
}, [worktrees, currentWorktreePath]); }, [worktrees, currentWorktreePath]);
// Auto mode hook - pass current worktree to get worktree-specific state // Auto mode hook - pass current worktree to get worktree-specific state
// Must be after selectedWorktree is defined // Must be after selectedWorktree is defined
const autoMode = useAutoMode(selectedWorktree); const autoMode = useAutoMode(selectedWorktree ?? undefined);
const refreshBoardState = useCallback(async () => {
if (!currentProject) return;
const projectPath = currentProject.path;
const beforeFeatures = (
queryClient.getQueryData(queryKeys.features.all(projectPath)) as Feature[] | undefined
)?.length;
const beforeWorktrees = (
queryClient.getQueryData(queryKeys.worktrees.all(projectPath)) as
| { worktrees?: unknown[] }
| undefined
)?.worktrees?.length;
const beforeRunningAgents = (
queryClient.getQueryData(queryKeys.runningAgents.all()) as { count?: number } | undefined
)?.count;
const beforeAutoModeRunning = autoMode.isRunning;
try {
await Promise.all([
queryClient.refetchQueries({ queryKey: queryKeys.features.all(projectPath) }),
queryClient.refetchQueries({ queryKey: queryKeys.runningAgents.all() }),
queryClient.refetchQueries({ queryKey: queryKeys.worktrees.all(projectPath) }),
autoMode.refreshStatus(),
]);
const afterFeatures = (
queryClient.getQueryData(queryKeys.features.all(projectPath)) as Feature[] | undefined
)?.length;
const afterWorktrees = (
queryClient.getQueryData(queryKeys.worktrees.all(projectPath)) as
| { worktrees?: unknown[] }
| undefined
)?.worktrees?.length;
const afterRunningAgents = (
queryClient.getQueryData(queryKeys.runningAgents.all()) as { count?: number } | undefined
)?.count;
const afterAutoModeRunning = autoMode.isRunning;
if (
beforeFeatures !== afterFeatures ||
beforeWorktrees !== afterWorktrees ||
beforeRunningAgents !== afterRunningAgents ||
beforeAutoModeRunning !== afterAutoModeRunning
) {
logger.info('[Board] Refresh detected state mismatch', {
features: { before: beforeFeatures, after: afterFeatures },
worktrees: { before: beforeWorktrees, after: afterWorktrees },
runningAgents: { before: beforeRunningAgents, after: afterRunningAgents },
autoModeRunning: { before: beforeAutoModeRunning, after: afterAutoModeRunning },
});
}
} catch (error) {
logger.error('[Board] Failed to refresh board state:', error);
toast.error('Failed to refresh board state');
}
}, [autoMode, currentProject, queryClient]);
// Get runningTasks from the hook (scoped to current project/worktree) // Get runningTasks from the hook (scoped to current project/worktree)
const runningAutoTasks = autoMode.runningTasks; const runningAutoTasks = autoMode.runningTasks;
// Get worktree-specific maxConcurrency from the hook // Get worktree-specific maxConcurrency from the hook
@@ -511,16 +463,6 @@ export function BoardView() {
const selectedWorktreeBranch = const selectedWorktreeBranch =
currentWorktreeBranch || worktrees.find((w) => w.isMain)?.branch || 'main'; currentWorktreeBranch || worktrees.find((w) => w.isMain)?.branch || 'main';
// Aggregate running auto tasks across all worktrees for this project
const autoModeByWorktree = useAppStore((state) => state.autoModeByWorktree);
const runningAutoTasksAllWorktrees = useMemo(() => {
if (!currentProject?.id) return [];
const prefix = `${currentProject.id}::`;
return Object.entries(autoModeByWorktree)
.filter(([key]) => key.startsWith(prefix))
.flatMap(([, state]) => state.runningTasks ?? []);
}, [autoModeByWorktree, currentProject?.id]);
// Get in-progress features for keyboard shortcuts (needed before actions hook) // Get in-progress features for keyboard shortcuts (needed before actions hook)
// Must be after runningAutoTasks is defined // Must be after runningAutoTasks is defined
const inProgressFeaturesForShortcuts = useMemo(() => { const inProgressFeaturesForShortcuts = useMemo(() => {
@@ -583,6 +525,8 @@ export function BoardView() {
handleMoveBackToInProgress, handleMoveBackToInProgress,
handleOpenFollowUp, handleOpenFollowUp,
handleSendFollowUp, handleSendFollowUp,
handleCommitFeature,
handleMergeFeature,
handleCompleteFeature, handleCompleteFeature,
handleUnarchiveFeature, handleUnarchiveFeature,
handleViewOutput, handleViewOutput,
@@ -1022,8 +966,8 @@ export function BoardView() {
const api = getElectronAPI(); const api = getElectronAPI();
if (!api?.backlogPlan) return; if (!api?.backlogPlan) return;
const unsubscribe = api.backlogPlan.onEvent((data: unknown) => { const unsubscribe = api.backlogPlan.onEvent(
const event = data as { type: string; result?: BacklogPlanResult; error?: string }; (event: { type: string; result?: BacklogPlanResult; error?: string }) => {
if (event.type === 'backlog_plan_complete') { if (event.type === 'backlog_plan_complete') {
setIsGeneratingPlan(false); setIsGeneratingPlan(false);
if (event.result && event.result.changes?.length > 0) { if (event.result && event.result.changes?.length > 0) {
@@ -1042,7 +986,8 @@ export function BoardView() {
setIsGeneratingPlan(false); setIsGeneratingPlan(false);
toast.error(`Plan generation failed: ${event.error}`); toast.error(`Plan generation failed: ${event.error}`);
} }
}); }
);
return unsubscribe; return unsubscribe;
}, []); }, []);
@@ -1154,10 +1099,10 @@ export function BoardView() {
// Build columnFeaturesMap for ListView // Build columnFeaturesMap for ListView
// pipelineConfig is now from usePipelineConfig React Query hook at the top // pipelineConfig is now from usePipelineConfig React Query hook at the top
const columnFeaturesMap = useMemo(() => { const columnFeaturesMap = useMemo(() => {
const columns = getColumnsWithPipeline(pipelineConfig ?? null); const columns = getColumnsWithPipeline(pipelineConfig);
const map: Record<string, typeof hookFeatures> = {}; const map: Record<string, typeof hookFeatures> = {};
for (const column of columns) { for (const column of columns) {
map[column.id] = getColumnFeatures(column.id as FeatureStatusWithPipeline); map[column.id] = getColumnFeatures(column.id as any);
} }
return map; return map;
}, [pipelineConfig, getColumnFeatures]); }, [pipelineConfig, getColumnFeatures]);
@@ -1332,10 +1277,8 @@ export function BoardView() {
maxConcurrency={maxConcurrency} maxConcurrency={maxConcurrency}
runningAgentsCount={runningAutoTasks.length} runningAgentsCount={runningAutoTasks.length}
onConcurrencyChange={(newMaxConcurrency) => { onConcurrencyChange={(newMaxConcurrency) => {
if (currentProject) { if (currentProject && selectedWorktree) {
// If selectedWorktree is undefined or it's the main worktree, branchName will be null. const branchName = selectedWorktree.isMain ? null : selectedWorktree.branch;
// Otherwise, use the branch name.
const branchName = selectedWorktree?.isMain === false ? selectedWorktree.branch : null;
setMaxConcurrencyForWorktree(currentProject.id, branchName, newMaxConcurrency); setMaxConcurrencyForWorktree(currentProject.id, branchName, newMaxConcurrency);
// Persist to server settings so capacity checks use the correct value // Persist to server settings so capacity checks use the correct value
@@ -1378,7 +1321,6 @@ export function BoardView() {
isCreatingSpec={isCreatingSpec} isCreatingSpec={isCreatingSpec}
creatingSpecProjectPath={creatingSpecProjectPath} creatingSpecProjectPath={creatingSpecProjectPath}
onShowBoardBackground={() => setShowBoardBackgroundModal(true)} onShowBoardBackground={() => setShowBoardBackgroundModal(true)}
onRefreshBoard={refreshBoardState}
viewMode={viewMode} viewMode={viewMode}
onViewModeChange={setViewMode} onViewModeChange={setViewMode}
/> />
@@ -1430,7 +1372,7 @@ export function BoardView() {
setWorktreeRefreshKey((k) => k + 1); setWorktreeRefreshKey((k) => k + 1);
}} }}
onRemovedWorktrees={handleRemovedWorktrees} onRemovedWorktrees={handleRemovedWorktrees}
runningFeatureIds={runningAutoTasksAllWorktrees} runningFeatureIds={runningAutoTasks}
branchCardCounts={branchCardCounts} branchCardCounts={branchCardCounts}
features={hookFeatures.map((f) => ({ features={hookFeatures.map((f) => ({
id: f.id, id: f.id,
@@ -1510,13 +1452,14 @@ export function BoardView() {
onAddFeature={() => setShowAddDialog(true)} onAddFeature={() => setShowAddDialog(true)}
onShowCompletedModal={() => setShowCompletedModal(true)} onShowCompletedModal={() => setShowCompletedModal(true)}
completedCount={completedFeatures.length} completedCount={completedFeatures.length}
pipelineConfig={pipelineConfig ?? null} pipelineConfig={pipelineConfig}
onOpenPipelineSettings={() => setShowPipelineSettings(true)} onOpenPipelineSettings={() => setShowPipelineSettings(true)}
isSelectionMode={isSelectionMode} isSelectionMode={isSelectionMode}
selectionTarget={selectionTarget} selectionTarget={selectionTarget}
selectedFeatureIds={selectedFeatureIds} selectedFeatureIds={selectedFeatureIds}
onToggleFeatureSelection={toggleFeatureSelection} onToggleFeatureSelection={toggleFeatureSelection}
onToggleSelectionMode={toggleSelectionMode} onToggleSelectionMode={toggleSelectionMode}
viewMode={viewMode}
isDragging={activeFeature !== null} isDragging={activeFeature !== null}
onAiSuggest={() => setShowPlanDialog(true)} onAiSuggest={() => setShowPlanDialog(true)}
className="transition-opacity duration-200" className="transition-opacity duration-200"
@@ -1669,7 +1612,7 @@ export function BoardView() {
open={showPipelineSettings} open={showPipelineSettings}
onClose={() => setShowPipelineSettings(false)} onClose={() => setShowPipelineSettings(false)}
projectPath={currentProject.path} projectPath={currentProject.path}
pipelineConfig={pipelineConfig ?? null} pipelineConfig={pipelineConfig}
onSave={async (config) => { onSave={async (config) => {
const api = getHttpApiClient(); const api = getHttpApiClient();
const result = await api.pipeline.saveConfig(currentProject.path, config); const result = await api.pipeline.saveConfig(currentProject.path, config);

View File

@@ -1,4 +1,4 @@
import { Tooltip, TooltipContent, TooltipTrigger } from '@/components/ui/tooltip'; import { Tooltip, TooltipContent, TooltipProvider, TooltipTrigger } from '@/components/ui/tooltip';
import { ImageIcon } from 'lucide-react'; import { ImageIcon } from 'lucide-react';
import { cn } from '@/lib/utils'; import { cn } from '@/lib/utils';
@@ -18,6 +18,7 @@ export function BoardControls({ isMounted, onShowBoardBackground }: BoardControl
); );
return ( return (
<TooltipProvider>
<div className="flex items-center gap-2"> <div className="flex items-center gap-2">
{/* Board Background Button */} {/* Board Background Button */}
<Tooltip> <Tooltip>
@@ -35,5 +36,6 @@ export function BoardControls({ isMounted, onShowBoardBackground }: BoardControl
</TooltipContent> </TooltipContent>
</Tooltip> </Tooltip>
</div> </div>
</TooltipProvider>
); );
} }

View File

@@ -1,9 +1,7 @@
import { useCallback, useState } from 'react'; import { useCallback, useState } from 'react';
import { Switch } from '@/components/ui/switch'; import { Switch } from '@/components/ui/switch';
import { Label } from '@/components/ui/label'; import { Label } from '@/components/ui/label';
import { Button } from '@/components/ui/button'; import { Wand2, GitBranch, ClipboardCheck } from 'lucide-react';
import { Tooltip, TooltipContent, TooltipTrigger } from '@/components/ui/tooltip';
import { Wand2, GitBranch, ClipboardCheck, RefreshCw } from 'lucide-react';
import { UsagePopover } from '@/components/usage-popover'; import { UsagePopover } from '@/components/usage-popover';
import { useAppStore } from '@/store/app-store'; import { useAppStore } from '@/store/app-store';
import { useSetupStore } from '@/store/setup-store'; import { useSetupStore } from '@/store/setup-store';
@@ -37,7 +35,6 @@ interface BoardHeaderProps {
creatingSpecProjectPath?: string; creatingSpecProjectPath?: string;
// Board controls props // Board controls props
onShowBoardBackground: () => void; onShowBoardBackground: () => void;
onRefreshBoard: () => Promise<void>;
// View toggle props // View toggle props
viewMode: ViewMode; viewMode: ViewMode;
onViewModeChange: (mode: ViewMode) => void; onViewModeChange: (mode: ViewMode) => void;
@@ -63,7 +60,6 @@ export function BoardHeader({
isCreatingSpec, isCreatingSpec,
creatingSpecProjectPath, creatingSpecProjectPath,
onShowBoardBackground, onShowBoardBackground,
onRefreshBoard,
viewMode, viewMode,
onViewModeChange, onViewModeChange,
}: BoardHeaderProps) { }: BoardHeaderProps) {
@@ -114,20 +110,9 @@ export function BoardHeader({
// State for mobile actions panel // State for mobile actions panel
const [showActionsPanel, setShowActionsPanel] = useState(false); const [showActionsPanel, setShowActionsPanel] = useState(false);
const [isRefreshingBoard, setIsRefreshingBoard] = useState(false);
const isTablet = useIsTablet(); const isTablet = useIsTablet();
const handleRefreshBoard = useCallback(async () => {
if (isRefreshingBoard) return;
setIsRefreshingBoard(true);
try {
await onRefreshBoard();
} finally {
setIsRefreshingBoard(false);
}
}, [isRefreshingBoard, onRefreshBoard]);
return ( return (
<div className="flex items-center justify-between gap-5 p-4 border-b border-border bg-glass backdrop-blur-md"> <div className="flex items-center justify-between gap-5 p-4 border-b border-border bg-glass backdrop-blur-md">
<div className="flex items-center gap-4"> <div className="flex items-center gap-4">
@@ -142,22 +127,6 @@ export function BoardHeader({
<BoardControls isMounted={isMounted} onShowBoardBackground={onShowBoardBackground} /> <BoardControls isMounted={isMounted} onShowBoardBackground={onShowBoardBackground} />
</div> </div>
<div className="flex gap-4 items-center"> <div className="flex gap-4 items-center">
{isMounted && !isTablet && (
<Tooltip>
<TooltipTrigger asChild>
<Button
variant="secondary"
size="icon-sm"
onClick={handleRefreshBoard}
disabled={isRefreshingBoard}
aria-label="Refresh board state from server"
>
<RefreshCw className={isRefreshingBoard ? 'w-4 h-4 animate-spin' : 'w-4 h-4'} />
</Button>
</TooltipTrigger>
<TooltipContent side="bottom">Refresh board state from server</TooltipContent>
</Tooltip>
)}
{/* Usage Popover - show if either provider is authenticated, only on desktop */} {/* Usage Popover - show if either provider is authenticated, only on desktop */}
{isMounted && !isTablet && (showClaudeUsage || showCodexUsage) && <UsagePopover />} {isMounted && !isTablet && (showClaudeUsage || showCodexUsage) && <UsagePopover />}

View File

@@ -1,7 +1,13 @@
import { memo, useEffect, useState, useMemo, useRef } from 'react'; import { memo, useEffect, useState, useMemo, useRef } from 'react';
import { Feature, ThinkingLevel, ReasoningEffort, ParsedTask } from '@/store/app-store'; import { Feature, ThinkingLevel, ParsedTask } from '@/store/app-store';
import type { ReasoningEffort } from '@automaker/types';
import { getProviderFromModel } from '@/lib/utils'; import { getProviderFromModel } from '@/lib/utils';
import { parseAgentContext, formatModelName, DEFAULT_MODEL } from '@/lib/agent-context-parser'; import {
AgentTaskInfo,
parseAgentContext,
formatModelName,
DEFAULT_MODEL,
} from '@/lib/agent-context-parser';
import { cn } from '@/lib/utils'; import { cn } from '@/lib/utils';
import type { AutoModeEvent } from '@/types/electron'; import type { AutoModeEvent } from '@/types/electron';
import { Brain, ListTodo, Sparkles, Expand, CheckCircle2, Circle, Wrench } from 'lucide-react'; import { Brain, ListTodo, Sparkles, Expand, CheckCircle2, Circle, Wrench } from 'lucide-react';
@@ -289,8 +295,7 @@ export const AgentInfoPanel = memo(function AgentInfoPanel({
// Agent Info Panel for non-backlog cards // Agent Info Panel for non-backlog cards
// Show panel if we have agentInfo OR planSpec.tasks (for spec/full mode) // Show panel if we have agentInfo OR planSpec.tasks (for spec/full mode)
// Note: hasPlanSpecTasks is already defined above and includes freshPlanSpec // Note: hasPlanSpecTasks is already defined above and includes freshPlanSpec
// (The backlog case was already handled above and returned early) if (feature.status !== 'backlog' && (agentInfo || hasPlanSpecTasks)) {
if (agentInfo || hasPlanSpecTasks) {
return ( return (
<> <>
<div className="mb-3 space-y-2 overflow-hidden"> <div className="mb-3 space-y-2 overflow-hidden">

View File

@@ -1,4 +1,4 @@
// @ts-nocheck - optional callback prop typing with feature status narrowing // @ts-nocheck
import { memo } from 'react'; import { memo } from 'react';
import { Feature } from '@/store/app-store'; import { Feature } from '@/store/app-store';
import { Button } from '@/components/ui/button'; import { Button } from '@/components/ui/button';
@@ -36,7 +36,7 @@ interface CardActionsProps {
export const CardActions = memo(function CardActions({ export const CardActions = memo(function CardActions({
feature, feature,
isCurrentAutoTask, isCurrentAutoTask,
hasContext: _hasContext, hasContext,
shortcutKey, shortcutKey,
isSelectionMode = false, isSelectionMode = false,
onEdit, onEdit,

View File

@@ -1,8 +1,8 @@
// @ts-nocheck - badge component prop variations with conditional rendering // @ts-nocheck
import { memo, useEffect, useMemo, useState } from 'react'; import { memo, useEffect, useMemo, useState } from 'react';
import { Feature, useAppStore } from '@/store/app-store'; import { Feature, useAppStore } from '@/store/app-store';
import { cn } from '@/lib/utils'; import { cn } from '@/lib/utils';
import { Tooltip, TooltipContent, TooltipTrigger } from '@/components/ui/tooltip'; import { Tooltip, TooltipContent, TooltipProvider, TooltipTrigger } from '@/components/ui/tooltip';
import { AlertCircle, Lock, Hand, Sparkles, SkipForward } from 'lucide-react'; import { AlertCircle, Lock, Hand, Sparkles, SkipForward } from 'lucide-react';
import { getBlockingDependencies } from '@automaker/dependency-resolver'; import { getBlockingDependencies } from '@automaker/dependency-resolver';
import { useShallow } from 'zustand/react/shallow'; import { useShallow } from 'zustand/react/shallow';
@@ -28,6 +28,7 @@ export const CardBadges = memo(function CardBadges({ feature }: CardBadgesProps)
return ( return (
<div className="flex flex-wrap items-center gap-1.5 px-3 pt-1.5 min-h-[24px]"> <div className="flex flex-wrap items-center gap-1.5 px-3 pt-1.5 min-h-[24px]">
{/* Error badge */} {/* Error badge */}
<TooltipProvider delayDuration={200}>
<Tooltip> <Tooltip>
<TooltipTrigger asChild> <TooltipTrigger asChild>
<div <div
@@ -44,6 +45,7 @@ export const CardBadges = memo(function CardBadges({ feature }: CardBadgesProps)
<p>{feature.error}</p> <p>{feature.error}</p>
</TooltipContent> </TooltipContent>
</Tooltip> </Tooltip>
</TooltipProvider>
</div> </div>
); );
}); });
@@ -98,11 +100,13 @@ export const PriorityBadges = memo(function PriorityBadges({
return; return;
} }
// eslint-disable-next-line no-undef
const interval = setInterval(() => { const interval = setInterval(() => {
setCurrentTime(Date.now()); setCurrentTime(Date.now());
}, 1000); }, 1000);
return () => { return () => {
// eslint-disable-next-line no-undef
clearInterval(interval); clearInterval(interval);
}; };
}, [feature.justFinishedAt, feature.status, currentTime]); }, [feature.justFinishedAt, feature.status, currentTime]);
@@ -134,6 +138,7 @@ export const PriorityBadges = memo(function PriorityBadges({
<div className="absolute top-2 left-2 flex items-center gap-1"> <div className="absolute top-2 left-2 flex items-center gap-1">
{/* Priority badge */} {/* Priority badge */}
{feature.priority && ( {feature.priority && (
<TooltipProvider delayDuration={200}>
<Tooltip> <Tooltip>
<TooltipTrigger asChild> <TooltipTrigger asChild>
<div <div
@@ -163,10 +168,12 @@ export const PriorityBadges = memo(function PriorityBadges({
</p> </p>
</TooltipContent> </TooltipContent>
</Tooltip> </Tooltip>
</TooltipProvider>
)} )}
{/* Manual verification badge */} {/* Manual verification badge */}
{showManualVerification && ( {showManualVerification && (
<TooltipProvider delayDuration={200}>
<Tooltip> <Tooltip>
<TooltipTrigger asChild> <TooltipTrigger asChild>
<div <div
@@ -183,10 +190,12 @@ export const PriorityBadges = memo(function PriorityBadges({
<p>Manual verification required</p> <p>Manual verification required</p>
</TooltipContent> </TooltipContent>
</Tooltip> </Tooltip>
</TooltipProvider>
)} )}
{/* Blocked badge */} {/* Blocked badge */}
{isBlocked && ( {isBlocked && (
<TooltipProvider delayDuration={200}>
<Tooltip> <Tooltip>
<TooltipTrigger asChild> <TooltipTrigger asChild>
<div <div
@@ -214,10 +223,12 @@ export const PriorityBadges = memo(function PriorityBadges({
</p> </p>
</TooltipContent> </TooltipContent>
</Tooltip> </Tooltip>
</TooltipProvider>
)} )}
{/* Just Finished badge */} {/* Just Finished badge */}
{isJustFinished && ( {isJustFinished && (
<TooltipProvider delayDuration={200}>
<Tooltip> <Tooltip>
<TooltipTrigger asChild> <TooltipTrigger asChild>
<div <div
@@ -234,10 +245,12 @@ export const PriorityBadges = memo(function PriorityBadges({
<p>Agent just finished working on this feature</p> <p>Agent just finished working on this feature</p>
</TooltipContent> </TooltipContent>
</Tooltip> </Tooltip>
</TooltipProvider>
)} )}
{/* Pipeline exclusion badge */} {/* Pipeline exclusion badge */}
{hasPipelineExclusions && ( {hasPipelineExclusions && (
<TooltipProvider delayDuration={200}>
<Tooltip> <Tooltip>
<TooltipTrigger asChild> <TooltipTrigger asChild>
<div <div
@@ -265,6 +278,7 @@ export const PriorityBadges = memo(function PriorityBadges({
</p> </p>
</TooltipContent> </TooltipContent>
</Tooltip> </Tooltip>
</TooltipProvider>
)} )}
</div> </div>
); );

View File

@@ -1,4 +1,4 @@
// @ts-nocheck - content section prop typing with feature data extraction // @ts-nocheck
import { memo } from 'react'; import { memo } from 'react';
import { Feature } from '@/store/app-store'; import { Feature } from '@/store/app-store';
import { GitBranch, GitPullRequest, ExternalLink } from 'lucide-react'; import { GitBranch, GitPullRequest, ExternalLink } from 'lucide-react';

View File

@@ -1,4 +1,4 @@
// @ts-nocheck - header component props with optional handlers and status variants // @ts-nocheck
import { memo, useState } from 'react'; import { memo, useState } from 'react';
import { Feature } from '@/store/app-store'; import { Feature } from '@/store/app-store';
import { cn } from '@/lib/utils'; import { cn } from '@/lib/utils';

View File

@@ -1,4 +1,4 @@
// @ts-nocheck - dnd-kit draggable/droppable ref combination type incompatibilities // @ts-nocheck
import React, { memo, useLayoutEffect, useState, useCallback } from 'react'; import React, { memo, useLayoutEffect, useState, useCallback } from 'react';
import { useDraggable, useDroppable } from '@dnd-kit/core'; import { useDraggable, useDroppable } from '@dnd-kit/core';
import { cn } from '@/lib/utils'; import { cn } from '@/lib/utils';

View File

@@ -1,4 +1,4 @@
// @ts-nocheck - dialog state typing with feature summary extraction // @ts-nocheck
import { Feature } from '@/store/app-store'; import { Feature } from '@/store/app-store';
import { AgentTaskInfo } from '@/lib/agent-context-parser'; import { AgentTaskInfo } from '@/lib/agent-context-parser';
import { import {

View File

@@ -78,9 +78,7 @@ export const KanbanColumn = memo(function KanbanColumn({
)} )}
> >
<div className={cn('w-2.5 h-2.5 rounded-full shrink-0', colorClass)} /> <div className={cn('w-2.5 h-2.5 rounded-full shrink-0', colorClass)} />
<h3 className="font-semibold text-sm text-foreground/90 flex-1 tracking-tight whitespace-nowrap"> <h3 className="font-semibold text-sm text-foreground/90 flex-1 tracking-tight">{title}</h3>
{title}
</h3>
{headerAction} {headerAction}
<span className="text-xs font-medium text-muted-foreground/80 bg-muted/50 px-2 py-0.5 rounded-md tabular-nums"> <span className="text-xs font-medium text-muted-foreground/80 bg-muted/50 px-2 py-0.5 rounded-md tabular-nums">
{count} {count}

View File

@@ -132,7 +132,7 @@ const SortableColumnHeader = memo(function SortableColumnHeader({
)} )}
data-testid={`list-header-${column.id}`} data-testid={`list-header-${column.id}`}
> >
<span className="whitespace-nowrap truncate">{column.label}</span> <span>{column.label}</span>
<SortIcon column={column.id} sortConfig={sortConfig} /> <SortIcon column={column.id} sortConfig={sortConfig} />
</div> </div>
); );
@@ -156,7 +156,7 @@ const StaticColumnHeader = memo(function StaticColumnHeader({ column }: { column
)} )}
data-testid={`list-header-${column.id}`} data-testid={`list-header-${column.id}`}
> >
<span className="whitespace-nowrap truncate">{column.label}</span> <span>{column.label}</span>
</div> </div>
); );
}); });

View File

@@ -1,7 +1,9 @@
// @ts-nocheck - BaseFeature index signature causes property access type errors // TODO: Remove @ts-nocheck after fixing BaseFeature's index signature issue
// The `[key: string]: unknown` in BaseFeature causes property access type errors
// @ts-nocheck
import { memo, useCallback, useState, useEffect } from 'react'; import { memo, useCallback, useState, useEffect } from 'react';
import { cn } from '@/lib/utils'; import { cn } from '@/lib/utils';
import { Tooltip, TooltipContent, TooltipTrigger } from '@/components/ui/tooltip'; import { Tooltip, TooltipContent, TooltipProvider, TooltipTrigger } from '@/components/ui/tooltip';
import { AlertCircle, Lock, Hand, Sparkles, FileText } from 'lucide-react'; import { AlertCircle, Lock, Hand, Sparkles, FileText } from 'lucide-react';
import type { Feature } from '@/store/app-store'; import type { Feature } from '@/store/app-store';
import { RowActions, type RowActionHandlers } from './row-actions'; import { RowActions, type RowActionHandlers } from './row-actions';
@@ -147,6 +149,7 @@ const IndicatorBadges = memo(function IndicatorBadges({
return ( return (
<div className="flex items-center gap-1 ml-2"> <div className="flex items-center gap-1 ml-2">
<TooltipProvider delayDuration={200}>
{badges.map((badge) => ( {badges.map((badge) => (
<Tooltip key={badge.key}> <Tooltip key={badge.key}>
<TooltipTrigger asChild> <TooltipTrigger asChild>
@@ -168,6 +171,7 @@ const IndicatorBadges = memo(function IndicatorBadges({
</TooltipContent> </TooltipContent>
</Tooltip> </Tooltip>
))} ))}
</TooltipProvider>
</div> </div>
); );
}); });

View File

@@ -8,7 +8,7 @@ import type { PipelineConfig, FeatureStatusWithPipeline } from '@automaker/types
import { ListHeader } from './list-header'; import { ListHeader } from './list-header';
import { ListRow, sortFeatures } from './list-row'; import { ListRow, sortFeatures } from './list-row';
import { createRowActionHandlers, type RowActionHandlers } from './row-actions'; import { createRowActionHandlers, type RowActionHandlers } from './row-actions';
import { getStatusOrder } from './status-badge'; import { getStatusLabel, getStatusOrder } from './status-badge';
import { getColumnsWithPipeline } from '../../constants'; import { getColumnsWithPipeline } from '../../constants';
import type { SortConfig, SortColumn } from '../../hooks/use-list-view-state'; import type { SortConfig, SortColumn } from '../../hooks/use-list-view-state';

View File

@@ -1,5 +1,6 @@
// @ts-nocheck - feature data building with conditional fields and model type inference // @ts-nocheck
import { useState, useEffect, useRef } from 'react'; import { useState, useEffect, useRef } from 'react';
import { createLogger } from '@automaker/utils/logger';
import { import {
Dialog, Dialog,
DialogContent, DialogContent,
@@ -26,10 +27,18 @@ import { useNavigate } from '@tanstack/react-router';
import { toast } from 'sonner'; import { toast } from 'sonner';
import { cn } from '@/lib/utils'; import { cn } from '@/lib/utils';
import { modelSupportsThinking } from '@/lib/utils'; import { modelSupportsThinking } from '@/lib/utils';
import { useAppStore, ThinkingLevel, FeatureImage, PlanningMode, Feature } from '@/store/app-store';
import type { ReasoningEffort, PhaseModelEntry, AgentModel } from '@automaker/types';
import { supportsReasoningEffort } from '@automaker/types';
import { import {
useAppStore,
ModelAlias,
ThinkingLevel,
FeatureImage,
PlanningMode,
Feature,
} from '@/store/app-store';
import type { ReasoningEffort, PhaseModelEntry, AgentModel } from '@automaker/types';
import { supportsReasoningEffort, isClaudeModel } from '@automaker/types';
import {
TestingTabContent,
PrioritySelector, PrioritySelector,
WorkModeSelector, WorkModeSelector,
PlanningModeSelect, PlanningModeSelect,
@@ -41,13 +50,15 @@ import {
} from '../shared'; } from '../shared';
import type { WorkMode } from '../shared'; import type { WorkMode } from '../shared';
import { PhaseModelSelector } from '@/components/views/settings-view/model-defaults/phase-model-selector'; import { PhaseModelSelector } from '@/components/views/settings-view/model-defaults/phase-model-selector';
import { Tooltip, TooltipContent, TooltipTrigger } from '@/components/ui/tooltip'; import { Tooltip, TooltipContent, TooltipProvider, TooltipTrigger } from '@/components/ui/tooltip';
import { import {
getAncestors, getAncestors,
formatAncestorContextForPrompt, formatAncestorContextForPrompt,
type AncestorContext, type AncestorContext,
} from '@automaker/dependency-resolver'; } from '@automaker/dependency-resolver';
const logger = createLogger('AddFeatureDialog');
/** /**
* Determines the default work mode based on global settings and current worktree selection. * Determines the default work mode based on global settings and current worktree selection.
* *
@@ -168,6 +179,9 @@ export function AddFeatureDialog({
// Model selection state // Model selection state
const [modelEntry, setModelEntry] = useState<PhaseModelEntry>({ model: 'claude-opus' }); const [modelEntry, setModelEntry] = useState<PhaseModelEntry>({ model: 'claude-opus' });
// Check if current model supports planning mode (Claude/Anthropic only)
const modelSupportsPlanningMode = isClaudeModel(modelEntry.model);
// Planning mode state // Planning mode state
const [planningMode, setPlanningMode] = useState<PlanningMode>('skip'); const [planningMode, setPlanningMode] = useState<PlanningMode>('skip');
const [requirePlanApproval, setRequirePlanApproval] = useState(false); const [requirePlanApproval, setRequirePlanApproval] = useState(false);
@@ -256,13 +270,6 @@ export function AddFeatureDialog({
allFeatures, allFeatures,
]); ]);
// Clear requirePlanApproval when planning mode is skip or lite
useEffect(() => {
if (planningMode === 'skip' || planningMode === 'lite') {
setRequirePlanApproval(false);
}
}, [planningMode]);
const handleModelChange = (entry: PhaseModelEntry) => { const handleModelChange = (entry: PhaseModelEntry) => {
setModelEntry(entry); setModelEntry(entry);
}; };
@@ -521,6 +528,7 @@ export function AddFeatureDialog({
<Cpu className="w-4 h-4 text-muted-foreground" /> <Cpu className="w-4 h-4 text-muted-foreground" />
<span>AI & Execution</span> <span>AI & Execution</span>
</div> </div>
<TooltipProvider>
<Tooltip> <Tooltip>
<TooltipTrigger asChild> <TooltipTrigger asChild>
<button <button
@@ -539,6 +547,7 @@ export function AddFeatureDialog({
<p>Change default model and planning settings for new features</p> <p>Change default model and planning settings for new features</p>
</TooltipContent> </TooltipContent>
</Tooltip> </Tooltip>
</TooltipProvider>
</div> </div>
<div className="space-y-1.5"> <div className="space-y-1.5">
@@ -553,13 +562,41 @@ export function AddFeatureDialog({
<div className="grid gap-3 grid-cols-2"> <div className="grid gap-3 grid-cols-2">
<div className="space-y-1.5"> <div className="space-y-1.5">
<Label className="text-xs text-muted-foreground">Planning</Label> <Label
className={cn(
'text-xs text-muted-foreground',
!modelSupportsPlanningMode && 'opacity-50'
)}
>
Planning
</Label>
{modelSupportsPlanningMode ? (
<PlanningModeSelect <PlanningModeSelect
mode={planningMode} mode={planningMode}
onModeChange={setPlanningMode} onModeChange={setPlanningMode}
testIdPrefix="add-feature-planning" testIdPrefix="add-feature-planning"
compact compact
/> />
) : (
<TooltipProvider>
<Tooltip>
<TooltipTrigger asChild>
<div>
<PlanningModeSelect
mode="skip"
onModeChange={() => {}}
testIdPrefix="add-feature-planning"
compact
disabled
/>
</div>
</TooltipTrigger>
<TooltipContent>
<p>Planning modes are only available for Claude Provider</p>
</TooltipContent>
</Tooltip>
</TooltipProvider>
)}
</div> </div>
<div className="space-y-1.5"> <div className="space-y-1.5">
<Label className="text-xs text-muted-foreground">Options</Label> <Label className="text-xs text-muted-foreground">Options</Label>
@@ -583,14 +620,20 @@ export function AddFeatureDialog({
id="add-feature-require-approval" id="add-feature-require-approval"
checked={requirePlanApproval} checked={requirePlanApproval}
onCheckedChange={(checked) => setRequirePlanApproval(!!checked)} onCheckedChange={(checked) => setRequirePlanApproval(!!checked)}
disabled={planningMode === 'skip' || planningMode === 'lite'} disabled={
data-testid="add-feature-planning-require-approval-checkbox" !modelSupportsPlanningMode ||
planningMode === 'skip' ||
planningMode === 'lite'
}
data-testid="add-feature-require-approval-checkbox"
/> />
<Label <Label
htmlFor="add-feature-require-approval" htmlFor="add-feature-require-approval"
className={cn( className={cn(
'text-xs font-normal', 'text-xs font-normal',
planningMode === 'skip' || planningMode === 'lite' !modelSupportsPlanningMode ||
planningMode === 'skip' ||
planningMode === 'lite'
? 'cursor-not-allowed text-muted-foreground' ? 'cursor-not-allowed text-muted-foreground'
: 'cursor-pointer' : 'cursor-pointer'
)} )}

View File

@@ -17,7 +17,6 @@ import { useAppStore } from '@/store/app-store';
import { extractSummary } from '@/lib/log-parser'; import { extractSummary } from '@/lib/log-parser';
import { useAgentOutput } from '@/hooks/queries'; import { useAgentOutput } from '@/hooks/queries';
import type { AutoModeEvent } from '@/types/electron'; import type { AutoModeEvent } from '@/types/electron';
import type { BacklogPlanEvent } from '@automaker/types';
interface AgentOutputModalProps { interface AgentOutputModalProps {
open: boolean; open: boolean;
@@ -49,16 +48,18 @@ export function AgentOutputModal({
const isBacklogPlan = featureId.startsWith('backlog-plan:'); const isBacklogPlan = featureId.startsWith('backlog-plan:');
// Resolve project path - prefer prop, fallback to window.__currentProject // Resolve project path - prefer prop, fallback to window.__currentProject
const resolvedProjectPath = projectPathProp || window.__currentProject?.path || ''; const resolvedProjectPath = projectPathProp || (window as any).__currentProject?.path || '';
// Track additional content from WebSocket events (appended to query data) // Track additional content from WebSocket events (appended to query data)
const [streamedContent, setStreamedContent] = useState<string>(''); const [streamedContent, setStreamedContent] = useState<string>('');
const [viewMode, setViewMode] = useState<ViewMode | null>(null); const [viewMode, setViewMode] = useState<ViewMode | null>(null);
// Use React Query for initial output loading // Use React Query for initial output loading
const { data: initialOutput = '', isLoading } = useAgentOutput(resolvedProjectPath, featureId, { const { data: initialOutput = '', isLoading } = useAgentOutput(
enabled: open && !!resolvedProjectPath, resolvedProjectPath,
}); featureId,
open && !!resolvedProjectPath
);
// Reset streamed content when modal opens or featureId changes // Reset streamed content when modal opens or featureId changes
useEffect(() => { useEffect(() => {
@@ -261,8 +262,7 @@ export function AgentOutputModal({
const api = getElectronAPI(); const api = getElectronAPI();
if (!api?.backlogPlan) return; if (!api?.backlogPlan) return;
const unsubscribe = api.backlogPlan.onEvent((data: unknown) => { const unsubscribe = api.backlogPlan.onEvent((event: any) => {
const event = data as BacklogPlanEvent;
if (!event?.type) return; if (!event?.type) return;
let newContent = ''; let newContent = '';
@@ -282,7 +282,7 @@ export function AgentOutputModal({
} }
if (newContent) { if (newContent) {
setStreamedContent((prev) => prev + newContent); setOutput((prev) => `${prev}${newContent}`);
} }
}); });

View File

@@ -1,4 +1,4 @@
// @ts-nocheck - completed features filtering and grouping with status transitions // @ts-nocheck
import { import {
Dialog, Dialog,
DialogContent, DialogContent,

View File

@@ -241,9 +241,9 @@ export function CreatePRDialog({
<GitPullRequest className="w-5 h-5" /> <GitPullRequest className="w-5 h-5" />
Create Pull Request Create Pull Request
</DialogTitle> </DialogTitle>
<DialogDescription className="break-words"> <DialogDescription>
Push changes and create a pull request from{' '} Push changes and create a pull request from{' '}
<code className="font-mono bg-muted px-1 rounded break-all">{worktree.branch}</code> <code className="font-mono bg-muted px-1 rounded">{worktree.branch}</code>
</DialogDescription> </DialogDescription>
</DialogHeader> </DialogHeader>

View File

@@ -1,4 +1,4 @@
// @ts-nocheck - dependency tree visualization with recursive feature relationships // @ts-nocheck
import { useState, useEffect } from 'react'; import { useState, useEffect } from 'react';
import { Dialog, DialogContent, DialogHeader, DialogTitle } from '@/components/ui/dialog'; import { Dialog, DialogContent, DialogHeader, DialogTitle } from '@/components/ui/dialog';
import { Feature } from '@/store/app-store'; import { Feature } from '@/store/app-store';

View File

@@ -1,5 +1,6 @@
// @ts-nocheck - form state management with partial feature updates and validation // @ts-nocheck
import { useState, useEffect } from 'react'; import { useState, useEffect } from 'react';
import { createLogger } from '@automaker/utils/logger';
import { import {
Dialog, Dialog,
DialogContent, DialogContent,
@@ -25,10 +26,11 @@ import { GitBranch, Cpu, FolderKanban, Settings2 } from 'lucide-react';
import { useNavigate } from '@tanstack/react-router'; import { useNavigate } from '@tanstack/react-router';
import { toast } from 'sonner'; import { toast } from 'sonner';
import { cn, modelSupportsThinking } from '@/lib/utils'; import { cn, modelSupportsThinking } from '@/lib/utils';
import { Feature, ModelAlias, ThinkingLevel, PlanningMode } from '@/store/app-store'; import { Feature, ModelAlias, ThinkingLevel, useAppStore, PlanningMode } from '@/store/app-store';
import type { ReasoningEffort, PhaseModelEntry, DescriptionHistoryEntry } from '@automaker/types'; import type { ReasoningEffort, PhaseModelEntry, DescriptionHistoryEntry } from '@automaker/types';
import { migrateModelId } from '@automaker/types'; import { migrateModelId } from '@automaker/types';
import { import {
TestingTabContent,
PrioritySelector, PrioritySelector,
WorkModeSelector, WorkModeSelector,
PlanningModeSelect, PlanningModeSelect,
@@ -39,9 +41,11 @@ import {
} from '../shared'; } from '../shared';
import type { WorkMode } from '../shared'; import type { WorkMode } from '../shared';
import { PhaseModelSelector } from '@/components/views/settings-view/model-defaults/phase-model-selector'; import { PhaseModelSelector } from '@/components/views/settings-view/model-defaults/phase-model-selector';
import { Tooltip, TooltipContent, TooltipTrigger } from '@/components/ui/tooltip'; import { Tooltip, TooltipContent, TooltipProvider, TooltipTrigger } from '@/components/ui/tooltip';
import { DependencyTreeDialog } from './dependency-tree-dialog'; import { DependencyTreeDialog } from './dependency-tree-dialog';
import { supportsReasoningEffort } from '@automaker/types'; import { isClaudeModel, supportsReasoningEffort } from '@automaker/types';
const logger = createLogger('EditFeatureDialog');
interface EditFeatureDialogProps { interface EditFeatureDialogProps {
feature: Feature | null; feature: Feature | null;
@@ -115,6 +119,9 @@ export function EditFeatureDialog({
reasoningEffort: feature?.reasoningEffort || 'none', reasoningEffort: feature?.reasoningEffort || 'none',
})); }));
// Check if current model supports planning mode (Claude/Anthropic only)
const modelSupportsPlanningMode = isClaudeModel(modelEntry.model);
// Track the source of description changes for history // Track the source of description changes for history
const [descriptionChangeSource, setDescriptionChangeSource] = useState< const [descriptionChangeSource, setDescriptionChangeSource] = useState<
{ source: 'enhance'; mode: EnhancementMode } | 'edit' | null { source: 'enhance'; mode: EnhancementMode } | 'edit' | null
@@ -187,13 +194,6 @@ export function EditFeatureDialog({
} }
}, [feature, allFeatures]); }, [feature, allFeatures]);
// Clear requirePlanApproval when planning mode is skip or lite
useEffect(() => {
if (planningMode === 'skip' || planningMode === 'lite') {
setRequirePlanApproval(false);
}
}, [planningMode]);
const handleModelChange = (entry: PhaseModelEntry) => { const handleModelChange = (entry: PhaseModelEntry) => {
setModelEntry(entry); setModelEntry(entry);
}; };
@@ -420,6 +420,7 @@ export function EditFeatureDialog({
<Cpu className="w-4 h-4 text-muted-foreground" /> <Cpu className="w-4 h-4 text-muted-foreground" />
<span>AI & Execution</span> <span>AI & Execution</span>
</div> </div>
<TooltipProvider>
<Tooltip> <Tooltip>
<TooltipTrigger asChild> <TooltipTrigger asChild>
<button <button
@@ -438,6 +439,7 @@ export function EditFeatureDialog({
<p>Change default model and planning settings for new features</p> <p>Change default model and planning settings for new features</p>
</TooltipContent> </TooltipContent>
</Tooltip> </Tooltip>
</TooltipProvider>
</div> </div>
<div className="space-y-1.5"> <div className="space-y-1.5">
@@ -452,13 +454,41 @@ export function EditFeatureDialog({
<div className="grid gap-3 grid-cols-2"> <div className="grid gap-3 grid-cols-2">
<div className="space-y-1.5"> <div className="space-y-1.5">
<Label className="text-xs text-muted-foreground">Planning</Label> <Label
className={cn(
'text-xs text-muted-foreground',
!modelSupportsPlanningMode && 'opacity-50'
)}
>
Planning
</Label>
{modelSupportsPlanningMode ? (
<PlanningModeSelect <PlanningModeSelect
mode={planningMode} mode={planningMode}
onModeChange={setPlanningMode} onModeChange={setPlanningMode}
testIdPrefix="edit-feature-planning" testIdPrefix="edit-feature-planning"
compact compact
/> />
) : (
<TooltipProvider>
<Tooltip>
<TooltipTrigger asChild>
<div>
<PlanningModeSelect
mode="skip"
onModeChange={() => {}}
testIdPrefix="edit-feature-planning"
compact
disabled
/>
</div>
</TooltipTrigger>
<TooltipContent>
<p>Planning modes are only available for Claude Provider</p>
</TooltipContent>
</Tooltip>
</TooltipProvider>
)}
</div> </div>
<div className="space-y-1.5"> <div className="space-y-1.5">
<Label className="text-xs text-muted-foreground">Options</Label> <Label className="text-xs text-muted-foreground">Options</Label>
@@ -484,14 +514,20 @@ export function EditFeatureDialog({
id="edit-feature-require-approval" id="edit-feature-require-approval"
checked={requirePlanApproval} checked={requirePlanApproval}
onCheckedChange={(checked) => setRequirePlanApproval(!!checked)} onCheckedChange={(checked) => setRequirePlanApproval(!!checked)}
disabled={planningMode === 'skip' || planningMode === 'lite'} disabled={
!modelSupportsPlanningMode ||
planningMode === 'skip' ||
planningMode === 'lite'
}
data-testid="edit-feature-require-approval-checkbox" data-testid="edit-feature-require-approval-checkbox"
/> />
<Label <Label
htmlFor="edit-feature-require-approval" htmlFor="edit-feature-require-approval"
className={cn( className={cn(
'text-xs font-normal', 'text-xs font-normal',
planningMode === 'skip' || planningMode === 'lite' !modelSupportsPlanningMode ||
planningMode === 'skip' ||
planningMode === 'lite'
? 'cursor-not-allowed text-muted-foreground' ? 'cursor-not-allowed text-muted-foreground'
: 'cursor-pointer' : 'cursor-pointer'
)} )}

View File

@@ -1,3 +1,5 @@
import { useState } from 'react';
import { createLogger } from '@automaker/utils/logger';
import { import {
Dialog, Dialog,
DialogContent, DialogContent,
@@ -16,7 +18,14 @@ import {
} from '@/components/ui/description-image-dropzone'; } from '@/components/ui/description-image-dropzone';
import { MessageSquare } from 'lucide-react'; import { MessageSquare } from 'lucide-react';
import { Feature } from '@/store/app-store'; import { Feature } from '@/store/app-store';
import { EnhanceWithAI, EnhancementHistoryButton, type BaseHistoryEntry } from '../shared'; import {
EnhanceWithAI,
EnhancementHistoryButton,
type EnhancementMode,
type BaseHistoryEntry,
} from '../shared';
const logger = createLogger('FollowUpDialog');
/** /**
* A single entry in the follow-up prompt history * A single entry in the follow-up prompt history

View File

@@ -11,6 +11,7 @@ import { Button } from '@/components/ui/button';
import { Checkbox } from '@/components/ui/checkbox'; import { Checkbox } from '@/components/ui/checkbox';
import { Label } from '@/components/ui/label'; import { Label } from '@/components/ui/label';
import { AlertCircle } from 'lucide-react'; import { AlertCircle } from 'lucide-react';
import { modelSupportsThinking } from '@/lib/utils';
import { Feature, ModelAlias, ThinkingLevel, PlanningMode } from '@/store/app-store'; import { Feature, ModelAlias, ThinkingLevel, PlanningMode } from '@/store/app-store';
import { import {
TestingTabContent, TestingTabContent,
@@ -21,8 +22,9 @@ import {
} from '../shared'; } from '../shared';
import type { WorkMode } from '../shared'; import type { WorkMode } from '../shared';
import { PhaseModelSelector } from '@/components/views/settings-view/model-defaults/phase-model-selector'; import { PhaseModelSelector } from '@/components/views/settings-view/model-defaults/phase-model-selector';
import type { PhaseModelEntry } from '@automaker/types'; import { isCursorModel, isClaudeModel, type PhaseModelEntry } from '@automaker/types';
import { cn } from '@/lib/utils'; import { cn } from '@/lib/utils';
import { Tooltip, TooltipContent, TooltipProvider, TooltipTrigger } from '@/components/ui/tooltip';
interface MassEditDialogProps { interface MassEditDialogProps {
open: boolean; open: boolean;
@@ -197,13 +199,6 @@ export function MassEditDialog({
} }
}, [open, selectedFeatures]); }, [open, selectedFeatures]);
// Clear requirePlanApproval when planning mode is skip or lite
useEffect(() => {
if (planningMode === 'skip' || planningMode === 'lite') {
setRequirePlanApproval(false);
}
}, [planningMode]);
const handleApply = async () => { const handleApply = async () => {
const updates: Partial<Feature> = {}; const updates: Partial<Feature> = {};
@@ -239,6 +234,9 @@ export function MassEditDialog({
}; };
const hasAnyApply = Object.values(applyState).some(Boolean); const hasAnyApply = Object.values(applyState).some(Boolean);
const isCurrentModelCursor = isCursorModel(model);
const modelAllowsThinking = !isCurrentModelCursor && modelSupportsThinking(model);
const modelSupportsPlanningMode = isClaudeModel(model);
return ( return (
<Dialog open={open} onOpenChange={(open) => !open && onClose()}> <Dialog open={open} onOpenChange={(open) => !open && onClose()}>
@@ -278,6 +276,7 @@ export function MassEditDialog({
<div className="border-t border-border" /> <div className="border-t border-border" />
{/* Planning Mode */} {/* Planning Mode */}
{modelSupportsPlanningMode ? (
<FieldWrapper <FieldWrapper
label="Planning Mode" label="Planning Mode"
isMixed={mixedValues.planningMode || mixedValues.requirePlanApproval} isMixed={mixedValues.planningMode || mixedValues.requirePlanApproval}
@@ -302,6 +301,39 @@ export function MassEditDialog({
testIdPrefix="mass-edit-planning" testIdPrefix="mass-edit-planning"
/> />
</FieldWrapper> </FieldWrapper>
) : (
<TooltipProvider>
<Tooltip>
<TooltipTrigger asChild>
<div
className={cn(
'p-3 rounded-lg border transition-colors border-border bg-muted/20 opacity-50 cursor-not-allowed'
)}
>
<div className="flex items-center justify-between mb-3">
<div className="flex items-center gap-2">
<Checkbox checked={false} disabled className="opacity-50" />
<Label className="text-sm font-medium text-muted-foreground">
Planning Mode
</Label>
</div>
</div>
<div className="opacity-50 pointer-events-none">
<PlanningModeSelect
mode="skip"
onModeChange={() => {}}
testIdPrefix="mass-edit-planning"
disabled
/>
</div>
</div>
</TooltipTrigger>
<TooltipContent>
<p>Planning modes are only available for Claude Provider</p>
</TooltipContent>
</Tooltip>
</TooltipProvider>
)}
{/* Priority */} {/* Priority */}
<FieldWrapper <FieldWrapper

View File

@@ -330,7 +330,7 @@ export function MergeWorktreeDialog({
> >
{isLoading ? ( {isLoading ? (
<> <>
<Spinner size="sm" variant="foreground" className="mr-2" /> <Spinner size="sm" className="mr-2" />
Merging... Merging...
</> </>
) : ( ) : (

View File

@@ -1,150 +0,0 @@
export const commitTemplate = {
id: 'commit',
name: 'Commit Changes',
colorClass: 'bg-purple-500/20',
instructions: `## Commit Changes Step
# ⚠️ CRITICAL REQUIREMENT: YOU MUST COMMIT ALL CHANGES USING CONVENTIONAL COMMIT FORMAT ⚠️
**THIS IS NOT OPTIONAL. YOU MUST CREATE AND EXECUTE A GIT COMMIT WITH ALL CHANGES.**
This step requires you to:
1. **REVIEW** all changes made in this feature
2. **CREATE** a conventional commit message
3. **EXECUTE** the git commit command
**You cannot complete this step by only reviewing changes. You MUST execute the git commit command.**
---
### Phase 1: Review Phase
Review all changes made in this feature:
- Review all modified files using \`git status\` and \`git diff\`
- Identify the scope and nature of changes
- Determine the appropriate conventional commit type
- Identify any breaking changes that need to be documented
---
### Phase 2: Commit Phase - ⚠️ MANDATORY ACTION REQUIRED ⚠️
**YOU MUST NOW CREATE AND EXECUTE A GIT COMMIT WITH ALL CHANGES.**
**This is not optional. You must stage all changes and commit them using conventional commit format.**
#### Conventional Commit Format
Follow this format for your commit message:
\`\`\`
<type>(<scope>): <subject>
<body>
<footer>
\`\`\`
#### Commit Types (choose the most appropriate):
- **feat**: A new feature
- **fix**: A bug fix
- **docs**: Documentation only changes
- **style**: Code style changes (formatting, missing semicolons, etc.)
- **refactor**: Code refactoring without changing functionality
- **perf**: Performance improvements
- **test**: Adding or updating tests
- **chore**: Changes to build process, dependencies, or tooling
- **ci**: Changes to CI configuration
- **build**: Changes to build system or dependencies
#### Scope (optional but recommended):
- Component/module name (e.g., \`ui\`, \`server\`, \`auth\`)
- Feature area (e.g., \`board\`, \`pipeline\`, \`agent\`)
- Package name (e.g., \`@automaker/types\`)
#### Subject:
- Use imperative mood: "add" not "added" or "adds"
- First letter lowercase
- No period at the end
- Maximum 72 characters
#### Body (optional but recommended for significant changes):
- Explain the "what" and "why" of the change
- Reference related issues or PRs
- Separate from subject with blank line
- Wrap at 72 characters
#### Footer (optional):
- Breaking changes: \`BREAKING CHANGE: <description>\`
- Issue references: \`Closes #123\`, \`Fixes #456\`
#### Action Steps (You MUST complete these):
1. **Stage All Changes** - PREPARE FOR COMMIT:
- ✅ Run \`git add .\` or \`git add -A\` to stage all changes
- ✅ Verify staged changes with \`git status\`
- ✅ Ensure all relevant changes are staged
2. **Create Commit Message** - FOLLOW CONVENTIONAL COMMIT FORMAT:
- ✅ Determine the appropriate commit type based on changes
- ✅ Identify the scope (component/module/feature)
- ✅ Write a clear, imperative subject line
- ✅ Add a body explaining the changes (if significant)
- ✅ Include breaking changes in footer if applicable
- ✅ Reference related issues if applicable
3. **Execute Commit** - COMMIT THE CHANGES:
- ✅ Run \`git commit -m "<type>(<scope>): <subject>" -m "<body>"\` or use a multi-line commit message
- ✅ Verify the commit was created with \`git log -1\`
- ✅ **EXECUTE THE ACTUAL GIT COMMIT COMMAND**
#### Example Commit Messages:
\`\`\`
feat(ui): add pipeline step commit template
Add a new pipeline step template for committing changes using
conventional commit format. This ensures all commits follow
a consistent pattern for better changelog generation.
Closes #123
\`\`\`
\`\`\`
fix(server): resolve agent session timeout issue
The agent session was timing out prematurely due to incorrect
WebSocket heartbeat configuration. Updated heartbeat interval
to match server expectations.
Fixes #456
\`\`\`
\`\`\`
refactor(pipeline): extract step template logic
Extract step template loading and validation into separate
utility functions to improve code organization and testability.
\`\`\`
---
### Summary Required
After completing BOTH review AND commit phases, provide:
- A summary of all changes that were committed
- **The exact commit message that was used (this proves you executed the commit)**
- The commit hash (if available)
- Any notes about the commit (breaking changes, related issues, etc.)
---
# ⚠️ FINAL REMINDER ⚠️
**Reviewing changes without committing is INCOMPLETE and UNACCEPTABLE.**
**You MUST stage all changes and execute a git commit command.**
**You MUST use conventional commit format for the commit message.**
**You MUST show evidence of the commit execution in your summary.**
**This step is only complete when changes have been committed to git.**`,
};

View File

@@ -4,7 +4,6 @@ import { uxReviewTemplate } from './ux-review';
import { testingTemplate } from './testing'; import { testingTemplate } from './testing';
import { documentationTemplate } from './documentation'; import { documentationTemplate } from './documentation';
import { optimizationTemplate } from './optimization'; import { optimizationTemplate } from './optimization';
import { commitTemplate } from './commit';
export interface PipelineStepTemplate { export interface PipelineStepTemplate {
id: string; id: string;
@@ -20,7 +19,6 @@ export const STEP_TEMPLATES: PipelineStepTemplate[] = [
testingTemplate, testingTemplate,
documentationTemplate, documentationTemplate,
optimizationTemplate, optimizationTemplate,
commitTemplate,
]; ];
// Helper to get template color class // Helper to get template color class

View File

@@ -210,7 +210,7 @@ export function PlanApprovalDialog({
className="bg-green-600 hover:bg-green-700 text-white" className="bg-green-600 hover:bg-green-700 text-white"
> >
{isLoading ? ( {isLoading ? (
<Spinner size="sm" variant="foreground" className="mr-2" /> <Spinner size="sm" className="mr-2" />
) : ( ) : (
<Check className="w-4 h-4 mr-2" /> <Check className="w-4 h-4 mr-2" />
)} )}

View File

@@ -23,7 +23,14 @@ import { getHttpApiClient } from '@/lib/http-api-client';
import { toast } from 'sonner'; import { toast } from 'sonner';
import { GitMerge, RefreshCw, AlertTriangle } from 'lucide-react'; import { GitMerge, RefreshCw, AlertTriangle } from 'lucide-react';
import { Spinner } from '@/components/ui/spinner'; import { Spinner } from '@/components/ui/spinner';
import type { WorktreeInfo } from '../worktree-panel/types';
interface WorktreeInfo {
path: string;
branch: string;
isMain: boolean;
hasChanges?: boolean;
changedFilesCount?: number;
}
interface RemoteBranch { interface RemoteBranch {
name: string; name: string;
@@ -42,7 +49,7 @@ interface PullResolveConflictsDialogProps {
open: boolean; open: boolean;
onOpenChange: (open: boolean) => void; onOpenChange: (open: boolean) => void;
worktree: WorktreeInfo | null; worktree: WorktreeInfo | null;
onConfirm: (worktree: WorktreeInfo, remoteBranch: string) => void | Promise<void>; onConfirm: (worktree: WorktreeInfo, remoteBranch: string) => void;
} }
export function PullResolveConflictsDialog({ export function PullResolveConflictsDialog({

View File

@@ -1,4 +1,4 @@
// @ts-nocheck - feature update logic with partial updates and image/file handling // @ts-nocheck
import { useCallback } from 'react'; import { useCallback } from 'react';
import { import {
Feature, Feature,

View File

@@ -1,4 +1,4 @@
// @ts-nocheck - column filtering logic with dependency resolution and status mapping // @ts-nocheck
import { useMemo, useCallback } from 'react'; import { useMemo, useCallback } from 'react';
import { Feature, useAppStore } from '@/store/app-store'; import { Feature, useAppStore } from '@/store/app-store';
import { import {
@@ -51,6 +51,7 @@ export function useBoardColumnFeatures({
// Determine the effective worktree path and branch for filtering // Determine the effective worktree path and branch for filtering
// If currentWorktreePath is null, we're on the main worktree // If currentWorktreePath is null, we're on the main worktree
const effectiveWorktreePath = currentWorktreePath || projectPath;
// Use the branch name from the selected worktree // Use the branch name from the selected worktree
// If we're selecting main (currentWorktreePath is null), currentWorktreeBranch // If we're selecting main (currentWorktreePath is null), currentWorktreeBranch
// should contain the main branch's actual name, defaulting to "main" // should contain the main branch's actual name, defaulting to "main"

View File

@@ -23,7 +23,7 @@ interface UseBoardDragDropProps {
export function useBoardDragDrop({ export function useBoardDragDrop({
features, features,
currentProject: _currentProject, currentProject,
runningAutoTasks, runningAutoTasks,
persistFeatureUpdate, persistFeatureUpdate,
handleStartImplementation, handleStartImplementation,
@@ -128,9 +128,10 @@ export function useBoardDragDrop({
const targetBranch = worktreeData.branch; const targetBranch = worktreeData.branch;
const currentBranch = draggedFeature.branchName; const currentBranch = draggedFeature.branchName;
// For main worktree, set branchName to undefined to indicate it should use main // For main worktree, set branchName to null to indicate it should use main
// (must use null not undefined so it serializes to JSON for the API call)
// For other worktrees, set branchName to the target branch // For other worktrees, set branchName to the target branch
const newBranchName: string | undefined = worktreeData.isMain ? undefined : targetBranch; const newBranchName = worktreeData.isMain ? null : targetBranch;
// If already on the same branch, nothing to do // If already on the same branch, nothing to do
// For main worktree: feature with null/undefined branchName is already on main // For main worktree: feature with null/undefined branchName is already on main

View File

@@ -1,16 +1,15 @@
import { useEffect, useRef } from 'react'; import { useEffect, useRef } from 'react';
import { getElectronAPI } from '@/lib/electron'; import { getElectronAPI } from '@/lib/electron';
import { createLogger } from '@automaker/utils/logger'; import { createLogger } from '@automaker/utils/logger';
import type { Feature } from '@/store/app-store';
const logger = createLogger('BoardEffects'); const logger = createLogger('BoardEffects');
interface UseBoardEffectsProps { interface UseBoardEffectsProps {
currentProject: { path: string; id: string; name?: string } | null; currentProject: { path: string; id: string } | null;
specCreatingForProject: string | null; specCreatingForProject: string | null;
setSpecCreatingForProject: (path: string | null) => void; setSpecCreatingForProject: (path: string | null) => void;
checkContextExists: (featureId: string) => Promise<boolean>; checkContextExists: (featureId: string) => Promise<boolean>;
features: Feature[]; features: any[];
isLoading: boolean; isLoading: boolean;
featuresWithContext: Set<string>; featuresWithContext: Set<string>;
setFeaturesWithContext: (set: Set<string>) => void; setFeaturesWithContext: (set: Set<string>) => void;
@@ -34,10 +33,10 @@ export function useBoardEffects({
// Make current project available globally for modal // Make current project available globally for modal
useEffect(() => { useEffect(() => {
if (currentProject) { if (currentProject) {
window.__currentProject = currentProject; (window as any).__currentProject = currentProject;
} }
return () => { return () => {
window.__currentProject = null; (window as any).__currentProject = null;
}; };
}, [currentProject]); }, [currentProject]);

View File

@@ -185,8 +185,8 @@ export function useBoardFeatures({ currentProject }: UseBoardFeaturesProps) {
features, features,
isLoading, isLoading,
persistedCategories, persistedCategories,
loadFeatures: async () => { loadFeatures: () => {
await queryClient.invalidateQueries({ queryClient.invalidateQueries({
queryKey: queryKeys.features.all(currentProject?.path ?? ''), queryKey: queryKeys.features.all(currentProject?.path ?? ''),
}); });
}, },

View File

@@ -1,6 +1,5 @@
import { useCallback } from 'react'; import { useCallback } from 'react';
import { useQueryClient } from '@tanstack/react-query'; import { useQueryClient } from '@tanstack/react-query';
import type { Feature as ApiFeature } from '@automaker/types';
import { Feature } from '@/store/app-store'; import { Feature } from '@/store/app-store';
import { getElectronAPI } from '@/lib/electron'; import { getElectronAPI } from '@/lib/electron';
import { useAppStore } from '@/store/app-store'; import { useAppStore } from '@/store/app-store';
@@ -49,14 +48,14 @@ export function useBoardPersistence({ currentProject }: UseBoardPersistenceProps
feature: result.feature, feature: result.feature,
}); });
if (result.success && result.feature) { if (result.success && result.feature) {
const updatedFeature = result.feature as Feature; const updatedFeature = result.feature;
updateFeature(updatedFeature.id, updatedFeature as Partial<Feature>); updateFeature(updatedFeature.id, updatedFeature);
queryClient.setQueryData<Feature[]>( queryClient.setQueryData<Feature[]>(
queryKeys.features.all(currentProject.path), queryKeys.features.all(currentProject.path),
(features) => { (features) => {
if (!features) return features; if (!features) return features;
return features.map((feature) => return features.map((feature) =>
feature.id === updatedFeature.id ? { ...feature, ...updatedFeature } : feature feature.id === updatedFeature.id ? updatedFeature : feature
); );
} }
); );
@@ -86,9 +85,9 @@ export function useBoardPersistence({ currentProject }: UseBoardPersistenceProps
return; return;
} }
const result = await api.features.create(currentProject.path, feature as ApiFeature); const result = await api.features.create(currentProject.path, feature);
if (result.success && result.feature) { if (result.success && result.feature) {
updateFeature(result.feature.id, result.feature as Partial<Feature>); updateFeature(result.feature.id, result.feature);
// Invalidate React Query cache to sync UI // Invalidate React Query cache to sync UI
queryClient.invalidateQueries({ queryClient.invalidateQueries({
queryKey: queryKeys.features.all(currentProject.path), queryKey: queryKeys.features.all(currentProject.path),

Some files were not shown because too many files have changed in this diff Show More