2 Commits

Author	SHA1	Message	Date
Stefan de Vogelaere	5ab53afd7f	feat: add per-project default model override for new features (#640) ... * feat: add per-project default model override for new features - Add defaultFeatureModel to ProjectSettings type for project-level override - Add defaultFeatureModel to Project interface for UI state - Display Default Feature Model in Model Defaults section alongside phase models - Include Default Feature Model in global Bulk Replace dialog - Add Default Feature Model override section to Project Settings - Add setProjectDefaultFeatureModel store action for project-level overrides - Update clearAllProjectPhaseModelOverrides to also clear defaultFeatureModel - Update add-feature-dialog to use project override when available - Include Default Feature Model in Project Bulk Replace dialog This allows projects with different complexity levels to use different default models (e.g., Haiku for simple tasks, Opus for complex projects). * fix: add server-side __CLEAR__ handler for defaultFeatureModel - Add handler in settings-service.ts to properly delete defaultFeatureModel when '__CLEAR__' marker is sent from the UI - Fix bulk-replace-dialog.tsx to correctly return claude-opus when resetting default feature model to Anthropic Direct (was incorrectly using enhancementModel's settings which default to sonnet) These fixes ensure: 1. Clearing project default model override properly removes the setting instead of storing literal '__CLEAR__' string 2. Global bulk replace correctly resets default feature model to opus * fix: include defaultFeatureModel in Reset to Defaults action - Updated resetPhaseModels to also reset defaultFeatureModel to claude-opus - Fixed initial state to use canonical 'claude-opus' instead of 'opus' * refactor: use DEFAULT_GLOBAL_SETTINGS constant for defaultFeatureModel Address PR review feedback: - Replace hardcoded { model: 'claude-opus' } with DEFAULT_GLOBAL_SETTINGS.defaultFeatureModel - Fix Prettier formatting for long destructuring lines - Import DEFAULT_GLOBAL_SETTINGS from @automaker/types where needed This improves maintainability by centralizing the default value.	2026-01-21 12:45:14 +01:00
Stefan de Vogelaere	a1f234c7e2	feat: Claude Compatible Providers System (#629) ... * feat: refactor Claude API Profiles to Claude Compatible Providers - Rename ClaudeApiProfile to ClaudeCompatibleProvider with models[] array - Each ProviderModel has mapsToClaudeModel field for Claude tier mapping - Add providerType field for provider-specific icons (glm, minimax, openrouter) - Add thinking level support for provider models in phase selectors - Show all mapped Claude models per provider model (e.g., "Maps to Haiku, Sonnet, Opus") - Add Bulk Replace feature to switch all phases to a provider at once - Hide Bulk Replace button when no providers are enabled - Fix project-level phaseModelOverrides not persisting after refresh - Fix deleting last provider not persisting (remove empty array guard) - Add getProviderByModelId() helper for all SDK routes - Update all routes to pass provider config for provider models - Update terminology from "profiles" to "providers" throughout UI - Update documentation to reflect new provider system * fix: atomic writer race condition and bulk replace reset to defaults 1. AtomicWriter Race Condition Fix (libs/utils/src/atomic-writer.ts): - Changed temp file naming from Date.now() to Date.now() + random hex - Uses crypto.randomBytes(4).toString('hex') for uniqueness - Prevents ENOENT errors when multiple concurrent writes happen within the same millisecond 2. Bulk Replace "Anthropic Direct" Reset (both dialogs): - When selecting "Anthropic Direct", now uses DEFAULT_PHASE_MODELS - Properly resets thinking levels and other settings to defaults - Added thinkingLevel to the change detection comparison - Affects both global and project-level bulk replace dialogs * fix: update tests for new model resolver passthrough behavior 1. model-resolver tests: - Unknown models now pass through unchanged (provider model support) - Removed expectations for warnings on unknown models - Updated case sensitivity and edge case tests accordingly - Added tests for provider-like model names (GLM-4.7, MiniMax-M2.1) 2. atomic-writer tests: - Updated regex to match new temp file format with random suffix - Format changed from .tmp.{timestamp} to .tmp.{timestamp}.{hex} * refactor: simplify getPhaseModelWithOverrides calls per code review Address code review feedback on PR #629: - Make settingsService parameter optional in getPhaseModelWithOverrides - Function now handles undefined settingsService gracefully by returning defaults - Remove redundant ternary checks in 4 call sites: - apps/server/src/routes/context/routes/describe-file.ts - apps/server/src/routes/context/routes/describe-image.ts - apps/server/src/routes/worktree/routes/generate-commit-message.ts - apps/server/src/services/auto-mode-service.ts - Remove unused DEFAULT_PHASE_MODELS imports where applicable * test: fix server tests for provider model passthrough behavior - Update model-resolver.test.ts to expect unknown models to pass through unchanged (supports ClaudeCompatibleProvider models like GLM-4.7) - Remove warning expectations for unknown models (valid for providers) - Add missing getCredentials and getGlobalSettings mocks to ideation-service.test.ts for settingsService * fix: address code review feedback for model providers - Honor thinkingLevel in generate-commit-message.ts - Pass claudeCompatibleProvider in ideation-service.ts for provider models - Resolve provider configuration for model overrides in generate-suggestions.ts - Update "Active Profile" to "Active Provider" label in project-claude-section - Use substring instead of deprecated substr in api-profiles-section - Preserve provider enabled state when editing in api-profiles-section * fix: address CodeRabbit review issues for Claude Compatible Providers - Fix TypeScript TS2339 error in generate-suggestions.ts where settingsService was narrowed to 'never' type in else branch - Use DEFAULT_PHASE_MODELS per-phase defaults instead of hardcoded 'sonnet' in settings-helpers.ts - Remove duplicate eventHooks key in use-settings-migration.ts - Add claudeCompatibleProviders to localStorage migration parsing and merging functions - Handle canonical claude-* model IDs (claude-haiku, claude-sonnet, claude-opus) in project-models-section display names This resolves the CI build failures and addresses code review feedback. * fix: skip broken list-view-priority E2E test and add Priority column label - Skip list-view-priority.spec.ts with TODO explaining the infrastructure issue: setupRealProject only sets localStorage but server settings take precedence with localStorageMigrated: true - Add 'Priority' label to list-header.tsx for the priority column (was empty string, now shows proper header text) - Increase column width to accommodate the label The E2E test issue is that tests create features in a temp directory, but the server loads from the E2E Test Project fixture path set in setup-e2e-fixtures.mjs. Needs infrastructure fix to properly switch projects or create features through UI instead of on disk.	2026-01-20 20:57:23 +01:00