refactor: simplify getPhaseModelWithOverrides calls per code review

Address code review feedback on PR #629:
- Make settingsService parameter optional in getPhaseModelWithOverrides
- Function now handles undefined settingsService gracefully by returning defaults
- Remove redundant ternary checks in 4 call sites:
  - apps/server/src/routes/context/routes/describe-file.ts
  - apps/server/src/routes/context/routes/describe-image.ts
  - apps/server/src/routes/worktree/routes/generate-commit-message.ts
  - apps/server/src/services/auto-mode-service.ts
- Remove unused DEFAULT_PHASE_MODELS imports where applicable
This commit is contained in:
Stefan de Vogelaere
2026-01-20 20:16:25 +01:00
parent 8efd14c580
commit f007ca2c80
5 changed files with 40 additions and 53 deletions

View File

@@ -2318,18 +2318,12 @@ Format your response as a structured markdown document.`;
phaseModel: phaseModelEntry,
provider: analysisClaudeProvider,
credentials,
} = this.settingsService
? await getPhaseModelWithOverrides(
'projectAnalysisModel',
this.settingsService,
projectPath,
'[AutoMode]'
)
: {
phaseModel: DEFAULT_PHASE_MODELS.projectAnalysisModel,
provider: undefined,
credentials: undefined,
};
} = await getPhaseModelWithOverrides(
'projectAnalysisModel',
this.settingsService,
projectPath,
'[AutoMode]'
);
const { model: analysisModel, thinkingLevel: analysisThinkingLevel } =
resolvePhaseModel(phaseModelEntry);
logger.info(