fix: address CodeRabbitAI review feedback

- Replace busy-wait loop in refreshModels with Promise-based approach
- Remove duplicate error logging in opencode-models.ts handlers
- Fix multi-slash parsing in provider-icon.tsx (only handle exactly one slash)
- Use dynamic icon resolution for selected OpenCode model in trigger
- Fix misleading comment about merge precedence (static takes precedence)
- Add enabledOpencodeModels and opencodeDefaultModel to settings sync
- Add clarifying comments about session-only dynamic model settings

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Stefan de Vogelaere
2026-01-11 22:03:59 +01:00
committed by DhanushSantosh
parent 20cc401238
commit edcc4e789b
4 changed files with 65 additions and 52 deletions

View File

@@ -122,7 +122,6 @@ export function createRefreshOpencodeModelsHandler() {
res.json(response);
} catch (error) {
logger.error('Refresh OpenCode models failed:', error);
logError(error, 'Refresh OpenCode models failed');
res.status(500).json({
success: false,
@@ -155,7 +154,6 @@ export function createGetOpencodeProvidersHandler() {
res.json(response);
} catch (error) {
logger.error('Get OpenCode providers failed:', error);
logError(error, 'Get OpenCode providers failed');
res.status(500).json({
success: false,