mirror of
https://github.com/AutoMaker-Org/automaker.git
synced 2026-02-04 09:13:08 +00:00
refactor: update kanban responsive scaling tests to adjust column width bounds and improve margin calculations
- Changed minimum column width from 240px to 280px to better align with design requirements. - Enhanced margin calculations to account for the actual container width and sidebar positioning, ensuring more accurate layout testing.
This commit is contained in:
@@ -110,8 +110,8 @@ test.describe("Kanban Responsive Scaling Tests", () => {
|
|||||||
expect(Math.abs(columnWidth - baseWidth)).toBeLessThan(2);
|
expect(Math.abs(columnWidth - baseWidth)).toBeLessThan(2);
|
||||||
}
|
}
|
||||||
|
|
||||||
// Column width should be within expected bounds (240px min, 360px max)
|
// Column width should be within expected bounds (280px min, 360px max)
|
||||||
expect(baseWidth).toBeGreaterThanOrEqual(240);
|
expect(baseWidth).toBeGreaterThanOrEqual(280);
|
||||||
expect(baseWidth).toBeLessThanOrEqual(360);
|
expect(baseWidth).toBeLessThanOrEqual(360);
|
||||||
|
|
||||||
// Columns should not overlap (check x positions)
|
// Columns should not overlap (check x positions)
|
||||||
@@ -149,9 +149,30 @@ test.describe("Kanban Responsive Scaling Tests", () => {
|
|||||||
expect(verifiedBox).not.toBeNull();
|
expect(verifiedBox).not.toBeNull();
|
||||||
|
|
||||||
if (backlogBox && verifiedBox) {
|
if (backlogBox && verifiedBox) {
|
||||||
// Calculate the left and right margins
|
// Get the actual container width (accounting for sidebar)
|
||||||
const leftMargin = backlogBox.x;
|
// The board-view container is inside a flex container that accounts for sidebar
|
||||||
const rightMargin = 1600 - (verifiedBox.x + verifiedBox.width);
|
const containerWidth = await page.evaluate(() => {
|
||||||
|
const boardView = document.querySelector('[data-testid="board-view"]');
|
||||||
|
if (!boardView) return window.innerWidth;
|
||||||
|
const parent = boardView.parentElement;
|
||||||
|
return parent ? parent.clientWidth : window.innerWidth;
|
||||||
|
});
|
||||||
|
|
||||||
|
// Calculate the left and right margins relative to the container
|
||||||
|
// The bounding box x is relative to the viewport, so we need to find where
|
||||||
|
// the container starts relative to the viewport
|
||||||
|
const containerLeft = await page.evaluate(() => {
|
||||||
|
const boardView = document.querySelector('[data-testid="board-view"]');
|
||||||
|
if (!boardView) return 0;
|
||||||
|
const parent = boardView.parentElement;
|
||||||
|
if (!parent) return 0;
|
||||||
|
const rect = parent.getBoundingClientRect();
|
||||||
|
return rect.left;
|
||||||
|
});
|
||||||
|
|
||||||
|
// Calculate margins relative to the container
|
||||||
|
const leftMargin = backlogBox.x - containerLeft;
|
||||||
|
const rightMargin = containerWidth - (verifiedBox.x + verifiedBox.width - containerLeft);
|
||||||
|
|
||||||
// The margins should be roughly equal (columns are centered)
|
// The margins should be roughly equal (columns are centered)
|
||||||
// Allow for some tolerance due to padding and gaps
|
// Allow for some tolerance due to padding and gaps
|
||||||
|
|||||||
Reference in New Issue
Block a user