feat: disable automated testing by default and rename checkbox

- Change default skipTests value from false to true (tests disabled by default)
- Rename checkbox label from 'Skip automated testing' to 'Enable automated testing'
- Invert checkbox logic so checked means tests enabled
- Update help text to clarify the new behavior

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Cody Seibert
2025-12-11 21:13:45 -05:00
parent b5d31db57c
commit e6857c6feb
3 changed files with 19 additions and 18 deletions

View File

@@ -2322,11 +2322,11 @@ export function BoardView() {
<div className="flex items-center space-x-2"> <div className="flex items-center space-x-2">
<Checkbox <Checkbox
id="skip-tests" id="skip-tests"
checked={newFeature.skipTests} checked={!newFeature.skipTests}
onCheckedChange={(checked) => onCheckedChange={(checked) =>
setNewFeature({ setNewFeature({
...newFeature, ...newFeature,
skipTests: checked === true, skipTests: checked !== true,
}) })
} }
data-testid="skip-tests-checkbox" data-testid="skip-tests-checkbox"
@@ -2336,14 +2336,14 @@ export function BoardView() {
htmlFor="skip-tests" htmlFor="skip-tests"
className="text-sm cursor-pointer" className="text-sm cursor-pointer"
> >
Skip automated testing Enable automated testing
</Label> </Label>
<FlaskConical className="w-3.5 h-3.5 text-muted-foreground" /> <FlaskConical className="w-3.5 h-3.5 text-muted-foreground" />
</div> </div>
</div> </div>
<p className="text-xs text-muted-foreground"> <p className="text-xs text-muted-foreground">
When enabled, this feature will require manual verification When enabled, this feature will use automated TDD. When
instead of automated TDD. disabled, it will require manual verification.
</p> </p>
{/* Verification Steps - Only shown when skipTests is enabled */} {/* Verification Steps - Only shown when skipTests is enabled */}
@@ -2742,11 +2742,11 @@ export function BoardView() {
<div className="flex items-center space-x-2"> <div className="flex items-center space-x-2">
<Checkbox <Checkbox
id="edit-skip-tests" id="edit-skip-tests"
checked={editingFeature.skipTests ?? false} checked={!(editingFeature.skipTests ?? false)}
onCheckedChange={(checked) => onCheckedChange={(checked) =>
setEditingFeature({ setEditingFeature({
...editingFeature, ...editingFeature,
skipTests: checked === true, skipTests: checked !== true,
}) })
} }
data-testid="edit-skip-tests-checkbox" data-testid="edit-skip-tests-checkbox"
@@ -2756,14 +2756,14 @@ export function BoardView() {
htmlFor="edit-skip-tests" htmlFor="edit-skip-tests"
className="text-sm cursor-pointer" className="text-sm cursor-pointer"
> >
Skip automated testing Enable automated testing
</Label> </Label>
<FlaskConical className="w-3.5 h-3.5 text-muted-foreground" /> <FlaskConical className="w-3.5 h-3.5 text-muted-foreground" />
</div> </div>
</div> </div>
<p className="text-xs text-muted-foreground"> <p className="text-xs text-muted-foreground">
When enabled, this feature will require manual verification When enabled, this feature will use automated TDD. When
instead of automated TDD. disabled, it will require manual verification.
</p> </p>
{/* Verification Steps - Only shown when skipTests is enabled */} {/* Verification Steps - Only shown when skipTests is enabled */}

View File

@@ -70,14 +70,14 @@ export function FeatureDefaultsSection({
{/* Separator */} {/* Separator */}
<div className="border-t border-border" /> <div className="border-t border-border" />
{/* Skip Tests Setting */} {/* Automated Testing Setting */}
<div className="space-y-3"> <div className="space-y-3">
<div className="flex items-start space-x-3"> <div className="flex items-start space-x-3">
<Checkbox <Checkbox
id="default-skip-tests" id="default-skip-tests"
checked={defaultSkipTests} checked={!defaultSkipTests}
onCheckedChange={(checked) => onCheckedChange={(checked) =>
onDefaultSkipTestsChange(checked === true) onDefaultSkipTestsChange(checked !== true)
} }
className="mt-0.5" className="mt-0.5"
data-testid="default-skip-tests-checkbox" data-testid="default-skip-tests-checkbox"
@@ -88,12 +88,13 @@ export function FeatureDefaultsSection({
className="text-foreground cursor-pointer font-medium flex items-center gap-2" className="text-foreground cursor-pointer font-medium flex items-center gap-2"
> >
<TestTube className="w-4 h-4 text-brand-500" /> <TestTube className="w-4 h-4 text-brand-500" />
Skip automated testing by default Enable automated testing by default
</Label> </Label>
<p className="text-xs text-muted-foreground"> <p className="text-xs text-muted-foreground">
When enabled, new features will default to manual verification When enabled, new features will use TDD (test-driven
instead of TDD (test-driven development). You can still override development) with automated tests. When disabled, features will
this for individual features. require manual verification. You can still override this for
individual features.
</p> </p>
</div> </div>
</div> </div>

View File

@@ -540,7 +540,7 @@ const initialState: AppState = {
autoModeActivityLog: [], autoModeActivityLog: [],
maxConcurrency: 3, // Default to 3 concurrent agents maxConcurrency: 3, // Default to 3 concurrent agents
kanbanCardDetailLevel: "standard", // Default to standard detail level kanbanCardDetailLevel: "standard", // Default to standard detail level
defaultSkipTests: false, // Default to TDD mode (tests enabled) defaultSkipTests: true, // Default to manual verification (tests disabled)
useWorktrees: false, // Default to disabled (worktree feature is experimental) useWorktrees: false, // Default to disabled (worktree feature is experimental)
showProfilesOnly: false, // Default to showing all options (not profiles only) showProfilesOnly: false, // Default to showing all options (not profiles only)
keyboardShortcuts: DEFAULT_KEYBOARD_SHORTCUTS, // Default keyboard shortcuts keyboardShortcuts: DEFAULT_KEYBOARD_SHORTCUTS, // Default keyboard shortcuts