ros/automaker
1
0
Fork 0
mirror of https://github.com/AutoMaker-Org/automaker.git synced 2026-02-03 08:53:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: adress pr reviews suggestions

Browse Source
This commit is contained in:
Kacper
2025-12-24 00:18:46 +01:00
parent dbc21c8f73
commit e07fba13d8
1 changed files with 16 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
apps/server/src/routes/suggestions/generate-suggestions.ts
View File

@@ -14,6 +14,10 @@ const logger = createLogger('Suggestions');
/** /**
* Extract implemented features from app_spec.txt XML content * Extract implemented features from app_spec.txt XML content
*
* Note: This uses regex-based parsing which is sufficient for our controlled
* XML structure. If more complex XML parsing is needed in the future, consider
* using a library like 'fast-xml-parser' or 'xml2js'.
*/ */
function extractImplementedFeatures(specContent: string): string[] { function extractImplementedFeatures(specContent: string): string[] {
const features: string[] = []; const features: string[] = [];
@@ -26,11 +30,11 @@ function extractImplementedFeatures(specContent: string): string[] {
if (implementedMatch) { if (implementedMatch) {
const implementedSection = implementedMatch[1]; const implementedSection = implementedMatch[1];
// Extract feature names from <name>...</name> tags // Extract feature names from <name>...</name> tags using matchAll
const nameRegex = /<name>(.*?)<\/name>/g; const nameRegex = /<name>(.*?)<\/name>/g;
let match; const matches = implementedSection.matchAll(nameRegex);
while ((match = nameRegex.exec(implementedSection)) !== null) { for (const match of matches) {
features.push(match[1].trim()); features.push(match[1].trim());
} }
} }
@@ -55,9 +59,7 @@ async function loadExistingContext(projectPath: string): Promise<string> {
if (implementedFeatures.length > 0) { if (implementedFeatures.length > 0) {
context += '\n\n=== ALREADY IMPLEMENTED FEATURES ===\n'; context += '\n\n=== ALREADY IMPLEMENTED FEATURES ===\n';
context += 'These features are already implemented in the codebase:\n'; context += 'These features are already implemented in the codebase:\n';
implementedFeatures.forEach((feature) => { context += implementedFeatures.map((feature) => `- ${feature}`).join('\n') + '\n';
context += `- ${feature}\n`;
});
} }
} }
} catch (error) { } catch (error) {
@@ -73,11 +75,14 @@ async function loadExistingContext(projectPath: string): Promise<string> {
if (features.length > 0) { if (features.length > 0) {
context += '\n\n=== EXISTING FEATURES IN BACKLOG ===\n'; context += '\n\n=== EXISTING FEATURES IN BACKLOG ===\n';
context += 'These features are already planned or in progress:\n'; context += 'These features are already planned or in progress:\n';
features.forEach((feature) => { context +=
const status = feature.status || 'pending'; features
const title = feature.title || feature.description.substring(0, 50); .map((feature) => {
context += `- ${title} (${status})\n`; const status = feature.status || 'pending';
}); const title = feature.title || feature.description?.substring(0, 50) || 'Untitled';
return `- ${title} (${status})`;
})
.join('\n') + '\n';
} }
} catch (error) { } catch (error) {
// Features directory doesn't exist or can't be read - that's okay // Features directory doesn't exist or can't be read - that's okay