ros/automaker
1
0
Fork 0
mirror of https://github.com/AutoMaker-Org/automaker.git synced 2026-02-03 08:53:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: address PR review feedback for JSON fallback

Browse Source 
- Simplify escapeXml() using 'str == null' check (type narrowing)
- Add validation for extracted JSON before passing to specToXml()
- Prevents runtime errors when JSON doesn't match SpecOutput schema

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
Seonfx
2026-01-16 13:43:56 -04:00
parent bcec178bbe
commit d651e9d8d6
2 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
apps/server/src/lib/app-spec-format.ts
View File

@@ -14,10 +14,10 @@ export { specOutputSchema } from '@automaker/types';
* Handles undefined/null values by converting them to empty strings * Handles undefined/null values by converting them to empty strings
*/ */
function escapeXml(str: string | undefined | null): string { function escapeXml(str: string | undefined | null): string {
if (str === undefined || str === null) { if (str == null) {
return ''; return '';
} }
return String(str) return str
.replace(/&/g, '&amp;') .replace(/&/g, '&amp;')
.replace(/</g, '&lt;') .replace(/</g, '&lt;')
.replace(/>/g, '&gt;') .replace(/>/g, '&gt;')

9
apps/server/src/routes/app-spec/generate-spec.ts
View File

@@ -205,7 +205,14 @@ Your entire response should be valid JSON starting with { and ending with }. No
logger.warn('⚠️ No XML tags found, attempting JSON extraction...'); logger.warn('⚠️ No XML tags found, attempting JSON extraction...');
const extractedJson = extractJson<SpecOutput>(responseText, { logger }); const extractedJson = extractJson<SpecOutput>(responseText, { logger });
if (extractedJson) { if (
extractedJson &&
typeof extractedJson.project_name === 'string' &&
typeof extractedJson.overview === 'string' &&
Array.isArray(extractedJson.technology_stack) &&
Array.isArray(extractedJson.core_capabilities) &&
Array.isArray(extractedJson.implemented_features)
) {
logger.info('✅ Successfully extracted JSON from response text'); logger.info('✅ Successfully extracted JSON from response text');
xmlContent = specToXml(extractedJson); xmlContent = specToXml(extractedJson);
logger.info(`✅ Converted extracted JSON to XML: ${xmlContent.length} chars`); logger.info(`✅ Converted extracted JSON to XML: ${xmlContent.length} chars`);