ros/automaker
1
0
Fork 0
mirror of https://github.com/AutoMaker-Org/automaker.git synced 2026-01-31 20:03:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: improve code quality based on Gemini Code Assist suggestions

Browse Source 
Applied three code quality improvements suggested by Gemini Code Assist:

1. **Replace nested ternary with map object (enhance.ts)**
   - Changed nested ternary operator to Record<EnhancementMode, string> map
   - Improves readability and maintainability
   - More declarative approach for system prompt selection

2. **Simplify handleToggle logic (prompt-customization-section.tsx)**
   - Removed redundant if/else branches
   - Both branches were calculating the same value
   - Cleaner, more concise implementation

3. **Add type safety to updatePrompt with generics (prompt-customization-section.tsx)**
   - Changed field parameter from string to keyof NonNullable<PromptCustomization[T]>
   - Prevents runtime errors from misspelled field names
   - Improved developer experience with autocomplete

All tests passing (774/774). Builds successful.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This commit is contained in:
Stephan Rieche
2025-12-30 01:09:25 +01:00
parent e448d6d4e5
commit d5aea8355b
2 changed files with 14 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
apps/ui/src/components/views/settings-view/prompts/prompt-customization-section.tsx
View File

@@ -72,15 +72,10 @@ function PromptField({
const minHeight = calculateMinHeight(displayValue);
const handleToggle = (enabled: boolean) => {
if (enabled) {
// Enable custom mode - preserve existing custom value or initialize with default
const value = customValue?.value ?? defaultValue;
onCustomValueChange({ value, enabled: true });
} else {
// Disable custom mode - preserve custom value but mark as disabled
const value = customValue?.value ?? defaultValue;
onCustomValueChange({ value, enabled: false });
}
// When toggling, preserve the existing custom value if it exists,
// otherwise initialize with the default value.
const value = customValue?.value ?? defaultValue;
onCustomValueChange({ value, enabled });
};
const handleTextChange = (newValue: string) => {
@@ -148,9 +143,9 @@ export function PromptCustomizationSection({
}: PromptCustomizationSectionProps) {
const [activeTab, setActiveTab] = useState('auto-mode');
const updatePrompt = (
category: keyof PromptCustomization,
field: string,
const updatePrompt = <T extends keyof PromptCustomization>(
category: T,
field: keyof NonNullable<PromptCustomization[T]>,
value: CustomPrompt | undefined
) => {
const updated = {