From d58bd782ef207d4b55d156ae7b6889c35552b71c Mon Sep 17 00:00:00 2001 From: trueheads Date: Tue, 16 Dec 2025 22:09:24 -0600 Subject: [PATCH] adjustments per gemini suggestions --- .../components/views/board-view/components/kanban-card.tsx | 7 ------- apps/app/src/lib/dependency-resolver.ts | 6 +++++- apps/server/src/lib/dependency-resolver.ts | 6 +++++- 3 files changed, 10 insertions(+), 9 deletions(-) diff --git a/apps/app/src/components/views/board-view/components/kanban-card.tsx b/apps/app/src/components/views/board-view/components/kanban-card.tsx index 30fa9a65..d0348979 100644 --- a/apps/app/src/components/views/board-view/components/kanban-card.tsx +++ b/apps/app/src/components/views/board-view/components/kanban-card.tsx @@ -164,13 +164,6 @@ export const KanbanCard = memo(function KanbanCard({ return getBlockingDependencies(feature, features); }, [enableDependencyBlocking, feature, features]); - // Determine if a badge occupies the top-right position - const hasBadgeAtTopRight = useMemo(() => { - return feature.status === "backlog" && - !feature.error && - (feature.skipTests || blockingDependencies.length > 0); - }, [feature.status, feature.error, feature.skipTests, blockingDependencies.length]); - const showSteps = kanbanCardDetailLevel === "standard" || kanbanCardDetailLevel === "detailed"; diff --git a/apps/app/src/lib/dependency-resolver.ts b/apps/app/src/lib/dependency-resolver.ts index bf8812c7..8e7d1c98 100644 --- a/apps/app/src/lib/dependency-resolver.ts +++ b/apps/app/src/lib/dependency-resolver.ts @@ -92,7 +92,11 @@ export function resolveDependencies(features: Feature[]): DependencyResolutionRe // Process features that depend on this one for (const dependentId of adjacencyList.get(current.id) || []) { - const newDegree = (inDegree.get(dependentId) || 1) - 1; + const currentDegree = inDegree.get(dependentId); + if (currentDegree === undefined) { + throw new Error(`In-degree not initialized for feature ${dependentId}`); + } + const newDegree = currentDegree - 1; inDegree.set(dependentId, newDegree); if (newDegree === 0) { diff --git a/apps/server/src/lib/dependency-resolver.ts b/apps/server/src/lib/dependency-resolver.ts index e263d6da..784c621d 100644 --- a/apps/server/src/lib/dependency-resolver.ts +++ b/apps/server/src/lib/dependency-resolver.ts @@ -92,7 +92,11 @@ export function resolveDependencies(features: Feature[]): DependencyResolutionRe // Process features that depend on this one for (const dependentId of adjacencyList.get(current.id) || []) { - const newDegree = (inDegree.get(dependentId) || 1) - 1; + const currentDegree = inDegree.get(dependentId); + if (currentDegree === undefined) { + throw new Error(`In-degree not initialized for feature ${dependentId}`); + } + const newDegree = currentDegree - 1; inDegree.set(dependentId, newDegree); if (newDegree === 0) {