From d0b3e0d9bbc6fafd141ee84feee751a616ccf938 Mon Sep 17 00:00:00 2001 From: Shirone Date: Tue, 6 Jan 2026 01:53:08 +0100 Subject: [PATCH] refactor: move logger initialization outside of useCliStatus function - Moved the logger initialization to the top of the file for better readability and to avoid re-initialization on each function call. - This change enhances the performance and clarity of the code in the useCliStatus hook. - fix infinite loop calling caused by rerender because of logger --- apps/ui/src/components/views/setup-view/hooks/use-cli-status.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/ui/src/components/views/setup-view/hooks/use-cli-status.ts b/apps/ui/src/components/views/setup-view/hooks/use-cli-status.ts index 43c8a6f6..811f7719 100644 --- a/apps/ui/src/components/views/setup-view/hooks/use-cli-status.ts +++ b/apps/ui/src/components/views/setup-view/hooks/use-cli-status.ts @@ -7,6 +7,7 @@ interface UseCliStatusOptions { setCliStatus: (status: any) => void; setAuthStatus: (status: any) => void; } +const logger = createLogger('CliStatus'); export function useCliStatus({ cliType, @@ -15,7 +16,6 @@ export function useCliStatus({ setAuthStatus, }: UseCliStatusOptions) { const [isChecking, setIsChecking] = useState(false); - const logger = createLogger('CliStatus'); const checkStatus = useCallback(async () => { logger.info(`Starting status check for ${cliType}...`);