fix: Complete fix for plan mode system across all providers

Closes #671 (Complete fix for the plan mode system inside automaker)
Related: #619, #627, #531, #660

## Issues Fixed

### 1. Non-Claude Provider Support
- Removed Claude model restriction from planning mode UI selectors
- Added `detectSpecFallback()` function to detect specs without `[SPEC_GENERATED]` marker
- All providers (OpenAI, Gemini, Cursor, etc.) can now use spec and full planning modes
- Fallback detection looks for structural elements: tasks block, acceptance criteria,
  problem statement, implementation plan, etc.

### 2. Crash/Restart Recovery
- Added `resetStuckFeatures()` to clean up transient states on auto-mode start
- Features stuck in `in_progress` are reset to `ready` or `backlog`
- Tasks stuck in `in_progress` are reset to `pending`
- Plan generation stuck in `generating` is reset to `pending`
- `loadPendingFeatures()` now includes recovery cases for interrupted executions
- Persisted task status in `planSpec.tasks` array allows resuming from last completed task

### 3. Spec Todo List UI Updates
- Added `ParsedTask` and `PlanSpec` types to `@automaker/types` for consistent typing
- New `auto_mode_task_status` event emitted when task status changes
- New `auto_mode_summary` event emitted when summary is extracted
- Query invalidation triggers on task status updates for real-time UI refresh
- Task markers (`[TASK_START]`, `[TASK_COMPLETE]`, `[PHASE_COMPLETE]`) are detected
  and persisted to planSpec.tasks for UI display

### 4. Summary Extraction
- Added `extractSummary()` function to parse summaries from multiple formats:
  - `<summary>` tags (explicit)
  - `## Summary` sections (markdown)
  - `**Goal**:` sections (lite mode)
  - `**Problem**:` sections (spec/full modes)
  - `**Solution**:` sections (fallback)
- Summary is saved to `feature.summary` field after execution
- Summary is extracted from plan content during spec generation

### 5. Worktree Mode Support (#619)
- Recovery logic properly handles branchName filtering
- Features in worktrees maintain correct association during recovery

## Files Changed
- libs/types/src/feature.ts - Added ParsedTask and PlanSpec interfaces
- libs/types/src/index.ts - Export new types
- apps/server/src/services/auto-mode-service.ts - Core fixes for all issues
- apps/server/tests/unit/services/auto-mode-task-parsing.test.ts - New tests
- apps/ui/src/store/app-store.ts - Import types from @automaker/types
- apps/ui/src/hooks/use-auto-mode.ts - Handle new events
- apps/ui/src/hooks/use-query-invalidation.ts - Invalidate on task updates
- apps/ui/src/types/electron.d.ts - New event type definitions
- apps/ui/src/components/views/board-view/dialogs/*.tsx - Enable planning for all models

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Shirone
2026-01-24 17:58:04 +01:00
parent d8fa5c4cd1
commit cec5f91a86
12 changed files with 970 additions and 84 deletions

View File

@@ -36,7 +36,7 @@ import {
Feature,
} from '@/store/app-store';
import type { ReasoningEffort, PhaseModelEntry, AgentModel } from '@automaker/types';
import { supportsReasoningEffort, isClaudeModel } from '@automaker/types';
import { supportsReasoningEffort } from '@automaker/types';
import {
TestingTabContent,
PrioritySelector,
@@ -179,8 +179,8 @@ export function AddFeatureDialog({
// Model selection state
const [modelEntry, setModelEntry] = useState<PhaseModelEntry>({ model: 'claude-opus' });
// Check if current model supports planning mode (Claude/Anthropic only)
const modelSupportsPlanningMode = isClaudeModel(modelEntry.model);
// All models support planning mode via marker-based instructions in prompts
const modelSupportsPlanningMode = true;
// Planning mode state
const [planningMode, setPlanningMode] = useState<PlanningMode>('skip');

View File

@@ -43,7 +43,7 @@ import type { WorkMode } from '../shared';
import { PhaseModelSelector } from '@/components/views/settings-view/model-defaults/phase-model-selector';
import { Tooltip, TooltipContent, TooltipProvider, TooltipTrigger } from '@/components/ui/tooltip';
import { DependencyTreeDialog } from './dependency-tree-dialog';
import { isClaudeModel, supportsReasoningEffort } from '@automaker/types';
import { supportsReasoningEffort } from '@automaker/types';
const logger = createLogger('EditFeatureDialog');
@@ -119,8 +119,8 @@ export function EditFeatureDialog({
reasoningEffort: feature?.reasoningEffort || 'none',
}));
// Check if current model supports planning mode (Claude/Anthropic only)
const modelSupportsPlanningMode = isClaudeModel(modelEntry.model);
// All models support planning mode via marker-based instructions in prompts
const modelSupportsPlanningMode = true;
// Track the source of description changes for history
const [descriptionChangeSource, setDescriptionChangeSource] = useState<

View File

@@ -22,7 +22,7 @@ import {
} from '../shared';
import type { WorkMode } from '../shared';
import { PhaseModelSelector } from '@/components/views/settings-view/model-defaults/phase-model-selector';
import { isCursorModel, isClaudeModel, type PhaseModelEntry } from '@automaker/types';
import { isCursorModel, type PhaseModelEntry } from '@automaker/types';
import { cn } from '@/lib/utils';
import { Tooltip, TooltipContent, TooltipProvider, TooltipTrigger } from '@/components/ui/tooltip';
@@ -236,7 +236,8 @@ export function MassEditDialog({
const hasAnyApply = Object.values(applyState).some(Boolean);
const isCurrentModelCursor = isCursorModel(model);
const modelAllowsThinking = !isCurrentModelCursor && modelSupportsThinking(model);
const modelSupportsPlanningMode = isClaudeModel(model);
// All models support planning mode via marker-based instructions in prompts
const modelSupportsPlanningMode = true;
return (
<Dialog open={open} onOpenChange={(open) => !open && onClose()}>

View File

@@ -492,6 +492,33 @@ export function useAutoMode(worktree?: WorktreeInfo) {
});
}
break;
case 'auto_mode_task_status':
// Task status updated - update planSpec.tasks in real-time
if (event.featureId && 'taskId' in event && 'tasks' in event) {
const statusEvent = event as Extract<AutoModeEvent, { type: 'auto_mode_task_status' }>;
logger.debug(
`[AutoMode] Task ${statusEvent.taskId} status updated to ${statusEvent.status} for ${event.featureId}`
);
// The planSpec.tasks array update is handled by query invalidation
// which will refetch the feature data
}
break;
case 'auto_mode_summary':
// Summary extracted and saved
if (event.featureId && 'summary' in event) {
const summaryEvent = event as Extract<AutoModeEvent, { type: 'auto_mode_summary' }>;
logger.debug(
`[AutoMode] Summary saved for ${event.featureId}: ${summaryEvent.summary.substring(0, 100)}...`
);
addAutoModeActivity({
featureId: event.featureId,
type: 'progress',
message: `Summary: ${summaryEvent.summary.substring(0, 100)}...`,
});
}
break;
}
});

View File

@@ -141,11 +141,13 @@ export function useAutoModeQueryInvalidation(projectPath: string | undefined) {
});
}
// Invalidate specific feature when it starts or has phase changes
// Invalidate specific feature when it starts, has phase changes, or task status updates
if (
(event.type === 'auto_mode_feature_start' ||
event.type === 'auto_mode_phase' ||
event.type === 'auto_mode_phase_complete' ||
event.type === 'auto_mode_task_status' ||
event.type === 'auto_mode_summary' ||
event.type === 'pipeline_step_started') &&
'featureId' in event
) {

View File

@@ -37,6 +37,8 @@ import type {
ClaudeApiProfile,
ClaudeCompatibleProvider,
SidebarStyle,
ParsedTask,
PlanSpec,
} from '@automaker/types';
import {
getAllCursorModelIds,
@@ -65,6 +67,8 @@ export type {
ServerLogLevel,
FeatureTextFilePath,
FeatureImagePath,
ParsedTask,
PlanSpec,
};
export type ViewMode =
@@ -469,28 +473,7 @@ export interface Feature extends Omit<
planSpec?: PlanSpec; // Explicit planSpec type to override BaseFeature's index signature
}
// Parsed task from spec (for spec and full planning modes)
export interface ParsedTask {
id: string; // e.g., "T001"
description: string; // e.g., "Create user model"
filePath?: string; // e.g., "src/models/user.ts"
phase?: string; // e.g., "Phase 1: Foundation" (for full mode)
status: 'pending' | 'in_progress' | 'completed' | 'failed';
}
// PlanSpec status for feature planning/specification
export interface PlanSpec {
status: 'pending' | 'generating' | 'generated' | 'approved' | 'rejected';
content?: string; // The actual spec/plan markdown content
version: number;
generatedAt?: string; // ISO timestamp
approvedAt?: string; // ISO timestamp
reviewedByUser: boolean; // True if user has seen the spec
tasksCompleted?: number;
tasksTotal?: number;
currentTaskId?: string; // ID of the task currently being worked on
tasks?: ParsedTask[]; // Parsed tasks from the spec
}
// ParsedTask and PlanSpec types are now imported from @automaker/types
// File tree node for project analysis
export interface FileTreeNode {

View File

@@ -334,6 +334,26 @@ export type AutoModeEvent =
projectPath?: string;
phaseNumber: number;
}
| {
type: 'auto_mode_task_status';
featureId: string;
projectPath?: string;
taskId: string;
status: 'pending' | 'in_progress' | 'completed' | 'failed';
tasks: Array<{
id: string;
description: string;
filePath?: string;
phase?: string;
status: 'pending' | 'in_progress' | 'completed' | 'failed';
}>;
}
| {
type: 'auto_mode_summary';
featureId: string;
projectPath?: string;
summary: string;
}
| {
type: 'auto_mode_resuming_features';
message: string;

View File

@@ -0,0 +1,131 @@
/**
* Planning Mode Fix Verification E2E Test
*
* Verifies GitHub issue #671 fixes:
* 1. Planning mode selector is enabled for all models (not restricted to Claude)
* 2. All planning mode options are accessible
*/
import { test, expect } from '@playwright/test';
import * as fs from 'fs';
import * as path from 'path';
import {
createTempDirPath,
cleanupTempDir,
setupRealProject,
waitForNetworkIdle,
clickAddFeature,
authenticateForTests,
handleLoginScreenIfPresent,
} from '../utils';
const TEST_TEMP_DIR = createTempDirPath('planning-mode-verification-test');
test.describe('Planning Mode Fix Verification (GitHub #671)', () => {
let projectPath: string;
const projectName = `test-project-${Date.now()}`;
test.beforeAll(async () => {
if (!fs.existsSync(TEST_TEMP_DIR)) {
fs.mkdirSync(TEST_TEMP_DIR, { recursive: true });
}
projectPath = path.join(TEST_TEMP_DIR, projectName);
fs.mkdirSync(projectPath, { recursive: true });
fs.writeFileSync(
path.join(projectPath, 'package.json'),
JSON.stringify({ name: projectName, version: '1.0.0' }, null, 2)
);
const automakerDir = path.join(projectPath, '.automaker');
fs.mkdirSync(automakerDir, { recursive: true });
fs.mkdirSync(path.join(automakerDir, 'features'), { recursive: true });
fs.mkdirSync(path.join(automakerDir, 'context'), { recursive: true });
fs.writeFileSync(
path.join(automakerDir, 'categories.json'),
JSON.stringify({ categories: [] }, null, 2)
);
fs.writeFileSync(
path.join(automakerDir, 'app_spec.txt'),
`# ${projectName}\n\nA test project for planning mode verification.`
);
});
test.afterAll(async () => {
cleanupTempDir(TEST_TEMP_DIR);
});
test('planning mode selector should be enabled and accessible in add feature dialog', async ({
page,
}) => {
await setupRealProject(page, projectPath, projectName, { setAsCurrent: true });
await authenticateForTests(page);
await page.goto('/board');
await page.waitForLoadState('load');
await handleLoginScreenIfPresent(page);
await waitForNetworkIdle(page);
await expect(page.locator('[data-testid="board-view"]')).toBeVisible({ timeout: 10000 });
await expect(page.locator('[data-testid="kanban-column-backlog"]')).toBeVisible({
timeout: 5000,
});
// Open the add feature dialog
await clickAddFeature(page);
// Wait for dialog to be visible
await expect(page.locator('[data-testid="add-feature-dialog"]')).toBeVisible({
timeout: 5000,
});
// Find the planning mode select trigger
const planningModeSelectTrigger = page.locator(
'[data-testid="add-feature-planning-select-trigger"]'
);
// Verify the planning mode selector is visible
await expect(planningModeSelectTrigger).toBeVisible({ timeout: 5000 });
// Verify the planning mode selector is NOT disabled
// This is the key check for GitHub #671 - planning mode should be enabled for all models
await expect(planningModeSelectTrigger).not.toBeDisabled();
// Click the trigger to open the dropdown
await planningModeSelectTrigger.click();
// Wait for dropdown to open
await page.waitForTimeout(300);
// Verify all planning mode options are visible
const skipOption = page.locator('[data-testid="add-feature-planning-option-skip"]');
const liteOption = page.locator('[data-testid="add-feature-planning-option-lite"]');
const specOption = page.locator('[data-testid="add-feature-planning-option-spec"]');
const fullOption = page.locator('[data-testid="add-feature-planning-option-full"]');
await expect(skipOption).toBeVisible({ timeout: 3000 });
await expect(liteOption).toBeVisible({ timeout: 3000 });
await expect(specOption).toBeVisible({ timeout: 3000 });
await expect(fullOption).toBeVisible({ timeout: 3000 });
// Select 'spec' mode to verify interaction works
await specOption.click();
await page.waitForTimeout(200);
// Verify the selection changed (the trigger should now show "Spec")
await expect(planningModeSelectTrigger).toContainText('Spec');
// Check that require approval checkbox appears for spec/full modes
const requireApprovalCheckbox = page.locator(
'[data-testid="add-feature-planning-require-approval-checkbox"]'
);
await expect(requireApprovalCheckbox).toBeVisible({ timeout: 3000 });
await expect(requireApprovalCheckbox).not.toBeDisabled();
// Close the dialog
await page.keyboard.press('Escape');
});
});