ros/automaker
1
0
Fork 0
mirror of https://github.com/AutoMaker-Org/automaker.git synced 2026-02-04 09:13:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: enhance spec editor tests by utilizing utility functions

Browse Source 
- Replaced direct element selectors with utility functions for improved readability and maintainability in spec editor tests.
- Streamlined waiting mechanisms by using the new waitForElement function, enhancing test reliability.
- Updated test cases to ensure consistent handling of element visibility and initialization, resulting in more efficient and clearer tests.
This commit is contained in:
Kacper
2025-12-15 02:52:02 +01:00
parent caae869501
commit c0e0f8d214
1 changed files with 11 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
apps/app/tests/spec-editor-persistence.spec.ts
View File

@@ -11,6 +11,7 @@ import {
clickElement, clickElement,
fillInput, fillInput,
waitForNetworkIdle, waitForNetworkIdle,
waitForElement,
} from "./utils"; } from "./utils";
test.describe("Spec Editor Persistence", () => { test.describe("Spec Editor Persistence", () => {
@@ -50,9 +51,7 @@ test.describe("Spec Editor Persistence", () => {
await specEditor.waitFor({ state: "visible", timeout: 10000 }); await specEditor.waitFor({ state: "visible", timeout: 10000 });
// Step 6: Wait for CodeMirror to initialize (it has a .cm-content element) // Step 6: Wait for CodeMirror to initialize (it has a .cm-content element)
await page.waitForSelector('[data-testid="spec-editor"] .cm-content', { await specEditor.locator(".cm-content").waitFor({ state: "visible", timeout: 10000 });
timeout: 10000,
});
// Small delay to ensure editor is fully initialized // Small delay to ensure editor is fully initialized
await page.waitForTimeout(500); await page.waitForTimeout(500);
@@ -69,15 +68,14 @@ test.describe("Spec Editor Persistence", () => {
// Step 10: Navigate back to the spec editor // Step 10: Navigate back to the spec editor
// After reload, we need to wait for the app to initialize // After reload, we need to wait for the app to initialize
await page.waitForSelector('[data-testid="sidebar"]', { timeout: 10000 }); await waitForElement(page, "sidebar", { timeout: 10000 });
// Navigate to spec editor again // Navigate to spec editor again
await navigateToSpecEditor(page); await navigateToSpecEditor(page);
// Wait for CodeMirror to be ready // Wait for CodeMirror to be ready
await page.waitForSelector('[data-testid="spec-editor"] .cm-content', { const specEditorAfterReload = await getByTestId(page, "spec-editor");
timeout: 10000, await specEditorAfterReload.locator(".cm-content").waitFor({ state: "visible", timeout: 10000 });
});
// Small delay to ensure editor content is loaded // Small delay to ensure editor content is loaded
await page.waitForTimeout(500); await page.waitForTimeout(500);
@@ -239,7 +237,7 @@ test.describe("Spec Editor - Full Open Project Flow", () => {
await waitForNetworkIdle(page); await waitForNetworkIdle(page);
// Wait for sidebar // Wait for sidebar
await page.waitForSelector('[data-testid="sidebar"]', { timeout: 10000 }); await waitForElement(page, "sidebar", { timeout: 10000 });
// Click the Open Project button // Click the Open Project button
const openProjectButton = await getByTestId(page, "open-project-button"); const openProjectButton = await getByTestId(page, "open-project-button");
@@ -295,10 +293,9 @@ test.describe("Spec Editor - Full Open Project Flow", () => {
await clickElement(page, "nav-spec"); await clickElement(page, "nav-spec");
// Wait for spec view with the editor (not the empty state) // Wait for spec view with the editor (not the empty state)
await page.waitForSelector('[data-testid="spec-view"]', { timeout: 10000 }); await waitForElement(page, "spec-view", { timeout: 10000 });
await page.waitForSelector('[data-testid="spec-editor"] .cm-content', { const specEditorForOpenFlow = await getByTestId(page, "spec-editor");
timeout: 10000, await specEditorForOpenFlow.locator(".cm-content").waitFor({ state: "visible", timeout: 10000 });
});
await page.waitForTimeout(500); await page.waitForTimeout(500);
// Edit the content // Edit the content
@@ -315,9 +312,8 @@ test.describe("Spec Editor - Full Open Project Flow", () => {
await specNav.waitFor({ state: "visible", timeout: 10000 }); await specNav.waitFor({ state: "visible", timeout: 10000 });
await clickElement(page, "nav-spec"); await clickElement(page, "nav-spec");
await page.waitForSelector('[data-testid="spec-editor"] .cm-content', { const specEditorAfterRefresh = await getByTestId(page, "spec-editor");
timeout: 10000, await specEditorAfterRefresh.locator(".cm-content").waitFor({ state: "visible", timeout: 10000 });
});
await page.waitForTimeout(500); await page.waitForTimeout(500);
// Verify the content persisted // Verify the content persisted