fix: clarify sandbox mode behavior in sdk-options

- Updated the checkSandboxCompatibility function to explicitly handle the case when enableSandboxMode is set to false, ensuring clearer logic for sandbox mode activation.
- Adjusted unit tests to reflect the new behavior, confirming that sandbox mode defaults to enabled when not specified and correctly disables for cloud storage paths.
- Enhanced test descriptions for better clarity on expected outcomes in various scenarios.
This commit is contained in:
webdevcody
2026-01-01 02:39:38 -05:00
parent 67c6c9a9e7
commit b51aed849c
2 changed files with 36 additions and 10 deletions

View File

@@ -147,15 +147,15 @@ export function checkSandboxCompatibility(
cwd: string,
enableSandboxMode?: boolean
): SandboxCheckResult {
// User has disabled sandbox mode
if (!enableSandboxMode) {
// User has explicitly disabled sandbox mode
if (enableSandboxMode === false) {
return {
enabled: false,
disabledReason: 'user_setting',
};
}
// Check for cloud storage incompatibility
// Check for cloud storage incompatibility (applies when enabled or undefined)
if (isCloudStoragePath(cwd)) {
return {
enabled: false,
@@ -164,7 +164,7 @@ export function checkSandboxCompatibility(
};
}
// Sandbox is compatible and enabled
// Sandbox is compatible and enabled (true or undefined defaults to enabled)
return {
enabled: true,
};