From a6190f71b3b9525ac4fa0931a36717384c2ceaa2 Mon Sep 17 00:00:00 2001 From: Shirone Date: Sat, 24 Jan 2026 15:48:46 +0100 Subject: [PATCH] refactor: Use Set for button variant lookup and improve undefined handling --- apps/ui/src/components/ui/button.tsx | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/apps/ui/src/components/ui/button.tsx b/apps/ui/src/components/ui/button.tsx index bce53665..683d1237 100644 --- a/apps/ui/src/components/ui/button.tsx +++ b/apps/ui/src/components/ui/button.tsx @@ -38,14 +38,14 @@ const buttonVariants = cva( ); /** Button variants that have colored backgrounds requiring foreground spinner color */ -const COLORED_BACKGROUND_VARIANTS = ['default', 'destructive'] as const; +const COLORED_BACKGROUND_VARIANTS = new Set(['default', 'destructive']); /** Get spinner variant based on button variant - use foreground for colored backgrounds */ function getSpinnerVariant( buttonVariant: VariantProps['variant'] ): SpinnerVariant { - // undefined defaults to 'default' variant which has a colored background - if (!buttonVariant || COLORED_BACKGROUND_VARIANTS.includes(buttonVariant as any)) { + const variant = buttonVariant ?? 'default'; + if (COLORED_BACKGROUND_VARIANTS.has(variant)) { return 'foreground'; } // outline, secondary, ghost, link, animated-outline use standard backgrounds