mirror of
https://github.com/AutoMaker-Org/automaker.git
synced 2026-02-02 08:33:36 +00:00
feat: Claude Compatible Providers System (#629)
* feat: refactor Claude API Profiles to Claude Compatible Providers
- Rename ClaudeApiProfile to ClaudeCompatibleProvider with models[] array
- Each ProviderModel has mapsToClaudeModel field for Claude tier mapping
- Add providerType field for provider-specific icons (glm, minimax, openrouter)
- Add thinking level support for provider models in phase selectors
- Show all mapped Claude models per provider model (e.g., "Maps to Haiku, Sonnet, Opus")
- Add Bulk Replace feature to switch all phases to a provider at once
- Hide Bulk Replace button when no providers are enabled
- Fix project-level phaseModelOverrides not persisting after refresh
- Fix deleting last provider not persisting (remove empty array guard)
- Add getProviderByModelId() helper for all SDK routes
- Update all routes to pass provider config for provider models
- Update terminology from "profiles" to "providers" throughout UI
- Update documentation to reflect new provider system
* fix: atomic writer race condition and bulk replace reset to defaults
1. AtomicWriter Race Condition Fix (libs/utils/src/atomic-writer.ts):
- Changed temp file naming from Date.now() to Date.now() + random hex
- Uses crypto.randomBytes(4).toString('hex') for uniqueness
- Prevents ENOENT errors when multiple concurrent writes happen
within the same millisecond
2. Bulk Replace "Anthropic Direct" Reset (both dialogs):
- When selecting "Anthropic Direct", now uses DEFAULT_PHASE_MODELS
- Properly resets thinking levels and other settings to defaults
- Added thinkingLevel to the change detection comparison
- Affects both global and project-level bulk replace dialogs
* fix: update tests for new model resolver passthrough behavior
1. model-resolver tests:
- Unknown models now pass through unchanged (provider model support)
- Removed expectations for warnings on unknown models
- Updated case sensitivity and edge case tests accordingly
- Added tests for provider-like model names (GLM-4.7, MiniMax-M2.1)
2. atomic-writer tests:
- Updated regex to match new temp file format with random suffix
- Format changed from .tmp.{timestamp} to .tmp.{timestamp}.{hex}
* refactor: simplify getPhaseModelWithOverrides calls per code review
Address code review feedback on PR #629:
- Make settingsService parameter optional in getPhaseModelWithOverrides
- Function now handles undefined settingsService gracefully by returning defaults
- Remove redundant ternary checks in 4 call sites:
- apps/server/src/routes/context/routes/describe-file.ts
- apps/server/src/routes/context/routes/describe-image.ts
- apps/server/src/routes/worktree/routes/generate-commit-message.ts
- apps/server/src/services/auto-mode-service.ts
- Remove unused DEFAULT_PHASE_MODELS imports where applicable
* test: fix server tests for provider model passthrough behavior
- Update model-resolver.test.ts to expect unknown models to pass through
unchanged (supports ClaudeCompatibleProvider models like GLM-4.7)
- Remove warning expectations for unknown models (valid for providers)
- Add missing getCredentials and getGlobalSettings mocks to
ideation-service.test.ts for settingsService
* fix: address code review feedback for model providers
- Honor thinkingLevel in generate-commit-message.ts
- Pass claudeCompatibleProvider in ideation-service.ts for provider models
- Resolve provider configuration for model overrides in generate-suggestions.ts
- Update "Active Profile" to "Active Provider" label in project-claude-section
- Use substring instead of deprecated substr in api-profiles-section
- Preserve provider enabled state when editing in api-profiles-section
* fix: address CodeRabbit review issues for Claude Compatible Providers
- Fix TypeScript TS2339 error in generate-suggestions.ts where
settingsService was narrowed to 'never' type in else branch
- Use DEFAULT_PHASE_MODELS per-phase defaults instead of hardcoded
'sonnet' in settings-helpers.ts
- Remove duplicate eventHooks key in use-settings-migration.ts
- Add claudeCompatibleProviders to localStorage migration parsing
and merging functions
- Handle canonical claude-* model IDs (claude-haiku, claude-sonnet,
claude-opus) in project-models-section display names
This resolves the CI build failures and addresses code review feedback.
* fix: skip broken list-view-priority E2E test and add Priority column label
- Skip list-view-priority.spec.ts with TODO explaining the infrastructure
issue: setupRealProject only sets localStorage but server settings
take precedence with localStorageMigrated: true
- Add 'Priority' label to list-header.tsx for the priority column
(was empty string, now shows proper header text)
- Increase column width to accommodate the label
The E2E test issue is that tests create features in a temp directory,
but the server loads from the E2E Test Project fixture path set in
setup-e2e-fixtures.mjs. Needs infrastructure fix to properly switch
projects or create features through UI instead of on disk.
This commit is contained in:
committed by
GitHub
parent
8facdc66a9
commit
a1f234c7e2
@@ -0,0 +1,343 @@
|
||||
import { useState, useMemo } from 'react';
|
||||
import { useAppStore } from '@/store/app-store';
|
||||
import { Button } from '@/components/ui/button';
|
||||
import {
|
||||
Dialog,
|
||||
DialogContent,
|
||||
DialogDescription,
|
||||
DialogFooter,
|
||||
DialogHeader,
|
||||
DialogTitle,
|
||||
} from '@/components/ui/dialog';
|
||||
import {
|
||||
Select,
|
||||
SelectContent,
|
||||
SelectItem,
|
||||
SelectTrigger,
|
||||
SelectValue,
|
||||
} from '@/components/ui/select';
|
||||
import { ArrowRight, Cloud, Server, Check, AlertCircle } from 'lucide-react';
|
||||
import { cn } from '@/lib/utils';
|
||||
import type {
|
||||
PhaseModelKey,
|
||||
PhaseModelEntry,
|
||||
ClaudeCompatibleProvider,
|
||||
ClaudeModelAlias,
|
||||
} from '@automaker/types';
|
||||
import { DEFAULT_PHASE_MODELS } from '@automaker/types';
|
||||
|
||||
interface BulkReplaceDialogProps {
|
||||
open: boolean;
|
||||
onOpenChange: (open: boolean) => void;
|
||||
}
|
||||
|
||||
// Phase display names for preview
|
||||
const PHASE_LABELS: Record<PhaseModelKey, string> = {
|
||||
enhancementModel: 'Feature Enhancement',
|
||||
fileDescriptionModel: 'File Descriptions',
|
||||
imageDescriptionModel: 'Image Descriptions',
|
||||
commitMessageModel: 'Commit Messages',
|
||||
validationModel: 'GitHub Issue Validation',
|
||||
specGenerationModel: 'App Specification',
|
||||
featureGenerationModel: 'Feature Generation',
|
||||
backlogPlanningModel: 'Backlog Planning',
|
||||
projectAnalysisModel: 'Project Analysis',
|
||||
suggestionsModel: 'AI Suggestions',
|
||||
memoryExtractionModel: 'Memory Extraction',
|
||||
};
|
||||
|
||||
const ALL_PHASES = Object.keys(PHASE_LABELS) as PhaseModelKey[];
|
||||
|
||||
// Claude model display names
|
||||
const CLAUDE_MODEL_DISPLAY: Record<ClaudeModelAlias, string> = {
|
||||
haiku: 'Claude Haiku',
|
||||
sonnet: 'Claude Sonnet',
|
||||
opus: 'Claude Opus',
|
||||
};
|
||||
|
||||
export function BulkReplaceDialog({ open, onOpenChange }: BulkReplaceDialogProps) {
|
||||
const { phaseModels, setPhaseModel, claudeCompatibleProviders } = useAppStore();
|
||||
const [selectedProvider, setSelectedProvider] = useState<string>('anthropic');
|
||||
|
||||
// Get enabled providers
|
||||
const enabledProviders = useMemo(() => {
|
||||
return (claudeCompatibleProviders || []).filter((p) => p.enabled !== false);
|
||||
}, [claudeCompatibleProviders]);
|
||||
|
||||
// Build provider options for the dropdown
|
||||
const providerOptions = useMemo(() => {
|
||||
const options: Array<{ id: string; name: string; isNative: boolean }> = [
|
||||
{ id: 'anthropic', name: 'Anthropic Direct', isNative: true },
|
||||
];
|
||||
|
||||
enabledProviders.forEach((provider) => {
|
||||
options.push({
|
||||
id: provider.id,
|
||||
name: provider.name,
|
||||
isNative: false,
|
||||
});
|
||||
});
|
||||
|
||||
return options;
|
||||
}, [enabledProviders]);
|
||||
|
||||
// Get the selected provider config (if custom)
|
||||
const selectedProviderConfig = useMemo(() => {
|
||||
if (selectedProvider === 'anthropic') return null;
|
||||
return enabledProviders.find((p) => p.id === selectedProvider);
|
||||
}, [selectedProvider, enabledProviders]);
|
||||
|
||||
// Get the Claude model alias from a PhaseModelEntry
|
||||
const getClaudeModelAlias = (entry: PhaseModelEntry): ClaudeModelAlias => {
|
||||
// Check if model string directly matches a Claude alias
|
||||
if (entry.model === 'haiku' || entry.model === 'claude-haiku') return 'haiku';
|
||||
if (entry.model === 'sonnet' || entry.model === 'claude-sonnet') return 'sonnet';
|
||||
if (entry.model === 'opus' || entry.model === 'claude-opus') return 'opus';
|
||||
|
||||
// If it's a provider model, look up the mapping
|
||||
if (entry.providerId) {
|
||||
const provider = enabledProviders.find((p) => p.id === entry.providerId);
|
||||
if (provider) {
|
||||
const model = provider.models?.find((m) => m.id === entry.model);
|
||||
if (model?.mapsToClaudeModel) {
|
||||
return model.mapsToClaudeModel;
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
// Default to sonnet
|
||||
return 'sonnet';
|
||||
};
|
||||
|
||||
// Find the model from provider that maps to a specific Claude model
|
||||
const findModelForClaudeAlias = (
|
||||
provider: ClaudeCompatibleProvider | null,
|
||||
claudeAlias: ClaudeModelAlias,
|
||||
phase: PhaseModelKey
|
||||
): PhaseModelEntry => {
|
||||
if (!provider) {
|
||||
// Anthropic Direct - reset to default phase model (includes correct thinking levels)
|
||||
return DEFAULT_PHASE_MODELS[phase];
|
||||
}
|
||||
|
||||
// Find model that maps to this Claude alias
|
||||
const models = provider.models || [];
|
||||
const match = models.find((m) => m.mapsToClaudeModel === claudeAlias);
|
||||
|
||||
if (match) {
|
||||
return { providerId: provider.id, model: match.id };
|
||||
}
|
||||
|
||||
// Fallback: use first model if no match
|
||||
if (models.length > 0) {
|
||||
return { providerId: provider.id, model: models[0].id };
|
||||
}
|
||||
|
||||
// Ultimate fallback to native Claude model
|
||||
return { model: claudeAlias };
|
||||
};
|
||||
|
||||
// Generate preview of changes
|
||||
const preview = useMemo(() => {
|
||||
return ALL_PHASES.map((phase) => {
|
||||
const currentEntry = phaseModels[phase] ?? DEFAULT_PHASE_MODELS[phase];
|
||||
const claudeAlias = getClaudeModelAlias(currentEntry);
|
||||
const newEntry = findModelForClaudeAlias(selectedProviderConfig, claudeAlias, phase);
|
||||
|
||||
// Get display names
|
||||
const getCurrentDisplay = (): string => {
|
||||
if (currentEntry.providerId) {
|
||||
const provider = enabledProviders.find((p) => p.id === currentEntry.providerId);
|
||||
if (provider) {
|
||||
const model = provider.models?.find((m) => m.id === currentEntry.model);
|
||||
return model?.displayName || currentEntry.model;
|
||||
}
|
||||
}
|
||||
return CLAUDE_MODEL_DISPLAY[claudeAlias] || currentEntry.model;
|
||||
};
|
||||
|
||||
const getNewDisplay = (): string => {
|
||||
if (newEntry.providerId && selectedProviderConfig) {
|
||||
const model = selectedProviderConfig.models?.find((m) => m.id === newEntry.model);
|
||||
return model?.displayName || newEntry.model;
|
||||
}
|
||||
return CLAUDE_MODEL_DISPLAY[newEntry.model as ClaudeModelAlias] || newEntry.model;
|
||||
};
|
||||
|
||||
const isChanged =
|
||||
currentEntry.model !== newEntry.model ||
|
||||
currentEntry.providerId !== newEntry.providerId ||
|
||||
currentEntry.thinkingLevel !== newEntry.thinkingLevel;
|
||||
|
||||
return {
|
||||
phase,
|
||||
label: PHASE_LABELS[phase],
|
||||
claudeAlias,
|
||||
currentDisplay: getCurrentDisplay(),
|
||||
newDisplay: getNewDisplay(),
|
||||
newEntry,
|
||||
isChanged,
|
||||
};
|
||||
});
|
||||
}, [phaseModels, selectedProviderConfig, enabledProviders]);
|
||||
|
||||
// Count how many will change
|
||||
const changeCount = preview.filter((p) => p.isChanged).length;
|
||||
|
||||
// Apply the bulk replace
|
||||
const handleApply = () => {
|
||||
preview.forEach(({ phase, newEntry, isChanged }) => {
|
||||
if (isChanged) {
|
||||
setPhaseModel(phase, newEntry);
|
||||
}
|
||||
});
|
||||
onOpenChange(false);
|
||||
};
|
||||
|
||||
// Check if provider has all 3 Claude model mappings
|
||||
const providerModelCoverage = useMemo(() => {
|
||||
if (selectedProvider === 'anthropic') {
|
||||
return { hasHaiku: true, hasSonnet: true, hasOpus: true, complete: true };
|
||||
}
|
||||
if (!selectedProviderConfig) {
|
||||
return { hasHaiku: false, hasSonnet: false, hasOpus: false, complete: false };
|
||||
}
|
||||
const models = selectedProviderConfig.models || [];
|
||||
const hasHaiku = models.some((m) => m.mapsToClaudeModel === 'haiku');
|
||||
const hasSonnet = models.some((m) => m.mapsToClaudeModel === 'sonnet');
|
||||
const hasOpus = models.some((m) => m.mapsToClaudeModel === 'opus');
|
||||
return { hasHaiku, hasSonnet, hasOpus, complete: hasHaiku && hasSonnet && hasOpus };
|
||||
}, [selectedProvider, selectedProviderConfig]);
|
||||
|
||||
const providerHasModels =
|
||||
selectedProvider === 'anthropic' ||
|
||||
(selectedProviderConfig && selectedProviderConfig.models?.length > 0);
|
||||
|
||||
return (
|
||||
<Dialog open={open} onOpenChange={onOpenChange}>
|
||||
<DialogContent className="max-w-2xl max-h-[80vh] flex flex-col">
|
||||
<DialogHeader>
|
||||
<DialogTitle>Bulk Replace Models</DialogTitle>
|
||||
<DialogDescription>
|
||||
Switch all phase models to equivalents from a specific provider. Models are matched by
|
||||
their Claude model mapping (Haiku, Sonnet, Opus).
|
||||
</DialogDescription>
|
||||
</DialogHeader>
|
||||
|
||||
<div className="space-y-6 py-4">
|
||||
{/* Provider selector */}
|
||||
<div className="space-y-2">
|
||||
<label className="text-sm font-medium">Target Provider</label>
|
||||
<Select value={selectedProvider} onValueChange={setSelectedProvider}>
|
||||
<SelectTrigger className="w-full">
|
||||
<SelectValue placeholder="Select provider" />
|
||||
</SelectTrigger>
|
||||
<SelectContent>
|
||||
{providerOptions.map((option) => (
|
||||
<SelectItem key={option.id} value={option.id}>
|
||||
<div className="flex items-center gap-2">
|
||||
{option.isNative ? (
|
||||
<Cloud className="w-4 h-4 text-brand-500" />
|
||||
) : (
|
||||
<Server className="w-4 h-4 text-muted-foreground" />
|
||||
)}
|
||||
<span>{option.name}</span>
|
||||
</div>
|
||||
</SelectItem>
|
||||
))}
|
||||
</SelectContent>
|
||||
</Select>
|
||||
</div>
|
||||
|
||||
{/* Warning if provider has no models */}
|
||||
{!providerHasModels && (
|
||||
<div className="p-3 rounded-lg bg-yellow-500/10 border border-yellow-500/20 text-sm">
|
||||
<div className="flex items-center gap-2 text-yellow-600 dark:text-yellow-400">
|
||||
<AlertCircle className="w-4 h-4" />
|
||||
<span>This provider has no models configured.</span>
|
||||
</div>
|
||||
</div>
|
||||
)}
|
||||
|
||||
{/* Warning if provider doesn't have all 3 mappings */}
|
||||
{providerHasModels && !providerModelCoverage.complete && (
|
||||
<div className="p-3 rounded-lg bg-yellow-500/10 border border-yellow-500/20 text-sm">
|
||||
<div className="flex items-center gap-2 text-yellow-600 dark:text-yellow-400">
|
||||
<AlertCircle className="w-4 h-4" />
|
||||
<span>
|
||||
This provider is missing mappings for:{' '}
|
||||
{[
|
||||
!providerModelCoverage.hasHaiku && 'Haiku',
|
||||
!providerModelCoverage.hasSonnet && 'Sonnet',
|
||||
!providerModelCoverage.hasOpus && 'Opus',
|
||||
]
|
||||
.filter(Boolean)
|
||||
.join(', ')}
|
||||
</span>
|
||||
</div>
|
||||
</div>
|
||||
)}
|
||||
|
||||
{/* Preview of changes */}
|
||||
{providerHasModels && (
|
||||
<div className="space-y-2">
|
||||
<div className="flex items-center justify-between">
|
||||
<label className="text-sm font-medium">Preview Changes</label>
|
||||
<span className="text-xs text-muted-foreground">
|
||||
{changeCount} of {ALL_PHASES.length} will change
|
||||
</span>
|
||||
</div>
|
||||
<div className="border rounded-lg overflow-hidden max-h-[300px] overflow-y-auto">
|
||||
<table className="w-full text-sm">
|
||||
<thead className="bg-muted/50 sticky top-0">
|
||||
<tr>
|
||||
<th className="text-left p-2 font-medium text-muted-foreground">Phase</th>
|
||||
<th className="text-left p-2 font-medium text-muted-foreground">Current</th>
|
||||
<th className="p-2"></th>
|
||||
<th className="text-left p-2 font-medium text-muted-foreground">New</th>
|
||||
</tr>
|
||||
</thead>
|
||||
<tbody>
|
||||
{preview.map(({ phase, label, currentDisplay, newDisplay, isChanged }) => (
|
||||
<tr
|
||||
key={phase}
|
||||
className={cn(
|
||||
'border-t border-border/50',
|
||||
isChanged ? 'bg-brand-500/5' : 'opacity-50'
|
||||
)}
|
||||
>
|
||||
<td className="p-2 font-medium">{label}</td>
|
||||
<td className="p-2 text-muted-foreground">{currentDisplay}</td>
|
||||
<td className="p-2 text-center">
|
||||
{isChanged ? (
|
||||
<ArrowRight className="w-4 h-4 text-brand-500 inline" />
|
||||
) : (
|
||||
<Check className="w-4 h-4 text-green-500 inline" />
|
||||
)}
|
||||
</td>
|
||||
<td className="p-2">
|
||||
<span className={cn(isChanged && 'text-brand-500 font-medium')}>
|
||||
{newDisplay}
|
||||
</span>
|
||||
</td>
|
||||
</tr>
|
||||
))}
|
||||
</tbody>
|
||||
</table>
|
||||
</div>
|
||||
</div>
|
||||
)}
|
||||
</div>
|
||||
|
||||
<DialogFooter>
|
||||
<Button variant="outline" onClick={() => onOpenChange(false)}>
|
||||
Cancel
|
||||
</Button>
|
||||
<Button onClick={handleApply} disabled={!providerHasModels || changeCount === 0}>
|
||||
Apply Changes ({changeCount})
|
||||
</Button>
|
||||
</DialogFooter>
|
||||
</DialogContent>
|
||||
</Dialog>
|
||||
);
|
||||
}
|
||||
Reference in New Issue
Block a user