From 980006d40efcd1c3f98a8bbb2505c541b8cc136e Mon Sep 17 00:00:00 2001 From: DhanushSantosh Date: Sun, 18 Jan 2026 19:06:07 +0530 Subject: [PATCH] fix: use setItem helper and safer Playwright selector in tests - Replace direct localStorage.setItem() with setItem helper in use-settings-migration.ts (line 472) for consistent storage-availability checks and error handling - Replace brittle attribute selector with Playwright's getByRole in open-existing-project.spec.ts (line 162) to handle names containing special characters Co-Authored-By: Claude Haiku 4.5 --- apps/ui/src/hooks/use-settings-migration.ts | 2 +- apps/ui/tests/projects/open-existing-project.spec.ts | 2 +- .../test-project-1768743000887/package.json | 4 ++++ .../test-project-1768742910934/package.json | 4 ++++ 4 files changed, 10 insertions(+), 2 deletions(-) create mode 100644 test/agent-session-test-115699-vyk2nk2/test-project-1768743000887/package.json create mode 100644 test/feature-backlog-test-114171-aysp86y/test-project-1768742910934/package.json diff --git a/apps/ui/src/hooks/use-settings-migration.ts b/apps/ui/src/hooks/use-settings-migration.ts index 487d23c9..63e62c50 100644 --- a/apps/ui/src/hooks/use-settings-migration.ts +++ b/apps/ui/src/hooks/use-settings-migration.ts @@ -469,7 +469,7 @@ export function useSettingsMigration(): MigrationState { // Update localStorage with fresh server data to keep cache in sync // This prevents stale localStorage data from being used when switching between modes try { - localStorage.setItem('automaker-settings-cache', JSON.stringify(serverSettings)); + setItem('automaker-settings-cache', JSON.stringify(serverSettings)); logger.debug('Updated localStorage with fresh server settings'); } catch (storageError) { logger.warn('Failed to update localStorage cache:', storageError); diff --git a/apps/ui/tests/projects/open-existing-project.spec.ts b/apps/ui/tests/projects/open-existing-project.spec.ts index 5018bed5..b89702fb 100644 --- a/apps/ui/tests/projects/open-existing-project.spec.ts +++ b/apps/ui/tests/projects/open-existing-project.spec.ts @@ -159,7 +159,7 @@ test.describe('Open Project', () => { // The project name appears in the project switcher button with title attribute // (The button uses data-testid with projectId, not projectName) if (targetProjectName) { - const projectSwitcherButton = page.locator(`button[title="${targetProjectName}"]`).first(); + const projectSwitcherButton = page.getByRole('button', { name: targetProjectName }).first(); await expect(projectSwitcherButton).toBeVisible({ timeout: 15000, }); diff --git a/test/agent-session-test-115699-vyk2nk2/test-project-1768743000887/package.json b/test/agent-session-test-115699-vyk2nk2/test-project-1768743000887/package.json new file mode 100644 index 00000000..68258c5b --- /dev/null +++ b/test/agent-session-test-115699-vyk2nk2/test-project-1768743000887/package.json @@ -0,0 +1,4 @@ +{ + "name": "test-project-1768743000887", + "version": "1.0.0" +} diff --git a/test/feature-backlog-test-114171-aysp86y/test-project-1768742910934/package.json b/test/feature-backlog-test-114171-aysp86y/test-project-1768742910934/package.json new file mode 100644 index 00000000..4ea81845 --- /dev/null +++ b/test/feature-backlog-test-114171-aysp86y/test-project-1768742910934/package.json @@ -0,0 +1,4 @@ +{ + "name": "test-project-1768742910934", + "version": "1.0.0" +}