From 98d98cc05691f20f8503dae2572cd0f97c6d5570 Mon Sep 17 00:00:00 2001 From: Shirone Date: Sun, 25 Jan 2026 13:58:21 +0100 Subject: [PATCH 1/3] fix(ui): fix spinner visibility in github issue validation button The spinner component in the GitHub issue validation button was blended into the button's primary background color, making it invisible. This was caused by the spinner using the default 'primary' variant which applies text-primary color, matching the button's background. Changed the spinner to use the 'foreground' variant which applies text-primary-foreground for proper contrast against the primary background. This follows the existing pattern already implemented in the worktree panel components. Fixes #697 --- .../views/github-issues-view/components/issue-detail-panel.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/ui/src/components/views/github-issues-view/components/issue-detail-panel.tsx b/apps/ui/src/components/views/github-issues-view/components/issue-detail-panel.tsx index cc62a7fe..dbf38e96 100644 --- a/apps/ui/src/components/views/github-issues-view/components/issue-detail-panel.tsx +++ b/apps/ui/src/components/views/github-issues-view/components/issue-detail-panel.tsx @@ -87,7 +87,7 @@ export function IssueDetailPanel({ if (isValidating) { return ( ); From 80ef21c8d048f4350fad6fe3d291fc7b699b4e74 Mon Sep 17 00:00:00 2001 From: Shirone Date: Sun, 25 Jan 2026 14:07:17 +0100 Subject: [PATCH 2/3] refactor(ui): use Button loading prop instead of manual Spinner MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Address PR #698 review feedback from Gemini Code Assist to use the Button component's built-in loading prop instead of manually rendering Spinner components. The Button component already handles spinner display with correct variant selection (foreground for default/destructive buttons, primary for others), so this simplifies the code and aligns with component abstractions. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 --- .../components/issue-detail-panel.tsx | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/apps/ui/src/components/views/github-issues-view/components/issue-detail-panel.tsx b/apps/ui/src/components/views/github-issues-view/components/issue-detail-panel.tsx index dbf38e96..c44dbbe2 100644 --- a/apps/ui/src/components/views/github-issues-view/components/issue-detail-panel.tsx +++ b/apps/ui/src/components/views/github-issues-view/components/issue-detail-panel.tsx @@ -86,8 +86,7 @@ export function IssueDetailPanel({ {(() => { if (isValidating) { return ( - ); @@ -335,15 +334,9 @@ export function IssueDetailPanel({ className="w-full" onClick={loadMore} disabled={loadingMore} + loading={loadingMore} > - {loadingMore ? ( - <> - - Loading... - - ) : ( - 'Load More Comments' - )} + {loadingMore ? 'Loading...' : 'Load More Comments'} )} From 08dc90b37858870787a6c6dcb401457f72abdfb8 Mon Sep 17 00:00:00 2001 From: Shirone Date: Sun, 25 Jan 2026 14:09:14 +0100 Subject: [PATCH 3/3] refactor(ui): remove redundant disabled props when using Button loading MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The Button component internally sets disabled when loading=true, so explicit disabled props are redundant and can be removed. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 --- .../views/github-issues-view/components/issue-detail-panel.tsx | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/apps/ui/src/components/views/github-issues-view/components/issue-detail-panel.tsx b/apps/ui/src/components/views/github-issues-view/components/issue-detail-panel.tsx index c44dbbe2..e81eac9b 100644 --- a/apps/ui/src/components/views/github-issues-view/components/issue-detail-panel.tsx +++ b/apps/ui/src/components/views/github-issues-view/components/issue-detail-panel.tsx @@ -86,7 +86,7 @@ export function IssueDetailPanel({ {(() => { if (isValidating) { return ( - ); @@ -333,7 +333,6 @@ export function IssueDetailPanel({ size="sm" className="w-full" onClick={loadMore} - disabled={loadingMore} loading={loadingMore} > {loadingMore ? 'Loading...' : 'Load More Comments'}