ros/automaker
1
0
Fork 0
mirror of https://github.com/AutoMaker-Org/automaker.git synced 2026-02-03 08:53:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #337 from AutoMaker-Org/addressing-pr-issues

Browse Source 
feat: improve error handling in HttpApiClient
This commit is contained in:
Web Dev Cody
2026-01-01 02:31:59 -05:00
committed by GitHub
parent 8c8a4875ca 50aac1c218
commit 90e62b8add
1 changed files with 56 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

56
apps/ui/src/lib/http-api-client.ts
View File

@@ -569,6 +569,20 @@ export class HttpApiClient implements ElectronAPI {
credentials: 'include', // Include cookies for session auth credentials: 'include', // Include cookies for session auth
body: body ? JSON.stringify(body) : undefined, body: body ? JSON.stringify(body) : undefined,
}); });
if (!response.ok) {
let errorMessage = `HTTP ${response.status}: ${response.statusText}`;
try {
const errorData = await response.json();
if (errorData.error) {
errorMessage = errorData.error;
}
} catch {
// If parsing JSON fails, use status text
}
throw new Error(errorMessage);
}
return response.json(); return response.json();
} }
@@ -579,6 +593,20 @@ export class HttpApiClient implements ElectronAPI {
headers: this.getHeaders(), headers: this.getHeaders(),
credentials: 'include', // Include cookies for session auth credentials: 'include', // Include cookies for session auth
}); });
if (!response.ok) {
let errorMessage = `HTTP ${response.status}: ${response.statusText}`;
try {
const errorData = await response.json();
if (errorData.error) {
errorMessage = errorData.error;
}
} catch {
// If parsing JSON fails, use status text
}
throw new Error(errorMessage);
}
return response.json(); return response.json();
} }
@@ -591,6 +619,20 @@ export class HttpApiClient implements ElectronAPI {
credentials: 'include', // Include cookies for session auth credentials: 'include', // Include cookies for session auth
body: body ? JSON.stringify(body) : undefined, body: body ? JSON.stringify(body) : undefined,
}); });
if (!response.ok) {
let errorMessage = `HTTP ${response.status}: ${response.statusText}`;
try {
const errorData = await response.json();
if (errorData.error) {
errorMessage = errorData.error;
}
} catch {
// If parsing JSON fails, use status text
}
throw new Error(errorMessage);
}
return response.json(); return response.json();
} }
@@ -602,6 +644,20 @@ export class HttpApiClient implements ElectronAPI {
headers: this.getHeaders(), headers: this.getHeaders(),
credentials: 'include', // Include cookies for session auth credentials: 'include', // Include cookies for session auth
}); });
if (!response.ok) {
let errorMessage = `HTTP ${response.status}: ${response.statusText}`;
try {
const errorData = await response.json();
if (errorData.error) {
errorMessage = errorData.error;
}
} catch {
// If parsing JSON fails, use status text
}
throw new Error(errorMessage);
}
return response.json(); return response.json();
} }