ros/automaker
1
0
Fork 0
mirror of https://github.com/AutoMaker-Org/automaker.git synced 2026-02-03 08:53:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: improve waitForBoardView to handle zustand hydration

Browse Source 
The zustand store may not have hydrated from localStorage by the time
the board view first renders, causing board-view-no-project to appear
briefly. Use waitForFunction to poll until board-view appears.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Kacper
2025-12-17 22:19:53 +01:00
parent 2c9f77356f
commit 8f2e06bc32
1 changed files with 14 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
apps/ui/tests/utils/git/worktree.ts
View File

@@ -459,6 +459,7 @@ export async function setupProjectWithStaleWorktree(page: Page, projectPath: str
/** /**
* Wait for the board view to load * Wait for the board view to load
* Navigates to /board first since the index route shows WelcomeView * Navigates to /board first since the index route shows WelcomeView
* Handles zustand store hydration timing (may show "no-project" briefly)
*/ */
export async function waitForBoardView(page: Page): Promise<void> { export async function waitForBoardView(page: Page): Promise<void> {
// Navigate directly to /board route (index route shows welcome view) // Navigate directly to /board route (index route shows welcome view)
@@ -467,7 +468,19 @@ export async function waitForBoardView(page: Page): Promise<void> {
await page.goto('/board'); await page.goto('/board');
await page.waitForLoadState('networkidle'); await page.waitForLoadState('networkidle');
} }
await page.waitForSelector('[data-testid="board-view"]', { timeout: TIMEOUTS.long });
// Wait for either board-view (success) or board-view-no-project (store not hydrated yet)
// Then poll until board-view appears (zustand hydrates from localStorage)
await page.waitForFunction(
() => {
const boardView = document.querySelector('[data-testid="board-view"]');
const noProject = document.querySelector('[data-testid="board-view-no-project"]');
const loading = document.querySelector('[data-testid="board-view-loading"]');
// Return true only when board-view is visible (store hydrated with project)
return boardView !== null;
},
{ timeout: TIMEOUTS.long }
);
} }
/** /**