Improve pull request flow, add branch selection for worktree creation, fix auto-mode concurrency count (#787)

* Changes from fix/fetch-before-pull-fetch

* feat: Improve pull request flow, add branch selection for worktree creation, fix for automode concurrency count

* feat: Add validation for remote names and improve error handling

* Address PR comments and mobile layout fixes

* ```
refactor: Extract PR target resolution logic into dedicated service
```

* feat: Add app shell UI and improve service imports. Address PR comments

* fix: Improve security validation and cache handling in git operations

* feat: Add GET /list endpoint and improve parameter handling

* chore: Improve validation, accessibility, and error handling across apps

* chore: Format vite server port configuration

* fix: Add error handling for gh pr list command and improve offline fallbacks

* fix: Preserve existing PR creation time and improve remote handling

apps/ui/tests/projects/new-project-creation.spec.ts

@@ -35,16 +35,42 @@ test.describe('Project Creation', () => {
     // Intercept settings API BEFORE authenticateForTests (which navigates to the page)
     // This prevents settings hydration from restoring a project and disables auto-open
     await page.route('**/api/settings/global', async (route) => {
+      const method = route.request().method();
+      if (method === 'PUT') {
+        // Allow settings sync writes to pass through
+        return route.continue();
+      }
       const response = await route.fetch();
       const json = await response.json();
       // Remove currentProjectId and clear projects to prevent auto-open
       if (json.settings) {
         json.settings.currentProjectId = null;
         json.settings.projects = [];
+        // Ensure setup is marked complete to prevent redirect to /setup on fresh CI
+        json.settings.setupComplete = true;
+        json.settings.isFirstRun = false;
+        // Preserve lastProjectDir so the new project modal knows where to create projects
+        json.settings.lastProjectDir = TEST_TEMP_DIR;
       }
       await route.fulfill({ response, json });
     });
 
+    // Mock workspace config API to return a valid default directory.
+    // In CI, ALLOWED_ROOT_DIRECTORY is unset and Documents path is unavailable,
+    // so without this mock, getDefaultWorkspaceDirectory() returns null and the
+    // "Will be created at:" text never renders in the new project modal.
+    await page.route('**/api/workspace/config', async (route) => {
+      await route.fulfill({
+        status: 200,
+        contentType: 'application/json',
+        body: JSON.stringify({
+          success: true,
+          configured: false,
+          defaultDir: TEST_TEMP_DIR,
+        }),
+      });
+    });
+
     await authenticateForTests(page);
 
     // Navigate directly to dashboard to avoid auto-open logic

apps/ui/tests/projects/overview-dashboard.spec.ts

@@ -20,6 +20,67 @@ test.describe('Projects Overview Dashboard', () => {
   test.beforeEach(async ({ page }) => {
     // Set up mock projects state
     await setupMockMultipleProjects(page, 3);
+
+    // Intercept settings API to preserve mock project data and prevent
+    // the server's settings from overriding our test setup.
+    // Without this, background reconciliation can clear the mock projects.
+    await page.route('**/api/settings/global', async (route) => {
+      const method = route.request().method();
+      if (method === 'PUT') {
+        // Allow settings sync writes to pass through
+        return route.continue();
+      }
+      const response = await route.fetch();
+      const json = await response.json();
+      if (json.settings) {
+        // Always overwrite projects with mock data so CI-provided projects
+        // that don't contain 'test-project-1' can't break hydration.
+        json.settings.projects = [
+          {
+            id: 'test-project-1',
+            name: 'Test Project 1',
+            path: '/mock/test-project-1',
+            lastOpened: new Date().toISOString(),
+          },
+          {
+            id: 'test-project-2',
+            name: 'Test Project 2',
+            path: '/mock/test-project-2',
+            lastOpened: new Date(Date.now() - 86400000).toISOString(),
+          },
+          {
+            id: 'test-project-3',
+            name: 'Test Project 3',
+            path: '/mock/test-project-3',
+            lastOpened: new Date(Date.now() - 172800000).toISOString(),
+          },
+        ];
+        json.settings.currentProjectId = 'test-project-1';
+        json.settings.setupComplete = true;
+        json.settings.isFirstRun = false;
+      }
+      await route.fulfill({ response, json });
+    });
+
+    // Mock the initialize-project endpoint for mock paths that don't exist on disk.
+    // This prevents auto-open from failing when it tries to verify the project directory.
+    await page.route('**/api/project/initialize', async (route) => {
+      await route.fulfill({
+        status: 200,
+        contentType: 'application/json',
+        body: JSON.stringify({ success: true }),
+      });
+    });
+
+    // Mock features list for mock project paths (they don't exist on disk)
+    await page.route('**/api/features/list**', async (route) => {
+      await route.fulfill({
+        status: 200,
+        contentType: 'application/json',
+        body: JSON.stringify({ success: true, features: [] }),
+      });
+    });
+
     await authenticateForTests(page);
   });