mirror of
https://github.com/AutoMaker-Org/automaker.git
synced 2026-01-31 06:42:03 +00:00
feat: improve rate limit error handling with user-friendly messages
- Add rate_limit error type to ErrorInfo classification - Implement isRateLimitError() and extractRetryAfter() utilities - Enhance ClaudeProvider error handling with actionable messages - Add comprehensive test coverage (8 new tests, 162 total passing) **Problem:** When hitting API rate limits, users saw cryptic 'exit code 1' errors with no explanation or guidance on how to resolve the issue. **Solution:** - Detect rate limit errors (429) and extract retry-after duration - Provide clear, user-friendly error messages with: * Explanation of what went wrong * How long to wait before retrying * Actionable tip to reduce concurrency in auto-mode - Preserve original error details for debugging **Changes:** - libs/types: Add 'rate_limit' type and retryAfter field to ErrorInfo - libs/utils: Add rate limit detection and extraction logic - apps/server: Enhance ClaudeProvider with better error messages - tests: Add 8 new test cases covering rate limit scenarios **Benefits:** ✅ Clear communication - users understand the problem ✅ Actionable guidance - users know how to fix it ✅ Better debugging - original errors preserved ✅ Type safety - proper TypeScript typing ✅ Comprehensive testing - all edge cases covered See CHANGELOG_RATE_LIMIT_HANDLING.md for detailed documentation.
This commit is contained in:
@@ -3,6 +3,8 @@ import {
|
||||
isAbortError,
|
||||
isCancellationError,
|
||||
isAuthenticationError,
|
||||
isRateLimitError,
|
||||
extractRetryAfter,
|
||||
classifyError,
|
||||
getUserFriendlyErrorMessage,
|
||||
} from '../src/error-handler';
|
||||
@@ -101,6 +103,63 @@ describe('error-handler.ts', () => {
|
||||
});
|
||||
});
|
||||
|
||||
describe('isRateLimitError', () => {
|
||||
it('should return true for errors with 429 status code', () => {
|
||||
const error = new Error('Error: 429 Too Many Requests');
|
||||
expect(isRateLimitError(error)).toBe(true);
|
||||
});
|
||||
|
||||
it('should return true for errors with rate_limit in message', () => {
|
||||
const error = new Error('rate_limit_error: Too many requests');
|
||||
expect(isRateLimitError(error)).toBe(true);
|
||||
});
|
||||
|
||||
it('should return true for string errors with 429', () => {
|
||||
expect(isRateLimitError('429 - rate limit exceeded')).toBe(true);
|
||||
});
|
||||
|
||||
it('should return false for non-rate-limit errors', () => {
|
||||
const error = new Error('Something went wrong');
|
||||
expect(isRateLimitError(error)).toBe(false);
|
||||
});
|
||||
|
||||
it('should return false for null/undefined', () => {
|
||||
expect(isRateLimitError(null)).toBe(false);
|
||||
expect(isRateLimitError(undefined)).toBe(false);
|
||||
});
|
||||
});
|
||||
|
||||
describe('extractRetryAfter', () => {
|
||||
it('should extract retry-after from error message', () => {
|
||||
const error = new Error('Rate limit exceeded. retry-after: 60');
|
||||
expect(extractRetryAfter(error)).toBe(60);
|
||||
});
|
||||
|
||||
it('should extract from retry_after format', () => {
|
||||
const error = new Error('retry_after: 120 seconds');
|
||||
expect(extractRetryAfter(error)).toBe(120);
|
||||
});
|
||||
|
||||
it('should extract from wait format', () => {
|
||||
const error = new Error('Please wait: 30 seconds before retrying');
|
||||
expect(extractRetryAfter(error)).toBe(30);
|
||||
});
|
||||
|
||||
it('should return default 60 for rate limit errors without explicit retry-after', () => {
|
||||
const error = new Error('429 rate_limit_error');
|
||||
expect(extractRetryAfter(error)).toBe(60);
|
||||
});
|
||||
|
||||
it('should return undefined for non-rate-limit errors', () => {
|
||||
const error = new Error('Something went wrong');
|
||||
expect(extractRetryAfter(error)).toBeUndefined();
|
||||
});
|
||||
|
||||
it('should handle string errors', () => {
|
||||
expect(extractRetryAfter('retry-after: 45')).toBe(45);
|
||||
});
|
||||
});
|
||||
|
||||
describe('classifyError', () => {
|
||||
it('should classify authentication errors', () => {
|
||||
const error = new Error('Authentication failed');
|
||||
@@ -110,10 +169,30 @@ describe('error-handler.ts', () => {
|
||||
expect(result.isAuth).toBe(true);
|
||||
expect(result.isAbort).toBe(false);
|
||||
expect(result.isCancellation).toBe(false);
|
||||
expect(result.isRateLimit).toBe(false);
|
||||
expect(result.message).toBe('Authentication failed');
|
||||
expect(result.originalError).toBe(error);
|
||||
});
|
||||
|
||||
it('should classify rate limit errors', () => {
|
||||
const error = new Error('Error: 429 rate_limit_error');
|
||||
const result = classifyError(error);
|
||||
|
||||
expect(result.type).toBe('rate_limit');
|
||||
expect(result.isRateLimit).toBe(true);
|
||||
expect(result.isAuth).toBe(false);
|
||||
expect(result.retryAfter).toBe(60); // Default
|
||||
});
|
||||
|
||||
it('should extract retryAfter from rate limit errors', () => {
|
||||
const error = new Error('429 - retry-after: 120');
|
||||
const result = classifyError(error);
|
||||
|
||||
expect(result.type).toBe('rate_limit');
|
||||
expect(result.isRateLimit).toBe(true);
|
||||
expect(result.retryAfter).toBe(120);
|
||||
});
|
||||
|
||||
it('should classify abort errors', () => {
|
||||
const error = new Error('aborted');
|
||||
const result = classifyError(error);
|
||||
@@ -169,6 +248,24 @@ describe('error-handler.ts', () => {
|
||||
expect(result2.message).toBe('Unknown error');
|
||||
});
|
||||
|
||||
it('should prioritize authentication over rate limit', () => {
|
||||
const error = new Error('Authentication failed - 429');
|
||||
const result = classifyError(error);
|
||||
|
||||
expect(result.type).toBe('authentication');
|
||||
expect(result.isAuth).toBe(true);
|
||||
expect(result.isRateLimit).toBe(true); // Both flags can be true
|
||||
});
|
||||
|
||||
it('should prioritize rate limit over abort', () => {
|
||||
const error = new Error('429 rate_limit - aborted');
|
||||
const result = classifyError(error);
|
||||
|
||||
expect(result.type).toBe('rate_limit');
|
||||
expect(result.isRateLimit).toBe(true);
|
||||
expect(result.isAbort).toBe(true);
|
||||
});
|
||||
|
||||
it('should prioritize authentication over abort', () => {
|
||||
const error = new Error('Authentication failed - aborted');
|
||||
const result = classifyError(error);
|
||||
@@ -223,6 +320,22 @@ describe('error-handler.ts', () => {
|
||||
expect(message).toBe('Authentication failed. Please check your API key.');
|
||||
});
|
||||
|
||||
it('should return friendly message for rate limit errors', () => {
|
||||
const error = new Error('429 rate_limit_error');
|
||||
const message = getUserFriendlyErrorMessage(error);
|
||||
|
||||
expect(message).toContain('Rate limit exceeded');
|
||||
expect(message).toContain('60 seconds');
|
||||
});
|
||||
|
||||
it('should include custom retry-after in rate limit message', () => {
|
||||
const error = new Error('429 - retry-after: 120');
|
||||
const message = getUserFriendlyErrorMessage(error);
|
||||
|
||||
expect(message).toContain('Rate limit exceeded');
|
||||
expect(message).toContain('120 seconds');
|
||||
});
|
||||
|
||||
it('should prioritize abort message over auth', () => {
|
||||
const error = new Error('Authentication failed - abort');
|
||||
const message = getUserFriendlyErrorMessage(error);
|
||||
|
||||
Reference in New Issue
Block a user