ros/automaker
1
0
Fork 0
mirror of https://github.com/AutoMaker-Org/automaker.git synced 2026-02-03 08:53:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: enable logger colors by default in Node.js subprocess environments

Browse Source 
Previously, colors were only enabled when stdout was a TTY, which caused
colored output to be stripped when the server ran as a subprocess. Now
colors are enabled by default in Node.js and can be disabled with
LOG_COLORS=false if needed.

Also removed the unused isTTY() function.
This commit is contained in:
Shirone
2026-01-03 02:54:14 +01:00
parent 35441c1a9d
commit 7596ff9ec3
1 changed files with 4 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
libs/utils/src/logger.ts
View File

@@ -3,7 +3,7 @@
* *
* Environment Variables: * Environment Variables:
* - LOG_LEVEL: error, warn, info, debug (default: info) * - LOG_LEVEL: error, warn, info, debug (default: info)
* - LOG_COLORS: true/false (default: auto-detect TTY) * - LOG_COLORS: true/false (default: true in Node.js)
* - LOG_TIMESTAMPS: true/false (default: false) * - LOG_TIMESTAMPS: true/false (default: false)
*/ */
@@ -59,16 +59,6 @@ const isBrowser = typeof (globalThis as any).window !== 'undefined';
// Configuration state // Configuration state
let currentLogLevel: LogLevel = LogLevel.INFO; let currentLogLevel: LogLevel = LogLevel.INFO;
// Detect if we're in a Node.js environment with TTY support
function isTTY(): boolean {
if (isBrowser) return false;
try {
return process?.stdout?.isTTY ?? false;
} catch {
return false;
}
}
// Get environment variable safely (works in both Node.js and browser) // Get environment variable safely (works in both Node.js and browser)
function getEnvVar(name: string): string | undefined { function getEnvVar(name: string): string | undefined {
if (isBrowser) return undefined; if (isBrowser) return undefined;
@@ -80,7 +70,8 @@ function getEnvVar(name: string): string | undefined {
} }
// Initialize configuration from environment variables // Initialize configuration from environment variables
let colorsEnabled = isTTY() && getEnvVar('LOG_COLORS') !== 'false'; // Colors enabled by default in Node.js, can be disabled with LOG_COLORS=false
let colorsEnabled = !isBrowser && getEnvVar('LOG_COLORS') !== 'false';
let timestampsEnabled = getEnvVar('LOG_TIMESTAMPS') === 'true'; let timestampsEnabled = getEnvVar('LOG_TIMESTAMPS') === 'true';
// Initialize log level from environment variable // Initialize log level from environment variable
@@ -209,7 +200,7 @@ export function createLogger(context: string): Logger {
warn: (...args: unknown[]): void => { warn: (...args: unknown[]): void => {
if (currentLogLevel >= LogLevel.WARN) { if (currentLogLevel >= LogLevel.WARN) {
console.warn(formatNodeLog('WARN', context, ANSI.yellow), ...args); console.log(formatNodeLog('WARN', context, ANSI.yellow), ...args);
} }
}, },