mirror of
https://github.com/AutoMaker-Org/automaker.git
synced 2026-03-18 22:33:08 +00:00
Make memory and context views mobile-friendly (#813)
* Changes from fix/memory-and-context-mobile-friendly * fix: Improve file extension detection and add path traversal protection * refactor: Extract file extension utilities and add path traversal guards Code review improvements: - Extract isMarkdownFilename and isImageFilename to shared image-utils.ts - Remove duplicated code from context-view.tsx and memory-view.tsx - Add path traversal guard for context fixture utilities (matching memory) - Add 7 new tests for context fixture path traversal protection - Total 61 tests pass Addresses code review feedback from PR #813 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * test: Add e2e tests for profiles crud and board background persistence * Update apps/ui/playwright.config.ts Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * fix: Add robust test navigation handling and file filtering * fix: Format NODE_OPTIONS configuration on single line * test: Update profiles and board background persistence tests * test: Replace iPhone 13 Pro with Pixel 5 for mobile test consistency --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
This commit is contained in:
@@ -17,6 +17,7 @@ const WORKSPACE_ROOT = getWorkspaceRoot();
|
||||
const FIXTURE_PATH = path.join(WORKSPACE_ROOT, 'test/fixtures/projectA');
|
||||
const SPEC_FILE_PATH = path.join(FIXTURE_PATH, '.automaker/app_spec.txt');
|
||||
const CONTEXT_PATH = path.join(FIXTURE_PATH, '.automaker/context');
|
||||
const MEMORY_PATH = path.join(FIXTURE_PATH, '.automaker/memory');
|
||||
|
||||
// Original spec content for resetting between tests
|
||||
const ORIGINAL_SPEC_CONTENT = `<app_spec>
|
||||
@@ -50,11 +51,53 @@ export function resetContextDirectory(): void {
|
||||
fs.mkdirSync(CONTEXT_PATH, { recursive: true });
|
||||
}
|
||||
|
||||
/**
|
||||
* Reset the memory directory to empty state
|
||||
*/
|
||||
export function resetMemoryDirectory(): void {
|
||||
if (fs.existsSync(MEMORY_PATH)) {
|
||||
fs.rmSync(MEMORY_PATH, { recursive: true });
|
||||
}
|
||||
fs.mkdirSync(MEMORY_PATH, { recursive: true });
|
||||
}
|
||||
|
||||
/**
|
||||
* Resolve and validate a context fixture path to prevent path traversal
|
||||
*/
|
||||
function resolveContextFixturePath(filename: string): string {
|
||||
const resolved = path.resolve(CONTEXT_PATH, filename);
|
||||
const base = path.resolve(CONTEXT_PATH) + path.sep;
|
||||
if (!resolved.startsWith(base)) {
|
||||
throw new Error(`Invalid context filename: ${filename}`);
|
||||
}
|
||||
return resolved;
|
||||
}
|
||||
|
||||
/**
|
||||
* Create a context file directly on disk (for test setup)
|
||||
*/
|
||||
export function createContextFileOnDisk(filename: string, content: string): void {
|
||||
const filePath = path.join(CONTEXT_PATH, filename);
|
||||
const filePath = resolveContextFixturePath(filename);
|
||||
fs.writeFileSync(filePath, content);
|
||||
}
|
||||
|
||||
/**
|
||||
* Resolve and validate a memory fixture path to prevent path traversal
|
||||
*/
|
||||
function resolveMemoryFixturePath(filename: string): string {
|
||||
const resolved = path.resolve(MEMORY_PATH, filename);
|
||||
const base = path.resolve(MEMORY_PATH) + path.sep;
|
||||
if (!resolved.startsWith(base)) {
|
||||
throw new Error(`Invalid memory filename: ${filename}`);
|
||||
}
|
||||
return resolved;
|
||||
}
|
||||
|
||||
/**
|
||||
* Create a memory file directly on disk (for test setup)
|
||||
*/
|
||||
export function createMemoryFileOnDisk(filename: string, content: string): void {
|
||||
const filePath = resolveMemoryFixturePath(filename);
|
||||
fs.writeFileSync(filePath, content);
|
||||
}
|
||||
|
||||
@@ -62,7 +105,15 @@ export function createContextFileOnDisk(filename: string, content: string): void
|
||||
* Check if a context file exists on disk
|
||||
*/
|
||||
export function contextFileExistsOnDisk(filename: string): boolean {
|
||||
const filePath = path.join(CONTEXT_PATH, filename);
|
||||
const filePath = resolveContextFixturePath(filename);
|
||||
return fs.existsSync(filePath);
|
||||
}
|
||||
|
||||
/**
|
||||
* Check if a memory file exists on disk
|
||||
*/
|
||||
export function memoryFileExistsOnDisk(filename: string): boolean {
|
||||
const filePath = resolveMemoryFixturePath(filename);
|
||||
return fs.existsSync(filePath);
|
||||
}
|
||||
|
||||
@@ -112,8 +163,29 @@ export async function setupProjectWithFixture(
|
||||
};
|
||||
localStorage.setItem('automaker-setup', JSON.stringify(setupState));
|
||||
|
||||
// Set settings cache so the fast-hydrate path uses our fixture project.
|
||||
// Without this, a stale settings cache from a previous test can override
|
||||
// the project we just set in automaker-storage.
|
||||
const settingsCache = {
|
||||
setupComplete: true,
|
||||
isFirstRun: false,
|
||||
projects: [
|
||||
{
|
||||
id: mockProject.id,
|
||||
name: mockProject.name,
|
||||
path: mockProject.path,
|
||||
lastOpened: mockProject.lastOpened,
|
||||
},
|
||||
],
|
||||
currentProjectId: mockProject.id,
|
||||
theme: 'dark',
|
||||
sidebarOpen: true,
|
||||
maxConcurrency: 3,
|
||||
};
|
||||
localStorage.setItem('automaker-settings-cache', JSON.stringify(settingsCache));
|
||||
|
||||
// Disable splash screen in tests
|
||||
sessionStorage.setItem('automaker-splash-shown', 'true');
|
||||
localStorage.setItem('automaker-disable-splash', 'true');
|
||||
}, projectPath);
|
||||
}
|
||||
|
||||
@@ -123,3 +195,14 @@ export async function setupProjectWithFixture(
|
||||
export function getFixturePath(): string {
|
||||
return FIXTURE_PATH;
|
||||
}
|
||||
|
||||
/**
|
||||
* Set up a mock project with the fixture path (for profile/settings tests that need a project).
|
||||
* Options such as customProfilesCount are reserved for future use (e.g. mocking server profile state).
|
||||
*/
|
||||
export async function setupMockProjectWithProfiles(
|
||||
page: Page,
|
||||
_options?: { customProfilesCount?: number }
|
||||
): Promise<void> {
|
||||
await setupProjectWithFixture(page, FIXTURE_PATH);
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user