ros/automaker
1
0
Fork 0
mirror of https://github.com/AutoMaker-Org/automaker.git synced 2026-03-18 10:23:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: E2E test stability and UI performance improvements (#823)

Browse Source
This commit is contained in:
gsxdsm
2026-03-02 18:46:28 -08:00
committed by GitHub
parent 1c3d6434a8
commit 54d69e907b
9 changed files with 88 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
apps/ui/tests/settings/event-hooks-settings.spec.ts
View File

@@ -12,7 +12,7 @@
*/
import { test, expect, type Page } from '@playwright/test';
import { authenticateForTests, navigateToSettings } from '../utils';
import { authenticateForTests, navigateToSettings, waitForSuccessToast } from '../utils';
// Timeout constants for maintainability
const TIMEOUTS = {
@@ -224,6 +224,9 @@ test.describe('Event Hooks Settings', () => {
const addButton = dialog.locator('button:has-text("Add Endpoint")').last();
await addButton.click();
// Wait for the success toast to confirm the save completed (including API call)
await waitForSuccessToast(page, 'Endpoint added', { timeout: 10000 });
// Dialog should close
await expect(dialog).toBeHidden({ timeout: TIMEOUTS.dialogHidden });
@@ -256,16 +259,13 @@ test.describe('Event Hooks Settings', () => {
// The endpoints tab should show either existing endpoints or the empty state
// The key is that it should NOT show "empty" if there are endpoints on the server
// Either we see "No endpoints configured" OR we see endpoint cards
const emptyState = page.locator('text=No endpoints configured');
// Either we see "No ntfy endpoints configured" OR we see endpoint cards
const emptyState = page.locator('text=No ntfy endpoints configured');
const endpointCard = page.locator('[data-testid="endpoint-card"]').first();
// One of these should be visible
await expect(
Promise.race([
emptyState.waitFor({ state: 'visible', timeout: 5000 }).then(() => 'empty'),
endpointCard.waitFor({ state: 'visible', timeout: 5000 }).then(() => 'card'),
])
).resolves.toBeDefined();
// One of these should be visible (use Playwright's .or() to match either locator)
await expect(emptyState.or(endpointCard)).toBeVisible({
timeout: TIMEOUTS.endpointVisible,
});
});
});