ros/automaker
1
0
Fork 0
mirror of https://github.com/AutoMaker-Org/automaker.git synced 2026-02-01 08:13:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Prevent command injection and stale state in test runner

Browse Source
This commit is contained in:
Shirone
2026-01-21 16:12:36 +01:00
parent b73885e04a
commit 4ab927a5fb
5 changed files with 70 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
apps/ui/src/hooks/use-test-logs.ts
View File

@@ -126,6 +126,9 @@ export function useTestLogs({
// Track the current session ID for filtering events
const currentSessionId = useRef<string | null>(targetSessionId ?? null);
// Guard against stale fetch results when switching worktrees/sessions
const fetchSeq = useRef(0);
/**
* Derived state: whether tests are currently running
*/
@@ -137,11 +140,16 @@ export function useTestLogs({
const fetchLogs = useCallback(async () => {
if (!worktreePath && !targetSessionId) return;
// Increment sequence to guard against stale responses
const seq = ++fetchSeq.current;
setState((prev) => ({ ...prev, isLoading: true, error: null }));
try {
const api = getElectronAPI();
if (!api?.worktree?.getTestLogs) {
// Check if this request is still current
if (seq !== fetchSeq.current) return;
setState((prev) => ({
...prev,
isLoading: false,
@@ -152,6 +160,9 @@ export function useTestLogs({
const result = await api.worktree.getTestLogs(worktreePath ?? undefined, targetSessionId);
// Check if this request is still current (prevent stale updates)
if (seq !== fetchSeq.current) return;
if (result.success && result.result) {
const { sessionId, command, status, testFile, logs, startedAt, finishedAt, exitCode } =
result.result;
@@ -183,6 +194,8 @@ export function useTestLogs({
}));
}
} catch (error) {
// Check if this request is still current
if (seq !== fetchSeq.current) return;
logger.error('Failed to fetch test logs:', error);
setState((prev) => ({
...prev,