ros/automaker
1
0
Fork 0
mirror of https://github.com/AutoMaker-Org/automaker.git synced 2026-03-16 21:53:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: Update task finalization behavior to keep pending tasks in review states

Browse Source
This commit is contained in:
gsxdsm
2026-02-16 21:24:24 -08:00
parent 4a8c6b0eba
commit 30fce3f746
1 changed files with 11 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
apps/server/tests/unit/services/feature-state-manager.test.ts
View File

@@ -151,7 +151,7 @@ describe('FeatureStateManager', () => {
expect(savedFeature.justFinishedAt).toBeUndefined(); expect(savedFeature.justFinishedAt).toBeUndefined();
}); });
it('should finalize in_progress and pending tasks when moving to waiting_approval', async () => { it('should finalize in_progress tasks but keep pending tasks when moving to waiting_approval', async () => {
const featureWithTasks: Feature = { const featureWithTasks: Feature = {
...mockFeature, ...mockFeature,
status: 'in_progress', status: 'in_progress',
@@ -178,13 +178,15 @@ describe('FeatureStateManager', () => {
await manager.updateFeatureStatus('/project', 'feature-123', 'waiting_approval'); await manager.updateFeatureStatus('/project', 'feature-123', 'waiting_approval');
const savedFeature = (atomicWriteJson as Mock).mock.calls[0][1] as Feature; const savedFeature = (atomicWriteJson as Mock).mock.calls[0][1] as Feature;
// Only in_progress tasks should be completed // Already completed tasks stay completed
expect(savedFeature.planSpec?.tasks?.[0].status).toBe('completed'); expect(savedFeature.planSpec?.tasks?.[0].status).toBe('completed');
// in_progress tasks should be finalized to completed
expect(savedFeature.planSpec?.tasks?.[1].status).toBe('completed'); expect(savedFeature.planSpec?.tasks?.[1].status).toBe('completed');
// pending tasks should remain pending (never started)
expect(savedFeature.planSpec?.tasks?.[2].status).toBe('pending'); expect(savedFeature.planSpec?.tasks?.[2].status).toBe('pending');
// currentTaskId should be cleared // currentTaskId should be cleared
expect(savedFeature.planSpec?.currentTaskId).toBeUndefined(); expect(savedFeature.planSpec?.currentTaskId).toBeUndefined();
// tasksCompleted should be 2, not 3 // tasksCompleted should equal actual completed tasks count
expect(savedFeature.planSpec?.tasksCompleted).toBe(2); expect(savedFeature.planSpec?.tasksCompleted).toBe(2);
}); });
@@ -215,14 +217,16 @@ describe('FeatureStateManager', () => {
await manager.updateFeatureStatus('/project', 'feature-123', 'verified'); await manager.updateFeatureStatus('/project', 'feature-123', 'verified');
const savedFeature = (atomicWriteJson as Mock).mock.calls[0][1] as Feature; const savedFeature = (atomicWriteJson as Mock).mock.calls[0][1] as Feature;
// All tasks should be completed // Already completed tasks stay completed
expect(savedFeature.planSpec?.tasks?.[0].status).toBe('completed'); expect(savedFeature.planSpec?.tasks?.[0].status).toBe('completed');
// in_progress tasks should be finalized to completed
expect(savedFeature.planSpec?.tasks?.[1].status).toBe('completed'); expect(savedFeature.planSpec?.tasks?.[1].status).toBe('completed');
expect(savedFeature.planSpec?.tasks?.[2].status).toBe('completed'); // pending tasks should remain pending (never started)
expect(savedFeature.planSpec?.tasks?.[2].status).toBe('pending');
// currentTaskId should be cleared // currentTaskId should be cleared
expect(savedFeature.planSpec?.currentTaskId).toBeUndefined(); expect(savedFeature.planSpec?.currentTaskId).toBeUndefined();
// tasksCompleted should equal total tasks // tasksCompleted should equal actual completed tasks count
expect(savedFeature.planSpec?.tasksCompleted).toBe(3); expect(savedFeature.planSpec?.tasksCompleted).toBe(2);
// justFinishedAt should be cleared for verified // justFinishedAt should be cleared for verified
expect(savedFeature.justFinishedAt).toBeUndefined(); expect(savedFeature.justFinishedAt).toBeUndefined();
}); });