From 2d937bc47f382c391fcb4fc0c51363dba3e0d8d3 Mon Sep 17 00:00:00 2001 From: Kacper Date: Thu, 11 Dec 2025 00:35:45 +0100 Subject: [PATCH] refactor(settings): move types.ts to shared folder - Move types.ts to shared/types.ts - Update all section files to import from ../shared/types - Update theme-options.ts to import from ../../shared/types - All TypeScript diagnostics passing - Completes settings-view folder restructuring Final structure: - api-keys/ (with hooks/, config/) - appearance/ (with config/) - cli-status/ (claude, codex) - feature-defaults/ - keyboard-shortcuts/ - kanban-display/ - danger-zone/ - shared/ (types.ts) --- .../views/settings-view/appearance/appearance-section.tsx | 2 +- .../views/settings-view/appearance/config/theme-options.ts | 2 +- .../views/settings-view/cli-status/claude-cli-status.tsx | 2 +- .../views/settings-view/cli-status/codex-cli-status.tsx | 2 +- .../views/settings-view/danger-zone/danger-zone-section.tsx | 2 +- .../settings-view/kanban-display/kanban-display-section.tsx | 2 +- app/src/components/views/settings-view/{ => shared}/types.ts | 0 7 files changed, 6 insertions(+), 6 deletions(-) rename app/src/components/views/settings-view/{ => shared}/types.ts (100%) diff --git a/app/src/components/views/settings-view/appearance/appearance-section.tsx b/app/src/components/views/settings-view/appearance/appearance-section.tsx index 4ccd0c24..e24c355d 100644 --- a/app/src/components/views/settings-view/appearance/appearance-section.tsx +++ b/app/src/components/views/settings-view/appearance/appearance-section.tsx @@ -2,7 +2,7 @@ import { Button } from "@/components/ui/button"; import { Label } from "@/components/ui/label"; import { Palette } from "lucide-react"; import { themeOptions } from "./config/theme-options"; -import type { Theme, Project } from "../types"; +import type { Theme, Project } from "../shared/types"; interface AppearanceSectionProps { effectiveTheme: Theme; diff --git a/app/src/components/views/settings-view/appearance/config/theme-options.ts b/app/src/components/views/settings-view/appearance/config/theme-options.ts index e59da056..9e52deb0 100644 --- a/app/src/components/views/settings-view/appearance/config/theme-options.ts +++ b/app/src/components/views/settings-view/appearance/config/theme-options.ts @@ -13,7 +13,7 @@ import { Terminal, Trees, } from "lucide-react"; -import { Theme } from "../types"; +import { Theme } from "../../shared/types"; export interface ThemeOption { value: Theme; diff --git a/app/src/components/views/settings-view/cli-status/claude-cli-status.tsx b/app/src/components/views/settings-view/cli-status/claude-cli-status.tsx index b5c4afe6..868024a5 100644 --- a/app/src/components/views/settings-view/cli-status/claude-cli-status.tsx +++ b/app/src/components/views/settings-view/cli-status/claude-cli-status.tsx @@ -5,7 +5,7 @@ import { AlertCircle, RefreshCw, } from "lucide-react"; -import type { CliStatus } from "../types"; +import type { CliStatus } from "../shared/types"; interface CliStatusProps { status: CliStatus | null; diff --git a/app/src/components/views/settings-view/cli-status/codex-cli-status.tsx b/app/src/components/views/settings-view/cli-status/codex-cli-status.tsx index 6dc41d72..5f0bde25 100644 --- a/app/src/components/views/settings-view/cli-status/codex-cli-status.tsx +++ b/app/src/components/views/settings-view/cli-status/codex-cli-status.tsx @@ -5,7 +5,7 @@ import { AlertCircle, RefreshCw, } from "lucide-react"; -import type { CliStatus } from "../types"; +import type { CliStatus } from "../shared/types"; interface CliStatusProps { status: CliStatus | null; diff --git a/app/src/components/views/settings-view/danger-zone/danger-zone-section.tsx b/app/src/components/views/settings-view/danger-zone/danger-zone-section.tsx index 3efdbaa7..f6bec6a8 100644 --- a/app/src/components/views/settings-view/danger-zone/danger-zone-section.tsx +++ b/app/src/components/views/settings-view/danger-zone/danger-zone-section.tsx @@ -1,6 +1,6 @@ import { Button } from "@/components/ui/button"; import { Trash2, Folder } from "lucide-react"; -import type { Project } from "../types"; +import type { Project } from "../shared/types"; interface DangerZoneSectionProps { project: Project | null; diff --git a/app/src/components/views/settings-view/kanban-display/kanban-display-section.tsx b/app/src/components/views/settings-view/kanban-display/kanban-display-section.tsx index 55cc0789..d371966e 100644 --- a/app/src/components/views/settings-view/kanban-display/kanban-display-section.tsx +++ b/app/src/components/views/settings-view/kanban-display/kanban-display-section.tsx @@ -1,7 +1,7 @@ import { Button } from "@/components/ui/button"; import { Label } from "@/components/ui/label"; import { LayoutGrid, Minimize2, Square, Maximize2 } from "lucide-react"; -import type { KanbanDetailLevel } from "../types"; +import type { KanbanDetailLevel } from "../shared/types"; interface KanbanDisplaySectionProps { detailLevel: KanbanDetailLevel; diff --git a/app/src/components/views/settings-view/types.ts b/app/src/components/views/settings-view/shared/types.ts similarity index 100% rename from app/src/components/views/settings-view/types.ts rename to app/src/components/views/settings-view/shared/types.ts