From 2c9a3c51617781529a96d8c4562d37baedbfd72f Mon Sep 17 00:00:00 2001
From: Kacper <kacperlachowiczwp.pl@wp.pl>
Date: Wed, 24 Dec 2025 02:12:22 +0100
Subject: [PATCH] feat: Refactor validation logic in GitHubIssuesView for
 improved clarity

- Simplified the validation staleness check by introducing a dedicated variable for stale validation status.
- Enhanced the conditions for unviewed and viewed validation indicators, improving user feedback on validation status.
- Added a visual indicator for viewed validations, enhancing the user interface and experience.
---
 .../components/views/github-issues-view.tsx   | 25 +++++++++++++------
 1 file changed, 18 insertions(+), 7 deletions(-)

diff --git a/apps/ui/src/components/views/github-issues-view.tsx b/apps/ui/src/components/views/github-issues-view.tsx
index e92bcc6a..1624b712 100644
--- a/apps/ui/src/components/views/github-issues-view.tsx
+++ b/apps/ui/src/components/views/github-issues-view.tsx
@@ -846,15 +846,18 @@ function IssueRow({
   cachedValidation,
   isValidating,
 }: IssueRowProps) {
+  // Check if validation exists and calculate staleness
+  const validationHoursSince = cachedValidation
+    ? (Date.now() - new Date(cachedValidation.validatedAt).getTime()) / (1000 * 60 * 60)
+    : null;
+  const isValidationStale = validationHoursSince !== null && validationHoursSince > 24;
+
   // Check if validation is unviewed (exists, not stale, not viewed)
   const hasUnviewedValidation =
-    cachedValidation &&
-    !cachedValidation.viewedAt &&
-    (() => {
-      const hoursSince =
-        (Date.now() - new Date(cachedValidation.validatedAt).getTime()) / (1000 * 60 * 60);
-      return hoursSince <= 24;
-    })();
+    cachedValidation && !cachedValidation.viewedAt && !isValidationStale;
+
+  // Check if validation has been viewed (exists and was viewed)
+  const hasViewedValidation = cachedValidation && cachedValidation.viewedAt && !isValidationStale;
   return (
     <div
       className={cn(
@@ -927,6 +930,14 @@ function IssueRow({
               Analysis Ready
             </span>
           )}
+
+          {/* Viewed validation indicator */}
+          {!isValidating && hasViewedValidation && (
+            <span className="inline-flex items-center gap-1 px-1.5 py-0.5 text-[10px] font-medium rounded-full bg-green-500/10 text-green-500 border border-green-500/20">
+              <CheckCircle className="h-3 w-3" />
+              Validated
+            </span>
+          )}
         </div>
       </div>