From 2a0719e00c07cc1ae34ae353d977ca6de7dc4302 Mon Sep 17 00:00:00 2001 From: Kacper Date: Tue, 6 Jan 2026 00:58:31 +0100 Subject: [PATCH] refactor: move logger initialization outside of useCliStatus hook - Moved the logger creation outside the hook to prevent infinite re-renders. - Updated dependencies in the checkStatus function to remove logger from the dependency array. These changes enhance performance and maintainability of the useCliStatus hook. --- .../src/components/views/setup-view/hooks/use-cli-status.ts | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/apps/ui/src/components/views/setup-view/hooks/use-cli-status.ts b/apps/ui/src/components/views/setup-view/hooks/use-cli-status.ts index 43c8a6f6..f543f34f 100644 --- a/apps/ui/src/components/views/setup-view/hooks/use-cli-status.ts +++ b/apps/ui/src/components/views/setup-view/hooks/use-cli-status.ts @@ -8,6 +8,9 @@ interface UseCliStatusOptions { setAuthStatus: (status: any) => void; } +// Create logger once outside the hook to prevent infinite re-renders +const logger = createLogger('CliStatus'); + export function useCliStatus({ cliType, statusApi, @@ -15,7 +18,6 @@ export function useCliStatus({ setAuthStatus, }: UseCliStatusOptions) { const [isChecking, setIsChecking] = useState(false); - const logger = createLogger('CliStatus'); const checkStatus = useCallback(async () => { logger.info(`Starting status check for ${cliType}...`); @@ -66,7 +68,7 @@ export function useCliStatus({ } finally { setIsChecking(false); } - }, [cliType, statusApi, setCliStatus, setAuthStatus, logger]); + }, [cliType, statusApi, setCliStatus, setAuthStatus]); return { isChecking, checkStatus }; }