refactor: use centralized logger instead of console.log

Replace all console.log/console.error calls in settings-helpers.ts with
the centralized logger from @automaker/utils for consistency.

Changes:
- Import createLogger from @automaker/utils
- Create logger instance: createLogger('SettingsHelper')
- Replace console.log → logger.info
- Replace console.error → logger.error

Benefits:
- Consistent logging across the codebase
- Better log formatting and structure
- Easier to filter/control log output
- Follows existing patterns in other services

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This commit is contained in:
Stephan Rieche
2025-12-29 23:35:22 +01:00
parent ec3d78922e
commit 04e6ed30a2

View File

@@ -4,6 +4,7 @@
import type { SettingsService } from '../services/settings-service.js'; import type { SettingsService } from '../services/settings-service.js';
import type { ContextFilesResult, ContextFileInfo } from '@automaker/utils'; import type { ContextFilesResult, ContextFileInfo } from '@automaker/utils';
import { createLogger } from '@automaker/utils';
import type { MCPServerConfig, McpServerConfig, PromptCustomization } from '@automaker/types'; import type { MCPServerConfig, McpServerConfig, PromptCustomization } from '@automaker/types';
import { import {
mergeAutoModePrompts, mergeAutoModePrompts,
@@ -12,6 +13,8 @@ import {
mergeEnhancementPrompts, mergeEnhancementPrompts,
} from '@automaker/prompts'; } from '@automaker/prompts';
const logger = createLogger('SettingsHelper');
/** /**
* Get the autoLoadClaudeMd setting, with project settings taking precedence over global. * Get the autoLoadClaudeMd setting, with project settings taking precedence over global.
* Returns false if settings service is not available. * Returns false if settings service is not available.
@@ -27,7 +30,7 @@ export async function getAutoLoadClaudeMdSetting(
logPrefix = '[SettingsHelper]' logPrefix = '[SettingsHelper]'
): Promise<boolean> { ): Promise<boolean> {
if (!settingsService) { if (!settingsService) {
console.log(`${logPrefix} SettingsService not available, autoLoadClaudeMd disabled`); logger.info(`${logPrefix} SettingsService not available, autoLoadClaudeMd disabled`);
return false; return false;
} }
@@ -35,7 +38,7 @@ export async function getAutoLoadClaudeMdSetting(
// Check project settings first (takes precedence) // Check project settings first (takes precedence)
const projectSettings = await settingsService.getProjectSettings(projectPath); const projectSettings = await settingsService.getProjectSettings(projectPath);
if (projectSettings.autoLoadClaudeMd !== undefined) { if (projectSettings.autoLoadClaudeMd !== undefined) {
console.log( logger.info(
`${logPrefix} autoLoadClaudeMd from project settings: ${projectSettings.autoLoadClaudeMd}` `${logPrefix} autoLoadClaudeMd from project settings: ${projectSettings.autoLoadClaudeMd}`
); );
return projectSettings.autoLoadClaudeMd; return projectSettings.autoLoadClaudeMd;
@@ -44,10 +47,10 @@ export async function getAutoLoadClaudeMdSetting(
// Fall back to global settings // Fall back to global settings
const globalSettings = await settingsService.getGlobalSettings(); const globalSettings = await settingsService.getGlobalSettings();
const result = globalSettings.autoLoadClaudeMd ?? false; const result = globalSettings.autoLoadClaudeMd ?? false;
console.log(`${logPrefix} autoLoadClaudeMd from global settings: ${result}`); logger.info(`${logPrefix} autoLoadClaudeMd from global settings: ${result}`);
return result; return result;
} catch (error) { } catch (error) {
console.error(`${logPrefix} Failed to load autoLoadClaudeMd setting:`, error); logger.error(`${logPrefix} Failed to load autoLoadClaudeMd setting:`, error);
throw error; throw error;
} }
} }
@@ -65,17 +68,17 @@ export async function getEnableSandboxModeSetting(
logPrefix = '[SettingsHelper]' logPrefix = '[SettingsHelper]'
): Promise<boolean> { ): Promise<boolean> {
if (!settingsService) { if (!settingsService) {
console.log(`${logPrefix} SettingsService not available, sandbox mode disabled`); logger.info(`${logPrefix} SettingsService not available, sandbox mode disabled`);
return false; return false;
} }
try { try {
const globalSettings = await settingsService.getGlobalSettings(); const globalSettings = await settingsService.getGlobalSettings();
const result = globalSettings.enableSandboxMode ?? true; const result = globalSettings.enableSandboxMode ?? true;
console.log(`${logPrefix} enableSandboxMode from global settings: ${result}`); logger.info(`${logPrefix} enableSandboxMode from global settings: ${result}`);
return result; return result;
} catch (error) { } catch (error) {
console.error(`${logPrefix} Failed to load enableSandboxMode setting:`, error); logger.error(`${logPrefix} Failed to load enableSandboxMode setting:`, error);
throw error; throw error;
} }
} }
@@ -177,13 +180,13 @@ export async function getMCPServersFromSettings(
sdkServers[server.name] = convertToSdkFormat(server); sdkServers[server.name] = convertToSdkFormat(server);
} }
console.log( logger.info(
`${logPrefix} Loaded ${enabledServers.length} MCP server(s): ${enabledServers.map((s) => s.name).join(', ')}` `${logPrefix} Loaded ${enabledServers.length} MCP server(s): ${enabledServers.map((s) => s.name).join(', ')}`
); );
return sdkServers; return sdkServers;
} catch (error) { } catch (error) {
console.error(`${logPrefix} Failed to load MCP servers setting:`, error); logger.error(`${logPrefix} Failed to load MCP servers setting:`, error);
return {}; return {};
} }
} }
@@ -213,12 +216,12 @@ export async function getMCPPermissionSettings(
mcpAutoApproveTools: globalSettings.mcpAutoApproveTools ?? true, mcpAutoApproveTools: globalSettings.mcpAutoApproveTools ?? true,
mcpUnrestrictedTools: globalSettings.mcpUnrestrictedTools ?? true, mcpUnrestrictedTools: globalSettings.mcpUnrestrictedTools ?? true,
}; };
console.log( logger.info(
`${logPrefix} MCP permission settings: autoApprove=${result.mcpAutoApproveTools}, unrestricted=${result.mcpUnrestrictedTools}` `${logPrefix} MCP permission settings: autoApprove=${result.mcpAutoApproveTools}, unrestricted=${result.mcpUnrestrictedTools}`
); );
return result; return result;
} catch (error) { } catch (error) {
console.error(`${logPrefix} Failed to load MCP permission settings:`, error); logger.error(`${logPrefix} Failed to load MCP permission settings:`, error);
return defaults; return defaults;
} }
} }
@@ -285,13 +288,13 @@ export async function getPromptCustomization(
try { try {
const globalSettings = await settingsService.getGlobalSettings(); const globalSettings = await settingsService.getGlobalSettings();
customization = globalSettings.promptCustomization || {}; customization = globalSettings.promptCustomization || {};
console.log(`${logPrefix} Loaded prompt customization from settings`); logger.info(`${logPrefix} Loaded prompt customization from settings`);
} catch (error) { } catch (error) {
console.error(`${logPrefix} Failed to load prompt customization:`, error); logger.error(`${logPrefix} Failed to load prompt customization:`, error);
// Fall through to use empty customization (all defaults) // Fall through to use empty customization (all defaults)
} }
} else { } else {
console.log(`${logPrefix} SettingsService not available, using default prompts`); logger.info(`${logPrefix} SettingsService not available, using default prompts`);
} }
return { return {