From 02e378905e180b4ab0b692a748769bbb6c457f04 Mon Sep 17 00:00:00 2001 From: Cody Seibert Date: Mon, 15 Dec 2025 20:21:09 -0500 Subject: [PATCH] chore: add lockfile linting check and convert SSH URLs to HTTPS MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Add npm script to check for SSH URLs in package-lock.json - Convert electron/node-gyp dependency from SSH to HTTPS URL - Add workflow step to lint lockfile in CI environment 🤖 Generated with Claude Code Co-Authored-By: Claude Haiku 4.5 --- .github/workflows/pr-check.yml | 3 +++ package-lock.json | 2 +- package.json | 3 ++- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pr-check.yml b/.github/workflows/pr-check.yml index 604c9d8d..ea452a15 100644 --- a/.github/workflows/pr-check.yml +++ b/.github/workflows/pr-check.yml @@ -24,6 +24,9 @@ jobs: cache: "npm" cache-dependency-path: package-lock.json + - name: Check for SSH URLs in lockfile + run: npm run lint:lockfile + - name: Configure Git for HTTPS # Convert SSH URLs to HTTPS for git dependencies (e.g., @electron/node-gyp) # This is needed because SSH authentication isn't available in CI diff --git a/package-lock.json b/package-lock.json index 2491864c..fca8e8c2 100644 --- a/package-lock.json +++ b/package-lock.json @@ -737,7 +737,7 @@ }, "node_modules/@electron/node-gyp": { "version": "10.2.0-electron.1", - "resolved": "git+ssh://git@github.com/electron/node-gyp.git#06b29aafb7708acef8b3669835c8a7857ebc92d2", + "resolved": "git+https://github.com/electron/node-gyp.git#06b29aafb7708acef8b3669835c8a7857ebc92d2", "integrity": "sha512-CrYo6TntjpoMO1SHjl5Pa/JoUsECNqNdB7Kx49WLQpWzPw53eEITJ2Hs9fh/ryUYDn4pxZz11StaBYBrLFJdqg==", "dev": true, "license": "MIT", diff --git a/package.json b/package.json index c736570a..fdd557b0 100644 --- a/package.json +++ b/package.json @@ -28,7 +28,8 @@ "test": "npm run test --workspace=apps/app", "test:headed": "npm run test:headed --workspace=apps/app", "test:server": "npm run test --workspace=apps/server", - "test:server:coverage": "npm run test:cov --workspace=apps/server" + "test:server:coverage": "npm run test:cov --workspace=apps/server", + "lint:lockfile": "! grep -q 'git+ssh://' package-lock.json || (echo 'Error: package-lock.json contains git+ssh:// URLs. Run: git config --global url.\"https://github.com/\".insteadOf \"git@github.com:\"' && exit 1)" }, "dependencies": { "cross-spawn": "^7.0.6"