ros/automaker
1
0
Fork 0
mirror of https://github.com/AutoMaker-Org/automaker.git synced 2026-02-02 08:33:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: replace magic numbers with named constants in polling logic

Browse Source 
Address PR review feedback:
- Use WS_ACTIVITY_THRESHOLD constant instead of hardcoded 10000 in agent-info-panel.tsx
- Extract AGENT_OUTPUT_POLLING_INTERVAL constant for 5000ms value in use-features.ts

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Shirone
2026-01-21 16:10:22 +01:00
parent aac59c2b3a
commit 02de3df3df
2 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
apps/ui/src/components/views/board-view/components/kanban-card/agent-info-panel.tsx
View File

@@ -117,7 +117,7 @@ export const AgentInfoPanel = memo(function AgentInfoPanel({
} }
// If receiving WebSocket events, use longer polling interval as fallback // If receiving WebSocket events, use longer polling interval as fallback
if (isReceivingWsEvents) { if (isReceivingWsEvents) {
return 10000; return WS_ACTIVITY_THRESHOLD;
} }
// Default polling interval // Default polling interval
return 3000; return 3000;

4
apps/ui/src/hooks/queries/use-features.ts
View File

@@ -15,6 +15,8 @@ import type { Feature } from '@/store/app-store';
const FEATURES_REFETCH_ON_FOCUS = false; const FEATURES_REFETCH_ON_FOCUS = false;
const FEATURES_REFETCH_ON_RECONNECT = false; const FEATURES_REFETCH_ON_RECONNECT = false;
/** Default polling interval for agent output when WebSocket is inactive */
const AGENT_OUTPUT_POLLING_INTERVAL = 5000;
/** /**
* Fetch all features for a project * Fetch all features for a project
@@ -136,7 +138,7 @@ export function useAgentOutput(
} }
// Only poll if we have data and it's not empty (indicating active task) // Only poll if we have data and it's not empty (indicating active task)
if (query.state.data && query.state.data.length > 0) { if (query.state.data && query.state.data.length > 0) {
return 5000; // 5 seconds return AGENT_OUTPUT_POLLING_INTERVAL;
} }
return false; return false;
}, },