refactor: centralize error handling utilities across route modules

- Introduced a new common utility module for error handling, providing consistent methods for retrieving error messages and logging errors.
- Updated individual route modules to utilize the shared error handling functions, reducing code duplication and improving maintainability.
- Ensured all routes now log errors in a standardized format, enhancing debugging and monitoring capabilities.
This commit is contained in:
Cody Seibert
2025-12-14 17:59:16 -05:00
parent 6b30271441
commit 01bae7d43e
25 changed files with 154 additions and 212 deletions

View File

@@ -129,9 +129,11 @@ export function getTokenExpiryMs(): number {
return TOKEN_EXPIRY_MS;
}
/**
* Get error message from error object
*/
export function getErrorMessage(error: unknown): string {
return error instanceof Error ? error.message : "Unknown error";
}
import {
getErrorMessage as getErrorMessageShared,
createLogError,
} from "../common.js";
// Re-export shared utilities
export { getErrorMessageShared as getErrorMessage };
export const logError = createLogError(logger);

View File

@@ -5,7 +5,7 @@
import type { Request, Response } from "express";
import { getTerminalService } from "../../../services/terminal-service.js";
import { getErrorMessage } from "../common.js";
import { getErrorMessage, logError } from "../common.js";
import { createLogger } from "../../../lib/logger.js";
const logger = createLogger("Terminal");
@@ -44,7 +44,7 @@ export function createSessionsCreateHandler() {
},
});
} catch (error) {
logger.error("[Terminal] Error creating session:", error);
logError(error, "Create terminal session failed");
res.status(500).json({
success: false,
error: "Failed to create terminal session",