refactor: centralize error handling utilities across route modules

- Introduced a new common utility module for error handling, providing consistent methods for retrieving error messages and logging errors.
- Updated individual route modules to utilize the shared error handling functions, reducing code duplication and improving maintainability.
- Ensured all routes now log errors in a standardized format, enhancing debugging and monitoring capabilities.

apps/server/src/routes/fs/common.ts

@@ -3,19 +3,13 @@
  */
 
 import { createLogger } from "../../lib/logger.js";
+import {
+  getErrorMessage as getErrorMessageShared,
+  createLogError,
+} from "../common.js";
 
 const logger = createLogger("FS");
 
-/**
- * Get error message from error object
- */
-export function getErrorMessage(error: unknown): string {
-  return error instanceof Error ? error.message : "Unknown error";
-}
-
-/**
- * Log error details consistently
- */
-export function logError(error: unknown, context: string): void {
-  logger.error(`❌ ${context}:`, error);
-}
+// Re-export shared utilities
+export { getErrorMessageShared as getErrorMessage };
+export const logError = createLogError(logger);

apps/server/src/routes/fs/routes/resolve-directory.ts

@@ -31,10 +31,11 @@ export function createResolveDirectoryHandler() {
           const stats = await fs.stat(resolvedPath);
           if (stats.isDirectory()) {
             addAllowedPath(resolvedPath);
-            return res.json({
+            res.json({
               success: true,
               path: resolvedPath,
             });
+            return;
           }
         } catch {
           // Not a valid absolute path, continue to search
@@ -102,10 +103,11 @@ export function createResolveDirectoryHandler() {
 
             // Found matching directory
             addAllowedPath(candidatePath);
-            return res.json({
+            res.json({
               success: true,
               path: candidatePath,
             });
+            return;
           }
         } catch {
           // Directory doesn't exist at this location, continue searching