mirror of
https://github.com/AutoMaker-Org/automaker.git
synced 2026-03-19 10:43:08 +00:00
Bug fixes and stability improvements (#815)
* fix(copilot): correct tool.execution_complete event handling The CopilotProvider was using incorrect event type and data structure for tool execution completion events from the @github/copilot-sdk, causing tool call outputs to be empty. Changes: - Update event type from 'tool.execution_end' to 'tool.execution_complete' - Fix data structure to use nested result.content instead of flat result - Fix error structure to use error.message instead of flat error - Add success field to match SDK event structure - Add tests for empty and missing result handling This aligns with the official @github/copilot-sdk v0.1.16 types defined in session-events.d.ts. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * test(copilot): add edge case test for error with code field Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * refactor(copilot): improve error handling and code quality Code review improvements: - Extract magic string '[ERROR]' to TOOL_ERROR_PREFIX constant - Add null-safe error handling with direct error variable assignment - Include error codes in error messages for better debugging - Add JSDoc documentation for tool.execution_complete handler - Update tests to verify error codes are displayed - Add missing tool_use_id assertion in error test These changes improve: - Code maintainability (no magic strings) - Debugging experience (error codes now visible) - Type safety (explicit null checks) - Test coverage (verify error code formatting) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Changes from fix/bug-fixes-1-0 * test(copilot): add edge case test for error with code field Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Changes from fix/bug-fixes-1-0 * fix: Handle detached HEAD state in worktree discovery and recovery * fix: Remove unused isDevServerStarting prop and md: breakpoint classes * fix: Add missing dependency and sanitize persisted cache data * feat: Ensure NODE_ENV is set to test in vitest configs * feat: Configure Playwright to run only E2E tests * fix: Improve PR tracking and dev server lifecycle management * feat: Add settings-based defaults for planning mode, model config, and custom providers. Fixes #816 * feat: Add worktree and branch selector to graph view * fix: Add timeout and error handling for worktree HEAD ref resolution * fix: use absolute icon path and place icon outside asar on Linux The hicolor icon theme index only lists sizes up to 512x512, so an icon installed only at 1024x1024 is invisible to GNOME/KDE's theme resolver, causing both the app launcher and taskbar to show a generic icon. Additionally, BrowserWindow.icon cannot be read by the window manager when the file is inside app.asar. - extraResources: copy logo_larger.png to resources/ (outside asar) so it lands at /opt/Automaker/resources/logo_larger.png on install - linux.desktop.Icon: set to the absolute resources path, bypassing the hicolor theme lookup and its size constraints entirely - icon-manager.ts: on Linux production use process.resourcesPath so BrowserWindow receives a real filesystem path the WM can read directly Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: use linux.desktop.entry for custom desktop Icon field electron-builder v26 rejects arbitrary keys in linux.desktop — the correct schema wraps custom .desktop overrides inside desktop.entry. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: set desktop name on Linux so taskbar uses the correct app icon Without app.setDesktopName(), the window manager cannot associate the running Electron process with automaker.desktop. GNOME/KDE fall back to _NET_WM_ICON which defaults to Electron's own bundled icon. Calling app.setDesktopName('automaker.desktop') before any window is created sets the _GTK_APPLICATION_ID hint and XDG app_id so the WM picks up the desktop entry's Icon for the taskbar. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Fix: memory and context views mobile friendly (#818) * Changes from fix/memory-and-context-mobile-friendly * fix: Improve file extension detection and add path traversal protection * refactor: Extract file extension utilities and add path traversal guards Code review improvements: - Extract isMarkdownFilename and isImageFilename to shared image-utils.ts - Remove duplicated code from context-view.tsx and memory-view.tsx - Add path traversal guard for context fixture utilities (matching memory) - Add 7 new tests for context fixture path traversal protection - Total 61 tests pass Addresses code review feedback from PR #813 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * test: Add e2e tests for profiles crud and board background persistence * Update apps/ui/playwright.config.ts Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * fix: Add robust test navigation handling and file filtering * fix: Format NODE_OPTIONS configuration on single line * test: Update profiles and board background persistence tests * test: Replace iPhone 13 Pro with Pixel 5 for mobile test consistency * Update apps/ui/src/components/views/context-view.tsx Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * chore: Remove test project directory * feat: Filter context files by type and improve mobile menu visibility --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * fix: Improve test reliability and localhost handling * chore: Use explicit TEST_USE_EXTERNAL_BACKEND env var for server cleanup * feat: Add E2E/CI mock mode for provider factory and auth verification * feat: Add remoteBranch parameter to pull and rebase operations * chore: Enhance E2E testing setup with worker isolation and auth state management - Updated .gitignore to include worker-specific test fixtures. - Modified e2e-tests.yml to implement test sharding for improved CI performance. - Refactored global setup to authenticate once and save session state for reuse across tests. - Introduced worker-isolated fixture paths to prevent conflicts during parallel test execution. - Improved test navigation and loading handling for better reliability. - Updated various test files to utilize new auth state management and fixture paths. * fix: Update Playwright configuration and improve test reliability - Increased the number of workers in Playwright configuration for better parallelism in CI environments. - Enhanced the board background persistence test to ensure dropdown stability by waiting for the list to populate before interaction, improving test reliability. * chore: Simplify E2E test configuration and enhance mock implementations - Updated e2e-tests.yml to run tests in a single shard for streamlined CI execution. - Enhanced unit tests for worktree list handling by introducing a mock for execGitCommand, improving test reliability and coverage. - Refactored setup functions to better manage command mocks for git operations in tests. - Improved error handling in mkdirSafe function to account for undefined stats in certain environments. * refactor: Improve test configurations and enhance error handling - Updated Playwright configuration to clear VITE_SERVER_URL, ensuring the frontend uses the Vite proxy and preventing cookie domain mismatches. - Enhanced MergeRebaseDialog logic to normalize selectedBranch for better handling of various ref formats. - Improved global setup with a more robust backend health check, throwing an error if the backend is not healthy after retries. - Refactored project creation tests to handle file existence checks more reliably. - Added error handling for missing E2E source fixtures to guide setup process. - Enhanced memory navigation to handle sandbox dialog visibility more effectively. * refactor: Enhance Git command execution and improve test configurations - Updated Git command execution to merge environment paths correctly, ensuring proper command execution context. - Refactored the Git initialization process to handle errors more gracefully and ensure user configuration is set before creating the initial commit. - Improved test configurations by updating Playwright test identifiers for better clarity and consistency across different project states. - Enhanced cleanup functions in tests to handle directory removal more robustly, preventing errors during test execution. * fix: Resolve React hooks errors from duplicate instances in dependency tree * style: Format alias configuration for improved readability --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: DhanushSantosh <dhanushsantoshs05@gmail.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
This commit is contained in:
gsxdsm
@@ -3,7 +3,7 @@
|
||||
*
|
||||
* Tests that board background settings are properly saved and loaded when switching projects.
|
||||
* This verifies that:
|
||||
* 1. Background settings are saved to .automaker-local/settings.json
|
||||
* 1. Background settings are saved to .automaker/settings.json
|
||||
* 2. Settings are loaded when switching back to a project
|
||||
* 3. Background image, opacity, and other settings are correctly restored
|
||||
* 4. Settings persist across app restarts (new page loads)
|
||||
@@ -41,8 +41,8 @@ test.describe('Board Background Persistence', () => {
|
||||
test('should load board background settings when switching projects', async ({ page }) => {
|
||||
const projectAName = `project-a-${Date.now()}`;
|
||||
const projectBName = `project-b-${Date.now()}`;
|
||||
const projectAPath = path.join(TEST_TEMP_DIR, projectAName);
|
||||
const projectBPath = path.join(TEST_TEMP_DIR, projectBName);
|
||||
const projectAPath = path.resolve(TEST_TEMP_DIR, projectAName);
|
||||
const projectBPath = path.resolve(TEST_TEMP_DIR, projectBName);
|
||||
const projectAId = `project-a-${Date.now()}`;
|
||||
const projectBId = `project-b-${Date.now()}`;
|
||||
|
||||
@@ -62,8 +62,8 @@ test.describe('Board Background Persistence', () => {
|
||||
fs.writeFileSync(path.join(projectPath, 'README.md'), `# ${name}\n`);
|
||||
}
|
||||
|
||||
// Create .automaker-local directory for project A with background settings
|
||||
const automakerDirA = path.join(projectAPath, '.automaker-local');
|
||||
// Create .automaker directory for project A with background settings
|
||||
const automakerDirA = path.join(projectAPath, '.automaker');
|
||||
fs.mkdirSync(automakerDirA, { recursive: true });
|
||||
fs.mkdirSync(path.join(automakerDirA, 'board'), { recursive: true });
|
||||
fs.mkdirSync(path.join(automakerDirA, 'features'), { recursive: true });
|
||||
@@ -92,8 +92,8 @@ test.describe('Board Background Persistence', () => {
|
||||
};
|
||||
fs.writeFileSync(settingsPath, JSON.stringify(backgroundSettings, null, 2));
|
||||
|
||||
// Create minimal automaker-local directory for project B (no background)
|
||||
const automakerDirB = path.join(projectBPath, '.automaker-local');
|
||||
// Create minimal .automaker directory for project B (no background)
|
||||
const automakerDirB = path.join(projectBPath, '.automaker');
|
||||
fs.mkdirSync(automakerDirB, { recursive: true });
|
||||
fs.mkdirSync(path.join(automakerDirB, 'features'), { recursive: true });
|
||||
fs.mkdirSync(path.join(automakerDirB, 'context'), { recursive: true });
|
||||
@@ -166,30 +166,139 @@ test.describe('Board Background Persistence', () => {
|
||||
currentProjectId: projects[0].id,
|
||||
theme: 'dark',
|
||||
sidebarOpen: true,
|
||||
sidebarStyle: 'unified',
|
||||
maxConcurrency: 3,
|
||||
};
|
||||
localStorage.setItem('automaker-settings-cache', JSON.stringify(settingsCache));
|
||||
|
||||
// Force unified sidebar (project-dropdown-trigger exists only in unified mode)
|
||||
const uiCache = {
|
||||
state: {
|
||||
cachedProjectId: projects[0].id,
|
||||
cachedSidebarOpen: true,
|
||||
cachedSidebarStyle: 'unified',
|
||||
cachedWorktreePanelCollapsed: false,
|
||||
cachedCollapsedNavSections: {},
|
||||
cachedCurrentWorktreeByProject: {},
|
||||
},
|
||||
version: 2,
|
||||
};
|
||||
localStorage.setItem('automaker-ui-cache', JSON.stringify(uiCache));
|
||||
|
||||
localStorage.setItem('automaker-disable-splash', 'true');
|
||||
},
|
||||
{ projects: [projectA, projectB], versions: { APP_STORE: 2, SETUP_STORE: 1 } }
|
||||
);
|
||||
|
||||
// Intercept settings API BEFORE authentication to ensure our test projects
|
||||
// are consistently returned by the server. Only intercept GET requests -
|
||||
// let PUT requests (settings saves) pass through unmodified.
|
||||
// Fast-track initializeProject API calls for test project paths.
|
||||
// initializeProject makes ~8 sequential HTTP calls (exists, stat, mkdir, etc.) that
|
||||
// can take 10+ seconds under parallel load, blocking setCurrentProject entirely.
|
||||
await page.route('**/api/fs/**', async (route) => {
|
||||
const body = route.request().postDataJSON?.() ?? {};
|
||||
const filePath = body?.filePath || body?.dirPath || '';
|
||||
if (filePath.startsWith(projectAPath) || filePath.startsWith(projectBPath)) {
|
||||
const url = route.request().url();
|
||||
if (url.includes('/api/fs/exists')) {
|
||||
await route.fulfill({
|
||||
status: 200,
|
||||
contentType: 'application/json',
|
||||
body: JSON.stringify({ success: true, exists: true }),
|
||||
});
|
||||
} else if (url.includes('/api/fs/stat')) {
|
||||
await route.fulfill({
|
||||
status: 200,
|
||||
contentType: 'application/json',
|
||||
body: JSON.stringify({
|
||||
success: true,
|
||||
stats: { isDirectory: true, isFile: false, size: 0, mtime: new Date().toISOString() },
|
||||
}),
|
||||
});
|
||||
} else if (url.includes('/api/fs/mkdir')) {
|
||||
await route.fulfill({
|
||||
status: 200,
|
||||
contentType: 'application/json',
|
||||
body: JSON.stringify({ success: true }),
|
||||
});
|
||||
} else if (url.includes('/api/fs/write')) {
|
||||
await route.fulfill({
|
||||
status: 200,
|
||||
contentType: 'application/json',
|
||||
body: JSON.stringify({ success: true }),
|
||||
});
|
||||
} else {
|
||||
await route.continue();
|
||||
}
|
||||
} else {
|
||||
await route.continue();
|
||||
}
|
||||
});
|
||||
|
||||
// Also fast-track git init for test projects
|
||||
await page.route('**/api/worktree/init-git', async (route) => {
|
||||
const body = route.request().postDataJSON?.() ?? {};
|
||||
if (
|
||||
body?.projectPath?.startsWith(projectAPath) ||
|
||||
body?.projectPath?.startsWith(projectBPath)
|
||||
) {
|
||||
await route.fulfill({
|
||||
status: 200,
|
||||
contentType: 'application/json',
|
||||
body: JSON.stringify({ success: true, result: { initialized: false } }),
|
||||
});
|
||||
} else {
|
||||
await route.continue();
|
||||
}
|
||||
});
|
||||
|
||||
// Intercept settings API: inject test projects and track current project so that
|
||||
// when the app switches to project B (PUT), subsequent GETs return B instead of
|
||||
// overwriting back to A (which would prevent the dropdown from ever showing B).
|
||||
let effectiveCurrentProjectId = projectAId;
|
||||
let cachedSettingsJson: Record<string, unknown> | null = null;
|
||||
await page.route('**/api/settings/global', async (route) => {
|
||||
if (route.request().method() !== 'GET') {
|
||||
const method = route.request().method();
|
||||
if (method === 'PUT') {
|
||||
try {
|
||||
const body = route.request().postDataJSON();
|
||||
if (body?.currentProjectId === projectAId || body?.currentProjectId === projectBId) {
|
||||
effectiveCurrentProjectId = body.currentProjectId;
|
||||
}
|
||||
} catch {
|
||||
// ignore parse errors
|
||||
}
|
||||
await route.continue();
|
||||
return;
|
||||
}
|
||||
const response = await route.fetch();
|
||||
const json = await response.json();
|
||||
if (json.settings) {
|
||||
json.settings.currentProjectId = projectAId;
|
||||
json.settings.projects = [projectA, projectB];
|
||||
if (method !== 'GET') {
|
||||
await route.continue();
|
||||
return;
|
||||
}
|
||||
await route.fulfill({ response, json });
|
||||
if (!cachedSettingsJson) {
|
||||
try {
|
||||
const response = await route.fetch();
|
||||
cachedSettingsJson = (await response.json()) as Record<string, unknown>;
|
||||
} catch {
|
||||
// route.fetch() can fail during navigation; fall through to continue
|
||||
await route.continue().catch(() => {});
|
||||
return;
|
||||
}
|
||||
}
|
||||
const json = JSON.parse(JSON.stringify(cachedSettingsJson)) as Record<string, unknown>;
|
||||
if (!json.settings || typeof json.settings !== 'object') {
|
||||
json.settings = {};
|
||||
}
|
||||
const settings = json.settings as Record<string, unknown>;
|
||||
settings.currentProjectId = effectiveCurrentProjectId;
|
||||
settings.projects = [projectA, projectB];
|
||||
settings.sidebarOpen = true;
|
||||
settings.sidebarStyle = 'unified';
|
||||
await route
|
||||
.fulfill({
|
||||
status: 200,
|
||||
contentType: 'application/json',
|
||||
body: JSON.stringify(json),
|
||||
})
|
||||
.catch(() => {});
|
||||
});
|
||||
|
||||
// Track API calls to /api/settings/project to verify settings are being loaded
|
||||
@@ -214,66 +323,91 @@ test.describe('Board Background Persistence', () => {
|
||||
// Wait for board view
|
||||
await expect(page.locator('[data-testid="board-view"]')).toBeVisible({ timeout: 15000 });
|
||||
|
||||
// CRITICAL: Wait for settings to be loaded (useProjectSettingsLoader hook)
|
||||
// This ensures the background settings are fetched from the server
|
||||
await page.waitForTimeout(2000);
|
||||
|
||||
// Check if background settings were applied by checking the store
|
||||
// We can't directly access React state, so we'll verify via DOM/CSS
|
||||
// Wait for settings to be loaded (useProjectSettingsLoader hook)
|
||||
// Poll for the board view to be fully rendered and stable
|
||||
const boardView = page.locator('[data-testid="board-view"]');
|
||||
await expect(boardView).toBeVisible();
|
||||
await expect(boardView).toBeVisible({ timeout: 15000 });
|
||||
|
||||
// Wait for initial project load to stabilize
|
||||
await page.waitForTimeout(500);
|
||||
// Wait for settings API calls to complete (at least one settings call should have been made)
|
||||
await expect(async () => {
|
||||
expect(settingsApiCalls.length).toBeGreaterThan(0);
|
||||
}).toPass({ timeout: 10000 });
|
||||
|
||||
// Ensure sidebar is expanded before interacting with project selector
|
||||
const expandSidebarButton = page.locator('button:has-text("Expand sidebar")');
|
||||
if (await expandSidebarButton.isVisible()) {
|
||||
await expandSidebarButton.click();
|
||||
await page.waitForTimeout(300);
|
||||
await page
|
||||
.locator('button:has-text("Collapse sidebar")')
|
||||
.waitFor({ state: 'visible', timeout: 5000 })
|
||||
.catch(() => {});
|
||||
}
|
||||
|
||||
// Switch to project B (no background)
|
||||
// Use retry pattern: background re-renders (worktree loading, settings sync) can
|
||||
// swallow clicks or close the dropdown immediately after it opens.
|
||||
const projectSelector = page.locator('[data-testid="project-dropdown-trigger"]');
|
||||
await expect(projectSelector).toBeVisible({ timeout: 5000 });
|
||||
await projectSelector.click();
|
||||
|
||||
// Wait for dropdown to be visible
|
||||
await expect(page.locator('[data-testid="project-dropdown-content"]')).toBeVisible({
|
||||
timeout: 5000,
|
||||
});
|
||||
await expect(async () => {
|
||||
await projectSelector.click();
|
||||
await expect(page.locator('[data-testid="project-dropdown-content"]')).toBeVisible({
|
||||
timeout: 2000,
|
||||
});
|
||||
}).toPass({ timeout: 10000 });
|
||||
|
||||
const projectPickerB = page.locator(`[data-testid="project-item-${projectBId}"]`);
|
||||
await expect(projectPickerB).toBeVisible({ timeout: 5000 });
|
||||
|
||||
// Update effectiveCurrentProjectId eagerly BEFORE clicking so any in-flight GET
|
||||
// responses return project B instead of overwriting the store back to A.
|
||||
effectiveCurrentProjectId = projectBId;
|
||||
await projectPickerB.click();
|
||||
|
||||
// Wait for project B to load
|
||||
// Wait for the project switch to take effect (dropdown trigger shows project B name).
|
||||
// With initializeProject API calls fast-tracked, setCurrentProject runs quickly
|
||||
// and the startTransition commits within a few seconds.
|
||||
await expect(
|
||||
page.locator('[data-testid="project-dropdown-trigger"]').getByText(projectBName)
|
||||
).toBeVisible({ timeout: 5000 });
|
||||
).toBeVisible({ timeout: 15000 });
|
||||
|
||||
// Wait a bit for project B to fully load before switching
|
||||
await page.waitForTimeout(500);
|
||||
// Ensure sidebar stays expanded after navigation (it may collapse when switching projects)
|
||||
const expandBtn = page.locator('button:has-text("Expand sidebar")');
|
||||
if (await expandBtn.isVisible()) {
|
||||
await expandBtn.click();
|
||||
await page
|
||||
.locator('button:has-text("Collapse sidebar")')
|
||||
.waitFor({ state: 'visible', timeout: 5000 })
|
||||
.catch(() => {});
|
||||
}
|
||||
|
||||
// Switch back to project A
|
||||
await projectSelector.click();
|
||||
|
||||
// Wait for dropdown to be visible
|
||||
await expect(page.locator('[data-testid="project-dropdown-content"]')).toBeVisible({
|
||||
timeout: 5000,
|
||||
});
|
||||
|
||||
const projectPickerA = page.locator(`[data-testid="project-item-${projectAId}"]`);
|
||||
await expect(projectPickerA).toBeVisible({ timeout: 5000 });
|
||||
await projectPickerA.click();
|
||||
// Switch back to project A. Settings polls can cause re-renders that detach dropdown
|
||||
// items mid-click, so we retry the entire open-and-click sequence with short timeouts.
|
||||
// Update effectiveCurrentProjectId eagerly to prevent polls from reverting the switch.
|
||||
effectiveCurrentProjectId = projectAId;
|
||||
const trigger = page.locator('[data-testid="project-dropdown-trigger"]');
|
||||
await expect(async () => {
|
||||
await trigger.click();
|
||||
await expect(page.locator('[data-testid="project-dropdown-content"]')).toBeVisible({
|
||||
timeout: 2000,
|
||||
});
|
||||
await page
|
||||
.locator(`[data-testid="project-item-${projectAId}"]`)
|
||||
.click({ force: true, timeout: 1000 });
|
||||
}).toPass({ timeout: 15000 });
|
||||
|
||||
// Verify we're back on project A
|
||||
await expect(
|
||||
page.locator('[data-testid="project-dropdown-trigger"]').getByText(projectAName)
|
||||
).toBeVisible({ timeout: 5000 });
|
||||
).toBeVisible({ timeout: 15000 });
|
||||
|
||||
// CRITICAL: Wait for settings to be loaded again
|
||||
await page.waitForTimeout(2000);
|
||||
// Wait for settings to be re-loaded for project A
|
||||
const prevCallCount = settingsApiCalls.length;
|
||||
await expect(async () => {
|
||||
expect(settingsApiCalls.length).toBeGreaterThan(prevCallCount);
|
||||
})
|
||||
.toPass({ timeout: 10000 })
|
||||
.catch(() => {
|
||||
// Settings may be cached, which is fine
|
||||
});
|
||||
|
||||
// Verify that the settings API was called for project A at least once (initial load).
|
||||
// Note: When switching back, the app may use cached settings and skip re-fetching.
|
||||
@@ -319,8 +453,8 @@ test.describe('Board Background Persistence', () => {
|
||||
JSON.stringify({ name: projectName, version: '1.0.0' }, null, 2)
|
||||
);
|
||||
|
||||
// Create .automaker-local with background settings
|
||||
const automakerDir = path.join(projectPath, '.automaker-local');
|
||||
// Create .automaker with background settings
|
||||
const automakerDir = path.join(projectPath, '.automaker');
|
||||
fs.mkdirSync(automakerDir, { recursive: true });
|
||||
fs.mkdirSync(path.join(automakerDir, 'board'), { recursive: true });
|
||||
fs.mkdirSync(path.join(automakerDir, 'features'), { recursive: true });
|
||||
@@ -419,7 +553,17 @@ test.describe('Board Background Persistence', () => {
|
||||
await route.continue();
|
||||
return;
|
||||
}
|
||||
const response = await route.fetch();
|
||||
let response: Awaited<ReturnType<typeof route.fetch>>;
|
||||
try {
|
||||
response = await route.fetch();
|
||||
} catch {
|
||||
await route.continue();
|
||||
return;
|
||||
}
|
||||
if (!response.ok()) {
|
||||
await route.fulfill({ response });
|
||||
return;
|
||||
}
|
||||
const json = await response.json();
|
||||
// Override to use our test project
|
||||
if (json.settings) {
|
||||
@@ -458,8 +602,11 @@ test.describe('Board Background Persistence', () => {
|
||||
// Should go straight to board view (not welcome) since we have currentProject
|
||||
await expect(page.locator('[data-testid="board-view"]')).toBeVisible({ timeout: 15000 });
|
||||
|
||||
// Wait for settings to load
|
||||
await page.waitForTimeout(2000);
|
||||
// Wait for settings to load by checking API calls
|
||||
await expect(async () => {
|
||||
const calls = settingsApiCalls.filter((call) => call.body.includes(projectPath));
|
||||
expect(calls.length).toBeGreaterThanOrEqual(1);
|
||||
}).toPass({ timeout: 10000 });
|
||||
|
||||
// Verify that the settings API was called for this project
|
||||
const projectSettingsCalls = settingsApiCalls.filter((call) => call.body.includes(projectPath));
|
||||
|
||||
Reference in New Issue
Block a user