mirror of
https://github.com/leonvanzyl/autocoder.git
synced 2026-02-01 15:03:36 +00:00
94e0b05cb1
Token reduction (~40% per session, ~2.3M fewer tokens per 200-feature project): - Agent-type-specific tool lists: coding 9, testing 5, init 5 (was 19 for all) - Right-sized max_turns: coding 300, testing 100 (was 1000 for all) - Trimmed coding prompt template (~150 lines removed) - Streamlined testing prompt with batch support - YOLO mode now strips browser testing instructions from prompt - Added Grep, WebFetch, WebSearch to expand project session Performance improvements: - Rate limit retries start at ~15s with jitter (was fixed 60s) - Post-spawn delay reduced to 0.5s (was 2s) - Orchestrator consolidated to 1 DB query per loop (was 5-7) - Testing agents batch 3 features per session (was 1) - Smart context compaction preserves critical state, discards noise Bug fixes: - Removed ghost feature_release_testing MCP tool (wasted tokens every test session) - Forward all 9 Vertex AI env vars to chat sessions (was missing 3) - Fix DetachedInstanceError risk in test batch ORM access - Prevent duplicate testing of same features in parallel mode Code deduplication: - _get_project_path(): 9 copies -> 1 shared utility (project_helpers.py) - validate_project_name(): 9 copies -> 2 variants in 1 file (validation.py) - ROOT_DIR: 10 copies -> 1 definition (chat_constants.py) - API_ENV_VARS: 4 copies -> 1 source of truth (env_constants.py) Security hardening: - Unified sensitive directory blocklist (14 dirs, was two divergent lists) - Cached get_blocked_paths() for O(1) directory listing checks - Terminal security warning when ALLOW_REMOTE=1 exposes WebSocket - 20 new security tests for EXTRA_READ_PATHS blocking - Extracted _validate_command_list() and _validate_pkill_processes() helpers Type safety: - 87 mypy errors -> 0 across 58 source files - Installed types-PyYAML for proper yaml stub types - Fixed SQLAlchemy Column[T] coercions across all routers Dead code removed: - 13 files deleted (~2,679 lines): unused UI components, debug logs, outdated docs - 7 unused npm packages removed (Radix UI components with 0 imports) - AgentAvatar.tsx reduced from 615 -> 119 lines (SVGs extracted to mascotData.tsx) New CLI options: - --testing-batch-size (1-5) for parallel mode test batching - --testing-feature-ids for direct multi-feature testing Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
358 lines
14 KiB
Python
358 lines
14 KiB
Python
"""
|
|
Spec Creation Router
|
|
====================
|
|
|
|
WebSocket and REST endpoints for interactive spec creation with Claude.
|
|
"""
|
|
|
|
import json
|
|
import logging
|
|
from typing import Optional
|
|
|
|
from fastapi import APIRouter, HTTPException, WebSocket, WebSocketDisconnect
|
|
from pydantic import BaseModel, ValidationError
|
|
|
|
from ..schemas import ImageAttachment
|
|
from ..services.spec_chat_session import (
|
|
SpecChatSession,
|
|
create_session,
|
|
get_session,
|
|
list_sessions,
|
|
remove_session,
|
|
)
|
|
from ..utils.project_helpers import get_project_path as _get_project_path
|
|
from ..utils.validation import is_valid_project_name as validate_project_name
|
|
|
|
logger = logging.getLogger(__name__)
|
|
|
|
router = APIRouter(prefix="/api/spec", tags=["spec-creation"])
|
|
|
|
|
|
# ============================================================================
|
|
# REST Endpoints
|
|
# ============================================================================
|
|
|
|
class SpecSessionStatus(BaseModel):
|
|
"""Status of a spec creation session."""
|
|
project_name: str
|
|
is_active: bool
|
|
is_complete: bool
|
|
message_count: int
|
|
|
|
|
|
@router.get("/sessions", response_model=list[str])
|
|
async def list_spec_sessions():
|
|
"""List all active spec creation sessions."""
|
|
return list_sessions()
|
|
|
|
|
|
@router.get("/sessions/{project_name}", response_model=SpecSessionStatus)
|
|
async def get_session_status(project_name: str):
|
|
"""Get status of a spec creation session."""
|
|
if not validate_project_name(project_name):
|
|
raise HTTPException(status_code=400, detail="Invalid project name")
|
|
|
|
session = get_session(project_name)
|
|
if not session:
|
|
raise HTTPException(status_code=404, detail="No active session for this project")
|
|
|
|
return SpecSessionStatus(
|
|
project_name=project_name,
|
|
is_active=True,
|
|
is_complete=session.is_complete(),
|
|
message_count=len(session.get_messages()),
|
|
)
|
|
|
|
|
|
@router.delete("/sessions/{project_name}")
|
|
async def cancel_session(project_name: str):
|
|
"""Cancel and remove a spec creation session."""
|
|
if not validate_project_name(project_name):
|
|
raise HTTPException(status_code=400, detail="Invalid project name")
|
|
|
|
session = get_session(project_name)
|
|
if not session:
|
|
raise HTTPException(status_code=404, detail="No active session for this project")
|
|
|
|
await remove_session(project_name)
|
|
return {"success": True, "message": "Session cancelled"}
|
|
|
|
|
|
class SpecFileStatus(BaseModel):
|
|
"""Status of spec files on disk (from .spec_status.json)."""
|
|
exists: bool
|
|
status: str # "complete" | "in_progress" | "not_started"
|
|
feature_count: Optional[int] = None
|
|
timestamp: Optional[str] = None
|
|
files_written: list[str] = []
|
|
|
|
|
|
@router.get("/status/{project_name}", response_model=SpecFileStatus)
|
|
async def get_spec_file_status(project_name: str):
|
|
"""
|
|
Get spec creation status by reading .spec_status.json from the project.
|
|
|
|
This is used for polling to detect when Claude has finished writing spec files.
|
|
Claude writes this status file as the final step after completing all spec work.
|
|
"""
|
|
if not validate_project_name(project_name):
|
|
raise HTTPException(status_code=400, detail="Invalid project name")
|
|
|
|
project_dir = _get_project_path(project_name)
|
|
if not project_dir:
|
|
raise HTTPException(status_code=404, detail="Project not found in registry")
|
|
|
|
if not project_dir.exists():
|
|
raise HTTPException(status_code=404, detail="Project directory not found")
|
|
|
|
from autocoder_paths import get_prompts_dir
|
|
status_file = get_prompts_dir(project_dir) / ".spec_status.json"
|
|
|
|
if not status_file.exists():
|
|
return SpecFileStatus(
|
|
exists=False,
|
|
status="not_started",
|
|
feature_count=None,
|
|
timestamp=None,
|
|
files_written=[],
|
|
)
|
|
|
|
try:
|
|
data = json.loads(status_file.read_text(encoding="utf-8"))
|
|
return SpecFileStatus(
|
|
exists=True,
|
|
status=data.get("status", "unknown"),
|
|
feature_count=data.get("feature_count"),
|
|
timestamp=data.get("timestamp"),
|
|
files_written=data.get("files_written", []),
|
|
)
|
|
except json.JSONDecodeError as e:
|
|
logger.warning(f"Invalid JSON in spec status file: {e}")
|
|
return SpecFileStatus(
|
|
exists=True,
|
|
status="error",
|
|
feature_count=None,
|
|
timestamp=None,
|
|
files_written=[],
|
|
)
|
|
except Exception as e:
|
|
logger.error(f"Error reading spec status file: {e}")
|
|
raise HTTPException(status_code=500, detail="Failed to read status file")
|
|
|
|
|
|
# ============================================================================
|
|
# WebSocket Endpoint
|
|
# ============================================================================
|
|
|
|
@router.websocket("/ws/{project_name}")
|
|
async def spec_chat_websocket(websocket: WebSocket, project_name: str):
|
|
"""
|
|
WebSocket endpoint for interactive spec creation chat.
|
|
|
|
Message protocol:
|
|
|
|
Client -> Server:
|
|
- {"type": "start"} - Start the spec creation session
|
|
- {"type": "message", "content": "..."} - Send user message
|
|
- {"type": "answer", "answers": {...}, "tool_id": "..."} - Answer structured question
|
|
- {"type": "ping"} - Keep-alive ping
|
|
|
|
Server -> Client:
|
|
- {"type": "text", "content": "..."} - Text chunk from Claude
|
|
- {"type": "question", "questions": [...], "tool_id": "..."} - Structured question
|
|
- {"type": "spec_complete", "path": "..."} - Spec file created
|
|
- {"type": "file_written", "path": "..."} - Other file written
|
|
- {"type": "complete"} - Session complete
|
|
- {"type": "error", "content": "..."} - Error message
|
|
- {"type": "pong"} - Keep-alive pong
|
|
"""
|
|
if not validate_project_name(project_name):
|
|
await websocket.close(code=4000, reason="Invalid project name")
|
|
return
|
|
|
|
# Look up project directory from registry
|
|
project_dir = _get_project_path(project_name)
|
|
if not project_dir:
|
|
await websocket.close(code=4004, reason="Project not found in registry")
|
|
return
|
|
|
|
if not project_dir.exists():
|
|
await websocket.close(code=4004, reason="Project directory not found")
|
|
return
|
|
|
|
await websocket.accept()
|
|
|
|
session: Optional[SpecChatSession] = None
|
|
|
|
try:
|
|
while True:
|
|
try:
|
|
# Receive message from client
|
|
data = await websocket.receive_text()
|
|
message = json.loads(data)
|
|
msg_type = message.get("type")
|
|
|
|
if msg_type == "ping":
|
|
await websocket.send_json({"type": "pong"})
|
|
continue
|
|
|
|
elif msg_type == "start":
|
|
# Create and start a new session
|
|
session = await create_session(project_name, project_dir)
|
|
|
|
# Track spec completion state
|
|
spec_complete_received = False
|
|
spec_path = None
|
|
|
|
# Stream the initial greeting
|
|
async for chunk in session.start():
|
|
# Track spec_complete but don't send complete yet
|
|
if chunk.get("type") == "spec_complete":
|
|
spec_complete_received = True
|
|
spec_path = chunk.get("path")
|
|
await websocket.send_json(chunk)
|
|
continue
|
|
|
|
# When response_done arrives, send complete if spec was done
|
|
if chunk.get("type") == "response_done":
|
|
await websocket.send_json(chunk)
|
|
if spec_complete_received:
|
|
await websocket.send_json({"type": "complete", "path": spec_path})
|
|
continue
|
|
|
|
await websocket.send_json(chunk)
|
|
|
|
elif msg_type == "message":
|
|
# User sent a message
|
|
if not session:
|
|
session = get_session(project_name)
|
|
if not session:
|
|
await websocket.send_json({
|
|
"type": "error",
|
|
"content": "No active session. Send 'start' first."
|
|
})
|
|
continue
|
|
|
|
user_content = message.get("content", "").strip()
|
|
|
|
# Parse attachments if present
|
|
attachments: list[ImageAttachment] = []
|
|
raw_attachments = message.get("attachments", [])
|
|
if raw_attachments:
|
|
try:
|
|
for raw_att in raw_attachments:
|
|
attachments.append(ImageAttachment(**raw_att))
|
|
except (ValidationError, Exception) as e:
|
|
logger.warning(f"Invalid attachment data: {e}")
|
|
await websocket.send_json({
|
|
"type": "error",
|
|
"content": f"Invalid attachment: {str(e)}"
|
|
})
|
|
continue
|
|
|
|
# Allow empty content if attachments are present
|
|
if not user_content and not attachments:
|
|
await websocket.send_json({
|
|
"type": "error",
|
|
"content": "Empty message"
|
|
})
|
|
continue
|
|
|
|
# Track spec completion state
|
|
spec_complete_received = False
|
|
spec_path = None
|
|
|
|
# Stream Claude's response (with attachments if present)
|
|
async for chunk in session.send_message(user_content, attachments if attachments else None):
|
|
# Track spec_complete but don't send complete yet
|
|
if chunk.get("type") == "spec_complete":
|
|
spec_complete_received = True
|
|
spec_path = chunk.get("path")
|
|
await websocket.send_json(chunk)
|
|
continue
|
|
|
|
# When response_done arrives, send complete if spec was done
|
|
if chunk.get("type") == "response_done":
|
|
await websocket.send_json(chunk)
|
|
if spec_complete_received:
|
|
await websocket.send_json({"type": "complete", "path": spec_path})
|
|
continue
|
|
|
|
await websocket.send_json(chunk)
|
|
|
|
elif msg_type == "answer":
|
|
# User answered a structured question
|
|
if not session:
|
|
session = get_session(project_name)
|
|
if not session:
|
|
await websocket.send_json({
|
|
"type": "error",
|
|
"content": "No active session"
|
|
})
|
|
continue
|
|
|
|
# Format the answers as a natural response
|
|
answers = message.get("answers", {})
|
|
if isinstance(answers, dict):
|
|
# Convert structured answers to a message
|
|
response_parts = []
|
|
for question_idx, answer_value in answers.items():
|
|
if isinstance(answer_value, list):
|
|
response_parts.append(", ".join(answer_value))
|
|
else:
|
|
response_parts.append(str(answer_value))
|
|
user_response = "; ".join(response_parts) if response_parts else "OK"
|
|
else:
|
|
user_response = str(answers)
|
|
|
|
# Track spec completion state
|
|
spec_complete_received = False
|
|
spec_path = None
|
|
|
|
# Stream Claude's response
|
|
async for chunk in session.send_message(user_response):
|
|
# Track spec_complete but don't send complete yet
|
|
if chunk.get("type") == "spec_complete":
|
|
spec_complete_received = True
|
|
spec_path = chunk.get("path")
|
|
await websocket.send_json(chunk)
|
|
continue
|
|
|
|
# When response_done arrives, send complete if spec was done
|
|
if chunk.get("type") == "response_done":
|
|
await websocket.send_json(chunk)
|
|
if spec_complete_received:
|
|
await websocket.send_json({"type": "complete", "path": spec_path})
|
|
continue
|
|
|
|
await websocket.send_json(chunk)
|
|
|
|
else:
|
|
await websocket.send_json({
|
|
"type": "error",
|
|
"content": f"Unknown message type: {msg_type}"
|
|
})
|
|
|
|
except json.JSONDecodeError:
|
|
await websocket.send_json({
|
|
"type": "error",
|
|
"content": "Invalid JSON"
|
|
})
|
|
|
|
except WebSocketDisconnect:
|
|
logger.info(f"Spec chat WebSocket disconnected for {project_name}")
|
|
|
|
except Exception as e:
|
|
logger.exception(f"Spec chat WebSocket error for {project_name}")
|
|
try:
|
|
await websocket.send_json({
|
|
"type": "error",
|
|
"content": f"Server error: {str(e)}"
|
|
})
|
|
except Exception:
|
|
pass
|
|
|
|
finally:
|
|
# Don't remove the session on disconnect - allow resume
|
|
pass
|