Files
autocoder/server/routers/assistant_chat.py
Auto 94e0b05cb1 refactor: optimize token usage, deduplicate code, fix bugs across agents
Token reduction (~40% per session, ~2.3M fewer tokens per 200-feature project):
- Agent-type-specific tool lists: coding 9, testing 5, init 5 (was 19 for all)
- Right-sized max_turns: coding 300, testing 100 (was 1000 for all)
- Trimmed coding prompt template (~150 lines removed)
- Streamlined testing prompt with batch support
- YOLO mode now strips browser testing instructions from prompt
- Added Grep, WebFetch, WebSearch to expand project session

Performance improvements:
- Rate limit retries start at ~15s with jitter (was fixed 60s)
- Post-spawn delay reduced to 0.5s (was 2s)
- Orchestrator consolidated to 1 DB query per loop (was 5-7)
- Testing agents batch 3 features per session (was 1)
- Smart context compaction preserves critical state, discards noise

Bug fixes:
- Removed ghost feature_release_testing MCP tool (wasted tokens every test session)
- Forward all 9 Vertex AI env vars to chat sessions (was missing 3)
- Fix DetachedInstanceError risk in test batch ORM access
- Prevent duplicate testing of same features in parallel mode

Code deduplication:
- _get_project_path(): 9 copies -> 1 shared utility (project_helpers.py)
- validate_project_name(): 9 copies -> 2 variants in 1 file (validation.py)
- ROOT_DIR: 10 copies -> 1 definition (chat_constants.py)
- API_ENV_VARS: 4 copies -> 1 source of truth (env_constants.py)

Security hardening:
- Unified sensitive directory blocklist (14 dirs, was two divergent lists)
- Cached get_blocked_paths() for O(1) directory listing checks
- Terminal security warning when ALLOW_REMOTE=1 exposes WebSocket
- 20 new security tests for EXTRA_READ_PATHS blocking
- Extracted _validate_command_list() and _validate_pkill_processes() helpers

Type safety:
- 87 mypy errors -> 0 across 58 source files
- Installed types-PyYAML for proper yaml stub types
- Fixed SQLAlchemy Column[T] coercions across all routers

Dead code removed:
- 13 files deleted (~2,679 lines): unused UI components, debug logs, outdated docs
- 7 unused npm packages removed (Radix UI components with 0 imports)
- AgentAvatar.tsx reduced from 615 -> 119 lines (SVGs extracted to mascotData.tsx)

New CLI options:
- --testing-batch-size (1-5) for parallel mode test batching
- --testing-feature-ids for direct multi-feature testing

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-01 13:16:24 +02:00

328 lines
12 KiB
Python

"""
Assistant Chat Router
=====================
WebSocket and REST endpoints for the read-only project assistant.
"""
import json
import logging
from typing import Optional
from fastapi import APIRouter, HTTPException, WebSocket, WebSocketDisconnect
from pydantic import BaseModel
from ..services.assistant_chat_session import (
AssistantChatSession,
create_session,
get_session,
list_sessions,
remove_session,
)
from ..services.assistant_database import (
create_conversation,
delete_conversation,
get_conversation,
get_conversations,
)
from ..utils.project_helpers import get_project_path as _get_project_path
from ..utils.validation import is_valid_project_name as validate_project_name
logger = logging.getLogger(__name__)
router = APIRouter(prefix="/api/assistant", tags=["assistant-chat"])
# ============================================================================
# Pydantic Models
# ============================================================================
class ConversationSummary(BaseModel):
"""Summary of a conversation."""
id: int
project_name: str
title: Optional[str]
created_at: Optional[str]
updated_at: Optional[str]
message_count: int
class ConversationMessageModel(BaseModel):
"""A message within a conversation."""
id: int
role: str
content: str
timestamp: Optional[str]
class ConversationDetail(BaseModel):
"""Full conversation with messages."""
id: int
project_name: str
title: Optional[str]
created_at: Optional[str]
updated_at: Optional[str]
messages: list[ConversationMessageModel]
class SessionInfo(BaseModel):
"""Active session information."""
project_name: str
conversation_id: Optional[int]
is_active: bool
# ============================================================================
# REST Endpoints - Conversation Management
# ============================================================================
@router.get("/conversations/{project_name}", response_model=list[ConversationSummary])
async def list_project_conversations(project_name: str):
"""List all conversations for a project."""
if not validate_project_name(project_name):
raise HTTPException(status_code=400, detail="Invalid project name")
project_dir = _get_project_path(project_name)
if not project_dir or not project_dir.exists():
raise HTTPException(status_code=404, detail="Project not found")
conversations = get_conversations(project_dir, project_name)
return [ConversationSummary(**c) for c in conversations]
@router.get("/conversations/{project_name}/{conversation_id}", response_model=ConversationDetail)
async def get_project_conversation(project_name: str, conversation_id: int):
"""Get a specific conversation with all messages."""
if not validate_project_name(project_name):
raise HTTPException(status_code=400, detail="Invalid project name")
project_dir = _get_project_path(project_name)
if not project_dir or not project_dir.exists():
raise HTTPException(status_code=404, detail="Project not found")
conversation = get_conversation(project_dir, conversation_id)
if not conversation:
raise HTTPException(status_code=404, detail="Conversation not found")
return ConversationDetail(
id=conversation["id"],
project_name=conversation["project_name"],
title=conversation["title"],
created_at=conversation["created_at"],
updated_at=conversation["updated_at"],
messages=[ConversationMessageModel(**m) for m in conversation["messages"]],
)
@router.post("/conversations/{project_name}", response_model=ConversationSummary)
async def create_project_conversation(project_name: str):
"""Create a new conversation for a project."""
if not validate_project_name(project_name):
raise HTTPException(status_code=400, detail="Invalid project name")
project_dir = _get_project_path(project_name)
if not project_dir or not project_dir.exists():
raise HTTPException(status_code=404, detail="Project not found")
conversation = create_conversation(project_dir, project_name)
return ConversationSummary(
id=int(conversation.id),
project_name=str(conversation.project_name),
title=str(conversation.title) if conversation.title else None,
created_at=conversation.created_at.isoformat() if conversation.created_at else None,
updated_at=conversation.updated_at.isoformat() if conversation.updated_at else None,
message_count=0,
)
@router.delete("/conversations/{project_name}/{conversation_id}")
async def delete_project_conversation(project_name: str, conversation_id: int):
"""Delete a conversation."""
if not validate_project_name(project_name):
raise HTTPException(status_code=400, detail="Invalid project name")
project_dir = _get_project_path(project_name)
if not project_dir or not project_dir.exists():
raise HTTPException(status_code=404, detail="Project not found")
success = delete_conversation(project_dir, conversation_id)
if not success:
raise HTTPException(status_code=404, detail="Conversation not found")
return {"success": True, "message": "Conversation deleted"}
# ============================================================================
# REST Endpoints - Session Management
# ============================================================================
@router.get("/sessions", response_model=list[str])
async def list_active_sessions():
"""List all active assistant sessions."""
return list_sessions()
@router.get("/sessions/{project_name}", response_model=SessionInfo)
async def get_session_info(project_name: str):
"""Get information about an active session."""
if not validate_project_name(project_name):
raise HTTPException(status_code=400, detail="Invalid project name")
session = get_session(project_name)
if not session:
raise HTTPException(status_code=404, detail="No active session for this project")
return SessionInfo(
project_name=project_name,
conversation_id=session.get_conversation_id(),
is_active=True,
)
@router.delete("/sessions/{project_name}")
async def close_session(project_name: str):
"""Close an active session."""
if not validate_project_name(project_name):
raise HTTPException(status_code=400, detail="Invalid project name")
session = get_session(project_name)
if not session:
raise HTTPException(status_code=404, detail="No active session for this project")
await remove_session(project_name)
return {"success": True, "message": "Session closed"}
# ============================================================================
# WebSocket Endpoint
# ============================================================================
@router.websocket("/ws/{project_name}")
async def assistant_chat_websocket(websocket: WebSocket, project_name: str):
"""
WebSocket endpoint for assistant chat.
Message protocol:
Client -> Server:
- {"type": "start", "conversation_id": int | null} - Start/resume session
- {"type": "message", "content": "..."} - Send user message
- {"type": "ping"} - Keep-alive ping
Server -> Client:
- {"type": "conversation_created", "conversation_id": int} - New conversation created
- {"type": "text", "content": "..."} - Text chunk from Claude
- {"type": "tool_call", "tool": "...", "input": {...}} - Tool being called
- {"type": "response_done"} - Response complete
- {"type": "error", "content": "..."} - Error message
- {"type": "pong"} - Keep-alive pong
"""
if not validate_project_name(project_name):
await websocket.close(code=4000, reason="Invalid project name")
return
project_dir = _get_project_path(project_name)
if not project_dir:
await websocket.close(code=4004, reason="Project not found in registry")
return
if not project_dir.exists():
await websocket.close(code=4004, reason="Project directory not found")
return
await websocket.accept()
logger.info(f"Assistant WebSocket connected for project: {project_name}")
session: Optional[AssistantChatSession] = None
try:
while True:
try:
data = await websocket.receive_text()
message = json.loads(data)
msg_type = message.get("type")
logger.debug(f"Assistant received message type: {msg_type}")
if msg_type == "ping":
await websocket.send_json({"type": "pong"})
continue
elif msg_type == "start":
# Get optional conversation_id to resume
conversation_id = message.get("conversation_id")
logger.debug(f"Processing start message with conversation_id={conversation_id}")
try:
# Create a new session
logger.debug(f"Creating session for {project_name}")
session = await create_session(
project_name,
project_dir,
conversation_id=conversation_id,
)
logger.debug("Session created, starting...")
# Stream the initial greeting
async for chunk in session.start():
if logger.isEnabledFor(logging.DEBUG):
logger.debug(f"Sending chunk: {chunk.get('type')}")
await websocket.send_json(chunk)
logger.debug("Session start complete")
except Exception as e:
logger.exception(f"Error starting assistant session for {project_name}")
await websocket.send_json({
"type": "error",
"content": f"Failed to start session: {str(e)}"
})
elif msg_type == "message":
if not session:
session = get_session(project_name)
if not session:
await websocket.send_json({
"type": "error",
"content": "No active session. Send 'start' first."
})
continue
user_content = message.get("content", "").strip()
if not user_content:
await websocket.send_json({
"type": "error",
"content": "Empty message"
})
continue
# Stream Claude's response
async for chunk in session.send_message(user_content):
await websocket.send_json(chunk)
else:
await websocket.send_json({
"type": "error",
"content": f"Unknown message type: {msg_type}"
})
except json.JSONDecodeError:
await websocket.send_json({
"type": "error",
"content": "Invalid JSON"
})
except WebSocketDisconnect:
logger.info(f"Assistant chat WebSocket disconnected for {project_name}")
except Exception as e:
logger.exception(f"Assistant chat WebSocket error for {project_name}")
try:
await websocket.send_json({
"type": "error",
"content": f"Server error: {str(e)}"
})
except Exception:
pass
finally:
# Don't remove session on disconnect - allow resume
pass