ros/autocoder
1
0
Fork 0
mirror of https://github.com/leonvanzyl/autocoder.git synced 2026-02-01 06:53:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Address CodeRabbit review feedback

Browse Source 
- Fix math error in category totals (155→165, 255→265)
- Fix example JSON to include [0,1,2,3,4] dependencies for all features
- Add more robust server shutdown (SIGTERM then SIGKILL)
- Add health check after server restart
- Align grep patterns between templates (add .js, testData, TODO/STUB/MOCK)
- Add package.json check for mock backend libraries
- Reference STEP 5.6 instead of duplicating grep commands

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
cabana8471
2026-01-25 11:43:54 +01:00
parent 8e23fee094
commit dae16c3cca
2 changed files with 31 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
.claude/templates/coding_prompt.template.md
View File

@@ -217,16 +217,24 @@ grep -r "new Map()\|new Set()" --include="*.ts" --include="*.tsx" src/lib/ src/s
3. **STOP the server completely:**
```bash
# Send SIGTERM first, then SIGKILL if needed
pkill -f "node" || pkill -f "npm" || pkill -f "next"
sleep 5
sleep 3
pkill -9 -f "node" 2>/dev/null || true
sleep 2
# Verify server is stopped
pgrep -f "node" && echo "ERROR: Server still running!" && exit 1
if pgrep -f "node" > /dev/null; then
echo "ERROR: Server still running!"
exit 1
fi
```
4. **RESTART the server:**
```bash
./init.sh &
sleep 15 # Allow server to fully start
# Verify server is responding
curl -f http://localhost:3000/api/health || curl -f http://localhost:3000 || echo "WARNING: Health check failed"
```
5. **Query for test data - it MUST still exist**
@@ -234,8 +242,8 @@ grep -r "new Map()\|new Set()" --include="*.ts" --include="*.tsx" src/lib/ src/s
- Via API: `curl http://localhost:PORT/api/items` - verify data in response
6. **If data is GONE:** Implementation uses in-memory storage → CRITICAL FAIL
- Search for: `grep -r "globalThis\|devStore\|dev-store" src/`
- You MUST fix the mock data implementation before proceeding
- Run all grep commands from STEP 5.6 to identify the mock pattern
- You MUST fix the in-memory storage implementation before proceeding
- Replace in-memory storage with real database queries
7. **Clean up test data** after successful verification